urbit/ares
1
1
Fork 0
mirror of https://github.com/urbit/ares.git synced 2024-12-23 21:31:57 +03:00
Code Issues Packages Projects Releases Wiki Activity

_pma_state->metadata mem leak

Browse Source
This commit is contained in:
barter-simsum 2023-05-09 16:46:37 -04:00
parent 15c4af135c
commit de52547506
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
rust/ares/src/pma/malloc.c
View File

@ -414,6 +414,19 @@ typedef struct _pma_global_state_t {
PageRunCache *free_page_runs; // Cache of free multi-page runs
} State;
#define pma_state_free(state) \
do { \
pma_state_free (state); \
state=NULL; \
} while(0)
inline void
(pma_state_free)(State *state)
{
if (state->metadata) free(state->metadata);
free(state);
}
//==============================================================================
// FORWARD DECLARATIONS
//==============================================================================
@ -727,7 +740,7 @@ init_error:
if (snapshot_fd) close(snapshot_fd);
if (page_dir_fd) close(page_dir_fd);
free(filepath);
free(_pma_state);
pma_state_free(_pma_state);
return -1;
}
@ -979,7 +992,7 @@ load_error:
if (snapshot_fd) close(snapshot_fd);
if (page_dir_fd) close(page_dir_fd);
free(filepath);
free(_pma_state);
pma_state_free(_pma_state);
return (RootState){0};
}
@ -1002,10 +1015,8 @@ pma_close(uint64_t epoch, uint64_t event, uint64_t root) {
close(_pma_state->page_dir_fd);
close(_pma_state->snapshot_fd);
_pma_state = NULL;
// Free PMA state
free(_pma_state);
// free pma state
pma_state_free(_pma_state);
return 0;
}