urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2024-12-20 09:21:42 +03:00
Code Issues Packages Projects Releases Wiki Activity
b802dce0fb
shrub/pkg/arvo/gen/hood/close-flows.hoon

92 lines
2.6 KiB
Plaintext
Raw Normal View History

ames: style fixes and comments
2023-02-14 08:06:41 +03:00
:: Deletes all stale ames flows from failed (re) subscriptions
ames, +close-flows: combine stale flows This combines two types of flows that can be closed: - nacking %watch pleas - resubscriptions that were not properly corked
2022-12-09 18:13:41 +03:00
::
ames: fix |close-flows generator
2023-01-07 19:42:59 +03:00
:: It runs in dry mode by default, printing the flows that can be closed.
:: To actually close the flows, run with |close-flows, =dry |
ames: add tool for removing failed %watch flows
2022-12-05 13:25:09 +03:00
::
:- %say
ames: move +on-kroc logic to |close-flows +on-kroc was cluttered with ad-hoc logic to indentify stale flows from failed resubscriptions that were not properly %corked. Here we move that logic to a generator that, if not in dry mode, will call %ames with a (list [ship bone]) to %cork them. Another option would be to move the logic in the generator to a state update in ames, which will trigger possibly thousands of %ames messages to be sent, on every ship that runs the state migration—these flows are not causing a problem that neds to be addressed, and only take extra space. If we decide that this needs to be run by everyone, one solution could be to set up a timer (maybe taking advantage of the fact that ships don't get the OTA a the same time) that will eventually poke %hood with a %helm-ames-kroc task.
2023-06-07 16:55:50 +03:00
|= [[now=@da eny=@uvJ bec=beak] arg=~ peer=(unit @p) dry=? veb=?]
ames: add tool for removing failed %watch flows
2022-12-05 13:25:09 +03:00
::
ames: move +on-kroc logic to |close-flows +on-kroc was cluttered with ad-hoc logic to indentify stale flows from failed resubscriptions that were not properly %corked. Here we move that logic to a generator that, if not in dry mode, will call %ames with a (list [ship bone]) to %cork them. Another option would be to move the logic in the generator to a state update in ames, which will trigger possibly thousands of %ames messages to be sent, on every ship that runs the state migration—these flows are not causing a problem that neds to be addressed, and only take extra space. If we decide that this needs to be run by everyone, one solution could be to set up a timer (maybe taking advantage of the fact that ships don't get the OTA a the same time) that will eventually poke %hood with a %helm-ames-kroc task.
2023-06-07 16:55:50 +03:00
=/ peers-map
.^((map ship ?(%alien %known)) %ax /(scot %p p.bec)//(scot %da now)/peers)
::
=/ peers=(list ship)
%+ murn ~(tap by peers-map)
|= [=ship val=?(%alien %known)]
?: =(ship p.bec)
~ :: this is weird, but we saw it
?- val
%alien ~
%known (some ship)
==
::
=; bones=(list [ship bone])
:- %helm-ames-kroc
~? dry "#{<(lent bones)>} flows can be closed"
dry^bones
::
%+ roll peers
|= [=ship bones=(list [ship bone])]
?: &(?=(^ peer) !=(u.peer ship))
bones
::
=+ .^ =ship-state:ames
%ax /(scot %p p.bec)//(scot %da now)/peers/(scot %p ship)
==
=/ =peer-state:ames ?>(?=(%known -.ship-state) +.ship-state)
|^
=/ subs=(jar path [bone sub-nonce=@]) resubscriptions
%+ roll ~(tap by subs)
|= [[=wire flows=(list [bone sub-nonce=@])] bones=_bones]
::
ames: account for / in pre-nonce %watches
2023-06-07 20:25:35 +03:00
%- flop %- tail
gen: restore sorting flows by nonce This was removed when the logic for re-subscriptions was taken from %ames into the generator. Sorting allows us to keep the current (last) subscription as the last in the list, and in this case we check if it received an ack for a naxplanation—see https://github.com/urbit/urbit/issues/6065#issuecomment-1322011137— in which case it's safe to be corked.
2023-06-12 17:04:46 +03:00
%+ roll (sort flows |=([[@ n=@] [@ m=@]] (lte n m)))
ames: move +on-kroc logic to |close-flows +on-kroc was cluttered with ad-hoc logic to indentify stale flows from failed resubscriptions that were not properly %corked. Here we move that logic to a generator that, if not in dry mode, will call %ames with a (list [ship bone]) to %cork them. Another option would be to move the logic in the generator to a state update in ames, which will trigger possibly thousands of %ames messages to be sent, on every ship that runs the state migration—these flows are not causing a problem that neds to be addressed, and only take extra space. If we decide that this needs to be run by everyone, one solution could be to set up a timer (maybe taking advantage of the fact that ships don't get the OTA a the same time) that will eventually poke %hood with a %helm-ames-kroc task.
2023-06-07 16:55:50 +03:00
|= [[=bone nonce=@] resubs=_(lent flows) bones=_bones]
=/ app=term ?>(?=([%gall %use sub=@ *] wire) i.t.t.wire)
=/ =path (slag 7 wire)
=/ log=tape "[bone={<bone>} agent={<app>} nonce={<nonce>}] {<path>}"
=; corkable=?
=? bones corkable [[ship bone] bones]
(dec resubs)^bones
:: checks if this is a stale re-subscription
::
?. =(resubs 1)
~? veb [ship (weld "stale %watch plea " log)]
&
:: the current subscription can be safely corked if there
:: is a flow with a naxplanation ack on a backward bone
::
=+ backward-bone=(mix 0b10 bone)
?. =(%2 (mod backward-bone 4))
|
?~ (~(get by rcv.peer-state) backward-bone)
|
~? veb [ship (weld "failed %watch plea " log)]
&
::
++ resubscriptions
%+ roll ~(tap by snd.peer-state)
|= $: [=forward=bone message-pump-state:ames]
subs=(jar path [bone sub-nonce=@])
==
?: (~(has in closing.peer-state) forward-bone)
~? veb
:- ship
%+ weld "stale flow bone={<forward-bone>} in closing, "
"#{<~(wyt in live:packet-pump-state)>} packets retrying"
subs
?~ duct=(~(get by by-bone.ossuary.peer-state) forward-bone)
subs
ames: account for / in pre-nonce %watches
2023-06-07 20:25:35 +03:00
?. ?=([* [%gall %use sub=@ @ %out @ @ *] *] u.duct)
ames: move +on-kroc logic to |close-flows +on-kroc was cluttered with ad-hoc logic to indentify stale flows from failed resubscriptions that were not properly %corked. Here we move that logic to a generator that, if not in dry mode, will call %ames with a (list [ship bone]) to %cork them. Another option would be to move the logic in the generator to a state update in ames, which will trigger possibly thousands of %ames messages to be sent, on every ship that runs the state migration—these flows are not causing a problem that neds to be addressed, and only take extra space. If we decide that this needs to be run by everyone, one solution could be to set up a timer (maybe taking advantage of the fact that ships don't get the OTA a the same time) that will eventually poke %hood with a %helm-ames-kroc task.
2023-06-07 16:55:50 +03:00
subs
=/ =wire i.t.u.duct
ames: account for / in pre-nonce %watches
2023-06-07 20:25:35 +03:00
=/ nonce=(unit @) ?~((slag 7 wire) ~ (slaw %ud &8.wire))
ames: move +on-kroc logic to |close-flows +on-kroc was cluttered with ad-hoc logic to indentify stale flows from failed resubscriptions that were not properly %corked. Here we move that logic to a generator that, if not in dry mode, will call %ames with a (list [ship bone]) to %cork them. Another option would be to move the logic in the generator to a state update in ames, which will trigger possibly thousands of %ames messages to be sent, on every ship that runs the state migration—these flows are not causing a problem that neds to be addressed, and only take extra space. If we decide that this needs to be run by everyone, one solution could be to set up a timer (maybe taking advantage of the fact that ships don't get the OTA a the same time) that will eventually poke %hood with a %helm-ames-kroc task.
2023-06-07 16:55:50 +03:00
%- ~(add ja subs)
:: 0 for old pre-nonce subscriptions
::
:_ [forward-bone ?~(nonce 0 u.nonce)]
?~ nonce wire
:: don't include the sub-nonce in the key
::
(weld (scag 7 wire) (slag 8 wire))
--
Reference in New Issue Copy Permalink