From 0567f249591a365536c6dece18a10e7bbada430e Mon Sep 17 00:00:00 2001
From: pilfer-pandex <47340789+pilfer-pandex@users.noreply.github.com>
Date: Tue, 3 Nov 2020 11:29:51 -0800
Subject: [PATCH] king: more warnery

---
 pkg/hs/proto/package.yaml                  | 1 +
 pkg/hs/racquire/lib/Data/RAcquire.hs       | 4 +---
 pkg/hs/racquire/package.yaml               | 8 +++++---
 pkg/hs/urbit-atom/package.yaml             | 2 +-
 pkg/hs/urbit-king/lib/Urbit/Arvo/Common.hs | 3 +++
 pkg/hs/urbit-termsize/app/Main.hs          | 1 -
 pkg/hs/urbit-termsize/package.yaml         | 9 ++++++---
 7 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/pkg/hs/proto/package.yaml b/pkg/hs/proto/package.yaml
index 4427b11615..bb8f9e8829 100644
--- a/pkg/hs/proto/package.yaml
+++ b/pkg/hs/proto/package.yaml
@@ -64,6 +64,7 @@ library:
     - -fwarn-incomplete-patterns
     - -fwarn-unused-binds
     - -fwarn-unused-imports
+    - -Wwarn
     - -O2
 
 executables:
diff --git a/pkg/hs/racquire/lib/Data/RAcquire.hs b/pkg/hs/racquire/lib/Data/RAcquire.hs
index 618013aa52..588db777fe 100644
--- a/pkg/hs/racquire/lib/Data/RAcquire.hs
+++ b/pkg/hs/racquire/lib/Data/RAcquire.hs
@@ -18,9 +18,7 @@ import qualified Control.Exception     as E
 import qualified Control.Monad.Catch   as C ()
 import qualified Data.Acquire.Internal as Act
 
-import Control.Applicative     (Applicative(..))
-import Control.Monad           (ap, liftM)
-import Control.Monad.IO.Unlift (MonadIO(..), MonadUnliftIO, withRunInIO)
+import Control.Monad.IO.Unlift (MonadUnliftIO, withRunInIO)
 import Control.Monad.Reader
 import Data.Typeable           (Typeable)
 
diff --git a/pkg/hs/racquire/package.yaml b/pkg/hs/racquire/package.yaml
index b882b2753b..bbaca592cc 100644
--- a/pkg/hs/racquire/package.yaml
+++ b/pkg/hs/racquire/package.yaml
@@ -6,9 +6,11 @@ license-file: LICENSE
 library:
   source-dirs: lib
   ghc-options:
-    - -fwarn-incomplete-patterns
-    - -fwarn-unused-binds
-    - -fwarn-unused-imports
+    - -Wall
+    - -Werror
+    - -Wno-type-defaults
+    - -Wno-unused-matches
+    - -Wno-name-shadowing
     - -O2
 
 dependencies:
diff --git a/pkg/hs/urbit-atom/package.yaml b/pkg/hs/urbit-atom/package.yaml
index a41b95d23a..088da5055a 100644
--- a/pkg/hs/urbit-atom/package.yaml
+++ b/pkg/hs/urbit-atom/package.yaml
@@ -9,7 +9,7 @@ ghc-options:
   - -Wno-type-defaults
   - -Wno-unused-matches
   - -Wno-name-shadowing
-  - -Wno-unused-do-bind
+  - -Wno-unbanged-strict-patterns
   - -O2
 
 library:
diff --git a/pkg/hs/urbit-king/lib/Urbit/Arvo/Common.hs b/pkg/hs/urbit-king/lib/Urbit/Arvo/Common.hs
index 312f288d93..f02c7f69d5 100644
--- a/pkg/hs/urbit-king/lib/Urbit/Arvo/Common.hs
+++ b/pkg/hs/urbit-king/lib/Urbit/Arvo/Common.hs
@@ -4,6 +4,9 @@
 -- combination with 'deriveNoun' which generates an unreachable pattern.
 {-# OPTIONS_GHC -Wno-overlapping-patterns #-}
 
+-- Hack. See comment above instance ToNoun H.StdMethod
+{-# OPTIONS_GHC -Wno-orphans #-}
+
 {-|
     Types used in both Events and Effects.
 -}
diff --git a/pkg/hs/urbit-termsize/app/Main.hs b/pkg/hs/urbit-termsize/app/Main.hs
index 798ece23fa..aed583c746 100644
--- a/pkg/hs/urbit-termsize/app/Main.hs
+++ b/pkg/hs/urbit-termsize/app/Main.hs
@@ -3,7 +3,6 @@ module Main where
 import Prelude
 
 import Urbit.TermSize (liveTermSize)
-import System.IO (getLine)
 
 main :: IO ()
 main = do
diff --git a/pkg/hs/urbit-termsize/package.yaml b/pkg/hs/urbit-termsize/package.yaml
index 83efc8c17a..d63d312f7f 100644
--- a/pkg/hs/urbit-termsize/package.yaml
+++ b/pkg/hs/urbit-termsize/package.yaml
@@ -9,9 +9,12 @@ dependencies:
   - unix
 
 ghc-options:
-  - -fwarn-incomplete-patterns
-  - -fwarn-unused-binds
-  - -fwarn-unused-imports
+  - -Wall
+  - -Werror
+  - -Wno-type-defaults
+  - -Wno-unused-matches
+  - -Wno-name-shadowing
+  - -Wno-unused-do-bind
   - -O2
 
 library: