urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2024-12-23 19:05:48 +03:00
Code Issues Packages Projects Releases Wiki Activity

chat: address PR comments

Browse Source 
Fixes urbit/landscape#303
This commit is contained in:
James Acklin 2021-02-08 10:48:29 -05:00
parent 6eb61f725f
commit 3a99a79867
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/interface/src/views/components/MentionText.tsx
View File

@ -46,9 +46,12 @@ export function Mention(props: {
const group = props.group ?? { hidden: true };
const [showOverlay, setShowOverlay] = useState(false);
const toggleOverlay = () => {
setShowOverlay((value) => !value);
};
const toggleOverlay = useCallback(
() => {
setShowOverlay(value => !value);
},
[showOverlay]
);
return (
<Box position='relative' display='inline-block' cursor='pointer'>

4
pkg/interface/src/views/components/OverlaySigil.tsx
View File

@ -72,7 +72,7 @@ export const OverlaySigil = (props: OverlaySigilProps): React.FC => {
if (scrollWindow)
scrollWindow.removeEventListener('scroll', updateContainerOffset, true);
};
}, []);
}, [scrollWindow]);
return (
<Box
@ -91,7 +91,7 @@ export const OverlaySigil = (props: OverlaySigilProps): React.FC => {
contact={contact}
group={group}
history={history}
onDismiss={() => onDismiss()}
onDismiss={onDismiss}
ship={ship}
topSpace={space.top}
{...rest}