From 479fbfd798413945a074bb3dcbe2a48d82e2ae37 Mon Sep 17 00:00:00 2001 From: Liam Fitzgerald Date: Fri, 2 Apr 2021 19:56:07 +1000 Subject: [PATCH] push-hook: noop on unversioned, unsupported watches Mainnet is currently experiencing undue load due to a watch-kick loop. If the watch is unsupported, it will be kicked due to a mark mismatch, which will be interpreted by the unversioned hooks as a network pressure kick, prompting a resub and continuing the loop. Instead, we now no-op on unversioned, unsupported watches, waiting for the subscriber to rewatch after it processes the versioning OTA. This will silently break groups for the subscriber until the reach the latest OTA, but is preferable to nacking, and kicking them permanently --- pkg/arvo/lib/push-hook.hoon | 3 +++ pkg/arvo/mar/metadata/update-1.hoon | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/arvo/lib/push-hook.hoon b/pkg/arvo/lib/push-hook.hoon index 4c732eca06..8c9708c160 100644 --- a/pkg/arvo/lib/push-hook.hoon +++ b/pkg/arvo/lib/push-hook.hoon @@ -277,6 +277,9 @@ :: ++ unversioned ?> ?=([%ship @ @ *] t.path) + ?. =(min-version.config 0) + ~& >>> "unversioned req from: {}, nooping" + `this =/ =resource (de-path:resource t.path) =/ =vase diff --git a/pkg/arvo/mar/metadata/update-1.hoon b/pkg/arvo/mar/metadata/update-1.hoon index 8f066cefad..36036d1098 100644 --- a/pkg/arvo/mar/metadata/update-1.hoon +++ b/pkg/arvo/mar/metadata/update-1.hoon @@ -4,7 +4,6 @@ ++ grow |% ++ noun update - ++ metadata-update update ++ json (update:enjs:store update) -- ::