From 286c6c28e5e3f0a40e7ac89bd14c4aa0b7f500cc Mon Sep 17 00:00:00 2001
From: Hunter Miller <hunter@thisdot.co>
Date: Fri, 16 Jul 2021 10:55:41 -0500
Subject: [PATCH 1/4] embeds: converted to links for better usability

---
 .../src/views/apps/permalinks/app.tsx         |  2 +-
 .../src/views/apps/permalinks/embed.tsx       | 17 ++----
 .../src/views/components/GroupLink.tsx        | 59 +++++++++++--------
 3 files changed, 38 insertions(+), 40 deletions(-)

diff --git a/pkg/interface/src/views/apps/permalinks/app.tsx b/pkg/interface/src/views/apps/permalinks/app.tsx
index 8e8d22f04a..30763b6545 100644
--- a/pkg/interface/src/views/apps/permalinks/app.tsx
+++ b/pkg/interface/src/views/apps/permalinks/app.tsx
@@ -77,7 +77,7 @@ function GroupRoutes(props: { group: string; url: string }) {
             return null;
           }
           if(!graphKeys.has(`${ship.slice(1)}/${name}`)) {
-            if(graphKeys.size > 0) {
+            if(graphKeys.size > 1) { // TODO: Better loading logic see https://github.com/urbit/landscape/issues/1063
               return <Redirect
                 to={toQuery(
                   { auto: 'y', redir: location.pathname },
diff --git a/pkg/interface/src/views/apps/permalinks/embed.tsx b/pkg/interface/src/views/apps/permalinks/embed.tsx
index ae637ae594..9670c045b4 100644
--- a/pkg/interface/src/views/apps/permalinks/embed.tsx
+++ b/pkg/interface/src/views/apps/permalinks/embed.tsx
@@ -2,7 +2,7 @@ import { BaseAnchor, Box, Center, Col, Icon, Row, Text } from '@tlon/indigo-reac
 import { Association, GraphNode, resourceFromPath, GraphConfig } from '@urbit/api';
 import React, { useCallback, useEffect, useState } from 'react';
 import _ from 'lodash';
-import { useHistory, useLocation } from 'react-router-dom';
+import { Link, useLocation } from 'react-router-dom';
 import {
   getPermalinkForGraph, GraphPermalink as IGraphPermalink, parsePermalink
 } from '~/logic/lib/permalinks';
@@ -76,7 +76,6 @@ function GraphPermalink(
   }
 ) {
   const { full = false, showOurContact, pending, graph, group, index, transcluded } = props;
-  const history = useHistory();
   const location = useLocation();
   const { ship, name } = resourceFromPath(graph);
   const node = useGraphState(
@@ -114,11 +113,6 @@ function GraphPermalink(
   const showTransclusion = Boolean(association && node && transcluded < 1);
   const permalink = getPermalinkForGraph(group, graph, index);
 
-  const navigate = (e) => {
-    e.stopPropagation();
-    history.push(`/perma${permalink.slice(16)}`);
-  };
-
   const [nodeGroupHost, nodeGroupName] = association?.group.split('/').slice(-2) ?? ['Unknown', 'Unknown'];
   const [nodeChannelHost, nodeChannelName] = association?.resource
     .split('/')
@@ -141,15 +135,16 @@ function GraphPermalink(
 
   return (
     <Col
+      as={Link}
+      to={`/perma${permalink.slice(16)}`}
       width="100%"
       bg="white"
       maxWidth={full ? null : '500px'}
       border={full ? null : '1'}
       borderColor="lightGray"
       borderRadius={2}
-      cursor="pointer"
       onClick={(e) => {
-        navigate(e);
+        e.stopPropagation();
       }}
     >
       {loading && association && !errored && Placeholder((association.metadata.config as GraphConfig).graph)}
@@ -167,7 +162,6 @@ function GraphPermalink(
           showTransclusion={showTransclusion}
           icon={getModuleIcon((association.metadata.config as GraphConfig).graph as GraphModule)}
           title={association.metadata.title}
-          permalink={permalink}
         />
       )}
       {association && isInSameResource && transcluded === 2 && !loading && (
@@ -176,7 +170,6 @@ function GraphPermalink(
           showTransclusion={showTransclusion}
           icon={getModuleIcon((association.metadata.config as GraphConfig).graph as GraphModule)}
           title={association.metadata.title}
-          permalink={permalink}
         />
       )}
       {isInSameResource && transcluded !== 2 && !loading && <Row height='2' />}
@@ -185,7 +178,6 @@ function GraphPermalink(
           icon="Groups"
           showDetails={false}
           title={graph.slice(5)}
-          permalink={permalink}
         />
       )}
     </Col>
@@ -195,7 +187,6 @@ function GraphPermalink(
 function PermalinkDetails(props: {
   title: string;
   icon: any;
-  permalink: string;
   showTransclusion?: boolean;
   showDetails?: boolean;
   known?: boolean;
diff --git a/pkg/interface/src/views/components/GroupLink.tsx b/pkg/interface/src/views/components/GroupLink.tsx
index 998a525eed..88b96e2729 100644
--- a/pkg/interface/src/views/components/GroupLink.tsx
+++ b/pkg/interface/src/views/components/GroupLink.tsx
@@ -1,56 +1,63 @@
 import { Box, Col, Icon, Row, Text } from '@tlon/indigo-react';
 import React, { ReactElement, useCallback } from 'react';
-import { useHistory } from 'react-router-dom';
+import { Link } from 'react-router-dom';
 import { useModal } from '~/logic/lib/useModal';
 import useMetadataState, { usePreview } from '~/logic/state/metadata';
 import { PropFunc } from '~/types';
 import { JoinGroup } from '../landscape/components/JoinGroup';
 import { MetadataIcon } from '../landscape/components/MetadataIcon';
 
-export function GroupLink(
-  props: {
-    resource: string;
-    detailed?: boolean;
-  } & PropFunc<typeof Row>
-): ReactElement {
-  const { resource, ...rest } = props;
+type GroupLinkProps = {
+  resource: string;
+  detailed?: boolean;
+} & PropFunc<typeof Row>
+
+export function GroupLink({
+  resource,
+  borderColor,
+  ...rest
+}: GroupLinkProps): ReactElement {
   const name = resource.slice(6);
   const joined = useMetadataState(
     useCallback(s => resource in s.associations.groups, [resource])
   );
-  const history = useHistory();
 
   const { modal, showModal } = useModal({
     modal: <JoinGroup autojoin={name} />
-    });
+  });
 
   const { preview } = usePreview(resource);
 
   return (
-    <Box
-      maxWidth="500px"
-      cursor='pointer'
-      {...rest}
-      onClick={(e) => {
-        e.stopPropagation();
-      }}
-      backgroundColor='white'
-      borderColor={props.borderColor}
-    >
+    <>
       {modal}
       <Row
-        width="100%"
+        {...rest}
+        as={Link}
+        to={joined ? `/~landscape/ship/${name}` : `/perma/group/${name}`}
+        onClick={(e: React.MouseEvent<HTMLAnchorElement>) => {
+          e.stopPropagation();
+
+          if (e.metaKey || e.ctrlKey) {
+            return;
+          }
+
+          e.preventDefault();
+          showModal();
+        }}
         flexShrink={1}
         alignItems="center"
+        width="100%"
+        maxWidth="500px"
         py={2}
         pr={2}
-        onClick={
-          joined ? () => history.push(`/~landscape/ship/${name}`) : showModal
-        }
+        cursor='pointer'
+        backgroundColor='white'
+        borderColor={borderColor}
         opacity={preview ? '1' : '0.6'}
       >
         <MetadataIcon height={6} width={6} metadata={preview ? preview.metadata : { color: '0x0' , picture: '' }} />
-          <Col>
+        <Col>
           <Text ml={2} fontWeight="medium" mono={!preview}>
             {preview ? preview.metadata.title : name}
           </Text>
@@ -70,6 +77,6 @@ export function GroupLink(
           </Box>
         </Col>
       </Row>
-    </Box>
+    </>
   );
 }

From 35e01deed4cc6ac3da4407fa9dd0bbc5ab666987 Mon Sep 17 00:00:00 2001
From: Hunter Miller <hunter@thisdot.co>
Date: Fri, 16 Jul 2021 15:42:04 -0500
Subject: [PATCH 2/4] StatusBar: converting more things to links

Fixes urbit/landscape#509 and also adds same functionality to the rest of the StatusBar items
---
 pkg/interface/src/views/components/StatusBar.tsx | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/pkg/interface/src/views/components/StatusBar.tsx b/pkg/interface/src/views/components/StatusBar.tsx
index 03bb009a61..ad72ff0c66 100644
--- a/pkg/interface/src/views/components/StatusBar.tsx
+++ b/pkg/interface/src/views/components/StatusBar.tsx
@@ -8,7 +8,7 @@ import {
   Text
 } from '@tlon/indigo-react';
 import React, { useRef } from 'react';
-import { useHistory } from 'react-router-dom';
+import { Link, useHistory } from 'react-router-dom';
 import { Sigil } from '~/logic/lib/sigil';
 import { uxToHex } from '~/logic/lib/util';
 import useContactState from '~/logic/state/contact';
@@ -75,11 +75,12 @@ const StatusBar = (props) => {
     >
       <Row>
         <Button
+          as={Link}
+          to="/"
           width='32px'
           borderColor='lightGray'
           mr={2}
           px={2}
-          onClick={() => history.push('/')}
           {...props}
         >
           <Icon icon='Dashboard' color='black' />
@@ -126,9 +127,10 @@ const StatusBar = (props) => {
           <Icon icon="Bug" color="#000000" />
         </StatusBarItem>
         <StatusBarItem
+          as={Link}
+          to="/~landscape/messages"
           width='32px'
           mr={2}
-          onClick={() => props.history.push('/~landscape/messages')}
         >
           <Icon icon='Messages' />
         </StatusBarItem>
@@ -150,24 +152,26 @@ const StatusBar = (props) => {
               boxShadow='0px 0px 0px 3px'
             >
               <Row
+                as={Link}
+                to={`/~profile/~${ship}`}
                 color='black'
                 cursor='pointer'
                 fontSize={1}
                 fontWeight='500'
                 px={3}
                 py={2}
-                onClick={() => history.push(`/~profile/~${ship}`)}
               >
                 View Profile
               </Row>
               <Row
+                as={Link}
+                to="/~settings"
                 color='black'
                 cursor='pointer'
                 fontSize={1}
                 fontWeight='500'
                 px={3}
                 py={2}
-                onClick={() => history.push('/~settings')}
               >
                 System Preferences
               </Row>

From efde98d57e1a82015440a9c1697d506cba7866c7 Mon Sep 17 00:00:00 2001
From: Liam Fitzgerald <liam.fitzgerald@tlon.io>
Date: Mon, 19 Jul 2021 15:40:07 +1000
Subject: [PATCH 3/4] interface: prevent crash in reducers on new group DMs

Fixes urbit/landscape#1044
---
 pkg/interface/src/logic/reducers/group-update.ts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pkg/interface/src/logic/reducers/group-update.ts b/pkg/interface/src/logic/reducers/group-update.ts
index a008b64c62..798ec3d2d4 100644
--- a/pkg/interface/src/logic/reducers/group-update.ts
+++ b/pkg/interface/src/logic/reducers/group-update.ts
@@ -103,6 +103,9 @@ const addMembers = (json: GroupUpdate, state: GroupState): GroupState => {
   if ('addMembers' in json) {
     const { resource, ships } = json.addMembers;
     const resourcePath = resourceAsPath(resource);
+    if(!(resourcePath in state.groups)) {
+      return;
+    }
     for (const member of ships) {
       state.groups[resourcePath].members.add(member);
       if (

From 6edf6b5af426e2a4f351e8bdbb844b866c99292b Mon Sep 17 00:00:00 2001
From: Liam Fitzgerald <liam.fitzgerald@tlon.io>
Date: Tue, 20 Jul 2021 14:04:46 +1000
Subject: [PATCH 4/4] lens: remove contact importing

---
 pkg/arvo/app/lens.hoon | 2 --
 1 file changed, 2 deletions(-)

diff --git a/pkg/arvo/app/lens.hoon b/pkg/arvo/app/lens.hoon
index ed9c93328f..74734f42ee 100644
--- a/pkg/arvo/app/lens.hoon
+++ b/pkg/arvo/app/lens.hoon
@@ -25,8 +25,6 @@
     ^-  (list @tas)
     :~  %group-store
         %metadata-store
-        %contact-store
-        %contact-hook
         %invite-store
         %graph-store
     ==