urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2025-01-03 01:54:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

We shouldn't use (unit) as an implicit cancelation.

Browse Source
This commit is contained in:
Elliot Glaysher 2019-02-06 15:09:46 -08:00
parent 0e589f38f2
commit 8075a43380
3 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/vane/light.hoon
View File

@ -717,7 +717,7 @@
:: email discussions make it sound like fixing that might be hard, so
:: maybe i should just live with the way it is now?
::
:- [outbound-duct.state %give %http-client %request id `http-request]~
:- [outbound-duct.state %give %http-client %request id http-request]~
state
:: +receive: receives a response to an http-request we made
::

9
sys/zuse.hoon
View File

@ -2008,8 +2008,6 @@
:: TODO: We need to actually return a (map (unit @t) http-config)
:: so we can apply configurations on a per-site basis
::
:: TODO: THIS WAS %form. When done renaming, be done renaming.
::
[%set-config =http-config]
:: response: response to an event from earth
::
@ -2024,12 +2022,15 @@
:: +client-gift: effects the client can emit
::
++ client-gift
$% :: %http-request: outbound http-request to earth
$% :: %request: outbound http-request to earth
::
:: TODO: id is sort of wrong for this interface; the duct should
:: be enough to identify which request we're talking about?
::
[%request id=@ud request=(unit http-request)]
[%request id=@ud request=http-request]
:: %cancel-request: tell earth to cancel a previous %request
::
[%cancel-request id=@ud]
:: periodically sent as an update on the duct that sent %fetch
::
$: %progress

2
tests/sys/vane/light.hoon
View File

@ -1339,7 +1339,6 @@
%http-client
%request
id=0
~
method=%'GET'
url='http://www.example.com'
~
@ -1448,7 +1447,6 @@
%http-client
%request
id=0
~
method=%'GET'
url='http://www.example.com'
~