urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2024-12-22 18:31:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

graph-view: address review comments

Browse Source
This commit is contained in:
Liam Fitzgerald 2020-09-04 17:51:28 +10:00
parent fe17e48713
commit 881146e476
6 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/arvo/lib/graph-view.hoon
View File

@ -19,6 +19,7 @@
:~ create+create :~ create+create
delete+delete delete+delete
join+join join+join
leave+leave
::groupify+groupify ::groupify+groupify
::invite+invite ::invite+invite
== ==
@ -31,13 +32,18 @@
app+app app+app
associated+associated associated+associated
== ==
::
++ app ++ app
|= jon=json |= jon=json
^- app-name ^- app-name
?> ?=(%s -.jon) ?> ?=(%s -.jon)
~! app-name
%chat %chat
:: ::
++ leave
%- ot
:~ resource+dejs:resource
==
::
++ delete ++ delete
%- ot %- ot
:~ resource+dejs:resource :~ resource+dejs:resource
@ -51,12 +57,12 @@
:: ::
++ groupify !! ++ groupify !!
++ invite !! ++ invite !!
::
++ associated ++ associated
%- of %- of
:~ group+dejs:resource :~ group+dejs:resource
policy+policy:dejs:group-store policy+policy:dejs:group-store
== ==
-- --
-- --
-- --

1
pkg/arvo/sur/graph-view.hoon
View File

@ -38,6 +38,7 @@
=associated =associated
== ==
[%delete rid=resource] [%delete rid=resource]
[%leave rid=resource]
[%join rid=resource =ship] [%join rid=resource =ship]
::[%invite rid=resource ships=(set ship)] ::[%invite rid=resource ships=(set ship)]
:: [%groupify rid=resource title=@t description=@t] :: [%groupify rid=resource title=@t description=@t]

3
pkg/arvo/ted/graph/create.hoon
View File

@ -5,6 +5,7 @@
++ strand strand:spider ++ strand strand:spider
++ poke poke:strandio ++ poke poke:strandio
++ poke-our poke-our:strandio ++ poke-our poke-our:strandio
::
++ handle-group ++ handle-group
|= [rid=resource =associated:graph-view] |= [rid=resource =associated:graph-view]
=/ m (strand ,resource) =/ m (strand ,resource)
@ -17,6 +18,7 @@
(poke-our %group-push-hook %push-hook-action !>([%add rid])) (poke-our %group-push-hook %push-hook-action !>([%add rid]))
(pure:m rid) (pure:m rid)
-- --
::
=, strand=strand:spider =, strand=strand:spider
^- thread:spider ^- thread:spider
|= arg=vase |= arg=vase
@ -54,4 +56,3 @@
;< ~ bind:m ;< ~ bind:m
(poke-our %metadata-hook %metadata-hook-action !>([%add-owned group-path])) (poke-our %metadata-hook %metadata-hook-action !>([%add-owned group-path]))
(pure:m !>(~)) (pure:m !>(~))

7
pkg/arvo/ted/graph/delete.hoon
View File

@ -5,6 +5,7 @@
++ strand strand:spider ++ strand strand:spider
++ poke poke:strandio ++ poke poke:strandio
++ poke-our poke-our:strandio ++ poke-our poke-our:strandio
::
++ scry-metadata ++ scry-metadata
|= rid=resource |= rid=resource
=/ m (strand ,(unit resource)) =/ m (strand ,(unit resource))
@ -16,6 +17,7 @@
/noun /noun
== ==
(pure:m (bind pax de-path:resource)) (pure:m (bind pax de-path:resource))
::
++ scry-group ++ scry-group
|= rid=resource |= rid=resource
=/ m (strand ,(unit resource)) =/ m (strand ,(unit resource))
@ -27,6 +29,7 @@
/noun /noun
== ==
(pure:m (need ugroup)) (pure:m (need ugroup))
::
++ delete-graph ++ delete-graph
|= rid=resource |= rid=resource
=/ m (strand ,~) =/ m (strand ,~)
@ -36,6 +39,7 @@
(poke-our %graph-store %graph-update [%archive-graph rid.action]) (poke-our %graph-store %graph-update [%archive-graph rid.action])
(pure:m ~) (pure:m ~)
-- --
::
^- thread:spider ^- thread:spider
|= arg=vase |= arg=vase
=/ m (strand ,vase) =/ m (strand ,vase)
@ -53,9 +57,8 @@
?. hidden.u.ugroup ?. hidden.u.ugroup
(delete-graph rid.action) (delete-graph rid.action)
;< ~ bind:m ;< ~ bind:m
(poke-our %group-push-hook %pull-hook-action [%remove rid.action]) (poke-our %group-push-hook %push-hook-action [%remove rid.action])
;< ~ bind:m ;< ~ bind:m
(poke-our %group-store %group-action !>([%remove-group rid.action]) (poke-our %group-store %group-action !>([%remove-group rid.action])
;< ~ bind:m (delete-graph rid.action) ;< ~ bind:m (delete-graph rid.action)
(pure:m !>(~)) (pure:m !>(~))

6
pkg/arvo/ted/graph/join.hoon
View File

@ -5,14 +5,16 @@
++ strand strand:spider ++ strand strand:spider
++ poke poke:strandio ++ poke poke:strandio
++ poke-our poke-our:strandio ++ poke-our poke-our:strandio
::
++ check-live ++ check-live
|= who=ship |= who=ship
=/ m (strand ,~) =/ m (strand ,~)
^- form:m ^- form:m
%+ (set-timeout:strandio ,~) ~s10 %+ (set-timeout:strandio ,~) ~s20
;< ~ bind:m ;< ~ bind:m
(poke [who %hood] %helm-hi !>(~)) (poke [who %hood] %helm-hi !>(~))
(pure:m ~) (pure:m ~)
::
++ scry-metadata ++ scry-metadata
|= rid=resource |= rid=resource
=/ m (strand ,(unit resource)) =/ m (strand ,(unit resource))
@ -29,6 +31,7 @@
?~ u.pax ~ ?~ u.pax ~
`(de-path:resource n.u.pax) `(de-path:resource n.u.pax)
-- --
::
^- thread:spider ^- thread:spider
|= arg=vase |= arg=vase
=/ m (strand ,vase) =/ m (strand ,vase)
@ -63,4 +66,3 @@
%+ poke-our %graph-pull-hook %+ poke-our %graph-pull-hook
pull-hook-action+!>([%add ship.action rid.action])) pull-hook-action+!>([%add ship.action rid.action]))
(pure:m !>(~)) (pure:m !>(~))

5
pkg/arvo/ted/graph/leave.hoon
View File

@ -5,6 +5,7 @@
++ strand strand:spider ++ strand strand:spider
++ poke poke:strandio ++ poke poke:strandio
++ poke-our poke-our:strandio ++ poke-our poke-our:strandio
::
++ scry-metadata ++ scry-metadata
|= rid=resource |= rid=resource
=/ m (strand ,(unit resource)) =/ m (strand ,(unit resource))
@ -16,6 +17,7 @@
/noun /noun
== ==
(pure:m (bind pax de-path:resource)) (pure:m (bind pax de-path:resource))
::
++ scry-group ++ scry-group
|= rid=resource |= rid=resource
=/ m (strand ,(unit resource)) =/ m (strand ,(unit resource))
@ -27,6 +29,7 @@
/noun /noun
== ==
(pure:m (need ugroup)) (pure:m (need ugroup))
::
++ delete-graph ++ delete-graph
|= rid=resource |= rid=resource
=/ m (strand ,~) =/ m (strand ,~)
@ -36,6 +39,7 @@
(poke-our %graph-store %graph-update [%archive-graph rid.action]) (poke-our %graph-store %graph-update [%archive-graph rid.action])
(pure:m ~) (pure:m ~)
-- --
::
^- thread:spider ^- thread:spider
|= arg=vase |= arg=vase
=/ m (strand ,vase) =/ m (strand ,vase)
@ -58,4 +62,3 @@
(poke-our %group-store %group-action !>([%remove-group rid.action]) (poke-our %group-store %group-action !>([%remove-group rid.action])
;< ~ bind:m (delete-graph rid.action) ;< ~ bind:m (delete-graph rid.action)
(pure:m !>(~)) (pure:m !>(~))