From b92cfdb242bbd3c109d5523cfbf2dc260a1d2ac4 Mon Sep 17 00:00:00 2001 From: fang Date: Sat, 24 Oct 2020 01:48:51 +0200 Subject: [PATCH] eyre: produce moves in correct order Because storing in reverse order means producing in reverse reverse order. The tests didn't catch this because they, too, were infected with the "reverse moves" meme. --- pkg/arvo/sys/vane/eyre.hoon | 2 +- pkg/arvo/tests/sys/vane/eyre.hoon | 38 +++++++++++++++---------------- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/pkg/arvo/sys/vane/eyre.hoon b/pkg/arvo/sys/vane/eyre.hoon index 8744d142a2..111f977cc0 100644 --- a/pkg/arvo/sys/vane/eyre.hoon +++ b/pkg/arvo/sys/vane/eyre.hoon @@ -1585,7 +1585,7 @@ == =? next-id kicking +(next-id) :: - :- moves + :- (flop moves) %_ state session.channel-state %+ ~(put by session.channel-state.state) channel-id diff --git a/pkg/arvo/tests/sys/vane/eyre.hoon b/pkg/arvo/tests/sys/vane/eyre.hoon index b5323038fe..a79508a628 100644 --- a/pkg/arvo/tests/sys/vane/eyre.hoon +++ b/pkg/arvo/tests/sys/vane/eyre.hoon @@ -1849,7 +1849,7 @@ ~ == ^= expected-moves - ~ ::NOTE tested elsewher + ~ ::NOTE tested elsewhere == :: user gets sent multiple subscription results :: @@ -1889,24 +1889,6 @@ == ^= moves :~ :* duct=~[/http-get-open] - %give - %response - %continue - :- ~ - %- as-octt:mimes:html - """ - id: {((d-co:co 1) +(clog-threshold:eyre-gate))} - data: \{"id":1,"response":"quit"} - - - """ - complete=%.n - == - :* duct=~[/http-put-request] %pass - /channel/subscription/'0123456789abcdef'/'1'/~nul/two - %g %deal [~nul ~nul] %two %leave ~ - == - :* duct=~[/http-get-open] %give %response %continue @@ -1920,6 +1902,24 @@ """ complete=%.n == + :* duct=~[/http-put-request] %pass + /channel/subscription/'0123456789abcdef'/'1'/~nul/two + %g %deal [~nul ~nul] %two %leave ~ + == + :* duct=~[/http-get-open] + %give + %response + %continue + :- ~ + %- as-octt:mimes:html + """ + id: {((d-co:co 1) +(clog-threshold:eyre-gate))} + data: \{"id":1,"response":"quit"} + + + """ + complete=%.n + == == == results