From 8efc0a90063b098766fdd348345143ced6272a4e Mon Sep 17 00:00:00 2001
From: Hunter Miller <hunter@tlon.io>
Date: Tue, 11 Jan 2022 16:43:57 -0600
Subject: [PATCH] dms: hiding delete for dms and hiding dropdown if only reply

---
 .../src/views/apps/chat/DmResource.tsx        |   9 +-
 .../apps/chat/components/ChatMessage.tsx      | 194 ++++--------------
 2 files changed, 45 insertions(+), 158 deletions(-)

diff --git a/pkg/interface/src/views/apps/chat/DmResource.tsx b/pkg/interface/src/views/apps/chat/DmResource.tsx
index 4c56d32fd5..6673f26df6 100644
--- a/pkg/interface/src/views/apps/chat/DmResource.tsx
+++ b/pkg/interface/src/views/apps/chat/DmResource.tsx
@@ -1,4 +1,4 @@
-import { acceptDm, cite, Content, declineDm, deSig, Post, removeDmMessage } from '@urbit/api';
+import { acceptDm, cite, Content, declineDm, deSig, Post } from '@urbit/api';
 import React, { useCallback, useEffect } from 'react';
 import _ from 'lodash';
 import bigInt from 'big-integer';
@@ -77,7 +77,7 @@ export function DmResource(props: DmResourceProps) {
   );
 
   useEffect(() => {
-    if(!dm) {
+    if(dm.size === 0) {
       getNewest(`~${window.ship}`, 'dm-inbox', 100, `/${patp2dec(ship)}`);
     }
   }, [ship, dm]);
@@ -127,10 +127,6 @@ export function DmResource(props: DmResourceProps) {
     [ship, addDmMessage]
   );
 
-  const onDelete = useCallback((msg: Post) => {
-    airlock.poke(removeDmMessage(`~${window.ship}`, msg.index));
-  }, []);
-
   const onAccept = async () => {
     await airlock.poke(acceptDm(ship));
   };
@@ -208,7 +204,6 @@ export function DmResource(props: DmResourceProps) {
           onReply={quoteReply}
           fetchMessages={fetchMessages}
           dismissUnread={dismissUnread}
-          onDelete={onDelete}
           getPermalink={() => undefined}
           isAdmin={false}
           onSubmit={onSubmit}
diff --git a/pkg/interface/src/views/apps/chat/components/ChatMessage.tsx b/pkg/interface/src/views/apps/chat/components/ChatMessage.tsx
index 5e59b19d23..8fb25e7747 100644
--- a/pkg/interface/src/views/apps/chat/components/ChatMessage.tsx
+++ b/pkg/interface/src/views/apps/chat/components/ChatMessage.tsx
@@ -284,6 +284,9 @@ const MessageActionItem = (props) => {
 const MessageActions = ({ onReply, onDelete, msg, isAdmin, permalink }) => {
   const isOwn = () => msg.author === window.ship;
   const { doCopy, copyDisplay } = useCopy(permalink, 'Copy Message Link');
+  const showCopyMessageLink = Boolean(permalink);
+  const showDelete = (isAdmin || isOwn()) && onDelete;
+  const showDropdown = showCopyMessageLink || showDelete;
 
   return (
     <Box
@@ -304,49 +307,46 @@ const MessageActions = ({ onReply, onDelete, msg, isAdmin, permalink }) => {
         >
           <Icon icon='Chat' size={3} />
         </Box>
-        <Dropdown
-          dropWidth='250px'
-          width='auto'
-          alignY='top'
-          alignX='right'
-          flexShrink={0}
-          offsetY={8}
-          offsetX={-24}
-          options={
-            <Col
-              py={2}
-              backgroundColor='white'
-              color='washedGray'
-              border={1}
-              borderRadius={2}
-              borderColor='lightGray'
-              boxShadow='0px 0px 0px 3px'
-            >
-              <MessageActionItem onClick={() => onReply(msg)}>
-                Reply
-              </MessageActionItem>
-              {permalink ? (
-                <MessageActionItem onClick={doCopy}>
-                  {copyDisplay}
+        {showDropdown && (
+          <Dropdown
+            dropWidth='250px'
+            width='auto'
+            alignY='top'
+            alignX='right'
+            flexShrink={0}
+            offsetY={8}
+            offsetX={-24}
+            options={
+              <Col
+                py={2}
+                backgroundColor='white'
+                color='washedGray'
+                border={1}
+                borderRadius={2}
+                borderColor='lightGray'
+                boxShadow='0px 0px 0px 3px'
+              >
+                <MessageActionItem onClick={() => onReply(msg)}>
+                  Reply
                 </MessageActionItem>
-              ) : null }
-              {(isAdmin || isOwn()) ? (
-                <MessageActionItem onClick={e => onDelete(msg)} color='red'>
-                  Delete Message
-                </MessageActionItem>
-              ) : null}
-              {false && (
-                <MessageActionItem onClick={e => console.log(e)}>
-                  View Signature
-                </MessageActionItem>
-              )}
-            </Col>
-          }
-        >
-          <Box padding={1} size={'24px'} cursor='pointer'>
-            <Icon icon='Menu' size={3} />
-          </Box>
-        </Dropdown>
+                {showCopyMessageLink && (
+                  <MessageActionItem onClick={doCopy}>
+                    {copyDisplay}
+                  </MessageActionItem>
+                )}
+                {showDelete && (
+                  <MessageActionItem onClick={e => onDelete(msg)} color='red'>
+                    Delete Message
+                  </MessageActionItem>
+                )}
+              </Col>
+            }
+          >
+            <Box padding={1} size={'24px'} cursor='pointer'>
+              <Icon icon='Menu' size={3} />
+            </Box>
+          </Dropdown>
+        )}
       </Row>
     </Box>
   );
@@ -418,7 +418,7 @@ function ChatMessage(props: ChatMessageProps) {
   }
 
   const onReply = props?.onReply || emptyCallback;
-  const onDelete = props?.onDelete || emptyCallback;
+  const onDelete = props?.onDelete; // If missing hide delete action
   const transcluded = props?.transcluded || 0;
   const renderSigil = props.renderSigil || (Boolean(nextMsg && msg.author !== nextMsg.author) ||
         !nextMsg
@@ -513,111 +513,3 @@ function ChatMessage(props: ChatMessageProps) {
 export default React.memo(React.forwardRef((props: Omit<ChatMessageProps, 'innerRef'>, ref: any) => (
   <ChatMessage {...props} innerRef={ref} />
 )));
-
-export const MessagePlaceholder = ({
-  height,
-  index,
-  className = '',
-  style = {},
-  ...props
-}) => (
-  <Box
-    width='100%'
-    fontSize={2}
-    pl={3}
-    pt={4}
-    pr={3}
-    display='flex'
-    lineHeight='tall'
-    className={className}
-    style={{ height, ...style }}
-    {...props}
-  >
-    <Box
-      pr={3}
-      verticalAlign='top'
-      backgroundColor='white'
-      style={{ float: 'left' }}
-    >
-      <Text
-        display='block'
-        background='washedGray'
-        width='24px'
-        height='24px'
-        borderRadius='50%'
-        style={{
-          visibility: index % 5 == 0 ? 'initial' : 'hidden'
-        }}
-      ></Text>
-    </Box>
-    <Box
-      style={{ float: 'right', flexGrow: 1 }}
-      color='black'
-      className='clamp-message'
-    >
-      <Box
-        className='hide-child'
-        paddingTop={4}
-        style={{ visibility: index % 5 == 0 ? 'initial' : 'hidden' }}
-      >
-        <Text
-          display='inline-block'
-          verticalAlign='middle'
-          fontSize={0}
-          color='washedGray'
-          cursor='default'
-        >
-          <Text maxWidth='32rem' display='block'>
-            <Text
-              backgroundColor='washedGray'
-              borderRadius={2}
-              display='block'
-              width='100%'
-              height='100%'
-            ></Text>
-          </Text>
-        </Text>
-        <Text
-          display='inline-block'
-          mono
-          verticalAlign='middle'
-          fontSize={0}
-          color='washedGray'
-        >
-          <Text
-            background='washedGray'
-            borderRadius={2}
-            display='block'
-            height='1em'
-            style={{ width: `${((index % 3) + 1) * 3}em` }}
-          ></Text>
-        </Text>
-        <Text
-          mono
-          verticalAlign='middle'
-          fontSize={0}
-          ml={2}
-          color='washedGray'
-          borderRadius={2}
-          display={['none', 'inline-block']}
-          className='child'
-        >
-          <Text
-            backgroundColor='washedGray'
-            borderRadius={2}
-            display='block'
-            width='100%'
-            height='100%'
-          ></Text>
-        </Text>
-      </Box>
-      <Text
-        display='block'
-        backgroundColor='washedGray'
-        borderRadius={2}
-        height='1em'
-        style={{ width: `${(index % 5) * 20}%` }}
-      ></Text>
-    </Box>
-  </Box>
-);