urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2024-12-19 16:51:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

VirtualScroller: rework scroll initialisation

Browse Source 
Calling restore if the scroll is locked simply resets the scroll,
instead of using the usual adjustment algorithm
This commit is contained in:
Liam Fitzgerald 2021-04-24 12:19:33 +10:00
parent 9ad12777ae
commit bc4f26b2b3
No known key found for this signature in database
GPG Key ID: D390E12C61D1CFFB
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/interface/src/views/components/VirtualScroller.tsx
View File

@ -146,8 +146,6 @@ export default class VirtualScroller<T> extends Component<VirtualScrollerProps<T
private cleanupRefInterval: NodeJS.Timeout | null = null;
private initScroll: NodeJS.Timeout | null = null;
constructor(props: VirtualScrollerProps<T>) {
super(props);
this.state = {
@ -170,15 +168,9 @@ export default class VirtualScroller<T> extends Component<VirtualScrollerProps<T
componentDidMount() {
this.updateVisible(0);
this.resetScroll();
this.loadTop();
this.loadBottom();
this.cleanupRefInterval = setInterval(this.cleanupRefs, 5000);
this.initScroll = setTimeout(() => {
log('scroll', 'initialised scroll');
this.restore();
this.initScroll = null;
}, 100);
}
@ -429,8 +421,11 @@ export default class VirtualScroller<T> extends Component<VirtualScrollerProps<T
log('bail', 'Deep restore');
return;
}
if(this.initScroll) {
log('bail', 'still initialising scroll');
if(this.scrollLocked) {
this.resetScroll();
this.savedIndex = null;
this.savedDistance = 0;
this.saveDepth--;
return;
}