From 0b0d2ca2a89814acc2c6c12f655b1c9080e8cc61 Mon Sep 17 00:00:00 2001
From: Elliot Glaysher <elliot@tlon.io>
Date: Sun, 2 Dec 2018 14:05:10 -0800
Subject: [PATCH 1/2] Prime the worm cache in arvo with scry types

The majority of time in handling a scry is spent in the compiler since it
doesn't use the compiler cache since scrying can't have side-effects and modify
the cache. So prime the worm cache at vane install time so the cache is
prepopulated before we call a scry.

This shaves off >10ms per scry.
---
 sys/arvo.hoon | 66 ++++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 52 insertions(+), 14 deletions(-)

diff --git a/sys/arvo.hoon b/sys/arvo.hoon
index 487b07e575..e393e27b63 100644
--- a/sys/arvo.hoon
+++ b/sys/arvo.hoon
@@ -65,6 +65,8 @@
 ++  ovum  {p/wire q/curd}                               ::  typeless ovum
 ++  pane  (list {p/@tas q/vase})                        ::  kernel modules
 ++  pone  (list {p/@tas q/vise})                        ::  kernel modules old
++$  scry-sample
+  [fur=(unit (set monk)) ren=@tas why=shop syd=desk lot=coin tyl=path]
 ++  ship  @p                                            ::  network identity
 ++  sink  (trel bone ship path)                         ::  subscription
 ++  sley  $-  {* (unit (set monk)) term beam}           ::  namespace function
@@ -136,8 +138,43 @@
     =+  gen=(rain pax txt)
     =+  rev=(slym (slap bud gen) bud)
     =+  syg=(slym rev arg)
-    ~|  %load-lost
-    +>.^$(vase.vane (slam (slap syg [%limb %load]) (slap rig [%limb %stay])))
+    ::  update the vane itself
+    ::
+    ::    We don't cache the +slap/+slam types because they're only used once
+    ::    right here; they'll never be used again.
+    ::
+    =.  vase.vane
+      ~|  %load-lost
+      (slam (slap syg [%limb %load]) (slap rig [%limb %stay]))
+    ::  prime the new compiler cache
+    ::
+    prime
+  ::  reset and prime the worm cache for scrys
+  ::
+  ::    If the +slap/+slym in scry isn't cached, we spend the majority of
+  ::    the time in a scry in the compiler. The +scry gate cannot have side
+  ::    effects so we can't modify the cache at access time. So we seed the
+  ::    cache with all the things +scry will need when we install the vane
+  ::
+  ++  prime
+    ^+  ..prime
+    ::
+    %_    ..prime
+        worm.vane
+      ::  reset cache and add in vane activation entry
+      ::
+      =^  rig  worm.vane
+        (~(slym wa *worm) vase.vane *[@da @ slyd])
+      ::  cache the access of the %scry arm
+      ::
+      =^  fun  worm.vane  (~(slap wa worm.vane) rig [%limb %scry])
+      ::  cache the call to +mint that the +slym in +scry will do
+      ::
+      =^  pro  worm.vane  (~(mint wa worm.vane) p.fun [%limb %$])
+      ::  cache the call to +mint that the +slot does for the return call
+      ::
+      +:(~(mint wa worm.vane) p.pro [%$ 7])
+    ==
   ::
   ++  wink                                              ::  deploy
     |=  {now/@da eny/@ ski/slyd}
@@ -282,19 +319,20 @@
           ==
       ^-  (unit (unit (cask)))
       ::  ~&  [%arvo-scry ren bed]
-      =+  ^=  old
-          :*  fur
-              ren
-              [%& p.bed]
-              q.bed
-              `coin`[%$ r.bed]
-              (flop s.bed)
-          ==
+      =/  old=scry-sample
+        :*  fur
+            ren
+            [%& p.bed]
+            q.bed
+            `coin`[%$ r.bed]
+            (flop s.bed)
+        ==
       ^-  (unit (unit (cask)))
-      =+  pro=(slym (slap rig [%limb %scry]) old)
+      =+  fun=-:(~(slap wa worm.vane) rig [%limb %scry])
+      =+  pro=-:(~(slym wa worm.vane) fun old)
       ?~  q.pro  ~
       ?~  +.q.pro  [~ ~]
-      =+  dat=(slot 7 pro)
+      =+  dat=-:(~(slot wa worm.vane) 7 pro)
       [~ ~ (mark -.q.dat) +.q.dat]
     ::
     ++  soar                                            ::  scrub vane
@@ -346,7 +384,7 @@
   ~&  [%vane-parsed `@p`(mug gen)]
   =+  pro=(vent lal vil bud [(slym (slap bud gen) bud) *worm])
   ~&  [%vane-compiled `@p`(mug pro)]
-  pro
+  prime:pro
 ::
 ++  viol                                                ::  vane tools
   |=  but/type
@@ -634,7 +672,7 @@
       =+  vin=(vint lal.fav vil bud pax.fav txt.fav)
       ?~  vin
         vanes
-      [[lal.fav vase.vane:u.vin *worm] vanes]
+      [[lal.fav vane:u.vin] vanes]
     ?.  =(lal.fav label.i.vanes)
       [i.vanes $(vanes t.vanes)]
       ~&  [%vane `@tas`lal.fav pax.fav `@p`(mug txt.fav)]

From 75341be2d8a21b8d6fa0e6567d6f201df75609b8 Mon Sep 17 00:00:00 2001
From: Elliot Glaysher <elliot@tlon.io>
Date: Mon, 3 Dec 2018 10:45:54 -0800
Subject: [PATCH 2/2] Don't use slot in +scry since the type is never used.

---
 sys/arvo.hoon | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/sys/arvo.hoon b/sys/arvo.hoon
index e393e27b63..8f64298990 100644
--- a/sys/arvo.hoon
+++ b/sys/arvo.hoon
@@ -170,10 +170,7 @@
       =^  fun  worm.vane  (~(slap wa worm.vane) rig [%limb %scry])
       ::  cache the call to +mint that the +slym in +scry will do
       ::
-      =^  pro  worm.vane  (~(mint wa worm.vane) p.fun [%limb %$])
-      ::  cache the call to +mint that the +slot does for the return call
-      ::
-      +:(~(mint wa worm.vane) p.pro [%$ 7])
+      +:(~(mint wa worm.vane) p.fun [%limb %$])
     ==
   ::
   ++  wink                                              ::  deploy
@@ -332,8 +329,8 @@
       =+  pro=-:(~(slym wa worm.vane) fun old)
       ?~  q.pro  ~
       ?~  +.q.pro  [~ ~]
-      =+  dat=-:(~(slot wa worm.vane) 7 pro)
-      [~ ~ (mark -.q.dat) +.q.dat]
+      =/  dat  +>.q.pro
+      [~ ~ (mark -.dat) +.dat]
     ::
     ++  soar                                            ::  scrub vane
       |=  sev/vase