From 8b6b1918eba95ccbeb9fae5ef25d6af54ac7beec Mon Sep 17 00:00:00 2001 From: Joe Bryan Date: Wed, 16 Jan 2019 12:03:36 -0500 Subject: [PATCH 1/3] don't retry, always advance after successful :acme registrations --- app/acme.hoon | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/acme.hoon b/app/acme.hoon index e829ba71fa..34fad9979b 100644 --- a/app/acme.hoon +++ b/app/acme.hoon @@ -494,6 +494,10 @@ :: ++ register ^+ this + ?. =(~ reg.act) + ?: =(~ next-order) + this + (validate-domain:effect 0) =/ =json [%o (my [['termsOfServiceAgreed' b+&] ~])] :: XX date in wire? :: From ce2cab4da2641c85a013a481125cc4c9c1eafd5e Mon Sep 17 00:00:00 2001 From: Joe Bryan Date: Wed, 16 Jan 2019 12:04:15 -0500 Subject: [PATCH 2/3] adds some more details to :acme %dbug pokes --- app/acme.hoon | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/app/acme.hoon b/app/acme.hoon index 34fad9979b..51561706bd 100644 --- a/app/acme.hoon +++ b/app/acme.hoon @@ -1160,15 +1160,25 @@ this :: %dbug-account - ~& [%private (ring:en:pem:pkcs1 key.act)] - ~& [%public (pass:en:pem:pkcs1 key.act)] ~& registered=reg.act + ~& [%public (pass:en:pem:pkcs1 key.act)] + ~? !=(~ sek.key.act) + [%private (ring:en:pem:pkcs1 key.act)] this :: %dbug-certificate ?~ liv ~&(~ this) ~& [%key (ring:en:pem:pkcs8 key.u.liv)] ~& [%cert `wain`cer.u.liv] + ~& [%expires exp.u.liv] + ~& :- %domains + (join ', ' (turn ~(tap in dom.u.liv) |=(a=turf (join '.' a)))) + this + :: + %dbug-history + ~& [%account-history act.hit] + ~& [%config-history fig.hit] + ~& [%failed-order-history fal.hit] this :: %init From e7049e90b23bda89d327b6b868a43c07ad67763d Mon Sep 17 00:00:00 2001 From: Joe Bryan Date: Wed, 16 Jan 2019 12:04:45 -0500 Subject: [PATCH 3/3] no-op instead of crash on spurious :dns binding creation retries --- app/dns.hoon | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/dns.hoon b/app/dns.hoon index 7a8c24638d..259bba45c6 100644 --- a/app/dns.hoon +++ b/app/dns.hoon @@ -792,7 +792,10 @@ ++ do-create |= [him=ship for=ship try=@ud] ^+ this - =/ tar (~(got by pen.nam) him) + =/ pending (~(get by pen.nam) him) + ?~ pending + this + =* tar u.pending =/ =wire (http-wire try /create/(scot %p him)/for/(scot %p for)) =/ pre=(unit [id=@ta tar=target])