urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2025-01-02 01:25:55 +03:00
Code Issues Packages Projects Releases Wiki Activity

hoon: refine +fish:ar and +lose:ar

Browse Source 
They were not handling the %over and %spec cases correctly. We update
the %over cases to recurse as they should, and the %spec cases to +mint
and +crop respectively.

Co-authored-by: joemfb <joemfb@users.noreply.github.com>
This commit is contained in:
fang 2022-07-01 14:51:55 +02:00
parent bf9d3752e0
commit e35fa977a2
No known key found for this signature in database
GPG Key ID: EB035760C1BBA972
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
pkg/arvo/sys/hoon.hoon
View File

@ -8846,9 +8846,14 @@
%dbug $(skin skin.skin) %dbug $(skin skin.skin)
%help $(skin skin.skin) %help $(skin skin.skin)
%name $(skin skin.skin) %name $(skin skin.skin)
%over $(skin skin.skin) %over ::TODO (find -> tend should just be a function)
%spec $(skin skin.skin) ::NOTE might need to guard with +feel, crashing is too strict
%wash [%1 1] ~| %oops-guess-you-needed-feel-after-all
=+ fid=(find %read wing.skin)
?> &(?=(%& -.fid) ?=(%& -.q.p.fid))
[%7 [%0 (tend p.p.fid)] $(skin skin.skin, sut p.q.p.fid)]
%spec q:(~(mint ut ref) %noun [%fits ~(example ax spec.skin) [&+1 ~]])
%wash [%1 1] ::TODO shouldn't this always _match_?
== ==
:: ::
:: -gain: make a $type by restricting .ref to .skin :: -gain: make a $type by restricting .ref to .skin
@ -9019,8 +9024,12 @@
%dbug $(skin skin.skin) %dbug $(skin skin.skin)
%help $(skin skin.skin) %help $(skin skin.skin)
%name $(skin skin.skin) %name $(skin skin.skin)
%over $(skin skin.skin) %over ::TODO if we guard in +fish (+feel), we have to guard again here
%spec $(skin skin.skin) $(skin skin.skin, sut (~(play ut sut) %wing wing.skin))
%spec =/ yon $(skin skin.skin)
=/ hit (~(play ut sut) ~(example ax spec.skin))
?< (~(nest ut hit) | yon)
(~(crop ut yon) hit)
%wash ref %wash ref
== ==
-- --