urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2024-12-01 06:35:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

hark-group-hook: address review comments

Browse Source
This commit is contained in:
Liam Fitzgerald 2020-10-22 11:30:18 +10:00
parent 4237d2caf6
commit f3fec6ac74
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/arvo/app/hark-group-hook.hoon
View File

@ -40,9 +40,8 @@
++ on-load ++ on-load
|= old=vase |= old=vase
^- (quip card _this) ^- (quip card _this)
:_ this(state !<(state-0 old)) `this(state !<(state-0 old))
~ ::
::
++ on-watch on-watch:def ++ on-watch on-watch:def
:: ::
++ on-poke ++ on-poke
@ -118,7 +117,7 @@
=/ =index:store =/ =index:store
[%group resource.update -.update] [%group resource.update -.update]
:_ state :_ state
~[(add-unread:ha index notification)] ~[(add-unread index notification)]
:: +metadata-update is stubbed for now, for the following reasons :: +metadata-update is stubbed for now, for the following reasons
:: - There's no semantic difference in metadata-store between :: - There's no semantic difference in metadata-store between
:: adding and editing a channel :: adding and editing a channel
@ -128,6 +127,12 @@
|= update=metadata-update:metadata-store |= update=metadata-update:metadata-store
^- (quip card _state) ^- (quip card _state)
[~ state] [~ state]
::
++ add-unread
|= [=index:store =notification:store]
^- card
=- [%pass / %agent [our.bowl %hark-store] %poke -]
hark-action+!>([%add index notification])
-- --
:: ::
++ on-peek on-peek:def ++ on-peek on-peek:def
@ -139,11 +144,6 @@
|_ =bowl:gall |_ =bowl:gall
+* met ~(. metadata bowl) +* met ~(. metadata bowl)
:: ::
++ add-unread
|= [=index:store =notification:store]
^- card
[%pass / %agent [our.bowl %hark-store] %poke %hark-action !>([%add index notification])]
::
++ watch-groups ++ watch-groups
^- card ^- card
[%pass /group %agent [our.bowl %group-store] %watch /groups] [%pass /group %agent [our.bowl %group-store] %watch /groups]