1
1
mirror of https://github.com/urbit/shrub.git synced 2024-12-26 05:23:35 +03:00
Commit Graph

1217 Commits

Author SHA1 Message Date
Ted Blackman
155ab60609
ford: dequeue orphans
@ixv recently uncovered a bug () in Ford that caused certain
rebuilds to crash. @Fang- and I believe this change should fix the bug,
and we have confirmed that the reproduction that used to fail about two
thirds of the time now has not failed at all in the ten or so times
we've run it since then. @Fang- is still running more tests to confirm
the fix with more certainty.

It turned out the cause was that (depending on the rebuild order, which
is unspecified and should not need to be specified), Ford could enqueue
a provisional sub-build to be run but then, later in the same +gather
call, discover that the sub-build was in fact an orphan and delete it
from builds.state accordingly. Then when Ford tried to run the
sub-build, it would have already been deleted from the state, so Ford
would crash when trying to process its result in +reduce.

The fix was to make sure that when we discover a provisional sub-build
is orphaned, dequeue it from candidate-builds and next-builds to make
sure we don't try to run it. I'm about 95% sure this fix completely
solves the bug.
2020-01-28 17:29:24 +04:00
Fang
f4ed3fe980
clay: document %t care 2020-01-22 21:23:14 -08:00
Jared Tobin
267081424b
Merge branch 'yt-preview' ()
* origin/yt-preview:
  chat: add expandable youtube embed messages

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-22 15:14:37 +04:00
Anthony Arroyo
b96d6c5b5f
chat: add expandable youtube embed messages
YouTube links now have a [embed] link that expands an inline embed of
the video. Embeds don't load until clicked, so don't fear the tracker.
2020-01-22 15:01:01 +04:00
Jared Tobin
c182672b54
Merge branch 'ames-goof' ()
* origin/ames-goof:
  ames: adjust route update logic

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-22 13:14:39 +04:00
Ted Blackman
11c92e691d
ames: adjust route update logic
There was a typo in the routing logic that was comparing equality
against a value where it should have been doing a pattern match. The
value compared against contained the literal * gate, which would never
match route.peer-state, so this condition was always true, meaning the
fix that had added this extra condition (5406f06) did not actually
change the behavior from what it been previously.
2020-01-22 12:50:18 +04:00
Jared Tobin
a0cb74b658
Merge branch 'matilde/chat-dark-mode' ()
* origin/matilde/chat-dark-mode:
  chat: fade images on dark mode
  chat: add dark mode

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-14 11:09:18 -08:00
Jared Tobin
430f4c36d6
Merge branch 'lens-fix' ()
* origin/lens-fix:
  lens: don't prematurely flush state

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-14 08:52:01 -08:00
Philip Monk
d578159791
ames: fix assertion bug and add debug info
If we receive the naxplanation before the nack, the assertion in the gte
direction fails.  The intent of the assertion is to make sure top of the
live queue never falls behind current.state, so it was simply in the
wrong direction.
2020-01-14 08:34:12 -08:00
Isaac Visintainer
2cd9fc75a4 lens: don't prematurely flush state 2020-01-10 12:55:58 -08:00
Isaac Visintainer
a07a3747d1 invite-hook: fixed incorrect assertion about outgoing invites 2020-01-09 16:16:39 -08:00
Jared Tobin
754fba30e3
Merge branch 'matilde/meta-morgue' ()
* origin/matilde/meta-morgue:
  soto: add "dead" alt keys to ignored list

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-08 10:12:10 +08:00
Jared Tobin
795b811aca
Merge branch 'matilde/chat-timestamp' ()
* origin/matilde/chat-timestamp:
  chat: correct datestamp to match @da

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-08 10:11:33 +08:00
Matilde Park
a5e68f280d soto: add "dead" alt keys to ignored list
alt+n produces a ~, on top of a key called "Dead". This ignores "dead"
to send the ~ and function as normal.
2020-01-07 20:14:39 -05:00
Jared Tobin
8afad66138
Merge branch 'm/chat-cli-reconnect' ()
* m/chat-cli-reconnect:
  chat-cli: reconnect with actual bowl

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-07 04:25:14 +08:00
Fang
0ff2f44f31
chat-cli: reconnect with actual bowl
Fixes a bug introduced in 4798b9d.

This, uh, fell into the same old case of using an arm from a |_ without
initializing that core with a sample first. In this case, that resulted
in the bowl in connect being the default bowl here. This is fine for
~zod, since it's the default ship, but gives incorrect behavior for
anyone else.
2020-01-07 04:21:49 +08:00
Jared Tobin
01afc2a143
Merge branch 'm/gall-gift-paths' ()
* origin/m/gall-gift-paths:
  gall: (list path) in %fact and %kick

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-07 04:17:32 +08:00
Matilde Park
4143b0060f chat: fade images on dark mode
Adds 60% opacity to dim images within messages in dark mode.
2020-01-06 08:09:53 -05:00
Jared Tobin
cd9624e097
Merge branch 'm/whitespace' ()
* origin/m/whitespace:
  various: remove trailing whitespace
  ci: reject trailing whitespace

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-06 10:55:13 +08:00
Jared Tobin
f94ba8ce9c
Merge branch 'm/xmas' ()
* origin/m/xmas:
  xmas: remove, obsoleted by alef

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-06 10:53:15 +08:00
Jared Tobin
836142ad0d
Merge branch 'rcrdlbl/chat-sidebar-margin-fix' ()
* rcrdlbl/chat-sidebar-margin-fix:
  chat: add bottom padding to sidebar items

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-06 07:45:25 +08:00
Jared Tobin
5b0fd5fb78
Merge branch 'm/webchat-me' ()
* origin/m/webchat-me:
  webchat: render "me" messages in italics

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-06 07:25:53 +08:00
Jared Tobin
6f7aae3574
Merge branch 'ames-clean' ()
* origin/ames-clean:
  ames: update comment docs

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-01-06 07:25:22 +08:00
Fang
fcf1846b6f
various: remove trailing whitespace 2020-01-03 22:06:42 +01:00
Matilde Park
271e594f61 chat: correct datestamp to match @da
The datestamp in webchat currently leftpads the month numeral.
This commit amends it so that the month numeral doesn't pad with zeroes.
2020-01-01 08:54:36 +01:00
Matilde Park
d45be05c26 chat: add dark mode
Adds custom classes and declarations for dark mode color scheme.
Uses prefers-color-scheme media query to check preference.
2019-12-27 12:15:03 +01:00
Fang
e005cefe77
xmas: remove, obsoleted by alef 2019-12-27 02:19:36 +01:00
Przemyslaw Dabrowski
f8c305b65b chat: add bottom padding to sidebar items
Pretty simple really, fixes issue .
Decided to use padding instead of margin because the underflow is nice,
but not at the detriment of being able to see the last chat preview
2019-12-23 22:24:24 -05:00
Fang
b8a336c607
webchat: render "me" messages in italics 2019-12-23 23:11:04 +01:00
Fang
ae8a57ca25
gall: (list path) in %fact and %kick
Instead of providing a (unit path), allows for (list path), which better
supports the "update to path and subpath cases".

For example, if /things wants updates about everything, and
/things/specific wants updates about the specific thing, they'll both
need to receive a %fact when the specific thing changes.
Previously, these would have been two separate moves. Now, gall handles
the multi-targeting for you.
2019-12-23 13:37:32 +01:00
Fang
ea7c1db61c
various: use =/ in place of =+ ^-
Also faceless =; where appropriate.
2019-12-21 14:29:14 -03:30
Fang
21ac0e513b
hoon: parse =; without face
Allows for =;([a=@ b=@] ...) and similar constructions.

Also affects =/ and =^.
2019-12-21 14:20:11 -03:30
Fang
4798b9df1f
chat-cli: reconnect to chat-store on-kick
Also reconnects on-load, if no chat-store subscription appears to be
open. This should resolve any current disconnects.
2019-12-21 13:02:33 +01:00
Fang
c814114d93
chat-cli: add trace printf for tuba crashes 2019-12-21 12:59:45 +01:00
Fang
5cd8d98dd6
chat-cli: don't pass mark into +poke-noun 2019-12-21 12:58:22 +01:00
Ted Blackman
895f1c069d ames: update comment docs 2019-12-21 01:56:51 -05:00
Jared Tobin
103e375417
Merge branch 'ford-safe' ()
* origin/ford-safe:
  ford: clear build results on +load

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-12-20 13:22:23 -03:30
Jared Tobin
e1df5545e5
Merge branch 'matilde/chat-name-validation' ()
* origin/matilde/chat-name-validation:
  chat: validate chat names

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-12-20 10:44:30 -03:30
Jared Tobin
ee0de1a657
Merge branch 'm/clay-u' ()
* origin/m/clay-u:
  clay: implement %u care

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-12-19 14:09:52 -03:30
Jared Tobin
eee651042c
Merge branch 'm/eth-sending' ()
* origin/m/eth-sending:
  eth-sender: do proper nonce reading
  zuse: implement eth rlp decoding
  zuse: correctly encode leading zeroes in rlp data
  zuse: lightly restructure encode:rlp:ethereum
  static gall: update send-txs
  ethio: implement +request-batch-rpc-loose

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-12-19 11:20:06 -03:30
Fang
3808f02287
clay: implement %u care
Previously, it would always produce ~, regardless of the path asked
about.

Now, it produces a loobean, based on whether or not a file exists at the
specified path.
2019-12-18 21:02:38 +01:00
Jared Tobin
9b0582323c
Merge branch 'philip/eth-watcher' ()
* philip/eth-watcher:
  ph: fix tests by spamming blocks regularly
  gaze: reflect changes to eth-watcher
  ames: better printfs
  jael: only advance lifes
  jael: stop ship-to-ship
  jael: add "eager" mode to avoid hitting nodes as much
  jael: properly store ship sources
  gen: add +azimuth-sources
  jael: re-enable ship-to-ship communication
  eth-watcher: actually stop pending thread when restarting

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-12-18 12:13:27 -03:30
Philip Monk
1a7658bd91
ph: fix tests by spamming blocks regularly 2019-12-18 11:53:36 -03:30
Philip Monk
de2d0f3014
gaze: reflect changes to eth-watcher 2019-12-18 11:38:56 -03:30
Philip Monk
0e876b3cd4
ames: better printfs 2019-12-18 11:31:17 -03:30
Philip Monk
3d30b3b73c
jael: only advance lifes
This matches the semantics of rifts and makes it more forgiving of
misordered updates.
2019-12-18 11:31:14 -03:30
Philip Monk
16d98e5eda
jael: stop ship-to-ship 2019-12-18 11:19:41 -03:30
Philip Monk
18c3e7253b
jael: add "eager" mode to avoid hitting nodes as much 2019-12-18 10:58:00 -03:30
Philip Monk
15bd35301e
jael: properly store ship sources 2019-12-18 10:42:57 -03:30
Philip Monk
7706ed6a0c
gen: add +azimuth-sources 2019-12-18 10:41:39 -03:30