urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2024-12-22 10:21:31 +03:00
Code Issues Packages Projects Releases Wiki Activity
18,576 Commits 768 Branches 10 Tags 215 MiB
239cd93f3a
Commit Graph

3484 Commits

Author SHA1 Message Date
Liam Fitzgerald
a424312d12 chat-js: add CodeMirror dependency 
Adds CodeMirror dependency and related css
 2020-04-16 20:21:27 +10:00
Fang
4c4858f198
chat-hook: clarify backlog wire handling logic 2020-04-16 01:44:36 +02:00
Fang
d1feabd1fb
dbug: print result with priority 
To give it some color, making it less easy to miss.
 2020-04-15 23:50:53 +02:00
Logan Allen
e98605c1bb chat-js: fix chat ordering and pending messages 2020-04-15 16:48:33 -04:00
Fang
e2034eca19
dbug: avoid printing nothing at all 
Previously, if filtering subscriptions turned up no results, nothing was
printed. With this change, we explicitly print "no matching subscriptions"
instead.
 2020-04-15 22:28:59 +02:00
Logan Allen
c497d5a6a6 chat-js: fix auto-join and a chatSynced error 2020-04-15 15:58:03 -04:00
Logan Allen
f035070387 chat-js: fix issue with autojoining 2020-04-15 15:04:54 -04:00
Fang
0f05ed3149
chat-hook: consistently pull backlog subs 
We weren't accounting for backlog subscriptions with non-zero message
indexes in their wires. Now, we look through all of our outgoing
subscriptions to identify relevant backlog subscriptions, and leave all
of those.

The more proper fix here is to not include message indexes in the wire
in the first place, since we don't ever reuse that anywhere. But that's
a more invasive change, so we just leave a TODO for it instead.
 2020-04-15 19:26:58 +02:00
Jared Tobin
65cad93b1b
Merge branch 'liam-fitzgerald/lf/chat-input-line-height' (#2743) 
* liam-fitzgerald/lf/chat-input-line-height:
  chat-js: adjust line height in chat input

Signed-off-by: Jared Tobin <jared@tlon.io>
 2020-04-15 20:18:14 +04:00
Fang
084ce356a8
chat-hook: on %remove, try our best to pull subs 
Previously, we were removing the relevant entry from the `synced` map
before calling `+pull-wire`, which requires an entry to still be there.
This lead to subscriptions not actually being pulled, commonly leading
to "subscribe wire not unique" errors on re-join.

In addition to fixing that, `%remove` actions now try to pull the
subscription regardless of whether they have an entry in the `synced`
map or not. `%leave` is always safe, and we might want to clean up
subscriptions that shouldn't be there anymore in the first place.
 2020-04-15 16:29:26 +02:00
Liam Fitzgerald
8b48f3fa0f chat-js: adjust line height in chat input 
Set the line height of the input to be the same as a sent message.
Additionally fixes an issue that would cause unnecessary scrollbars to
be shown.
 2020-04-15 15:08:42 +10:00
Liam Fitzgerald
536e3121b6 link-js: fix pages disappearing on small screens 
The rightPanelHide prop was being improperly set on the home, settings
and members screens, causing them to be blank on small screen sizes

Fixes #2727
 2020-04-15 14:27:29 +10:00
Liam Fitzgerald
50dca97b07 publish: increase legibility for code in dark mode 
Makes the rules that set both a background and foreground color come
last in the CSS, increasing their specificity. Changes the highlight to a
lighter grey, to better stand out. Correctly aligns highlights with code
block backgrounds.

Fixes #2684
 2020-04-15 13:45:22 +10:00
Liam Fitzgerald
ba18737b5e chat-fe: move cancel button below comment edit 2020-04-15 10:59:56 +10:00
Liam Fitzgerald
963d04831d Merge branch 'master' into lf/publish-del-edit 2020-04-15 10:07:29 +10:00
Liam Fitzgerald
595acd17ff publish-js: lift editing state to comment list 2020-04-15 09:57:43 +10:00
Liam Fitzgerald
c46642af8d publish: fix check on edit-comment delta 
An incorrect check caused comment editing to never be propagated.
 2020-04-15 09:57:07 +10:00
ixv
b978d4f824
Merge pull request #2736 from urbit/ixv/fix-comment-grow 
publish: fix bug in comment mark
 2020-04-14 15:53:26 -07:00
ixv
5bb9776b70
Merge pull request #2730 from liam-fitzgerald/lf/chat-synced-fix 
chat-fe: resubscribe message iff chatSynced is populated
 2020-04-14 11:40:45 -07:00
ixv
e5cf4fb813
Merge pull request #2720 from urbit/la-channel-err 
channel.js: added way to handle event source errors more smoothly, and implemented in chat
 2020-04-14 11:40:02 -07:00
Isaac Visintainer
113c86037c publish: fix bug in comment mark 2020-04-14 11:23:06 -07:00
Fang
7b5f7cde6b
link-listen-hook: partially revert 05e6519 
We still want to auto-opt-in to new collections for _unmanaged groups_,
because we have no other way to join them.
 2020-04-14 16:12:09 +02:00
Liam Fitzgerald
a3fed45af1 publish-js: avoid unnecessary scrollbars on note view 
the root container had height: 100% but also a margin-top set on it. This
caused unnecessary scrollbars to appear when the content did not
actually overflow the container.
 2020-04-14 20:38:35 +10:00
Liam Fitzgerald
d63cc0d7de publish-js: allow deletion and editing of comments 
Adds interface affordances for the addition and removal of comments.
 2020-04-14 20:20:59 +10:00
Liam Fitzgerald
fa92d1cb7f publish: use @tas for comment ref in marks 
Comment references in publish actions are @tas of a rendered @da. The
mark expected @da, causing a mismatch.
 2020-04-14 20:15:57 +10:00
Liam Fitzgerald
9ddf06d2a1 chat-fe: correct FF scroll behaviour 
Firefox treats the reflow in the scroll container weirdly so for the
scrollback case, we save the position to restore later, when the backlog
messages come in. For the 'locked at bottom' case we add a new state
variable and rescroll based on that.
 2020-04-14 16:34:10 +10:00
Isaac Visintainer
d8cdbfdeb8 release: urbit-os-v1.0.13 2020-04-13 19:26:13 -07:00
ixv
2c56937f0d
Merge pull request #2701 from lukechampine/syntax-error-src 
ford: print source line on syntax error
 2020-04-13 19:03:05 -07:00
Liam Fitzgerald
786f2518e7 chat-fe: resubscribe message iff chatSynced is populated 
Previously, if a room was navigated to directly, the resubscribe message
would show before the chatSynced state was loaded. Initialises
chatSynced as null and checks it is not null before showing the
resubscribe message.
 2020-04-14 11:41:38 +10:00
Matilde Park
a4d37c0313 Merge branch 'master' into mp/chat/firefox-take-2 2020-04-13 21:38:27 -04:00
ixv
a7f20c37c1
Merge pull request #2700 from liam-fitzgerald/lf/invite-search-short 
invite-search: handle suggestions for short searches
 2020-04-13 16:56:26 -07:00
ixv
2d30886b65
Merge pull request #2724 from urbit/ixv/install-mousetrap 
publish: install mousetrap before we use it....
 2020-04-13 16:55:40 -07:00
ixv
228bee42e4
Merge pull request #2707 from urbit/ixv/cache-posts 
publish: eagerly store your own changes
 2020-04-13 16:54:41 -07:00
ixv
3526cfa4e6
Merge pull request #2618 from urbit/chat-reverse-messages 
chat: reversed order that messages are stored in for faster performance
 2020-04-13 16:54:16 -07:00
Isaac Visintainer
78023b8eff publish: ignore edit updates if they originated with us 2020-04-13 13:34:50 -07:00
Isaac Visintainer
7edcd65699 publish: add facilities for managing limbo state 2020-04-13 13:33:34 -07:00
Fang
7aebcad25b
link fe: refactor message display into component 2020-04-13 21:54:50 +02:00
Fang
0d73b391b4
link fe: more informative "empty list" display 
Displays "Loading..." if the links haven't loaded yet. If there are no
links, tells the user they can save one.
 2020-04-13 21:37:42 +02:00
Fang
4da0d636d3
link-view: in pagination logic, only +lent once 
Also just use +swag instead of chaining +scag and +slag manually.
 2020-04-13 21:26:44 +02:00
Fang
8f3d174c94
link: minimal initial view result 
On initial load, instead of getting the first 25 links for every
collection, only get their totals and unread counts. This drastically
reduces the pageload time.

Updates the frontend to match:
- Handle initial results without link content.
- Dynamically load in collection's links, even for page 0.
 2020-04-13 21:26:09 +02:00
Fang
bf42afbd56
link-view: add some hints to aid profiling 2020-04-13 21:15:51 +02:00
Jared Tobin
cc16e905af
Merge branch 'yosoyubik/apt-dup' (#2417) 
* yosoyubik/apt-dup:
  hoon: +apt:by check for duplicate keys
 2020-04-13 17:43:41 +04:00
Jared Tobin
bf78e71479
Merge branch 'courajs/json-unit-tests' (#1769) 
* courajs/json-unit-tests:
  Change at:dejs-soft:format to reject too-long json arrays
  Add unit tests for json de/serialization.
 2020-04-13 16:38:42 +04:00
Isaac Visintainer
2608dea563 publish: style changes and comments 2020-04-13 00:04:33 -07:00
Isaac Visintainer
d3ab26e57c publish: restore OS0 -> OS1 transition logic 2020-04-12 23:38:54 -07:00
Isaac Visintainer
277bc8d465 publish: make reducers able to handle duplicate updates now that we send updates both pre and post confirmation 2020-04-12 23:21:43 -07:00
Isaac Visintainer
a40d292bb7 publish: remove or add posts/comments from limbo depending on whether they succeeded or failed 2020-04-12 23:21:42 -07:00
Isaac Visintainer
d2fdae4d4b publish: immediately store post and comment changes 2020-04-12 23:21:42 -07:00
Isaac Visintainer
f9e17e61a2 publish: update state with limbo field 2020-04-12 23:21:42 -07:00
Isaac Visintainer
20d3c4105d publish: install mousetrap before we use it.... 2020-04-12 23:05:32 -07:00
Liam Fitzgerald
e5634a913d invite-search: always add search query if valid patp 2020-04-11 10:17:49 +10:00
Logan Allen
fb3111e88a channel.js: added way to handle event source errors more smoothly, and implemented in chat 2020-04-10 19:38:13 -04:00
Logan Allen
98f4df14a4 chat-js: made scrollback work for new message indexing 2020-04-10 22:22:14 +00:00
Logan Allen
8ffca926e7 chat-js: reverted built files 2020-04-10 17:34:23 -04:00
Logan Allen
6d1efde884 chat-js: fixed scrollback for reverse message chatrooms 2020-04-10 17:29:23 -04:00
Matilde Park
948dbe85e7 chat: scrollToBottom on mount for FF 2020-04-10 16:55:23 -04:00
Matilde Park
a212a5dc69 Merge branch 'master' into mp/chat/firefox-take-2 2020-04-10 16:44:15 -04:00
Matilde Park
1ddbc77157 chat: only scrolltobottom if first backlog grab 2020-04-10 16:42:05 -04:00
Matilde Park
3dc6a0bc9a chat: add firefox-specific chat window 2020-04-10 16:34:27 -04:00
ixv
e253ec1860
Merge pull request #2562 from nijynot/chore/interface-lint 
interface: add eslint to interface and lint `launch` and `chat`
 2020-04-10 13:04:58 -07:00
Logan Allen
b85697cbec chat-hook: respect backlog index, no longer truncate 2020-04-10 15:25:58 -04:00
Logan Allen
be1d5cee56 chat-store: flop envelopes in handle-messages so backlog comes in correct order 2020-04-10 15:25:58 -04:00
Logan Allen
8cdfb559f6 chat-view and hook: style pass and backlog truncation 2020-04-10 15:25:58 -04:00
Logan Allen
ecc8942eaf chat: reversed order that messages are stored in for faster performance 2020-04-10 15:25:58 -04:00
Liam Fitzgerald
e7887b34c3 invite-search: handle suggestions for short searches 
Triggers invitee suggestions after one character of input. To
compensate for the potential explosion of suggestions, we
tighten our group searching criteria and truncate the
ship suggestions on short searches. Also addresses a bug where names of
groups were not being downcased before search.

Fixes #2635
 2020-04-10 19:57:50 +10:00
Isaac Visintainer
eef6e56dca release: urbit-os-v1.0.12 2020-04-09 17:47:55 -07:00
ixv
12b6a5ccc5
Merge pull request #2600 from urbit/dk-help-generator 
completed +help comments for places they were missing
 2020-04-09 16:51:22 -07:00
ixv
b43f4d9d39
Merge pull request #2709 from urbit/mp/chat/namespace-group-chats 
chat: add unique ID to grouped chat paths
 2020-04-09 15:54:53 -07:00
ixv
f0d702002a
Merge pull request #2708 from urbit/m/link-opt-in 
link: require explicit opt-in for new collections
 2020-04-09 15:54:41 -07:00
ixv
c65b896a2c
Merge pull request #2705 from liam-fitzgerald/lf/publish-loading-fix 
publish-fe: improve UX of loading spinner on new note
 2020-04-09 15:54:04 -07:00
ixv
d376fd6998
Merge pull request #2704 from liam-fitzgerald/lf/chat-padding-sidebar 
chat-fe: filter empty groups in sidebar
 2020-04-09 15:53:55 -07:00
ixv
8e480b611d
Merge pull request #2703 from liam-fitzgerald/lf/chat-patp-copy 
chat-fe: copy patp to clipboard on author name click
 2020-04-09 15:53:46 -07:00
ixv
c5eb540c71
Merge pull request #2702 from liam-fitzgerald/lf/chat-join-spinner 
chat-fe: show spinner on join
 2020-04-09 15:53:35 -07:00
ixv
bc5358c0fd
Merge pull request #2695 from liam-fitzgerald/lf/sanitise-md-publish 
publish: sanitise markdown snippets in preview
 2020-04-09 15:52:52 -07:00
ixv
a41096153d
Merge pull request #2694 from liam-fitzgerald/lf/invite-search-arrow-keys 
invite-search: allow keyboard nav + selection
 2020-04-09 15:52:36 -07:00
ixv
77933e992a
Merge pull request #2693 from urbit/mp/re-alphabetise 
various: alphabetise associations accesses the object
 2020-04-09 15:52:18 -07:00
ixv
5fe16a7f47
Merge pull request #2687 from urbit/la-resub-on-err 
chat-js: resubscribe on error, not just on quit
 2020-04-09 15:52:03 -07:00
Isaac Visintainer
1fdf8a9789 Merge branch 'gall-hack-new-deal' 2020-04-09 15:39:49 -07:00
ixv
43484d613c
Merge pull request #2683 from urbit/mp/invite-search/associations 
invite search: populate group index from contacts
 2020-04-09 15:37:56 -07:00
ixv
8d32d49daf
Merge pull request #2668 from urbit/mp/link/dib-ing 
link: line up link info on same line height
 2020-04-09 15:37:38 -07:00
Logan Allen
a5d6403f39 gall: updated to soft properly 2020-04-09 14:53:12 -04:00
Matilde Park
9881fb2a2b chat: add unique ID to grouped chat paths 2020-04-09 14:37:21 -04:00
Fang
05e651970e
link: require explicit opt-in for new collections 
Instead of auto-watching a new collection when it gets added to group
associations, require that the user explicitly choose to view it.

Of course, creation counts as opting in, so watch the collections we
create by default.
 2020-04-09 19:01:58 +02:00
nijynot
6536054b91 interface: add eslint and update contrib docs 2020-04-09 12:08:23 +02:00
Logan Allen
7edc183ded gall: soft cast chat-action, and remove the chat-update hack 2020-04-09 02:09:51 -04:00
Liam Fitzgerald
0c062104a5 publish-fe: improve UX of loading spinner on new note 
Improve the UX of the loading spinner that shows when you have a new
note, by displaying it until we receive the new note in the
subscription, instead of until the poke succeeds.
 2020-04-09 16:06:10 +10:00
Liam Fitzgerald
6586aa98e3 chat-fe: filter empty groups in sidebar 
Empty groups caused the padding on the first group to be too large.
Filter the groups before we map over them so that we can set padding
properly.

Fixes #2674
 2020-04-09 15:08:06 +10:00
Liam Fitzgerald
e2f8be20de chat-fe: make copy status text inter 2020-04-09 14:13:23 +10:00
Liam Fitzgerald
648eced4ff chat-fe: copy patp to clipboard on author name click 2020-04-09 13:12:48 +10:00
Liam Fitzgerald
b4fb8d5163 chat-fe: show spinner on join 
Shows the spinner whilst joining a channel, both manually and from a
url. Also fixes an issue where a newly joined channel may be navigated
away from automatically.
 2020-04-09 12:48:55 +10:00
lukechampine
cb4cae01c8 ford: print source line on syntax error 2020-04-08 21:11:15 -04:00
Fang
c570def06a
Merge pull request #2680 from mhartl/master 
Fix spelling of "existent"
 2020-04-09 00:32:34 +02:00
Liam Fitzgerald
3801056d3c invite-search: allow keyboard nav + selection 
Allows the user to navigate potential invitees with the arrow keys and
with shift+tab and tab. Enter adds the currently selected invitee.
 2020-04-09 08:03:21 +10:00
Liam Fitzgerald
ff70a2be89 publish: sanitise markdown snippets in preview 
Runs the snippet through ReactMarkdown instead of rendering it as text.
We restrict the allowed nodes in the render to pure text, so the snippet is not
overly visually heavy.
 2020-04-09 07:56:44 +10:00
Elliot Glaysher
81fb798bfb king: handle IOError from recvFrom in ames. 
This is an attempt to fix the ames driver so that it reestablishes
a socket after a socket error. This should theoretically fix the
"ames dcoesn't work after computer sleeps" issue, so that when the
os closses a socket, we detect this in waitPacket and attempt to
reestablish the socket.

Closes #2190
 2020-04-08 13:33:33 -07:00
Elliot Glaysher
238f6db097 king: increment version for new pill 2020-04-08 13:33:16 -07:00
Matilde Park
839f9090bb various: alphabetise associations accesses obj 
Previously we were checking for a title for the association by accessing
a non-existent property of the key we were using to iterate through
the object. What we want to do is access the iterated object to find
that title, and so this commit does that.
 2020-04-07 17:35:02 -04:00
Fang
e9233b1a50
link fe: fix "mark all as read" button 
This wasn't bound, nor calling, correctly.
 2020-04-07 20:45:27 +02:00
Fang
9f47cbd568
dbug: document "all subscriptions" option in gen 2020-04-07 11:21:17 +02:00
Logan Allen
7a41f2dcab chat-js: resubscribe on error, not just on quit 2020-04-06 23:24:13 -04:00