Commit Graph

4339 Commits

Author SHA1 Message Date
Philip Monk
bc7f139725
dojo: add tags to identify errors
Particularly useful in cases where there is no trace, for example if you
simply execute `!!` or `_!! 5`.
2020-07-07 17:25:44 -07:00
Liam Fitzgerald
76bc3d82e1 Merge branch 'release/next-userspace' into lf/groups-refactor 2020-07-08 10:04:02 +10:00
Logan Allen
24e0d597ba or-map: added get arm and tested it 2020-07-07 19:19:47 -04:00
Logan Allen
d272da0f57 or-map: added get function based off of +find-ducts in behn 2020-07-07 19:19:47 -04:00
Logan Allen
7cdc12ff4c lib: or-map test library 2020-07-07 19:19:47 -04:00
Logan Allen
cd5840770e zuse: ordered-map subset style fixes 2020-07-07 19:19:47 -04:00
Logan Allen
4168344c3b zuse: added mop, a mold builder for ordered-maps 2020-07-07 19:19:47 -04:00
Logan Allen
04232e0ebe zuse: add subset arm to ordered-map 2020-07-07 19:19:47 -04:00
matildepark
a0b5a3a6df
Merge pull request #3097 from urbit/mp/select-group
group-filter: specify local api for all cases
2020-07-06 20:59:24 -04:00
Matilde Park
4b32987b8a group-filter: specify local api for all cases
Fixes #3096. During the migration to global store, the API became
structured such that you must specify the local (app-specific) API.
Some cases were missed. This includes them.
2020-07-06 16:55:57 -04:00
Fang
777bf76a13
chat-store: don't trim on %messages, either 2020-07-03 11:22:16 +02:00
Philip Monk
935ffaaf23
eyre: give scry function to generators
In Ford Fusion, Clay builds generators but Dojo and Eyre run them.  Dojo
is already virtualized with a scry function, so +mule is fine, but Eyre
is not, so Eyre needs to use +mock and explicitly supply the scry
function.  This does that.  Fortunately, the produced result is simple
and easily clammable.

Fixes #3089
2020-07-02 23:30:17 -07:00
Philip Monk
38095d525d
release: urbit-os-v1.0.26 2020-07-02 18:56:25 -07:00
Philip Monk
37b9f854fd
eyre: give all args to generators
fixes #3082
2020-07-02 14:42:26 -07:00
Philip Monk
c5711ef77c
Merge branch 'release/next-userspace' into release/next-sys 2020-07-02 14:25:56 -07:00
Philip Monk
8f1dc8aca6
Merge branch 'la/remove-trim' (#3083)
* origin/la/remove-trim:
  chat-store: trim on demand, not automatically
  release: urbit-os-v1.0.25

Signed-off-by: Philip Monk <phil@pcmonk.me>
2020-07-02 14:23:53 -07:00
Logan Allen
0995cf00f7 chat-store: trim on demand, not automatically 2020-07-02 15:54:52 -04:00
Liam Fitzgerald
0265ddc3ca chat: fix sigil overlay perf issue
Changes the sigil overlay to only start checking for its position when it
becomes visible.

Fixes: #3055
2020-07-02 13:49:06 +10:00
Liam Fitzgerald
8d308b2458 groups: cleanup merge errors 2020-07-02 13:08:47 +10:00
Liam Fitzgerald
93cf40a604 Merge branch 'release/next-userspace' into lf/groups-refactor 2020-07-02 12:38:12 +10:00
Liam Fitzgerald
bd2fbc2f9c groups: address review comments 2020-07-02 12:20:23 +10:00
Liam Fitzgerald
7686f850dc interface: fix tsc errors 2020-07-02 12:20:23 +10:00
Liam Fitzgerald
da6d653465 link-js: update for new group-store 2020-07-02 12:20:23 +10:00
Liam Fitzgerald
93a5dc0400 publish-js: update frontend for new group-store 2020-07-02 12:20:23 +10:00
Liam Fitzgerald
7d3a7a166b chat-js: update frontend for new group-store 2020-07-02 12:20:23 +10:00
Liam Fitzgerald
2bf1969312 groups-js: update frontend for new group store 2020-07-02 12:20:23 +10:00
Liam Fitzgerald
26c610f8d2 interface: update store + api + subscriptions for new groups 2020-07-02 12:19:32 +10:00
Philip Monk
f3dede23d1
Merge pull request #3076 from urbit/philip/clay-print
kiln: Small fixes
2020-06-30 18:08:01 -07:00
Philip Monk
bead3ab081
Merge remote-tracking branch 'origin/master' into release/next-sys 2020-06-30 16:14:31 -07:00
Philip Monk
ba9e894580
trouble: report source of OTA instead of parent 2020-06-30 16:10:12 -07:00
Philip Monk
f4f1d0ab4b
clay: print conflicts 2020-06-30 15:24:42 -07:00
Matilde Park
1adca22298 release: urbit-os-v1.0.25 2020-06-30 16:21:01 -04:00
matildepark
ef562e5008
Merge pull request #3066 from urbit/m/webm-not-img
chat fe: don't embed webms as images
2020-06-30 10:49:01 -04:00
Matilde Park
16f2f7bc59 Merge branch 'master' into release/next-userspace 2020-06-29 23:53:29 -04:00
matildepark
0de4bdb3bb
Merge pull request #3031 from urbit/lf/links-unread
links: fix unread counts
2020-06-29 23:26:13 -04:00
Matilde Park
9686f3483a interface: update production build for typescript 2020-06-29 22:48:17 -04:00
Philip Monk
51c5a74360
Merge remote-tracking branch 'origin/philip/jael-breach-restart' into release/next-sys 2020-06-29 19:25:13 -07:00
Matilde Park
12dfdbc2a6 spa: restore previous line-height, padding
Fixes #3053.
2020-06-29 21:59:48 -04:00
Fang
ad4e2c0c9d
chat fe: don't embed webms as images 2020-06-30 01:19:44 +02:00
Philip Monk
0574546b77
Merge branch 'ford-fusion' (#3060)
* ford-fusion: (259 commits)
  clay: remove scaffolding
  kiln: make otas continue even if they failed to apply
  metadata-store: add cleanup utility, use on-poke:def instead of no-op
  clay: flop syntax error trace
  landscape/img/codeeval.png: typo in filename
  invite-view: reinstate as potato
  goad: don't crash on pre-OTA sign
  chat-store: responded to comments, cleaned up
  -test: support other desks (full beams in args)
  arvo: use date instead of kelvin
  hoon: re-fix +slab; /tests: fix clay tests
  kiln: don't implicitly create syncs
  gall: don't make large stack trace
  ames: use +cut in +encrypt
  pill: solid
  dojo: print generator type errors
  Squashed commit of the following:
  ci: fix herb tests; update pills
  ford,kiln: nicer errors
  dojo: too many nouns
  ...

Signed-off-by: Philip Monk <phil@pcmonk.me>
2020-06-29 16:07:38 -07:00
Philip Monk
e7e2c07d6f
clay: remove scaffolding 2020-06-29 14:30:33 -07:00
Philip Monk
40db8ea580
kiln: make otas continue even if they failed to apply 2020-06-29 13:25:10 -07:00
Isaac Visintainer
a958cb9288 metadata-store: add cleanup utility, use on-poke:def instead of no-op 2020-06-29 11:07:26 -04:00
Ted Blackman
ede7105820 clay: flop syntax error trace 2020-06-29 11:01:23 -04:00
Ted Blackman
7611c2fc08 landscape/img/codeeval.png: typo in filename 2020-06-29 05:26:41 -04:00
Ted Blackman
29a6234633 invite-view: reinstate as potato 2020-06-29 05:15:25 -04:00
Ted Blackman
043b8a4cc0 goad: don't crash on pre-OTA sign 2020-06-29 02:43:52 -04:00
Logan Allen
3b8790cc04 chat-store: responded to comments, cleaned up 2020-06-29 00:24:18 -04:00
Fang
0ecd108f98
zuse: make +drop-pole produce a unit
Both +drop-list and +drop-map produce units instead of crashing. This makes
+drop-pole match that behavior, producing a unit of the resulting tuple.
2020-06-28 21:33:17 +02:00
Ted Blackman
d7b9889b4a -test: support other desks (full beams in args) 2020-06-28 05:06:16 -04:00
Ted Blackman
f6171042ae arvo: use date instead of kelvin 2020-06-28 01:13:42 -04:00
Ted Blackman
7266b3f5c3 hoon: re-fix +slab; /tests: fix clay tests 2020-06-28 00:59:02 -04:00
Philip Monk
42de999024
kiln: don't implicitly create syncs
Also silence some spurious errors.
2020-06-26 19:21:09 -07:00
Philip Monk
0301838f25
Merge remote-tracking branch 'origin/release/next-sys' into ford-fusion 2020-06-26 17:46:25 -07:00
Liam Fitzgerald
9b61c5571b Merge branch 'ford-fusion' into lf/groups-refactor 2020-06-27 10:42:16 +10:00
Joe Bryan
f7930aaa83 Merge branch 'master' into release/next-sys
* master:
  vere: bump version to 0.10.7
  libsigsegv: disable stack vma check
  vere: bump version to 0.10.6
  ci: add travis as trusted user
  jets: use appropriate macro
  noun: add -C to control memo cache size
  jets: restore fond/play/peek hooks
  jam: add commented-out functionality to count size of atom
  jets: cap memo cache and remove peek, play, and fond jets
  noun: add functions to count size of noun
2020-06-26 15:19:23 -07:00
Fang
523acf2eaf behn: optimize bounded timers scry 2020-06-26 15:17:20 -07:00
Fang
fe87d69ad1 behn: improve scry interface
No longer abuse the desk field, instead making use of the path. Reject
any scries outside of the local ship, empty desk and current time as
invalid.

Expose ducts only under a debug endpoint, nothing else should care about
being able to inspect them.

Add scry endpoints for the very next timer (if any), and all timers up
to and including a specified timestamp.
2020-06-26 15:17:12 -07:00
Fang
b824d5bd70 arvo: allow the empty desk (%$) in scries
+slaw fails to parse empty strings as %tas, so we special-case it here.
2020-06-26 15:17:03 -07:00
Philip Monk
271abcd3e7
vere: bump version to 0.10.7 2020-06-26 11:17:02 -07:00
Philip Monk
77df80d603
gall: don't make large stack trace 2020-06-26 09:20:17 -07:00
Liam Fitzgerald
846fe8c048 groups: convert JSON encodings to camelcase 2020-06-26 17:02:51 +10:00
Ted Blackman
ef138bb007 ames: use +cut in +encrypt 2020-06-25 22:54:37 -04:00
Liam Fitzgerald
ad6efe44ff groups: update generators and marks for ford-fusion 2020-06-26 12:45:02 +10:00
Ted Blackman
26ff47b93d Merge remote-tracking branch 'origin/release/next-userspace' into ford-fusion 2020-06-25 22:24:30 -04:00
Liam Fitzgerald
f27037d2de links: filter unread count on selected groups 2020-06-26 12:03:52 +10:00
Liam Fitzgerald
9aa4d96fb5 chat: refine image scaling 2020-06-26 12:03:52 +10:00
Liam Fitzgerald
48ae088bbd links-js: calculate header unread count correctly 2020-06-26 12:03:52 +10:00
Ted Blackman
3daecd8c1b Merge remote-tracking branch 'origin/fix-slab' into ford-fusion 2020-06-25 21:58:21 -04:00
Ted Blackman
c0e5bd8d9b Merge remote-tracking branch 'origin/la/chat-space-leak' into ford-fusion 2020-06-25 21:52:04 -04:00
Ted Blackman
68802ea041 dojo: print generator type errors 2020-06-25 15:38:15 -04:00
Ted Blackman
1216510fdb Squashed commit of the following:
commit 8f6aee0fdb
Author: Ted Blackman <ted@tlon.io>
Date:   Thu Jun 25 03:13:19 2020 -0400

    ci: revert debugging artifacts

commit e13a7fc050
Author: Ted Blackman <ted@tlon.io>
Date:   Thu Jun 25 02:48:55 2020 -0400

    ci: try @joemfb's one weird trick
2020-06-25 03:25:31 -04:00
Ted Blackman
82cfc691ce ci: fix herb tests; update pills 2020-06-25 02:14:16 -04:00
Philip Monk
51c6faaa31
ford,kiln: nicer errors 2020-06-24 21:24:58 -07:00
Philip Monk
7044f1fae6
dojo: too many nouns 2020-06-24 21:24:58 -07:00
Philip Monk
3a662881be
clay: don't be evil 2020-06-24 21:24:27 -07:00
Philip Monk
fc42bf6039
clay: special-case +run-pact for %hoon 2020-06-24 20:26:04 -07:00
Philip Monk
cbb80e9e7d
vere: bump version to 0.10.6 2020-06-24 19:09:03 -07:00
Philip Monk
f9d02263ee
jets: use appropriate macro 2020-06-24 17:11:46 -07:00
Philip Monk
361e41e78d
noun: add -C to control memo cache size 2020-06-24 17:08:50 -07:00
Philip Monk
71fa03457c
jets: restore fond/play/peek hooks 2020-06-24 13:42:51 -07:00
matildepark
77925b06be
Merge pull request #3048 from urbit/mp/spa-debug-debug
dbug: init new channel on start
2020-06-24 12:01:20 -04:00
Matilde Park
67a09d7d19 dbug: init new channel on start 2020-06-23 21:46:20 -04:00
Liam Fitzgerald
98f9dddebe Merge branch 'release/next-userspace' into lf/ts-global-store 2020-06-24 11:16:44 +10:00
Liam Fitzgerald
5bcbfe25a4 contacts-js: dismiss spinner on share 2020-06-24 11:11:13 +10:00
ixv
3d27c63a21
Merge pull request #3042 from urbit/mp/publish/restore-edits
publish: edit post content no longer tied to api
2020-06-23 17:51:17 -07:00
Liam Fitzgerald
47352a06ba groups: finalize state adapters 2020-06-24 10:28:57 +10:00
Matilde Park
42adb02b6b groups: fix broken image upload src 2020-06-22 22:38:21 -04:00
Matilde Park
ceff9626c5 publish: edit post content no longer tied to api
The component for editing a post was tied up in checking for API
instantiation -- we want the check for a blank body to be independent
of that.

Fixes #3040.
2020-06-22 22:36:39 -04:00
Philip Monk
6c3b7aeef5
jam: add commented-out functionality to count size of atom
This is a convenient way to count memory usage of noun by simplying
running `(jam 1.337 noun-1 noun-2 ... ~)`.  This should
be a hint, but for debugging this is sufficient.
2020-06-22 19:29:00 -07:00
Philip Monk
fa6748a7e1
jets: cap memo cache and remove peek, play, and fond jets
With these changes, about 90% less memory and 15% less time is needed to
compile hoon.hoon.  The produced noun is within 3% of the same size,
which suggests this results in little if any duplication.

These are three of the four most commonly hit +ut jets.  The other is
+nest, which cannot be un-memoized without taking much longer to compile
(it didn't finish in my test).  These four jets combined for 2.3 million
out of the 2.4 million cache entries, the other +ut jets combine for
less than 100k, and literal ~+ accounted for about 50k entries.

This also caps the memo cache at 50k entries.  Even with these jets not
memoized, the memo cache grows to 357k entries and 122 MB.  Capping at
50k entries has no effect on time and reduces memory usage of the hash
table to about 25MB.  Entries are reclaimed with the clock algorithm,
which seems to be sufficient for this use.
2020-06-22 19:29:00 -07:00
Philip Monk
d8aed4d4af
noun: add functions to count size of noun
Adds a few functions to count the size of nouns in the current road.
Since this marks the nouns (high bit of refcount), you need to
"discount" them immediately after to unmark them.  Parallel functions
exist for the counting the size of a hashtable.

It would nice to hook this up to a hint, but these are useful to have
available to run in the debugger or by inserting callsites as necessary.
It's also possible to hook them up to the +jam jet gated on a special
value.
2020-06-22 19:29:00 -07:00
Liam Fitzgerald
8cf81002ec Merge branch 'ford-fusion' into lf/groups-refactor 2020-06-23 12:13:03 +10:00
Ted Blackman
154f153801 gall: fix routes in +ap-yoke 2020-06-22 21:37:17 -04:00
Liam Fitzgerald
292c5625e3 interface: always show sidebar on nav 2020-06-23 11:05:31 +10:00
Liam Fitzgerald
555857513a launch-js: update to global store 2020-06-23 10:19:57 +10:00
Liam Fitzgerald
7be0831f39 Merge branch 'release/next-userspace' into lf/ts-global-store 2020-06-23 09:33:47 +10:00
Ted Blackman
70ce1d6d5f -test: fixed clay tests 2020-06-22 18:05:55 -04:00
matildepark
7fd2ead858
Merge pull request #3037 from urbit/lf/reconnect-fix
interface: correct order of arguments in resubscribe logic
2020-06-22 10:26:40 -04:00
Matilde Park
5ad03868b2 Merge branch 'master' into release/next-userspace 2020-06-22 10:24:34 -04:00
Liam Fitzgerald
535f415ebd chat-js: update to global store 2020-06-22 16:05:43 +10:00
Liam Fitzgerald
85aa12a5a9 contacts-js: update to global store 2020-06-22 16:04:21 +10:00
Liam Fitzgerald
3a3a6ab254 publish-js: update to global store 2020-06-22 15:40:43 +10:00
Liam Fitzgerald
076e52c27e links-js: update to global store 2020-06-22 15:15:46 +10:00
Liam Fitzgerald
60ff310422 interface: make store global 2020-06-22 14:59:02 +10:00
Liam Fitzgerald
4dfce2a757 interface: correct order of arguments in resubscribe logic 2020-06-20 21:26:44 +10:00
Ted Blackman
652dc70304 clay,dojo: clean up stack traces 2020-06-20 03:46:22 -04:00
Liam Fitzgerald
05b665f908 interface: convert api and reducers to typescript 2020-06-20 14:49:18 +10:00
Philip Monk
6ff9f75bb7
Merge remote-tracking branch 'origin/master' into ford-fusion 2020-06-19 14:52:18 -07:00
Logan Allen
ac864bd42a chat-store: added %trim command as a hack that runs once +on-load and again every 5.000 messages 2020-06-19 14:45:08 -04:00
Ted Blackman
d1b4af89fe sys: s/mure/road 2020-06-19 00:44:17 -04:00
Philip Monk
7494bf57c6
clay: make reachable-takos linear instead of exponential
When merging, +reachable-takos is called roughly once per merge commit
in the ancestry of the new commit.  +reachable-takos was exponential in
the number of merge commits in the ancestry of the commit it's looking
at, due to mishandling of the accumulator.  This makes it linear.

Of course, linear x linear is still quadratic, which is not great.  I
doubt +reachable-takos can be made asymptotically better, but
+reduce-merge-points/+find-merge-points probably can.  50 merge commits
already gives about 14.000 iterations through the loop in
+reachable-takos.  Another option is to try to memoize this somehow, but
a simple ~+ is insufficient since `s` is usually different.

In local tests on macOS with a -L copy of ~wicdev-wisryt, this speeds up
OTAs significantly.  The majority of time was spent on this.
2020-06-18 18:56:31 -07:00
Philip Monk
7206ab6c98
Merge remote-tracking branch 'origin/master' into release/next-sys 2020-06-18 18:50:10 -07:00
Isaac Visintainer
4fded00005 release: urbit-os-v1.0.23 2020-06-18 17:51:16 -06:00
Matilde Park
506c8996d6 interface/config: fix production build 2020-06-18 18:04:30 -04:00
Fang
3ecb6f7154
Merge branch 'release/next-sys' into m/eyre-kill-channels 2020-06-18 22:34:22 +02:00
Fang
b2600f553c
Merge branch 'master' into m/eyre-kill-channels 2020-06-18 22:23:47 +02:00
Fang
8cb81370bb
Merge ford-fusion into m/eyre-scries 2020-06-18 20:23:06 +02:00
Liam Fitzgerald
0ac7a75896 soto: run +on-load migration once 2020-06-18 21:47:44 +10:00
Ted Blackman
f2ee0a1380 drum: fix +on-load resubscribes 2020-06-18 00:58:47 -04:00
Ted Blackman
3914c0c0dd ota: works on my machine 2020-06-17 23:31:37 -04:00
Matilde Park
08b4a47589 publish, links: restore full height 2020-06-17 19:13:34 -04:00
Matilde Park
35edce597b interface/CONTRIBUTING: amend for SPA / webpack 2020-06-17 17:41:12 -04:00
Matilde Park
a65edb52cd Merge branch 'master' into feat/spa 2020-06-17 17:12:13 -04:00
Logan Allen
08e1abb139 hood + apps: fix OTA process for feat/SPA 2020-06-17 15:51:13 -04:00
Logan Allen
eaf523e3c2 hood: add version %6 for %file-server upgrade 2020-06-17 14:27:30 -04:00
Matilde Park
304438009e chat: equally size both code + s3 buttons 2020-06-17 13:09:07 -04:00
Matilde Park
2fdbdccae1 Merge branch 'feat/spa' into lf/ios-spa-fixes 2020-06-17 12:56:51 -04:00
Ted Blackman
d395c2711d hood: WIP compiles but +on-load crashes 2020-06-17 03:54:27 -04:00
Ted Blackman
bcf79e38a1 Merge branch 'ota-ford-fusion' into ted/kiln-fusion 2020-06-17 02:37:45 -04:00
Ted Blackman
ac77d0a3ec hood: uncompiled first try at state as tuple 2020-06-17 02:36:09 -04:00
Liam Fitzgerald
81a9b0d08e chat: prevent reflow from image loading
Sets a static height on inline images in chat to prevent loss of scroll
position.

Fixes #2883
2020-06-17 16:10:46 +10:00
Liam Fitzgerald
77731f6ca0 chat: scroll on code overflow
Adds a scroll container if code is posted and the code will overflow the
width of the page.

Fixes #2829
2020-06-17 16:08:32 +10:00
Liam Fitzgerald
a2970ce929 chat: cap maximum backlog size at 1000
Caps maximum unread backlog that chat will fetch at 1000 messages.
2020-06-17 15:24:22 +10:00
Matilde Park
5757fd8f5d chat, publish: Filter unreads for current group
Fixes #2897.
2020-06-16 22:27:51 -04:00
Fang
c9db959c2d
Merge pull request #3018 from urbit/m/softer-tab
shoe: print tab options less eagerly
2020-06-16 14:57:43 +02:00
Ted Blackman
01eee03340 kiln: WIP state as tuple 2020-06-16 03:29:17 -04:00
Philip Monk
1acd8fe6d6
Merge branch 'ixv/fix-chat-hook' (#3020)
* origin/ixv/fix-chat-hook:
  chat-hook: pull on store path when removing

Signed-off-by: Philip Monk <phil@pcmonk.me>
2020-06-15 19:58:29 -07:00
Philip Monk
4e3aace970
Merge branch 'jb/aes-siv-fix' (#3013)
* origin/jb/aes-siv-fix:
  tests: updates aes-siv regression test comment
  pill: updates solid
  zuse: propagates fix to aes-128-siv and aes-192-siv as well
  Revert "test: disable aes-siv jets to demonstrate test failure"
  pill: updates solid
  zuse: fixes bug in aes-256-siv iv calculation (+s2vc:aes:crypto)
  test: disable aes-siv jets to demonstrate test failure
  test: add test case for aes-256-siv jet mismatch, observed in the wild

Signed-off-by: Philip Monk <phil@pcmonk.me>
2020-06-15 19:57:01 -07:00
Philip Monk
9410b4f66d
arvo: +mure is taken 2020-06-15 19:34:30 -07:00
Isaac Visintainer
f0d36f6a52 chat-hook: pull on store path when removing 2020-06-15 16:01:46 -06:00
Matilde Park
34dcc9f971 chat, links, publish: join upon api instantiation 2020-06-15 15:19:00 -04:00
Matilde Park
ef00dc71e4 group-filter: close modal on navigation 2020-06-15 12:45:02 -04:00
Liam Fitzgerald
dea59807a7 publish: fix remaining bugs with new groups 2020-06-15 18:10:09 +10:00
Liam Fitzgerald
0d80e4cf19 links: update to new groups 2020-06-15 18:09:49 +10:00
Liam Fitzgerald
d5466ff31a groups: fix remaining bugs in new implementation 2020-06-15 18:09:03 +10:00
Liam Fitzgerald
9123cabed7 chat: fix remaining issues with new groups 2020-06-15 18:07:21 +10:00
Fang
d4b4fe67f3
shoe: print tab options less eagerly
Turns out that having these pop up on every tab-press is really annoying,
and you usually only want them when it didn't manage to autocomplete anything.
2020-06-14 23:36:03 +02:00
Fang
8f8ec8bcc5
language-server: parse commands permissively
Parses commands as arbitrary strings, instead of strictly symbols.
2020-06-14 18:48:27 +02:00
Joe Bryan
6d56a95837 tests: updates aes-siv regression test comment 2020-06-12 23:26:10 -07:00