Commit Graph

2578 Commits

Author SHA1 Message Date
Philip Monk
4fda5e8e38
gall: give both acks in case of unexpected ack
It's hard to say what's the safest thing to do when we get an ack we
weren't expecting due to losing outstanding.agents.state in +load
3-to-4, so this gives both a watch-ack and a poke-ack.  This seems most
likely to succeed.
2020-02-13 17:48:33 -08:00
Logan Allen
498c6e8e97 metadata-store: added scry + watch paths, an %update-metadata update 2020-02-13 17:22:52 -08:00
Philip Monk
e082845e0d
gall: make 2140e07 ota-able
Does not change state type, but clears outstanding.agents.state since
it's full of garbage values.  This introduces a possibility that we may
have been in the middle of something, so we handle that in a reasonably
sane way.
2020-02-13 17:20:27 -08:00
Fang
c86b1c9944
link fe: render unseen count in the launch tile 2020-02-14 02:03:19 +01:00
Fang
45088621f4
link-view: properly support the launch tile 2020-02-14 02:02:47 +01:00
Fang
1f4a41e550
link-store: support "all unseen" scry
Instead of forcing clients to scry at every path, they can now scry for
all paths at once.
2020-02-14 01:57:58 +01:00
Fang
fafe4cf2bd
link-store: always mark our own submission as seen 2020-02-14 01:55:17 +01:00
Fang
102424af40
link-store: fix incorrect arm calls
Also changes a typecheck to be more correct, and updates docs to match
implementation.
2020-02-14 01:54:16 +01:00
Philip Monk
2140e07a99
gall: properly track remote acknowledgments
outstanding.agents.state is a queue of what sort of message we sent to a
foreign app.  We use it so that when the acknowledgment comes back we
know whether to treat it as a watch-ack, poke-ack, or neither.  We used
to put this info in the wire, but this gave us a different ames flow,
which meant %leave and %watch didn't get associated (causing #2079).

The error was that when when retrieving the item from the queue, we put
the new 1-item-shorter queue back in outstanding.agents.state at a
different wire than it came from, so the queues never actually got
shorter, and acknowledgments of the wrong sort were commonly produced.
This caused problems mainly in situations where we poke and peer on the
same wire, and possibly when a subscription was cancelled.

Possibly related to #2206 and #2176.  I would expect this bug to cause
those issues, but I haven't verified the converse.  Also possibly
related to #2153 and #2079.
2020-02-13 15:12:07 -08:00
Fang
fa138ef216
hoon: clarify comments for +rep:in and +rep:by
"Replace" suggests this function either produces an updated set/map when done,
like +snap, or changes all values in-place, like +turn. In truth, it's more
similar to +roll, which does reduction/accumulation.

("Reduce" specifically was chosen because it maintains the mnemonic relation to
the arm name.)
2020-02-13 23:56:44 +01:00
Isaac Visintainer
56807dd52f added members and settings page 2020-02-13 14:00:55 -08:00
Logan Allen
9205c7c7db sur: added metadata-store structures 2020-02-13 13:13:10 -08:00
Logan Allen
ca7cc1fc10 metadata-store: first compiling version of metadata-store 2020-02-13 13:13:10 -08:00
Logan Allen
a9231fd5f9 chat-js: one line fix to create chat screen to enable managed group creation 2020-02-13 13:11:22 -08:00
Matilde Park
ced119271f contacts: add resizable "notes" field 2020-02-13 12:27:27 -07:00
Logan
f316d0f118
Merge pull request #2282 from urbit/fix-remove
contacts: improve remove from group experience in UI and terminal log
2020-02-13 11:08:12 -08:00
Matilde Park
914d312f06 publish: refine "all notebooks" on mobile 2020-02-12 20:59:49 -05:00
Matilde Park
231ead27df publish: add mobile back nav to notebook.js 2020-02-12 20:57:48 -05:00
Matilde Park
60c496ccf8 publish: sidebar switch + popout to note.js 2020-02-12 20:50:58 -05:00
Matilde Park
778ba9849d publish: sidebar switch + popout to notebook.js 2020-02-12 20:17:13 -05:00
Matilde Park
213ab1e0a9 publish: add popout/sidebar switch to new-post.js 2020-02-12 19:51:27 -05:00
Matilde Park
0075668065 publish: remove scrolling overflow from skeleton 2020-02-12 19:51:06 -05:00
Matilde Park
6c6e33f5a7 publish: add sidebar switcher and popout logic
The scaffold and reducer work thus far had some bugs and shims. This commit
adds the parameters, API calls and fixes the reducers for the two
features.
2020-02-12 19:08:13 -05:00
Logan
610474795f
Merge pull request #2280 from urbit/m/chat-cli-perms
chat-cli: remove r/w specifiers for invite and banish
2020-02-12 14:58:19 -08:00
Logan
b1b141faa8
Merge pull request #2281 from urbit/m/link-fe-uxtohex
link fe: make uxToHex more safe
2020-02-12 14:57:50 -08:00
Logan Allen
ef8aa94171 contact-js: change text to 'delete group' when removing yourself as a member when you own the group 2020-02-12 14:33:07 -08:00
Logan Allen
5aa7a91134 contact-hook: suppress resubscribe stack trace 2020-02-12 14:29:29 -08:00
Logan Allen
fb0ef50f43 contacts-js: fix case where default contact can be removed 2020-02-12 14:09:04 -08:00
matildepark
a6133e44b2
Merge pull request #2278 from urbit/mp/os1/publish-comments-contact
publish: add nicknames and sigils to interface
2020-02-12 15:34:34 -05:00
Fang
a675e5442b
link fe: make uxToHex more safe
Matching implementation from contacts' lib/util.js.
2020-02-12 21:03:04 +01:00
Fang
d840c384e1
chat-cli: remove r/w specifiers for invite and banish
No longer supported. As such, we also don't include that in the
permission path anymore.
2020-02-12 15:53:44 +01:00
Matilde Park
e59b783337 publish: add nicknames and sigils to interface 2020-02-11 17:49:35 -05:00
Logan
33f7d62186
Merge pull request #2273 from urbit/mp/os1/weather-error
weather: concise error, input layout placement
2020-02-11 13:13:43 -08:00
Logan
e2a07efef8
Merge pull request #2269 from urbit/mp/os1/authenticate
eyre: add new os1 login screen
2020-02-11 13:13:04 -08:00
Logan
0ec32f0606
Merge pull request #2270 from urbit/mp/os1/contact-design-tweaking
contacts: design tweaks for share sheet
2020-02-11 13:11:48 -08:00
Jimmy
e10b6784ae chat-js: slightly cleaner sig string 2020-02-11 13:09:03 -08:00
Jimmy
8b8472f231 removing console log 2020-02-11 13:06:42 -08:00
Jimmy
a5301251c3 patp name now has sigil, and nickname now renders inter 2020-02-11 13:06:42 -08:00
Logan
5bb0f5d59f
Merge pull request #2277 from urbit/chat-os1-fixes
chat-js: fix ui regression for new and join (always create /~/ groups)
2020-02-11 13:04:36 -08:00
Logan Allen
ebab101213 chat-js: fix ui regression for new and join (always create /~/ groups) 2020-02-11 12:59:10 -08:00
matildepark
ffff42d371
Merge pull request #2274 from urbit/m/link-fe-previews
link fe: properly downscale wide images to fit screen
2020-02-11 15:49:55 -05:00
Matilde Park
7a530d1001 eyre: amend "purchase an id" link to urbit.org 2020-02-11 15:27:08 -05:00
Logan
1406363623
Merge pull request #2276 from urbit/chat-double-invite
chat-hook: fix double invite bug
2020-02-11 11:51:00 -08:00
Logan Allen
d7d7cc6f94 chat-hook: fix double invite bug 2020-02-11 11:47:34 -08:00
Fang
27be1861db
chat-cli: no longer allows %mailbox and %journal chats
Also adds in some casts to ensure sane action data. The chat-view-action
changed in this commit should've been nest-failing.
2020-02-11 20:39:14 +01:00
Logan
d5c94a4421
Merge pull request #2265 from urbit/chat-disable-name-on-group
chat-js: on selecting a group from search, set id of chat to that nam…
2020-02-11 11:17:13 -08:00
Fang
4d78808075
link fe: properly downscale wide images to fit screen
We no longer downscale to 500px wide, but rather however wide fits
within the container, and doesn't exceed 500px in height.
2020-02-11 19:17:07 +01:00
Matilde Park
5c06d1b464 weather: concise error, input layout placement
This lines up the input with the "Set location" button,
and makes the latitude/longitude setting error
more concise, in order to fit within the tile without overflow.

This commit also removes some Tachyons-specific CSS classes.
2020-02-11 13:05:52 -05:00
Fang
9a29e72560
link fe: prefix ship names in comments with sig 2020-02-11 17:41:32 +01:00
Fang
8d7d1af3aa
link fe: rename members -> contacts and refactor
Renames the somewhat ambiguous "members" property into "contacts", to
more clearly indicate the source/nature of the data within. (Avoid
confusion with "members of a group", which is contained in groups
instead.)

Also refactors the retrieving of appropriately-defaulted contact values
into a utility function.
2020-02-11 17:39:03 +01:00
Fang
e801316368
link fe: display correct member counts
We were passing in a contacts object, which may not always contain all
group members. We now pass in a groups object (set of ships) instead,
and derive contributor count from that.
2020-02-11 17:17:33 +01:00
Fang
94feb5bf2e
link fe: ensure item and page counts
Getting updates for things we hadn't gotten initial data on would leave
us without any counters. This defaults them to zero, if we don't have
any yet.
2020-02-11 16:50:42 +01:00
Fang
5caf5fa00d
link fe: display unread counts for public channels
Was previously only displaying for the private channel.
2020-02-11 16:47:00 +01:00
Matilde Park
662661e316 eyre: add new os1 login screen 2020-02-10 23:24:16 -05:00
Matilde Park
415553f13a contacts: comment out invert class 2020-02-10 21:18:57 -05:00
Matilde Park
5312638a90 contacts: amend share sheet font / padding 2020-02-10 21:17:56 -05:00
Philip Monk
41fd367bff
ames: make routing simpler 2020-02-10 17:49:18 -08:00
Logan Allen
2cae31783e chat-js: on selecting a group from search, set id of chat to that name and disable form 2020-02-10 16:24:05 -08:00
Isaac Visintainer
b59eb4e8ee make sure notes page has access to subscribers/writers path 2020-02-10 15:57:45 -08:00
Logan
41f1cb67ca
Merge pull request #2262 from urbit/dupe-invite-os1
contact-hook: fix invite to group being sent back to owner upon accep…
2020-02-10 15:29:13 -08:00
Logan Allen
2d0e7c76c5 contact-hook: fix invite to group being sent back to owner upon acceptance 2020-02-10 15:25:48 -08:00
Matilde Park
33c825b131 publish: hide overflow in sidebar 2020-02-10 17:25:28 -05:00
Isaac Visintainer
d98aed183f add ourselves to the notebook groups we create 2020-02-10 12:44:10 -08:00
Fang
5eab689d0a
Merge pull request #2259 from urbit/m/link-unreader
link: unread counters in sidebar
2020-02-10 20:53:07 +01:00
Fang
9c9b1fcaec
link fe: display unseen link counts in sidebar 2020-02-10 20:52:47 +01:00
Fang
fcf1255b7d
link-store: add scry endpoint for getting unseen urls 2020-02-10 20:18:42 +01:00
Fang
b876716f0d
chat-hook: evaluate result-less %code messages
Prior to sending them out to the messaging target.
2020-02-10 16:34:37 +01:00
Logan Allen
c38641c182 chat: gray out and disable the security toggle when create group is selected 2020-02-07 17:27:01 -08:00
Logan
d9a94633cb
Merge pull request #2254 from urbit/repn-os1-rc
hoon: added +repn
2020-02-07 16:26:30 -08:00
Logan
86893ab645
Merge pull request #2253 from urbit/chat-auto-add
chat: auto-invite on addition to group
2020-02-07 16:18:36 -08:00
Logan Allen
a025a7fcb0 hoon: added +repn 2020-02-07 15:59:53 -08:00
Logan Allen
3e94033196 chat: auto-invite on addition to group 2020-02-07 15:52:55 -08:00
ixv
fbe9882888
Merge pull request #2252 from urbit/ixv/publish-multiple-fixes
OS1: publish, multiple fixes
2020-02-07 15:23:14 -08:00
Fang
789d9719a4
Merge pull request #2246 from urbit/mp/os1/link-previews
links: link previews for images and youtube
2020-02-08 00:22:35 +01:00
Fang
7a5b79b020
link fe: ensure we don't visually truncate titles 2020-02-08 00:21:49 +01:00
Fang
8fee37be56
link fe: indicate unseen status on links 2020-02-07 23:11:13 +01:00
Isaac Visintainer
769075e5d5 make comment box clear on submit, and disable submit button when textbox is empty 2020-02-07 14:06:19 -08:00
Isaac Visintainer
aa61831d5a added create group toggle to new notebook page 2020-02-07 14:06:19 -08:00
Isaac Visintainer
7a64615cf7 added new post button for all members of the notebook writers group 2020-02-07 14:06:19 -08:00
Isaac Visintainer
3e308fe15b handle inviting/kicking when ship is added/removed from group 2020-02-07 14:06:19 -08:00
Fang
475bbe0d39
link fe: make image previews clickable 2020-02-07 22:57:41 +01:00
Fang
0abbac2457
link fe: fix image preview sizing
Image should retain its own width if it's smaller than the bound, but
not go beyond them.

Height bounding wasn't being inherited properly through the "100%", so
we're moving the max-height into the embed itself instead.
(Making its container div always contain it rather than overflow also
prevents bleeding the preview down the page in case of sizing error.)
2020-02-07 22:30:13 +01:00
Fang
fec2f51273
link fe: pass time into detail head instead of all data 2020-02-07 22:16:08 +01:00
Fang
b8ffebcb9d
link: support marking urls as seen 2020-02-07 21:49:16 +01:00
Fang
b08a4ef605
link-store: touch up interface path docs 2020-02-07 21:43:11 +01:00
Fang
2df646bd0a
link-store: reject pokes without content 2020-02-07 21:42:33 +01:00
Matilde Park
f4faef2b6c link: link previews for images and youtube 2020-02-06 20:48:30 -05:00
Matilde Park
112326a939 link: front matter to preview component, imgs 2020-02-06 20:35:47 -05:00
pkova
e090b6b8b8 chat: fix double message bug 2020-02-07 03:01:19 +02:00
Matilde Park
83a7e45e74 link: add "groupPath" to link-submit.js 2020-02-06 19:42:26 -05:00
matildepark
140e1b4d9d
Merge pull request #2243 from urbit/la-chat-sig-path
chat + contacts: finished integration for managed groups
2020-02-06 19:29:18 -05:00
matildepark
6f65a65d85
Merge pull request #2244 from urbit/m/link-fe-path
link fe: use base64url
2020-02-06 19:20:02 -05:00
Fang
5443a3ec7b
link fe: be consistent about groupPath (vs path)
Prefer "groupPath" name over just "path" consistently to avoid
ambiguity.
2020-02-07 01:07:36 +01:00
Logan Allen
ea93dd3af8 chat + contacts: finished integration for managed groups
Specifically, this commit removes the add action from the contact-view
and replaces it with a listener within contact-hook for additions
to groups. This means that when a ship is added to a group that the
contact-hook is watching, the ship is automatically sent an invite to
join that "managed group" from the contacts application. This also
includes the UI integration work on the management screen and settings
screen for working with the new group / permission structure.
2020-02-06 16:02:45 -08:00
Logan Allen
64ff95d27c chat: backend work to support ~ paths 2020-02-06 16:01:00 -08:00
Fang
e5337c99c7
link fe: use base64url for encoding URLs
base64 is not actually url-safe, since it includes / (and +). This
includes a simple hand-rolled base64url implementation, and uses that
instead.
2020-02-07 00:18:52 +01:00
Fang
b0759ad8bc
link fe: move @ta encoding into lib 2020-02-07 00:14:54 +01:00
Isaac Visintainer
93b9c6d5d9 added invites to sidebar in publish 2020-02-06 14:31:51 -08:00
Fang
1490e415c4
Merge branch 'os1-rc' into m/link-fe 2020-02-06 21:38:11 +01:00
Fang
ea70307f29
link fe: copy in contact-update reducer 2020-02-06 21:33:18 +01:00