urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2024-12-20 09:21:42 +03:00
Code Issues Packages Projects Releases Wiki Activity
18,625 Commits 768 Branches 10 Tags 215 MiB
5b45ad986d
Commit Graph

964 Commits

Author SHA1 Message Date
Matilde Park
948dbe85e7 chat: scrollToBottom on mount for FF 2020-04-10 16:55:23 -04:00
Matilde Park
a212a5dc69 Merge branch 'master' into mp/chat/firefox-take-2 2020-04-10 16:44:15 -04:00
Matilde Park
1ddbc77157 chat: only scrolltobottom if first backlog grab 2020-04-10 16:42:05 -04:00
Matilde Park
3dc6a0bc9a chat: add firefox-specific chat window 2020-04-10 16:34:27 -04:00
ixv
e253ec1860
Merge pull request #2562 from nijynot/chore/interface-lint 
interface: add eslint to interface and lint `launch` and `chat`
 2020-04-10 13:04:58 -07:00
Logan Allen
ecc8942eaf chat: reversed order that messages are stored in for faster performance 2020-04-10 15:25:58 -04:00
Liam Fitzgerald
e7887b34c3 invite-search: handle suggestions for short searches 
Triggers invitee suggestions after one character of input. To
compensate for the potential explosion of suggestions, we
tighten our group searching criteria and truncate the
ship suggestions on short searches. Also addresses a bug where names of
groups were not being downcased before search.

Fixes #2635
 2020-04-10 19:57:50 +10:00
Liam Fitzgerald
c162f0f212 chat-fe: add DMs and related screens 
Adds DMs, which are just unmanaged chats whose last path component
starts with dm-- followed by the patp of the other user.
 2020-04-10 19:45:25 +10:00
Liam Fitzgerald
1bca495d8a chat-fe: reflow profile overlay near edges of screen 
Polls for the distance between the top of the container and reflows the
overlay accordingly.
 2020-04-10 17:59:04 +10:00
Liam Fitzgerald
188a1e8dcf chat-fe: hide/show profile overlay on sigil click 
Hide and shows profile overlay on sigil click. Shows the overlay for 2
seconds after click. If the user moves their mouse into the overlay then
it will remain open as long as the mouse is inside the overlay.
 2020-04-10 17:59:04 +10:00
Liam Fitzgerald
f3c21fae36 chat-fe: add profile overlay 
Adds a profile overlay to display information about the user on hover.
Also adds the svgClass prop to the sigil component, to allow setting
classes directly on the sigil svg.
 2020-04-10 17:58:46 +10:00
ixv
b43f4d9d39
Merge pull request #2709 from urbit/mp/chat/namespace-group-chats 
chat: add unique ID to grouped chat paths
 2020-04-09 15:54:53 -07:00
ixv
c65b896a2c
Merge pull request #2705 from liam-fitzgerald/lf/publish-loading-fix 
publish-fe: improve UX of loading spinner on new note
 2020-04-09 15:54:04 -07:00
ixv
d376fd6998
Merge pull request #2704 from liam-fitzgerald/lf/chat-padding-sidebar 
chat-fe: filter empty groups in sidebar
 2020-04-09 15:53:55 -07:00
ixv
8e480b611d
Merge pull request #2703 from liam-fitzgerald/lf/chat-patp-copy 
chat-fe: copy patp to clipboard on author name click
 2020-04-09 15:53:46 -07:00
ixv
c5eb540c71
Merge pull request #2702 from liam-fitzgerald/lf/chat-join-spinner 
chat-fe: show spinner on join
 2020-04-09 15:53:35 -07:00
ixv
bc5358c0fd
Merge pull request #2695 from liam-fitzgerald/lf/sanitise-md-publish 
publish: sanitise markdown snippets in preview
 2020-04-09 15:52:52 -07:00
ixv
a41096153d
Merge pull request #2694 from liam-fitzgerald/lf/invite-search-arrow-keys 
invite-search: allow keyboard nav + selection
 2020-04-09 15:52:36 -07:00
ixv
77933e992a
Merge pull request #2693 from urbit/mp/re-alphabetise 
various: alphabetise associations accesses the object
 2020-04-09 15:52:18 -07:00
ixv
5fe16a7f47
Merge pull request #2687 from urbit/la-resub-on-err 
chat-js: resubscribe on error, not just on quit
 2020-04-09 15:52:03 -07:00
ixv
43484d613c
Merge pull request #2683 from urbit/mp/invite-search/associations 
invite search: populate group index from contacts
 2020-04-09 15:37:56 -07:00
ixv
8d32d49daf
Merge pull request #2668 from urbit/mp/link/dib-ing 
link: line up link info on same line height
 2020-04-09 15:37:38 -07:00
Matilde Park
9881fb2a2b chat: add unique ID to grouped chat paths 2020-04-09 14:37:21 -04:00
nijynot
6536054b91 interface: add eslint and update contrib docs 2020-04-09 12:08:23 +02:00
Liam Fitzgerald
0c062104a5 publish-fe: improve UX of loading spinner on new note 
Improve the UX of the loading spinner that shows when you have a new
note, by displaying it until we receive the new note in the
subscription, instead of until the poke succeeds.
 2020-04-09 16:06:10 +10:00
Liam Fitzgerald
6586aa98e3 chat-fe: filter empty groups in sidebar 
Empty groups caused the padding on the first group to be too large.
Filter the groups before we map over them so that we can set padding
properly.

Fixes #2674
 2020-04-09 15:08:06 +10:00
Liam Fitzgerald
e2f8be20de chat-fe: make copy status text inter 2020-04-09 14:13:23 +10:00
Liam Fitzgerald
648eced4ff chat-fe: copy patp to clipboard on author name click 2020-04-09 13:12:48 +10:00
Liam Fitzgerald
b4fb8d5163 chat-fe: show spinner on join 
Shows the spinner whilst joining a channel, both manually and from a
url. Also fixes an issue where a newly joined channel may be navigated
away from automatically.
 2020-04-09 12:48:55 +10:00
Liam Fitzgerald
3801056d3c invite-search: allow keyboard nav + selection 
Allows the user to navigate potential invitees with the arrow keys and
with shift+tab and tab. Enter adds the currently selected invitee.
 2020-04-09 08:03:21 +10:00
Liam Fitzgerald
ff70a2be89 publish: sanitise markdown snippets in preview 
Runs the snippet through ReactMarkdown instead of rendering it as text.
We restrict the allowed nodes in the render to pure text, so the snippet is not
overly visually heavy.
 2020-04-09 07:56:44 +10:00
Matilde Park
839f9090bb various: alphabetise associations accesses obj 
Previously we were checking for a title for the association by accessing
a non-existent property of the key we were using to iterate through
the object. What we want to do is access the iterated object to find
that title, and so this commit does that.
 2020-04-07 17:35:02 -04:00
Fang
e9233b1a50
link fe: fix "mark all as read" button 
This wasn't bound, nor calling, correctly.
 2020-04-07 20:45:27 +02:00
Logan Allen
7a41f2dcab chat-js: resubscribe on error, not just on quit 2020-04-06 23:24:13 -04:00
Matilde Park
00ed295d48 invite search: populate group index from contacts 2020-04-06 19:45:40 -04:00
édouard
6ed7520444 contributing.md: removed interface dev instructions from root-level doc, integrated into existing interface-specific doc 
I've moved the slightly edited interface development instructions from the root controbuting.md doc, over to the one located in pkg/interface. I've made sure to ensure any precvious information in the interface contributing doc has been matched or expanded upon in the new writing, which is a incrementally more thorough, and assumes a lower level of build-tooling knowledge.
 2020-04-03 15:37:42 -04:00
ixv
58b7f94e86
Merge pull request #2667 from urbit/la-chat-loading 
chat-js: transition to new chat upon chatSynced changing in join or new chat screen
 2020-04-03 10:21:36 -07:00
Matilde Park
e2cc01445b link: line up link info on same line height 2020-04-02 23:09:10 -04:00
Logan Allen
7eb499abda chat-js: transition to new chat upon chatSynced changing in join or new chat screen 2020-04-02 23:03:28 -04:00
Matilde Park
d943ed353e publish: add rollup-plugin-json to production imports 2020-04-02 22:46:12 -04:00
Matilde Park
f4c3b73346 publish: add rollupReplace to gulpfile 2020-04-02 22:33:04 -04:00
Isaac Visintainer
5faaa6c710 release: urbit-os-v1.0.10 2020-04-02 15:54:24 -07:00
Matilde Park
e358c1dbfb Merge branch 'master' into mp/invites-to-group-filter 2020-04-02 18:25:59 -04:00
Matilde Park
e2c36cda0b publish: propagate meta key for comment posting 2020-04-02 18:20:20 -04:00
Matilde Park
e51bd46224 link: fix meta key propagation for comment posting 2020-04-02 18:20:15 -04:00
Matilde Park
d03dcd8289 groups: preload spinner asset 2020-04-02 18:19:50 -04:00
Matilde Park
c873c4d01b chat: add spinner component and behaviours 2020-04-02 18:19:50 -04:00
Matilde Park
afec74cb2e groups: add componentised spinner and behaviours 2020-04-02 18:19:48 -04:00
Matilde Park
48e65499e2 groups: set sigil color on blur, not automatically 2020-04-02 18:18:42 -04:00
Matilde Park
7dbd2a09f0 soto: fix purple back arrows 2020-04-02 18:18:40 -04:00
Matilde Park
d49ace002d soto: add componentised spinner 2020-04-02 18:18:14 -04:00
Matilde Park
1bc973c520 link: reimplement spinner as component 2020-04-02 18:18:10 -04:00
Matilde Park
ef69ad6853 link: fix api call to change description 
When changing description, some pre-metadata refactors were resulting in
permanently broken calls to the API. This accesses our resource object
correctly.
 2020-04-02 18:17:12 -04:00
Matilde Park
6e0a29b79d links: move 'mark all as seen' to settings 2020-04-02 18:17:11 -04:00
Matilde Park
93587dd84d links: show pending comments 2020-04-02 18:17:11 -04:00
Matilde Park
48c9bdc702 publish: componentise spinner as part of layout 
This commit pulls the spinner out of the header bar -- and
reincorporates it as a component that hooks into local state when
awaiting a new prop, or disabling an input.
 2020-04-02 18:17:11 -04:00
Matilde Park
a21294f02e publish: atomically refresh our settings inputs 
Before, when we got new props for the metadata of the notebook, all the
fields would flash blank or to previous inputs. This rewrites the
update function to be more atomic with how it edits state,
which seems to correct the behaviour to avoid blank fields and disable fields
correctly.
 2020-04-02 18:17:11 -04:00
Matilde Park
c91ec10e78 link: fix skeleton border css class 2020-04-02 16:46:21 -04:00
Matilde Park
7cde503f80 groups: fix skeleton css 2020-04-02 16:43:33 -04:00
Matilde Park
06cf5a0ce6 group filter: enumerate and show invites correctly 2020-04-02 16:36:50 -04:00
Matilde Park
d8fbd75dbf launch: pass invites correctly to group filter 2020-04-02 16:36:50 -04:00
Matilde Park
f4c63b25c6 publish: pass invites to group filter 2020-04-02 16:36:50 -04:00
Matilde Park
0aff179e71 groups: pass invites to group filter 2020-04-02 16:36:50 -04:00
Matilde Park
8a43f7fc44 link: pass "/contacts" to group-filter 2020-04-02 16:36:50 -04:00
Matilde Park
a500038bed chat: pass full invites object 2020-04-02 16:36:41 -04:00
Matilde Park
65f8991ac8 invite search: avoid crashing with no associations 
By using an array, not a set, we stop deduplicating our group index,
pushing redundant information instead. When searching, this prevents a
component fail state where it cannot search a non-existent index for
matches.
 2020-04-02 14:50:29 -04:00
ixv
1d59ca7a16
Merge pull request #2640 from urbit/mp/groupify-2-dms-below 
chat: DMs repositioned below grouped chats
 2020-04-02 10:48:25 -07:00
ixv
75922dd017
Merge pull request #2654 from urbit/mp/ctrl-enter 
link, publish: submit comment on ctrl+enter
 2020-04-02 07:34:47 -07:00
ixv
d61c2831e8
Merge pull request #2637 from urbit/mp/new-ui-dark-header 
os1: add dark mode style for app name in headers
 2020-04-02 07:25:35 -07:00
ixv
275b0e65c5
Merge pull request #2652 from urbit/scrollback-fix-2 
chat-js: fix scrollback for small chat channels
 2020-04-02 07:23:59 -07:00
ixv
f6954e6a55
Merge pull request #2644 from urbit/mp/group-typing 
groups: show tile icon, not full color; alphabetically sort group channels
 2020-04-02 07:18:05 -07:00
ixv
42f9fa4f8b
Merge pull request #2642 from urbit/mp/new-borders 
os1: skeleton uses b--gray4, not b--gray2
 2020-04-02 07:17:50 -07:00
Matilde Park
8bafdea10c links: submit comment on ctrl+enter 2020-04-01 22:36:11 -04:00
Matilde Park
7a796549bd publish: submit comment on ctrl+enter 2020-04-01 22:33:56 -04:00
Logan
0ce28806a9
Merge branch 'master' into matilde/interface-prod 2020-04-01 22:24:33 -04:00
Logan Allen
72fbe18aff chat-js: fix scrollback for small chat channels 2020-04-01 22:14:33 -04:00
Matilde Park
8c7898786e groups: add slight background overlay to channel tiles 2020-04-01 21:08:00 -04:00
Matilde Park
e5c7539106 chat: sort DMs by most recent, sort grouped by alphabetical 2020-04-01 18:18:56 -04:00
Matilde Park
e70643b44d groups: default to coloured tile if unknown app 2020-04-01 15:46:59 -04:00
Matilde Park
e1af036f1c groups: show tile icon, not full color 2020-04-01 15:26:47 -04:00
Matilde Park
922318e072 os1: skeleton uses b--gray4, not b--gray2 2020-04-01 12:06:36 -04:00
Matilde Park
04b3a2a8cf chat: DMs repositioned below grouped chats 2020-04-01 01:07:32 -04:00
Matilde Park
0c87c2c186 link, publish: fix sidebar for multi-item groups 
A syntax typo led the array for nested notebooks to not have paths
pushed into it. Only the last item in the group would be pushed into the
array. This commit fixes that typo.
 2020-04-01 00:53:49 -04:00
Matilde Park
bfeb481b80 os1: add dark mode style for app name in headers 2020-03-31 22:01:08 -04:00
ixv
e76fe83ea1
Merge pull request #2615 from urbit/mp/grouping-take-2 
os1: reintegrating groups into all Landscape applications
 2020-03-31 15:17:57 -07:00
ixv
5791f8b86d
Merge pull request #2630 from urbit/mp/chat/fix-settings-invitesearch 
chat: settings pass 'groups' prop from permissions
 2020-03-31 14:18:25 -07:00
édouard
d40ce1a233 Merge branch 'mp/grouping-take-2' of https://github.com/urbit/urbit into mp/grouping-take-2 2020-03-31 17:18:22 -04:00
ixv
e5c06f2549
Merge pull request #2632 from liam-fitzgerald/lf/patp-validate 
various: bump urbit-ob version
 2020-03-31 14:18:10 -07:00
édouard
9851b58d1c os1: numerous cross-module padding changes 
Across every OS1 module (including the launch/home screen context) I edited some padding/margin/sizing for navigational elements for consistency across paging.
 2020-03-31 17:18:09 -04:00
Matilde Park
25e279ed82 chat, launch: style fixes post-#2615 code review 2020-03-31 14:03:12 -04:00
Liam Fitzgerald
81efbd1357 various: bump urbit-ob version 
The new version of urbit-ob includes stricter isValidPatp checks.

Fixes #2556
 2020-04-01 03:32:57 +10:00
Matilde Park
23ca02dd38 chat: settings pass 'groups' prop from permissions 2020-03-31 11:50:37 -04:00
ixv
c0b4de176a
Merge pull request #2627 from urbit/mp/publish/dark-syntax 
publish: dark mode syntax css
 2020-03-30 19:39:43 -07:00
Matilde Park
34528ff3d8 publish: dark mode syntax css 2020-03-30 18:31:58 -04:00
Logan Allen
49476aac66 chat-js: refactored subscriptions to auto-resubscribe 2020-03-30 18:07:33 -04:00
Logan Allen
c2070dbcc6 chat-js: pass in groups property, convert from permissions 2020-03-30 17:59:52 -04:00
Matilde Park
57d3f5327d os1: store.selected -> store.selectedGroups 2020-03-30 16:45:34 -04:00
Matilde Park
660cabf074 launch: link color unsetting agnostically 2020-03-30 15:57:09 -04:00
matildepark
2f3d681975
launch, link: apply @Fang- suggestions to #2615 review 
Co-Authored-By: Fang <git@fang.io>
 2020-03-30 15:50:16 -04:00
Matilde Park
1c45d4c46c publish: handle 'no notebooks' case 2020-03-27 16:44:15 -04:00
Matilde Park
952ea831d9 chat: handle 'no chats' case 2020-03-27 16:42:29 -04:00
Matilde Park
5b6902e065 soto: update header bar 2020-03-27 16:30:17 -04:00
Matilde Park
21c989fee1 publish: incorporate group filter component 2020-03-27 15:09:27 -04:00
Matilde Park
9cb90405c1 link: incorporate group filter component 2020-03-27 14:57:25 -04:00
Matilde Park
8335ae059c groups: incorporate group filter component 2020-03-27 14:39:01 -04:00
Matilde Park
612a88272f chat: incorporate group filter component 2020-03-27 14:26:23 -04:00
Matilde Park
891018159a launch: add group filter dropdown, header redesign 2020-03-27 12:45:51 -04:00
Matilde Park
09eec6ea65 launch: prevent dismissed welcome affecting mobile 
Flexbox would provide the empty <div> some space in our mobile layout.
This replaces the div with null.
 2020-03-27 12:45:51 -04:00
Matilde Park
744dc47be9 link: sidebar redesign with grouped collections 2020-03-27 12:45:51 -04:00
Matilde Park
e7a29dc628 publish: sidebar redesign with grouped notebooks 2020-03-27 12:45:49 -04:00
Matilde Park
afa38b1d2d chat: sidebar redesign, sorted by group 2020-03-27 12:45:27 -04:00
Matilde Park
f5e9b2d171 groups: alphabetise sidebar items 2020-03-27 12:44:49 -04:00
Logan Allen
221238c0fa chat-js: improve subscription speed by doing two rounds of subscriptions and no longer subscribing to groups 2020-03-26 17:41:11 -04:00
ixv
b8a222ea75
Merge pull request #2606 from urbit/la-scrollback 
Scrollback fixed and tested in Brave, Safari, and Chrome
 2020-03-26 09:02:24 -07:00
Logan Allen
2719a24dcc chat: decreased message limit to 20, now asking for more messages upon navigating to a chat channel when we have < 100 messages for that channel 2020-03-25 19:48:35 -04:00
ixv
755fbb7d14
Merge pull request #2583 from urbit/mp/os1/welcome 
os1: add startup content
 2020-03-25 16:26:01 -07:00
Fang
f39cdbb26f
link fe: split remove & delete logic 
Deletion retains its old behavior: can only be done by group owner, and
propagates.

Removing can now always be done by anyone, and works using
link-listen-hook: removing the collections from the set of ones we're
interested in, no longer syncing or showing up in the sidebar.
 2020-03-25 22:48:59 +01:00
Fang
e028d6eacf
link fe: base sidebar on link-listen-hook 
Instead of on associations, which may contain collections we're no
longer interested in.
 2020-03-25 22:47:05 +01:00
Logan Allen
a787eceae9 chat-js: turned off perf testing 2020-03-25 17:36:51 -04:00
Logan Allen
eb51ff693c chat: changed initial scrollback to 50 because 25 short messages wouldn't trigger any scrollbar at all, and fixed scrollback condition 2020-03-25 17:35:51 -04:00
Logan Allen
8d64d9d253 chat: fixed indentation 
logging for scrollback
 2020-03-25 17:34:59 -04:00
ixv
024b0717e0
Merge pull request #2601 from urbit/mp/publish/delete-note 
publish: delete notes
 2020-03-25 09:52:32 -07:00
Matilde Park
d2ac232a20 publish: pending comments use our ship, not owner 2020-03-24 21:20:35 -04:00
Matilde Park
19ee376aa9 links: prevent duplicate link submissions 
Adds a disabled check during link submission to prevent duplicates.

Also fixes an unmarked bug where 'linkValid' was not being reset to
false on submission, allowing for submitting blank links after one
correct link has been submitted.
 2020-03-24 20:00:10 -04:00
Matilde Park
cdc4fb5da0 various: graphic tweaks to welcome as per design 2020-03-24 19:27:34 -04:00
Matilde Park
fe341d7d8e publish: line up mobile navigation for 'all books' 
This mobile navigation was being padded into the middle to fit the
layout; this just excludes it from that inner layout.
 2020-03-24 18:39:34 -04:00
Matilde Park
a474d134c3 publish: add delete note front-end for note author 2020-03-24 18:36:43 -04:00
ixv
fd52384445
Merge pull request #2596 from urbit/mp/publish/publish-m-flexauto 
publish: flexbox sizing in skeleton, links open in _blank
 2020-03-24 15:19:34 -07:00
ixv
a5ed4e15e2
Merge pull request #2593 from urbit/mp/soto/empty-backspace 
soto: ignore backspace at cursor position 0
 2020-03-24 15:02:49 -07:00
ixv
a88ced01af
Merge pull request #2564 from urbit/mp/link-sigil-size 
links: adjust sigil size to 38
 2020-03-24 15:01:12 -07:00
Matilde Park
4c26419ff2 various: post-review adjustments for #2583 
This commit introduces some refactoring of localStorage logic, copy
changes and a rearrangement of the launch welcome message to the top
of the screen.
 2020-03-24 15:34:40 -04:00
Jared Tobin
cd9f23d6db
Merge branch 'liam-fitzgerald/lf/chat-patp-autocomplete' (#2571) 
* liam-fitzgerald/lf/chat-patp-autocomplete:
  chat-fe: fix incorrect property in css
  chat-fe: improve name legibility in autocomplete
  chat-fe: match autocomplete to designs
  chat-fe: autocomplete nicknames in message input
  chat-fe: ignore comets in autocomplete
  chat-fe: correct light mode autocomplete styling
  chat-fe: add patp autocomplete to message input

Signed-off-by: Jared Tobin <jared@tlon.io>
 2020-03-24 17:37:51 +04:00
Matilde Park
c1ed7a4841 publish: links open in _blank targets 2020-03-23 21:26:43 -04:00
Matilde Park
4395b130dd publish: add flex-auto to skeleton 
-m viewports had overflow out of parent containers;
this uses flex-auto to ensure the skeleton stays within its flex
container.
 2020-03-23 21:24:06 -04:00
Liam Fitzgerald
ca8f436fd0 chat-fe: fix incorrect property in css 2020-03-24 11:01:46 +10:00
Liam Fitzgerald
302c3dc4cc chat-fe: improve name legibility in autocomplete 2020-03-24 10:50:53 +10:00
Matilde Park
c1a4aeb60e soto: ignore backspace at cursor position 0 
If you entered the web dojo and hit Backspace immediately,
it would still process it as a valid key but pass the whole key forward.

This adds a conditional to ignore the key in those cases.
 2020-03-23 11:25:36 -04:00
Liam Fitzgerald
6c403f5135 chat-fe: match autocomplete to designs 2020-03-21 13:52:41 +10:00
Liam Fitzgerald
9c759a7e68 chat-fe: autocomplete nicknames in message input 2020-03-21 13:49:57 +10:00
ixv
fed93b1fe5
Merge pull request #2565 from urbit/groups/leave-group-text 
groups: two contact card changes
 2020-03-20 16:17:33 -07:00
ixv
3ba00c3623
Merge pull request #2580 from urbit/mp/publish/pending 
publish: add pending state for comments
 2020-03-20 16:16:51 -07:00
Matilde Park
41f95e231f publish: pending comments get correct timestamp 2020-03-20 17:46:00 -04:00
Matilde Park
812ab41a81 publish: abundant safety checks in comments update 2020-03-20 17:36:25 -04:00
Matilde Park
29c432408c groups: add startup content 2020-03-20 17:16:15 -04:00
Matilde Park
b16a64ae03 publish: add startup content 2020-03-20 17:16:08 -04:00
Matilde Park
d68b2e44d8 links: add startup content 2020-03-20 17:08:59 -04:00
Matilde Park
0d9a604ecd chat: add startup content 2020-03-20 17:05:15 -04:00
Matilde Park
9114d1e858 launch: add startup content 2020-03-20 16:30:20 -04:00
Fang
2db5f7bb59
Revert "chat fe: disable advanced groupify" 2020-03-20 18:45:22 +01:00
Matilde Park
0246bea613 publish: add pending state for comments 2020-03-20 13:23:47 -04:00