Commit Graph

2 Commits

Author SHA1 Message Date
Jōshin
4aa9bba5b3
gcp: isConfigured doesn't touch store
Makes the thread return a simple boolean; almost as simple as just
returning %.y or %.n.

gcpManager now stores whether GCP is configured as a private variable.

Also fixes some type errors in gcp.
2021-04-06 19:08:53 +00:00
J
c1b259af5b interface, gcp: don't spam the console with 500s
Options here were: make the get-token thread try to return a unit, or
write a different thread to check whether GCP Storage seemed to be
configured and poll on that thread, or move the whole thing into a Gall
app.

The compromise between time-to-implement and overall cleanliness seemed
to be to write a different thread that just checks whether the settings
fields have been poked. Unfortunately this means GcpManager is now a
somewhat hefty JavaScript state machine.

Took out the logic to check whether S3 was configured in GcpManager,
since it was really only there to prevent spamming the console with
500s. If you have both S3 and GCP Storage configured for some reason,
you will now use GCP per the logic in useStorage.
2021-02-26 23:42:57 +00:00