Liam Fitzgerald
6a1f0e2ac9
VirtualScroller: aggressively cleanup refs
...
Prevents a memory leak, as it appears React holds onto the class
instance after unmounting
2021-04-24 12:20:42 +10:00
Liam Fitzgerald
bc4f26b2b3
VirtualScroller: rework scroll initialisation
...
Calling restore if the scroll is locked simply resets the scroll,
instead of using the usual adjustment algorithm
2021-04-24 12:19:33 +10:00
matildepark
9ad12777ae
Merge pull request #4786 from urbit/la/fix-omnibox
...
interface: group feed no longer shows in omnibox
2021-04-23 15:45:40 -04:00
Logan Allen
27e5a6aef4
omnibox: add maybe operators
2021-04-23 14:34:39 -05:00
matildepark
b78e7583db
Merge pull request #4812 from urbit/mp/landscape/indigo-bump
...
landscape: update indigo-react to 1.2.21
2021-04-23 09:46:28 -04:00
Matilde Park
a13542dfa7
interface/logic: revert group-update type change
...
It broke tags, needs a redo.
2021-04-22 21:21:44 -04:00
Matilde Park
04f46eefe5
landscape: update indigo-react to 1.2.21
2021-04-22 19:46:43 -04:00
Matilde Park
236b7a047f
Merge branch 'release/next-js' into mp/landscape/indigo-bump
2021-04-22 19:43:47 -04:00
matildepark
5c5aefa9fc
Merge pull request #4806 from urbit/lf/fix-virt-scroller
...
VirtualScroller: fix race conditions and excessive scroll adjusting
2021-04-22 17:50:19 -04:00
matildepark
94435de867
Merge pull request #4807 from urbit/lf/offsettop-crash
...
Dropdown: check ref exists
2021-04-22 17:10:27 -04:00
matildepark
906f513959
Merge pull request #4808 from urbit/lf/flex-shrink-typings
...
interface: fix flex-shrink typings
2021-04-22 17:09:39 -04:00
janeway-bot
423613eed0
Merge b46f2e24e6 into release/next-js
2021-04-22 14:33:43 +04:00
Liam Fitzgerald
08452efef8
interface: fix flex-shrink, grow typings pt.2
2021-04-22 16:35:44 +10:00
Liam Fitzgerald
a7afaf065d
interface: fix flex-shrink, grow typings
2021-04-22 16:30:13 +10:00
Liam Fitzgerald
24259dab87
Dropdown: check ref exists
...
Fixes urbit/landscape#805
2021-04-22 15:16:04 +10:00
Liam Fitzgerald
6f7ed005ae
VirtualScroller: fix race condition in ref deletion
...
A callback ref is called after the component is mounted, but before the
component is unmounted. However, we might still be adjusting scroll
position based on a component that is going to be remounted. Previously,
we delayed the deletion until the next tick with setTimeout. With the
faster ordered map implementation, the component may be remounted
before the next tick, leading to the deletion of a ref that is still
mounted. To work around this, we store a set of 'orphans' and clear the
map of orphans on an interval, and only clear the map if we are not
currently adjusting our scroll position. Also includes fixes for jumpy
scroll behaviour on initial mount.
2021-04-22 15:04:38 +10:00
Liam Fitzgerald
f80ca5a3da
virtualContext: fix useVirtualResizeProp
2021-04-22 15:02:21 +10:00
Liam Fitzgerald
77fded3dab
GraphNotification: safe property access
2021-04-22 11:02:23 +10:00
Matilde Park
75f06a7c9e
landscape/logic: type safety adjustments
2021-04-21 17:22:08 -04:00
matildepark
1a01e58b7b
Merge pull request #4798 from urbit/mp/landscape/action-bg
...
landscape: pass background colors to actions
2021-04-21 14:38:39 -04:00
matildepark
62e2ea39c2
Merge pull request #4794 from urbit/lf/fast-ordered-map
...
interface: fast BigIntOrderedMap
2021-04-21 12:06:07 -04:00
Matilde Park
ab6239bf59
landscape: pass background colors to actions
...
Fixes urbit/landscape#802
2021-04-21 11:20:14 -04:00
Liam Fitzgerald
f9cf711c69
Merge remote-tracking branch 'origin/release/next-js'
2021-04-20 14:53:28 +10:00
Liam Fitzgerald
f038176169
Merge remote-tracking branch 'origin/la/font-display-swap'
2021-04-20 14:52:41 +10:00
Liam Fitzgerald
fc955ab83e
interface: new BigIntOrderedMap
...
New ordered map implementation that is faster and more space
efficient. Stores the map and keys as a flat POJO, sorting them upon
iteration. The sorting cost is only typically paid once per render
however as the sorted array is cached until the map is mutated. This
implementation appears to play nicer with immer's structural sharing,
reducing the incidence of 'props are equal by value, but not by
reference'.
2021-04-20 13:31:57 +10:00
Liam Fitzgerald
1ab925f84c
interface: unify BigIntOrderedMap imports
2021-04-20 13:11:39 +10:00
matildepark
110bcaa6ce
Merge pull request #4785 from urbit/la/fix-591
...
interface: fix #591 message display by time-sent in chat
2021-04-19 17:28:55 -04:00
matildepark
b090311964
Merge pull request #4689 from urbit/lf/form-merge
...
ChannelSettings: unify form handling
2021-04-19 17:22:16 -04:00
matildepark
fe61b8b7a9
Merge pull request #4782 from urbit/lf/notif-fixes
...
notifications: preferences screen, fix pagination
2021-04-19 17:18:03 -04:00
L
f26e63421e
Merge pull request #4777 from urbit/mp/group-feed/show-parent-if-parent
...
PostReplies: show parent author in parent postItem
2021-04-19 14:03:41 -05:00
Logan Allen
87feb74184
interface: group feed no longer shows in omnibox
2021-04-19 12:53:26 -05:00
Logan Allen
9a61daaa69
interface: fix #591 message display by time-sent in chat
2021-04-19 12:37:40 -05:00
Liam Fitzgerald
c92753d1ed
ChannelPopover: cancel dismisses popover
2021-04-19 15:58:44 +10:00
Liam Fitzgerald
f1be29389a
settings: default tutorial to seen
...
Prevents a race condition where the tutorial prompt will always show
2021-04-19 15:47:35 +10:00
matildepark
9a7f90bb63
Merge pull request #4783 from urbit/lf/tut-island-fix
...
launch: fix reversed destructure
2021-04-19 01:35:50 -04:00
Liam Fitzgerald
4c02bd0698
launch: fix reversed destructure
...
This was causing the tutorial to never be shown. This change should be
deployed with a new pill, to ensure comets show the tutorial.
2021-04-19 15:32:44 +10:00
Liam Fitzgerald
6128c8d096
notifications: bring preferences to spec
2021-04-19 15:24:30 +10:00
Liam Fitzgerald
988e614db4
interface: correctly scroll lock document
...
Even if overflow is hidden, certain mobile browsers may interpret a
scroll event to be on the document root, leading to strange and
inconsistent scrolling behaviours. Addresses this by adding
touch-action: none, which explicitly instructs browers to ignore this
element in scroll calculations.
2021-04-19 14:28:51 +10:00
Liam Fitzgerald
0ef452f8b3
notifications: update dismiss action styling
2021-04-19 13:26:21 +10:00
Liam Fitzgerald
048bd02604
notifications: fix broken pagination
...
Fixes urbit/landscape#788
2021-04-19 13:15:46 +10:00
édouard
deeab71831
sidebar: provide more contrast to sidebar items
...
Reverting this back to a most contrasty state in answer to frequent complaints of being unable to tell which channels were unread
2021-04-16 21:44:48 -04:00
édouard
503a3a8a49
invite notifications: fix radius of mention line
2021-04-16 20:28:50 -04:00
Matilde Park
55c1da67c6
PostReplies: show parent author in parent postItem
...
If an item is top of view, and has a parent,
we now render the parent author we are
replying to.
Fixes an unfiled bug
2021-04-16 16:05:14 -04:00
Matilde Park
8b82aec6c2
MentionText: pass all ships with sigs
2021-04-16 12:28:06 -04:00
Matilde Park
cd6e44ac82
Merge branch 'release/next-js' into mp/landscape/indigo-bump
2021-04-16 12:12:08 -04:00
matildepark
f2d91fdc98
Merge pull request #4772 from urbit/mp/landscape/prod
...
meta/interface: re-integrate preinstall script with clean install
2021-04-16 12:08:44 -04:00
Matilde Park
290b8c7c38
notifications: add margins to each
...
Otherwise they are not distinguished apart.
2021-04-16 11:47:40 -04:00
Liam Fitzgerald
d5bbc58c2b
Merge remote-tracking branch 'origin/release/next-js' into lf/notif-v2
2021-04-16 16:03:07 +10:00
Liam Fitzgerald
83901ece22
notifications: refactor invites to match spec
2021-04-16 16:02:26 +10:00
Liam Fitzgerald
3bd1e06f0f
notifications: refactor inbox to match spec
2021-04-16 16:02:05 +10:00
