Patrick O'Sullivan
4bc543a6ec
groups: handle italic or bold markdown around @p's in messages
2022-03-04 12:46:16 -06:00
Hunter Miller
137e3970b9
Merge branch 'master' into next/landscape
2022-03-04 10:51:44 -06:00
Patrick O'Sullivan
d715c7d7cb
landscape: Prevent adding duplicate ships to ShipSearch pills
2022-03-03 05:20:59 -06:00
Jōshin
06fe78ef6e
Merge branch 'next/arvo' into jo/khan
2022-03-02 20:28:44 -06:00
Jōshin
0d3b6d3d2a
Merge branch 'master' into next/arvo
2022-03-02 20:28:09 -06:00
Jōshin
0139550c79
khan: saner tic rollover, remove our
2022-03-02 20:15:44 -06:00
Hunter Miller
6c221fbddc
interface: updating glob to trigger properly uploaded glob
2022-03-02 18:32:45 -06:00
Jōshin
e54e92cfa9
khan: docs
2022-03-02 18:02:20 -06:00
Jōshin
9d50957861
arvo: remove $crag, promote $page
2022-03-02 17:59:56 -06:00
Jōshin
8afea3c2ba
arvo: $card is not a cask
2022-03-02 17:38:45 -06:00
Jōshin
d06d8044fd
test: confirm different tids on same eny
2022-03-02 17:30:56 -06:00
Jōshin
0b507cf498
khan: don't reset tic
...
instead make it a rolling 128-bit integer. 128 bits is the same size as
the +sham space, so is one natural choice for "big enough to never have
to think about this." 64, 32, 16, even 8 bits would probably be fine.
2022-03-02 17:28:10 -06:00
Jōshin
18274090b2
khan: handle multiple %fards in one event
2022-03-02 16:37:46 -06:00
Jōshin
5d7321385f
khan: separate arms by blank comments
2022-03-02 15:09:01 -06:00
Jōshin
1ef958ea25
khan: use +en-beam / +de-beam, wide form
2022-03-02 15:07:38 -06:00
Jōshin
02d796cddb
arvo: remove redundant *
2022-03-02 15:07:10 -06:00
Jōshin
e4b6fe6ad3
test: 1162
2022-03-02 13:25:10 -06:00
Jōshin
91d390d529
khan: update docs
2022-03-02 13:23:06 -06:00
Jōshin
340f4d5b6c
khan: %fard/%arow use $cage, not $vase
...
Threads should eventually take and produce $cage instead of $vase. Since
%khan is likely to be used by third parties, we write to the eventual
intended API. We ignore the mark on the input $cage (it is safe to
always specify %noun), and we always use %noun as the output mark.
%fyrd now makes more sense. It was previously discarding the type of the
output %arow and re-encoding the raw noun as a vase of the output mark;
it is now performing mark conversion from the mark of the output $cage
to the originally requested output mark.
2022-03-02 13:07:52 -06:00
Yaseen
a57cb822a3
Merge branch 'urbit:master' into story
2022-03-02 12:03:44 -05:00
Jōshin
f5fb214939
khan: initial state version is %0
2022-03-01 23:38:55 -06:00
Jōshin
6ce6e4f504
khan: structural slap, not general slam
2022-03-01 19:34:56 -06:00
Jōshin
2e9b4f5a94
khan: better wire production
...
runs afoul of a likely hoon bug and/or use case for dependent hoon.
2022-03-01 19:33:54 -06:00
tomholford
3bbfd20022
Merge branch 'master' into next/landscape
2022-02-28 15:39:17 -06:00
Hunter Miller
c4bc9b3428
groups: updating glob and version
2022-02-28 11:32:05 -06:00
Yaseen
591c19b9a9
story: rename generators
2022-02-25 18:27:54 -05:00
Yaseen
70afcbd642
clay: fix bug in fuse
...
Co-authored-by: Philip Monk <phil@pcmonk.me>
2022-02-25 16:34:44 -05:00
Yaseen
c1a8d527fa
story: fix output formatting in +story-log
2022-02-25 16:28:17 -05:00
tomholford
5959b73ecb
interface: use single sig in NotificationText
...
The `ProfileOverlay` component expects a `ship` arg as a patp without the sig. This deSigs the ship value used in `NotificationText`.
This closes urbit/landscape#1376
2022-02-25 15:24:14 -06:00
Liam Fitzgerald
cbb17a2135
interface: fix subscription reconnect issues
...
Restores subscription reconnect issues by correctly throwing a
FatalError so that subscriptions are correctly restarted
2022-02-25 13:25:18 -06:00
Jōshin
a9442040be
khan: alignment
2022-02-25 11:16:47 -08:00
Jōshin
224a363780
test: fix failure introduced by random tids
2022-02-25 11:08:09 -08:00
tomholford
4c25bcd586
devex: peg interface node version
...
See: https://nodejs.org/en/about/releases/
2022-02-24 16:32:39 -06:00
Hunter Miller
ce75499ae5
Merge branch 'next/groups'
2022-02-24 10:44:08 -06:00
tomholford
47338cffc6
Merge branch 'master' into next/groups
2022-02-23 17:14:34 -06:00
Hunter Miller
2da5e9c5ca
landscape: fixing bad glob
2022-02-23 13:30:56 -06:00
Hunter Miller
b4adaf2fee
landscape: updating glob and version
2022-02-23 10:45:32 -06:00
Joe Bryan
ff3bb495d8
hoon: updates %mcgl with an hygienic expansion
2022-02-22 20:39:30 -05:00
Yaseen
33aa0c8fa7
story: generators: fix case check
2022-02-22 18:33:38 -05:00
Yaseen
5f421d577a
story: fix scry path in |story-set
2022-02-22 18:11:55 -05:00
ryjm
7ce7d2622d
graph-store: fix scrying into archive
2022-02-22 08:07:40 -05:00
Yaseen
38a2e9d74a
story: generators: add desk existence everywhere
2022-02-21 22:13:15 -05:00
Yaseen
4eb7e623cd
story: generators: fix case scry
2022-02-21 22:10:22 -05:00
Jōshin
d771a4b9ef
khan: randomize tids
...
tid was accidentally getting set to the name of the output mark. As we
don't currently support cancelling threads, there is no reason to
maintain the originally-intended correspondence between tid and conn
request-id.
Take the opportunity to clean up indentation somewhat.
2022-02-19 02:18:49 -08:00
Yaseen
a149dc6c40
story: generators: add check for invalid case
2022-02-18 22:30:24 -05:00
Yaseen
c02f59818e
story: fix generator bugs
2022-02-18 18:51:37 -05:00
Yaseen
05784fcee3
story: check for storyfile existence and use case from beak where appl.
2022-02-18 18:20:17 -05:00
Yaseen
4b04da5a9a
story: make |story-{set,remove} use $cash instead of $case
2022-02-18 17:49:17 -05:00
Yaseen
b616f48169
story: add $cash
2022-02-18 17:46:04 -05:00
Yaseen
3d006d60ad
clay: add scry for case existence check
2022-02-18 17:43:38 -05:00
Yaseen
9d85401832
story: add generator help text
2022-02-18 17:40:55 -05:00
fang
98c6c77ebb
Merge branch 'next/arvo'
2022-02-17 20:32:26 +01:00
Jōshin
470ae80d4b
khan: cleanup
2022-02-15 22:32:52 -08:00
Jōshin
0e185b66ed
test: fix
2022-02-15 22:32:43 -08:00
Hunter Miller
2959549594
Merge pull request #5600 from urbit/mackenzie/theme-color
...
interface: adds `theme-color` meta tag, removes outdated safari web app meta tag
2022-02-15 16:32:10 -06:00
Mackenzie Davidson
7b835165e0
interface: adds theme-color meta tag, removes outdated safari web app meta tag
...
fixes urbit/landscape#1392
2022-02-15 12:27:04 -05:00
Jōshin
6aa72069e3
arvo: introduces $crag
...
Also strips out `$` from khan top-level comment.
There are arguments for keeping $crag in lull, and on the other side for
moving $cast to arvo. This seemed like the most reasonable approach.
2022-02-14 12:46:31 -06:00
Jōshin
6d275fe9f3
khan: move =/ down
2022-02-14 09:09:55 -06:00
Jōshin
6c443191a7
khan: name $cast type
2022-02-13 21:13:48 -06:00
Jōshin
044e9015af
Merge branch 'next/arvo' into jo/khan
...
Conflicts:
bin/brass.pill
bin/solid.pill
Resolved by regenerating pills.
2022-02-13 21:00:10 -06:00
Jōshin
e4f5438e88
test: tlv
2022-02-13 20:37:34 -06:00
Jōshin
22ef135323
test: missing mark cases, further cleanup
2022-02-13 20:30:36 -06:00
Jōshin
a1621ed2d4
test: cleanup
2022-02-13 19:58:36 -06:00
Jōshin
76911c6784
test: cleanup
2022-02-13 19:56:29 -06:00
Jōshin
27b6b4f706
test: %fyrd fail case
2022-02-13 13:09:39 -08:00
Jōshin
286c909283
test: refactor, strip out inner %fard call
2022-02-13 12:54:21 -08:00
Jōshin
18e2d751a5
test: remaining %fard failures
2022-02-13 12:51:43 -08:00
Jōshin
5750f5f0f6
test: %khan full run, %fyrd
2022-02-13 12:02:13 -08:00
Jōshin
1d487a758b
test: full run, happy path
2022-02-13 07:33:03 -08:00
yosoyubik
1dd5fca11c
roller: bug fix in looking for sending diff
2022-02-12 14:36:40 +01:00
yosoyubik
72794870c8
roller: include signing address in sending txs
2022-02-12 14:02:50 +01:00
Jōshin
d7608019f2
khan: cleanup, namespace
2022-02-11 22:18:15 -08:00
Jōshin
c0423adea6
khan: parameterized types, nested implementation
...
%fyrd is now implemented in terms of %fard, and likewise %avow in terms
of %arow. State is tracked via wire rather than in a global map.
Unit tests adjusted to match.
2022-02-11 21:58:09 -08:00
Yaseen
61ca368f28
story: |story-set: better error message on missing desk
2022-02-11 13:08:16 -05:00
Yaseen
52537a7b3b
story: lib: remove ;; in favor of typecast
2022-02-11 12:12:20 -05:00
yosoyubik
403c8af519
roller: check for existence in resend nonce
2022-02-11 15:46:13 +01:00
yosoyubik
5c9fc52f47
roller: keep force flag in sending transactions
2022-02-11 14:28:27 +01:00
yosoyubik
db660b6167
roller-rpc: make force field optional
2022-02-10 20:44:50 +01:00
yosoyubik
5fd991161c
roller: add support for forced transactions
2022-02-10 20:23:27 +01:00
Jōshin
ca0a861c5e
zuse: add missing assertions
2022-02-09 14:14:12 -06:00
Liam Fitzgerald
981bcfdecc
landscape: cache marks again
...
Fixes urbit/urbit#5590
2022-02-09 10:52:04 -06:00
Jōshin
5ff5082a5d
khan: docs, lift arg vase into (unit)
2022-02-08 12:03:00 -06:00
Jōshin
34fd7f5adf
test: wip full-run test
2022-02-08 08:44:55 -06:00
rabsef-bicrym
22a69d38f4
%depth-first has pattern-matching issue
...
support a `%depth-first` scry constructed as follows `.^(* %gx /=graph-store=/graph/<ship of resource>/<name of resource>/depth-first/<count>/<start>/graph-update-3)`
2022-02-07 17:49:11 -08:00
Jōshin
776604bf74
test: rewrite khan start-args unit test
2022-02-07 17:51:05 -06:00
Jōshin
8123255a62
khan: add %fard/%arow for in-arvo threads
...
These take and produce vases, and assign random tids (rather than
deducing them from the input duct.)
Since %fard does not require mark conversion, we make the mark/beak on
$thread-state optional (and use this to decide whether to send %avow or
%arow.) Provide a state adapter since it's possible that people have
been experimenting with this vane.
This makes the negative case of %avow/%arow kind of clunky, since there
is no content difference, but the following does not seem possible
within the Hoon type system:
=/ gif
?~ p.tad
%arow %avow
[hen %give gif %| p.cag tang]~
2022-02-07 17:51:05 -06:00
Yaseen
8814f31879
story: shorten recur statement in +story-log
2022-02-05 22:56:27 -05:00
Yaseen
fc5c7d53ea
story: make desk an optional param in story-list
2022-02-05 22:50:10 -05:00
Yaseen
4a921ad68b
story: fix |story-remove and allow it to remove a specific prose
2022-02-05 22:50:10 -05:00
Yaseen
ce0fa85e18
story: generators improvements
...
- use desk parameter instead of %base everywhere
- formatting clean up
- make |story-remove take a case instead of an aeon
- make desk param optional for story-set and story-log
2022-02-05 22:50:10 -05:00
Yaseen
5346784609
story: parser improvements
2022-02-05 06:16:59 -05:00
Yaseen
a38ec43d99
story: misc clean up
2022-02-05 06:15:45 -05:00
Yaseen
322fb5ecce
story: clean up snoc in txt:grow
2022-02-04 12:53:13 -05:00
Yaseen
75b01a2c0c
story: fix dif-ju correctness on empty input
2022-02-04 12:51:58 -05:00
Yaseen
9b66cb9b81
story: make lib lead core
2022-02-04 12:49:55 -05:00
Yaseen
94d55f1e33
story: misc changes
2022-02-04 12:49:10 -05:00
Jōshin
64fcd685af
zuse: comment clarifying sk bounds check
2022-02-03 13:52:09 -06:00
Jōshin
4cef7dc38b
bounds-check against sk=1
...
+sign:schnorr crashes on `=(0 sk)`, so the bounds checking code is not
exercised for sk=0. It also crashes on `(gte sk n.domain.c)`, which is
redundant with the size check on sk, so we remove that.
2022-02-03 13:21:21 -06:00
Jōshin
f07f759253
zuse: style cleanup, use +rep/+end
2022-02-03 12:54:27 -06:00
Liam Fitzgerald
f3da5488ce
Merge remote-tracking branch 'origin/next/groups' into lf/no-perms-rejoin
2022-02-03 11:12:43 -06:00
Yaseen
e1f8f4db45
story: fix error with null jug
2022-02-02 23:35:55 -05:00
Jōshin
822eb6ea08
Merge branch 'next/arvo' into jo/secp-arvo
2022-02-02 20:34:11 -06:00
Liam Fitzgerald
b14dc76992
interface: refine joining error cases
2022-01-31 16:21:27 -06:00
Liam Fitzgerald
9540afecad
group-view: fix errored rollback
2022-01-31 16:20:57 -06:00
Jōshin
4c22e2ceaa
spider: blank lines
2022-01-31 15:47:14 -06:00
Yaseen
b7e0b28220
Merge branch 'urbit:master' into story
2022-01-30 16:03:48 -05:00
Yaseen
9afc2b8258
story: diff: use dif-ju and uni-ju
2022-01-30 16:03:10 -05:00
Yaseen
68da061f47
story: update outdated diff types
2022-01-30 16:02:47 -05:00
Yaseen
f723088f4d
story: create fundamental jug operations
2022-01-30 16:02:25 -05:00
Yaseen
e791c501a0
story: fix lib import
2022-01-30 16:01:45 -05:00
Yaseen
08cd2feed7
story: use new parser in mark
2022-01-30 16:01:31 -05:00
Yaseen
10e252bca0
story: add new parsers to lib
2022-01-30 16:01:00 -05:00
Yaseen
b87a754622
story: rip out parsers
2022-01-30 16:00:38 -05:00
Yaseen
75d6882b51
story: fix to-text arms
2022-01-30 15:59:58 -05:00
Yaseen
9286d89fa2
story: add chapter type
2022-01-30 15:59:06 -05:00
Yaseen
8787c43c83
story: cleanup
2022-01-30 15:58:35 -05:00
Hunter Miller
874d380ad5
groups: updating version
2022-01-28 20:30:13 -06:00
Hunter Miller
dc188d6059
groups: fixing bad glob
2022-01-28 20:29:34 -06:00
Hunter Miller
de747b343f
join: don't show modal if no kind
2022-01-28 19:51:35 -06:00
Hunter Miller
509bd2b11a
groups: updating glob
2022-01-28 19:39:48 -06:00
Hunter Miller
0d93cf9cff
join: handling kind safer and join links more consistent
2022-01-28 19:33:42 -06:00
drbeefsupreme
f67962b803
helm: cleanup +poke-rekey to match #5522
2022-01-28 12:23:36 -05:00
Jōshin
ccf9110f7f
test: khan test cleanup
...
;;(vase ...) does a nest-check of the type of the kernel. This is
undesirable, so we instead run everything through +slum and cast the
result to +tang.
2022-01-28 09:05:37 -08:00
Jōshin
21ea32e8ad
khan: +bear allows a full +beak
2022-01-27 22:28:30 -08:00
Jōshin
72981203c8
khan: PR feedback, wip tests
2022-01-27 22:20:31 -08:00
Hunter Miller
c07bcd6e03
Merge branch 'next/groups'
2022-01-27 10:25:14 -06:00
Hunter Miller
88e956df01
Merge branch 'next/landscape'
2022-01-27 10:24:04 -06:00
Jōshin
7f6868a06e
khan: strip inner faces from +bear
2022-01-26 21:50:08 -08:00
Jōshin
05a11d57b3
khan: cleanup
...
- only store metadata in the persistent map. just enough to support
(eventual) thread cancellation and output mark lookup.
- try to delete thread state at other failure points not covered by
%kick.
- reflect back the passed output mark rather than form.dais. not sure
about this one yet.
2022-01-26 20:09:36 -08:00
Jōshin
aba5c0303d
khan: del in %kick
2022-01-26 17:45:25 -08:00
Jōshin
1281e1cdbe
khan: functionally done
2022-01-26 17:41:01 -08:00
Jōshin
425bf6b011
khan: accepts thread arguments with marks
2022-01-26 16:26:30 -08:00
fang
d7d15115ee
Merge branch 'next/webterm'
2022-01-27 00:30:17 +01:00
fang
192f2cd19d
webterm: v1.0.1
2022-01-27 00:29:24 +01:00
Yaseen
a0cc6d8980
story: make +story-log use arms from lib
2022-01-26 18:07:29 -05:00
Yaseen
1e871e3c35
story: use crip/trip where necessary
2022-01-26 18:07:00 -05:00
drbeefsupreme
b5f299c02d
helm: fix |rekey to work with multikey files
2022-01-26 16:29:14 -05:00
Philip Monk
34bcd2ffcd
Merge pull request #5495 from urbit/m/whos-who
...
helm: bind /who.json
2022-01-26 12:47:47 -07:00
Hunter Miller
0abf7eecfe
app: refactoring app to TS and removing lots of unused props
2022-01-26 12:21:19 -06:00
Yaseen
484772e2b7
story: misc changes
2022-01-26 11:41:22 -05:00
Yaseen
d8450c2892
story: use lib arms in txt:grow
2022-01-26 11:41:08 -05:00
Yaseen
3105176df9
story: handle conflicts for updated $story type (mvp)
2022-01-26 11:39:18 -05:00
Yaseen
b0a666d2eb
story: add lib/story.hoon
2022-01-26 11:37:02 -05:00
Hunter Miller
79f0fd98dd
chat-resource: fixing admin detection
2022-01-26 10:29:04 -06:00
Jōshin
8ad57d8bd2
khan: cleanup
2022-01-25 21:28:45 -08:00
Jōshin
12b4c80cf1
khan: wip threads v0
...
super ghetto first pass with a bunch of stuff hard-coded to prevent
sending giant vases over the wire.
2022-01-25 20:08:48 -08:00
Jōshin
fd7d315e3b
khan: wip fyrd
2022-01-25 15:37:48 -08:00
Hunter Miller
049a85bc60
Merge branch 'next/groups' into hm/landscape-perf-optimization
2022-01-25 17:05:32 -06:00
Yaseen
5b512abae5
story: update |story-remove to use new types
2022-01-25 14:54:55 -05:00
Yaseen
86ef82dbe1
story: misc changes
2022-01-25 14:54:30 -05:00
Yaseen
194f3d55c6
story: make sur file an lead core
2022-01-25 13:52:40 -05:00
Hunter Miller
5426f2aff8
Merge branch 'next/groups' into hm/fix-group-dm-initial-load
2022-01-25 11:23:30 -06:00
Hunter Miller
86d9aba7fb
garden,landscape: updating globs and versions
2022-01-24 16:14:26 -06:00
Liam Fitzgerald
14ca87c43c
dm-hook: mutate screened before giving fact
...
Fixes an issue where the subscription update would contain stale data
2022-01-24 15:18:52 -06:00
fang
a51ac14833
webterm: improve readability of char under cursor
...
Make sure it's the opposite of the cursor color.
2022-01-24 14:33:25 +01:00
Jōshin
30df250c7d
khan: closer to starting threads
2022-01-22 01:46:59 +00:00
Jōshin
a247113c57
khan: %done task
2022-01-22 01:46:12 +00:00
Jōshin
3cf803129d
khan: basic +call, types
2022-01-21 22:09:01 +00:00
Jōshin
575ff61fa6
khan: vane skeleton
2022-01-21 18:48:05 +00:00
Yaseen
c818d293ba
story: add generator +story-log
2022-01-21 11:50:42 -05:00
Yaseen
606acd8fa2
story: restore previous mark functionality, ignore conflicts
2022-01-21 11:50:05 -05:00
Liam Fitzgerald
c5c7946e5a
Merge pull request #5553 from urbit/la/proxy-sigs
...
graph-push-hook: proxy add and remove signatures across the network
2022-01-20 16:52:22 -06:00
Logan Allen
bb953945f8
graph-push-hook: proxy add and remove signatures across the network
2022-01-20 21:58:00 +00:00
Yaseen
a927d31629
story: make |story-list use new types
2022-01-20 16:01:01 -05:00
Yaseen
f491aa0384
story: update |story-set to use new types
2022-01-20 15:58:05 -05:00
Yaseen
b06df068c0
story: make |story-init use new types and make overwriting optional
2022-01-20 15:56:47 -05:00
Yaseen
f2b8a1b7f7
story: update sur file
2022-01-20 15:54:37 -05:00
yosoyubik
d62ba7d6b5
roller: fix wrong ship quota
2022-01-20 16:15:38 +01:00
yosoyubik
0c9fc76b93
eth-watcher: fix zoom-margin to account for reorgs
...
The previous value—used for testing—didn't consider
block reorgs, which meant that if we zoom to the latest
block that has no transactions, but that gets later replaced
by a 1-block reorg that does have a transaction, we'll miss it,
making our Azimuth state incomplete.
To fix it, we rewind the Azimuth state to the contents of the snapshot,
and then start retrieving logs from the latest one we have.
2022-01-19 17:41:05 +01:00
Hunter Miller
09f71e504b
dms: don't load if pending
2022-01-18 14:38:45 -06:00
yosoyubik
3d943ec201
ames: ignore missing peer-state on-publ-sponsor
2022-01-18 20:34:32 +01:00
Yaseen
df9e5175d1
story: create sur file and extract type
2022-01-16 22:36:52 -05:00
Yaseen
6a25f8ffca
story: add custom ++grad core
2022-01-15 23:37:51 -05:00
Yaseen
e5642b5ff3
story: rename door sample to tale
2022-01-15 23:26:33 -05:00
Hunter Miller
3bbaf6de80
join: making sure group is in state and retaining join request state
2022-01-13 16:15:38 -06:00
Hunter Miller
ed3b19cd0f
sidebarlistheader: fixing potential undefined ref
2022-01-13 16:14:22 -06:00
Yaseen
b37fd09fab
clay: implement %base-tako scry under the %s care
2022-01-13 15:56:20 -05:00
fang
7be6950fe5
Merge branch 'm/helm-perms' into next/arvo
2022-01-13 00:36:22 +01:00
fang
b9491bcbb8
Merge branch 'master' into next/arvo
2022-01-13 00:36:07 +01:00
fang
0bc1f49f0f
drum: only process pokes from the local ship
...
No mark files exist for any of the drum marks, so trying to poke remote drums
would fail anyway, but relying on the mark system in that way seems a bit
fragile, so we add an explicit permission check.
2022-01-13 00:24:31 +01:00
fang
bde8c0b04a
helm: only process pokes from the local ship
...
No mark files exist for any of the helm marks (except `%helm-hi`), so trying to
poke remote helms would fail anyway, but relying on the mark system in that way
seems a bit fragile, so we add an explicit permission check.
2022-01-12 13:28:44 +01:00
jose
f158ebe312
Merge pull request #5532 from urbit/azimuth/jael-fix
...
jael: give new private key to subscribers on %keys new-event
2022-01-12 12:47:21 +01:00
yosoyubik
432d9674f5
jael: don't put conflicting this-su in the subject
2022-01-12 11:01:06 +01:00
Hunter Miller
c13ec5a698
notification-redirect: send to already joined chat instead of showing join modal
2022-01-11 19:36:06 -06:00
Hunter Miller
1ddd38e82c
join: removing unused props, fixing invite 'kind' for proper linking
2022-01-11 19:32:51 -06:00
Hunter Miller
5fba433415
hark-update: fixing desk check
2022-01-11 19:30:53 -06:00
Hunter Miller
846502ef51
Merge branch 'next/groups' into hm/remove-dm-delete
2022-01-11 18:16:29 -06:00
Hunter Miller
4ee680807f
Merge branch 'master' into next/groups
2022-01-11 18:15:25 -06:00
Hunter Miller
8efc0a9006
dms: hiding delete for dms and hiding dropdown if only reply
2022-01-11 16:43:57 -06:00
Hunter Miller
f6db32e669
webpack: fixing refresh in dev
2022-01-11 16:43:02 -06:00
Hunter Miller
158dfc0dec
interface: fixing type errors
2022-01-11 16:42:38 -06:00
Liam Fitzgerald
6c1ce45815
Merge pull request #5489 from urbit/lf/fix-revoke
...
groups: fix permission handling
2022-01-10 11:11:12 -06:00
Liam Fitzgerald
f1f57abec0
Merge pull request #5485 from urbit/lf/recency-improvements
...
landscape: better leap searching
2022-01-10 11:10:51 -06:00
Liam Fitzgerald
b4512bf1a0
Merge pull request #5490 from urbit/lf/groups-grabbag
...
groups: misc frontend fixes
2022-01-10 11:08:14 -06:00
Liam Fitzgerald
4009f9d350
Merge pull request #5525 from urbit/lf/fix-dm-loading
...
DmResource: reload DM if cleared by kick
2022-01-10 11:07:25 -06:00
Liam Fitzgerald
a1aee5d2c8
Merge pull request #5519 from urbit/lf/fix-admin-remove
...
graph-validator-chat: allow admin removal of any message
2022-01-10 11:06:58 -06:00
Jōshin
ce05e562ed
test: schnorr bounds checking
2022-01-09 05:49:47 +00:00
Jōshin
71c59737d8
zuse: boundary assertions for schnorr
...
Just assert on mis-sized values.
2022-01-09 05:31:36 +00:00
Jōshin
4591fa272e
zuse: schnorr test cases
...
These are from:
<https://github.com/bitcoin/bips/blob/master/bip-0340/test-vectors.csv >
2022-01-09 05:28:22 +00:00
yosoyubik
fccf99e0a6
jael: refactor new-event for %keys diff
...
this also adds a %rerun %poke to /app/azimuth
2022-01-08 19:28:11 +01:00
yosoyubik
8535563de6
jael: give private key to subscribers on keys diff
...
Triggering this event has been added to /app/azimuth's +on-load
2022-01-08 09:48:28 +01:00
yosoyubik
583d5f5063
azimuth: process snapshot on-load
2022-01-07 18:13:51 +01:00
Hunter Miller
1ddc7fee83
types: fixing type issues from merge
2022-01-07 11:08:59 -06:00
yosoyubik
1950736518
azimuth: update snapshot at block 13.958.653
2022-01-07 17:31:49 +01:00
fang
afea2edc59
webterm: improve selection look & feel
2022-01-07 14:02:28 +01:00
Hunter Miller
9c5f90fe3b
Merge branch 'next/groups' into hm/landscape-perf-optimization
2022-01-06 16:52:55 -06:00
Hunter Miller
4834ec59a2
Merge branch 'master' into next/landscape
2022-01-06 16:25:04 -06:00
Liam Fitzgerald
a42b344559
DmResource: reload DM if cleared by kick
2022-01-06 13:55:22 -06:00
yosoyubik
8df443bc46
azimuth: remove eth-logs
2022-01-06 16:43:28 +01:00
Hunter Miller
318cb9f00e
Merge branch 'master' into next/landscape
2022-01-05 16:59:32 -06:00
Liam Fitzgerald
05de25a22f
graph-validator-chat: allow admin removal of any message
2022-01-04 15:11:24 -06:00
Yaseen
dcb8aedc09
story: amend |story-set to use the tako from appropriate desk
2021-12-30 21:01:03 -05:00
Jōshin
40fbd16036
zuse: schnorr address
2021-12-30 05:46:44 +00:00
Jōshin
cb5983c6ae
zuse: schnorr jet hints
2021-12-30 04:25:31 +00:00
Jōshin
f93457ce9c
zuse: style
2021-12-30 04:14:25 +00:00
Jōshin
0fb3dd5ed0
zuse: cleanup
2021-12-30 00:47:11 +00:00
Jōshin
022ec2867d
zuse: banish byte twiddling from schnorr
...
Actually it's just hidden in +sha-256l:sha now.
2021-12-30 00:42:47 +00:00
Jōshin
57ef17fc91
zuse: signatures were backwards
2021-12-29 23:58:31 +00:00
Jōshin
09294d79bc
zuse: unused ffra
2021-12-29 23:50:16 +00:00
Jōshin
4c6187787f
zuse: remove redundant flips on sig
2021-12-29 23:50:16 +00:00
Jōshin
4f1269b205
zuse: cleanup in schnorr
2021-12-29 23:50:15 +00:00
Jōshin
b296f3912e
zuse: verify:schnorr works
2021-12-29 23:50:15 +00:00
Jōshin
ab4b735471
zuse: sign:schnorr basically done
...
Schnorr's choice of big-endian encoding commits us to some degree of
byte twiddling; try to make this fairly seamless.
2021-12-29 23:49:54 +00:00
Jōshin
f39421c97b
zuse: flip bytes in sig
...
gross!
2021-12-29 19:02:51 +00:00
Jōshin
a1c548ced4
zuse: schnorrsig-sign from spec
...
test vectors match, but are byte-flipped. has to do a lot of endianness
twiddling.
2021-12-29 18:57:45 +00:00
Jōshin
aa3bbe165e
zuse: schnorrsig stubs
2021-12-25 08:47:43 +00:00
Mackenzie Davidson
da2b31750b
theme_color meta precedence corrected
2021-12-20 13:20:59 -05:00
Mackenzie Davidson
bc249fc204
replace theme color override with existing background color value (rgb(26, 26, 26), in hex) for dark mode users
2021-12-20 13:15:02 -05:00
Mackenzie Davidson
453a253091
override theme_color in manifest
2021-12-20 13:12:33 -05:00
Mackenzie Davidson
f9c76914a9
Merge branch 'master' of https://github.com/mwvd/urbit into html-theme-updates
2021-12-20 12:58:49 -05:00
Philip Monk
e243d5adf6
landscape,garden: make build
...
Boot was broken, fixing the hark-note file mark and re-adding the
hark-store library fixed it.
This lets us push a new pill, which is necessary for the fix in #5434 to
actually work.
Fixes #5501
Fixes #5502
2021-12-18 22:54:49 -08:00
Joe Bryan
1657c548cc
Merge branch 'master' into next/arvo
...
* master:
[nix] track nixos-21.11 branch whenever niv updates, bump to include qemu-in-virtualization fix
webterm: v1.0.0
herm: permission checks
herm: avoid trailing empty path segments
pmnsh: update secp256k1 configure flags
secp256k1: use nixpkgs provided secp256k1 and add to sources-pmnsh
webterm: remove border, let term live in page
theme: cleaning up a few mismatches
webterm: handle old-style blits and belts
build: correct lmdb static builds
build: explicitly override h2o build platforms to support darwin
ci: upgrade cachix/install-nix-action from v13 -> v16
build: remove haskell related nix code and haskell.nix dependency
webterm: update imports
@urbit/api: move term types
webterm: fix broken imports
webterm: update package name for lerna
webterm: commit missing api files
webterm: backport
2021-12-17 23:39:04 -05:00
Joe Bryan
663934b5cf
Merge pull request #5478 from urbit/bh/remove-haskell-nix
...
build: remove urbit-king haskell releases and haskell.nix dependency
2021-12-17 20:36:21 -08:00
fang
970075bbcd
helm, docket: bind /who endpoint in helm instead
...
This seems like a better place.
2021-12-17 00:42:57 +01:00
Joe Bryan
e8cdafddfc
arvo: refactor |mass output, make vane /whey peek optional
2021-12-16 12:21:21 -05:00
Joe Bryan
32e1ed0a15
arvo: fix type typo (s/mein/mien/g)
2021-12-16 12:15:48 -05:00
yosoyubik
1bda134280
azimuth: update /app/azimuth snapshot
2021-12-15 08:31:26 +01:00
fang
81f1d816e0
docket: bind /who.json
2021-12-14 22:42:42 +01:00
Yaseen
077c23b9e7
story: add generator |story-init
2021-12-14 14:31:38 -05:00
Yaseen
2626c32085
story: let |story-set take a case and make it optional
2021-12-14 14:31:09 -05:00
fang
dd6b090bfa
Merge pull request #5454 from urbit/m/backport-nu-webterm
...
webterm: backport
2021-12-14 19:23:23 +01:00
fang
960f2b1ae2
webterm: v1.0.0
2021-12-14 17:17:32 +01:00
yosoyubik
5d4a410653
roller: don't set :frequency timer on commit
2021-12-14 16:39:22 +01:00
yosoyubik
d0309abfd8
roller: get suggested gas price only for mainnet
2021-12-14 15:44:43 +01:00
yosoyubik
1b278ce104
dice: dont print %failed logs in tx-effects
2021-12-14 15:27:44 +01:00
yosoyubik
fc540bf209
roller: handle sending malformed batches
2021-12-14 15:24:25 +01:00
Liam Fitzgerald
e8ba3b5f73
metadata-push-hook: address mark review
2021-12-14 08:50:57 -05:00
yosoyubik
d1a04c7c54
Merge branch 'naive/snapshot' into roller/gas-price
2021-12-14 09:41:22 +01:00
yosoyubik
4724c32d3d
pill: load azimuth snapshot file with mime mark
2021-12-14 09:40:34 +01:00
yosoyubik
0c7ada2076
roller: fix response parsing from gasoracle
2021-12-13 19:16:47 +01:00
Liam Fitzgerald
bfaec1daab
interface: address hunter review
2021-12-13 10:23:37 -05:00
Liam Fitzgerald
7252c7c1da
interface: fix unreads not clearing chats
...
Fixes urbit/landscape#761
2021-12-13 08:44:29 -05:00
Liam Fitzgerald
740d9b796e
interface: inset by safe-area on iOS
...
Fixes urbit/landscape#242
2021-12-13 08:25:59 -05:00
fang
fd375c1d90
herm: permission checks
...
Make sure herm can only be interacted with by the local ship.
2021-12-13 14:25:14 +01:00
fang
c7c601c041
herm: avoid trailing empty path segments
...
append /view to the existing subscription paths to "wrap" the possibly
empty path segment of the session name.
2021-12-13 14:24:20 +01:00
Liam Fitzgerald
917b53b374
interface: add disable spellcheck setting
...
Fixes urbit/landscape#79
2021-12-13 08:18:38 -05:00
Liam Fitzgerald
dc305371bc
interface: strip apps from landscape omnibox
...
Fixes urbit/landscape#1295
2021-12-13 08:02:14 -05:00
Liam Fitzgerald
0e847ec53c
landscape: do not show cross-desk notifications
2021-12-13 07:52:41 -05:00
Liam Fitzgerald
167718bd8e
interface: prevent hook crash in publish notes
...
Fixes urbit/landscape#1299
Fixes urbit/landscape#1343
2021-12-13 07:45:25 -05:00
Liam Fitzgerald
28ace88bd9
interface: remove My Channels link from GroupSwitcher
...
Fixes urbit/landscape#1331
2021-12-13 07:39:08 -05:00
Liam Fitzgerald
418ad3736d
-group-leave: cleanup seperation of concerns between groups, metadata, graphs
2021-12-13 06:29:00 -05:00
Liam Fitzgerald
6a6af5edc4
metadata-pull-hook: fix limb expression in on-pull-nack
2021-12-13 06:26:44 -05:00
Liam Fitzgerald
224353364a
metadata-push-hook: watch group-store for permission revocation
2021-12-13 06:26:07 -05:00
Liam Fitzgerald
e1138e1684
push-hook: fix %revoke action for versioned subscriptions
2021-12-13 06:23:03 -05:00
Liam Fitzgerald
fd4844bf9f
pull-hook: fix swapped argument preventing cards being sent
2021-12-13 06:19:00 -05:00
Liam Fitzgerald
722b19066e
landscape: defer removing metadata until on-leave thread
...
Addresses graphs not being archived correctly, and causing spurious
notifications
2021-12-13 04:37:08 -05:00
yosoyubik
92c498cd04
Merge branch 'naive/snapshot' into roller/gas-price
2021-12-10 18:42:55 +01:00
yosoyubik
8601b13e3f
azimuth: remove unused import in snapshot mark
2021-12-10 16:59:30 +01:00
yosoyubik
f6dca03786
pill: restore solid pill
2021-12-10 16:19:59 +01:00
yosoyubik
fd2ff95989
roller: fix refuel generator
2021-12-10 13:13:14 +01:00
yosoyubik
f6ff4f108b
roller: add utilities for handling low-gas batches
...
This adds support for handling cases where the send-batch thread failed,
mainly among them, a thread crash. One of the events that causes this
behavior is a ver low gas price for this L1 transaction.
Here we add support for manually bumping the price for such transaction,
and for increasing the default fallback gas-price, together with discarding
any malformed batch from the sending queue.
2021-12-10 11:36:45 +01:00
Jōshin
d94aa5704b
Merge branch 'master' into next/arvo
...
Conflicts:
pkg/arvo/lib/azimuth.hoon
This file was turned into a symlink to pkg/base-dev/lib/azimuth.hoon on
one side of the fork, and meanwhile edited on the other side of the fork
(to update ecliptic to the new address for the WSTR fix.)
The two sides of the fork both had different outdated addresses in
base-dev's azimuth.hoon file, and Git's UI helpfully refilled the
contents of arvo's azimuth.hoon so that it showed a merge conflict with
an empty diff.
Resolved by reading out HEAD:pkg/arvo/lib/azimuth.hoon into
pkg/base-dev/lib/azimuth.hoon and manually recreating the symlink.
2021-12-10 08:24:32 +00:00
Liam Fitzgerald
6de9dbdd3f
landscape: better leap searching
...
Allows categories to reorder. Improves searching algorithm to order by
strength of match
2021-12-09 16:49:43 -05:00
Mackenzie Davidson
8d4b325477
landscape - safari theme-color prefers-color-scheme dark + fallbacks
2021-12-09 10:50:38 -05:00
Mackenzie Davidson
809f8f7159
safari theme-color fallbacks
2021-12-09 10:33:32 -05:00
Mackenzie Davidson
280e4da513
safari theme-color prefers-color-scheme dark
2021-12-09 10:31:42 -05:00
yosoyubik
c467d5aa67
Merge branch 'roller/quota-left' into naive/snapshot
2021-12-09 07:45:18 +01:00
yosoyubik
ae05bbf571
roller: don't crash if nonce not in queue
2021-12-09 07:44:53 +01:00
yosoyubik
4384f19643
azimuth: use ship as prefix for loading snapshot log
2021-12-09 07:30:08 +01:00
yosoyubik
fb2c078fde
pill: load azimuth snapshot as mime in file-ovum
2021-12-09 07:28:57 +01:00
fang
b20abb8841
webterm: remove border, let term live in page
...
This also helps conceal some xterm resizing inaccuracies.
2021-12-09 00:36:50 +01:00
Hunter Miller
3ee9132416
theme: cleaning up a few mismatches
2021-12-08 17:00:25 -06:00
Liam Fitzgerald
ac2337a6a7
landscape: bump version, glob
2021-12-08 16:46:59 -05:00
Liam Fitzgerald
0979b8fc39
interface: hide invite if already joined
2021-12-08 15:24:32 -05:00
Liam Fitzgerald
b8da026c5e
Merge branch 'next/groups'
2021-12-08 13:42:49 -05:00
fang
81a45608a0
webterm: handle old-style blits and belts
...
Additions and changes easily distinguishable for extermination once the
new backend lands.
2021-12-08 17:12:38 +01:00
fang
35e820bfe6
Merge branch 'next/arvo' into m/shoe-scry
2021-12-08 13:13:54 +01:00
yosoyubik
cce14699c8
azimuth: update log message
2021-12-08 12:52:23 +01:00
yosoyubik
37adba1ba0
various: update to new udiff:point type
2021-12-08 11:23:35 +01:00
yosoyubik
1e912d1ec4
Merge branch 'roller/quota-left' into naive/snapshot
2021-12-08 11:02:23 +01:00
yosoyubik
463ca6e8db
roller: set default quota to 25
2021-12-08 11:02:05 +01:00
Brendan Hay
16379db9b0
build: remove haskell related nix code and haskell.nix dependency
...
* Upgrades the nixpkgs pin to 21.11.
* Removes nix code, sources, and attributes related to haskell.nix and
the code under pkg/hs.
* Continuous integration no longer builds (or packages/releases)
urbit-king (haskell).
* To continue to developing any haskell code under pkg/hs it's left as
a user exercise uto install and configure GHC/Stack.
As a consequence running nix-shell should be considerably more
performant and requires downloading or building less dependencies.
2021-12-08 10:06:42 +01:00
Philip Monk
5c20b63a5a
Merge pull request #5412 from urbit/jb/safer-dojo
...
dojo: improve safety of mark conversion
2021-12-07 20:20:53 -08:00
Philip Monk
1ffdad8719
Merge pull request #5439 from ynx0/dev-fixes
...
meta: fix various issues in file tree for development
2021-12-07 19:07:34 -08:00
Philip Monk
7583d33cf1
Merge pull request #5436 from urbit/m/claz-lockup-txs
...
claz: better linear lockup ops support
2021-12-07 18:41:55 -08:00
yosoyubik
28dacad857
Merge branch 'roller/quota-left' into naive/snapshot
2021-12-07 17:48:30 +01:00
yosoyubik
33852ea90e
roller: support private keys with leading 0x
2021-12-07 17:47:56 +01:00
Liam Fitzgerald
1893ffd651
landscape: update glob
2021-12-07 11:23:50 -05:00
Liam Fitzgerald
ba9cfd8e92
interface: do not redirect to joined group automatically
2021-12-07 11:04:36 -05:00
Liam Fitzgerald
119805fd04
interface: hide aborted requests
2021-12-07 11:02:23 -05:00
yosoyubik
0833ee9ea6
azimuth: only print number of points during init
2021-12-07 16:32:39 +01:00
yosoyubik
81eb6ae247
pill: add azimuth snapshot
2021-12-07 16:13:39 +01:00
Liam Fitzgerald
d58666d4c7
invite-store: change /all scry to return %invite-update
2021-12-06 15:28:26 -05:00
Liam Fitzgerald
8be81d7dc5
Merge pull request #5469 from urbit/hm/group-join-fixes
...
interface: minor group join fixes
2021-12-06 14:34:35 -05:00
Liam Fitzgerald
641cf79894
interface: fix tsc
2021-12-06 14:16:17 -05:00
Liam Fitzgerald
9de35cfd70
webterm: update imports
2021-12-06 10:05:54 -05:00
Liam Fitzgerald
cbc1b910fd
@urbit/api: move term types
2021-12-06 10:05:36 -05:00
Liam Fitzgerald
3fa572b53a
webterm: fix broken imports
2021-12-06 10:05:14 -05:00
Liam Fitzgerald
3b3564cae9
webterm: update package name for lerna
2021-12-06 10:04:36 -05:00
Liam Fitzgerald
97f334e819
interface: address hunter review
2021-12-06 09:38:20 -05:00
Liam Fitzgerald
4dbf4a9e9f
Merge pull request #5472 from urbit/jo/graph-store-mark
...
landscape: correct mark
2021-12-06 09:36:15 -05:00
fang
3df0efd7c6
Merge pull request #5473 from urbit/m/base-atom
...
pkg: include atom mark in base-dev
2021-12-06 15:11:12 +01:00
yosoyubik
d08ab43f3a
lull: skip rift/life printf when booting
2021-12-06 13:47:59 +01:00
fang
4bff1df7e8
pkg: include atom mark in base-dev
2021-12-05 14:50:50 +01:00
Jōshin
ffc2d8f0b9
landscape: correct mark
...
This was crashing before due to a `[%no-cast-from %graph-update-3 %graph-update]`. With this change it produces output.
2021-12-04 20:55:15 -08:00
Hunter Miller
9e3ed16c76
Merge branch 'master' into next/landscape
2021-12-03 16:44:51 -06:00
Liam Fitzgerald
04d88ae5e7
interface: refine spacing
2021-12-03 15:16:50 -05:00
Liam Fitzgerald
dff232816d
interface: fix invite notifications
2021-12-03 15:16:13 -05:00
Liam Fitzgerald
413b4b8c9f
landscape: add invite declination
2021-12-03 14:42:39 -05:00
Liam Fitzgerald
e655b84f10
landscape: prevent reflow jank in group summary on load
2021-12-03 12:39:46 -05:00
Liam Fitzgerald
f863a83d4c
interface: fix unjoined graph permalink redirect
2021-12-03 12:39:24 -05:00
yosoyubik
ad16155c77
azimuth: load azimuth state from state snapshot
2021-12-03 16:11:15 +01:00
Hunter Miller
87337d0e7a
join: automatically join when done
2021-12-02 17:06:42 -06:00
fang
2c71a5d79d
azimuth: update ecliptic address
...
To account for the recent upgrade.
2021-12-02 21:45:39 +01:00
Liam Fitzgerald
fe84339747
landscape: update glob, version
2021-12-02 14:07:41 -05:00
Liam Fitzgerald
0af4d998c1
Merge pull request #5449 from urbit/lf/group-view-refactor
...
groups: refactor joining process
2021-12-02 12:09:09 -05:00
Liam Fitzgerald
9658d45dac
Merge pull request #5461 from urbit/lf/revive-notify
...
notify: upgrade for new hark-store, miscellaneous improvements
2021-12-02 12:08:26 -05:00
Liam Fitzgerald
f68c4db4d2
notify: address mark review
2021-12-02 10:19:22 -05:00
Liam Fitzgerald
12cc826a38
Merge pull request #5462 from urbit/lf/fix-moon-invites
...
invite-hook: use equality instead of team:title
2021-12-02 09:06:01 -05:00
fang
fa2afa3c10
webterm: commit missing api files
2021-12-02 14:24:28 +01:00
Liam Fitzgerald
77d0071315
Merge pull request #5465 from urbit/ixv/publish-url-fix
2021-12-02 08:24:16 -05:00
ixv
0b678949e1
interface: fix publish url preprocessing
2021-12-01 15:48:41 -08:00
Yaseen
1d111db103
story: rename generator |story-add to |story-set
2021-12-01 11:45:11 -05:00
Hunter Miller
41b17ce7be
Merge pull request #5463 from urbit/hm/color-changer-fix
...
groups: fixing color input
2021-11-30 21:17:56 -06:00
Hunter Miller
98496c1bfd
bg-color: changing to always store ux, optimizing displayform and colorinput
2021-11-30 16:59:16 -06:00
Hunter Miller
39b4749b65
api: handling 000000 hexToUX
2021-11-30 16:56:49 -06:00
Liam Fitzgerald
eb4cce0da7
invite-hook: use equality instead of team:title
...
Fixes a bug that prevented moons from being invited
2021-11-30 16:19:24 -05:00
Liam Fitzgerald
c6a68ced13
notify: prevent memory leak, cleanup notifications when dismissed
2021-11-30 13:41:51 -05:00
Liam Fitzgerald
4c47bc3ba0
notify: rework subscription wires and rewatch
2021-11-30 13:05:59 -05:00
Liam Fitzgerald
1f0465c1d6
notify: update for new hark-store
2021-11-30 11:31:46 -05:00
Liam Fitzgerald
accba6a3ea
landscape: add %hark-note mark
2021-11-30 11:25:48 -05:00
Liam Fitzgerald
5f52ec9ad6
garden: move /+ hark-store into -dev
2021-11-30 11:25:30 -05:00
yosoyubik
d5c44598ba
roller: refactor and clean up
2021-11-28 16:37:06 +01:00
h5gq3
c742b58426
improve de-xml parser
...
de-xml parser fails when xml content node contains doublequotes (`doq` rule), this PR proposes to remove this restriction as high-level javascript APIs that operate on DOM don't entitize/encode doublequotes by default.
2021-11-28 12:34:10 +02:00
Yaseen
7add802ab9
story: add generator |story-remove
2021-11-26 20:53:52 -05:00
Yaseen
78468dc8ee
story: add generator |story-add
2021-11-26 20:53:20 -05:00
Yaseen
808e6ce763
story: add generator +story-list
2021-11-25 17:02:29 -05:00
yosoyubik
8c8aef96aa
dice: include nas when rolling over tx-effects
2021-11-25 21:22:15 +01:00
Yaseen
163ed030d4
clay: add new %s scry which gives the tako for a given beak
2021-11-25 12:48:24 -05:00
Yaseen
6982735650
story: make sure terminating newline is present in text encoding
2021-11-25 11:38:06 -05:00
