Jared Tobin
65cad93b1b
Merge branch 'liam-fitzgerald/lf/chat-input-line-height' ( #2743 )
...
* liam-fitzgerald/lf/chat-input-line-height:
chat-js: adjust line height in chat input
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-15 20:18:14 +04:00
Jared Tobin
e6eaae43c4
Merge branch 'liam-fitzgerald/lf/code-links-dark-mode' ( #2741 )
...
* liam-fitzgerald/lf/code-links-dark-mode:
publish: increase legibility for code in dark mode
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-15 20:17:58 +04:00
Fang
084ce356a8
chat-hook: on %remove, try our best to pull subs
...
Previously, we were removing the relevant entry from the `synced` map
before calling `+pull-wire`, which requires an entry to still be there.
This lead to subscriptions not actually being pulled, commonly leading
to "subscribe wire not unique" errors on re-join.
In addition to fixing that, `%remove` actions now try to pull the
subscription regardless of whether they have an entry in the `synced`
map or not. `%leave` is always safe, and we might want to clean up
subscriptions that shouldn't be there anymore in the first place.
2020-04-15 16:29:26 +02:00
Liam Fitzgerald
8b48f3fa0f
chat-js: adjust line height in chat input
...
Set the line height of the input to be the same as a sent message.
Additionally fixes an issue that would cause unnecessary scrollbars to
be shown.
2020-04-15 15:08:42 +10:00
Liam Fitzgerald
536e3121b6
link-js: fix pages disappearing on small screens
...
The rightPanelHide prop was being improperly set on the home, settings
and members screens, causing them to be blank on small screen sizes
Fixes #2727
2020-04-15 14:27:29 +10:00
Liam Fitzgerald
50dca97b07
publish: increase legibility for code in dark mode
...
Makes the rules that set both a background and foreground color come
last in the CSS, increasing their specificity. Changes the highlight to a
lighter grey, to better stand out. Correctly aligns highlights with code
block backgrounds.
Fixes #2684
2020-04-15 13:45:22 +10:00
Liam Fitzgerald
ba18737b5e
chat-fe: move cancel button below comment edit
2020-04-15 10:59:56 +10:00
Liam Fitzgerald
963d04831d
Merge branch 'master' into lf/publish-del-edit
2020-04-15 10:07:29 +10:00
Liam Fitzgerald
595acd17ff
publish-js: lift editing state to comment list
2020-04-15 09:57:43 +10:00
Liam Fitzgerald
c46642af8d
publish: fix check on edit-comment delta
...
An incorrect check caused comment editing to never be propagated.
2020-04-15 09:57:07 +10:00
ixv
b978d4f824
Merge pull request #2736 from urbit/ixv/fix-comment-grow
...
publish: fix bug in comment mark
2020-04-14 15:53:26 -07:00
ixv
5bb9776b70
Merge pull request #2730 from liam-fitzgerald/lf/chat-synced-fix
...
chat-fe: resubscribe message iff chatSynced is populated
2020-04-14 11:40:45 -07:00
ixv
e5cf4fb813
Merge pull request #2720 from urbit/la-channel-err
...
channel.js: added way to handle event source errors more smoothly, and implemented in chat
2020-04-14 11:40:02 -07:00
Isaac Visintainer
113c86037c
publish: fix bug in comment mark
2020-04-14 11:23:06 -07:00
Fang
7b5f7cde6b
link-listen-hook: partially revert 05e6519
...
We still want to auto-opt-in to new collections for _unmanaged groups_,
because we have no other way to join them.
2020-04-14 16:12:09 +02:00
Liam Fitzgerald
a3fed45af1
publish-js: avoid unnecessary scrollbars on note view
...
the root container had height: 100% but also a margin-top set on it. This
caused unnecessary scrollbars to appear when the content did not
actually overflow the container.
2020-04-14 20:38:35 +10:00
Liam Fitzgerald
d63cc0d7de
publish-js: allow deletion and editing of comments
...
Adds interface affordances for the addition and removal of comments.
2020-04-14 20:20:59 +10:00
Liam Fitzgerald
fa92d1cb7f
publish: use @tas for comment ref in marks
...
Comment references in publish actions are @tas of a rendered @da. The
mark expected @da, causing a mismatch.
2020-04-14 20:15:57 +10:00
Liam Fitzgerald
9ddf06d2a1
chat-fe: correct FF scroll behaviour
...
Firefox treats the reflow in the scroll container weirdly so for the
scrollback case, we save the position to restore later, when the backlog
messages come in. For the 'locked at bottom' case we add a new state
variable and rescroll based on that.
2020-04-14 16:34:10 +10:00
Isaac Visintainer
d8cdbfdeb8
release: urbit-os-v1.0.13
2020-04-13 19:26:13 -07:00
ixv
2c56937f0d
Merge pull request #2701 from lukechampine/syntax-error-src
...
ford: print source line on syntax error
2020-04-13 19:03:05 -07:00
Liam Fitzgerald
786f2518e7
chat-fe: resubscribe message iff chatSynced is populated
...
Previously, if a room was navigated to directly, the resubscribe message
would show before the chatSynced state was loaded. Initialises
chatSynced as null and checks it is not null before showing the
resubscribe message.
2020-04-14 11:41:38 +10:00
Matilde Park
a4d37c0313
Merge branch 'master' into mp/chat/firefox-take-2
2020-04-13 21:38:27 -04:00
ixv
a7f20c37c1
Merge pull request #2700 from liam-fitzgerald/lf/invite-search-short
...
invite-search: handle suggestions for short searches
2020-04-13 16:56:26 -07:00
ixv
2d30886b65
Merge pull request #2724 from urbit/ixv/install-mousetrap
...
publish: install mousetrap before we use it....
2020-04-13 16:55:40 -07:00
ixv
228bee42e4
Merge pull request #2707 from urbit/ixv/cache-posts
...
publish: eagerly store your own changes
2020-04-13 16:54:41 -07:00
ixv
3526cfa4e6
Merge pull request #2618 from urbit/chat-reverse-messages
...
chat: reversed order that messages are stored in for faster performance
2020-04-13 16:54:16 -07:00
Isaac Visintainer
78023b8eff
publish: ignore edit updates if they originated with us
2020-04-13 13:34:50 -07:00
Isaac Visintainer
7edcd65699
publish: add facilities for managing limbo state
2020-04-13 13:33:34 -07:00
Fang
7aebcad25b
link fe: refactor message display into component
2020-04-13 21:54:50 +02:00
Fang
0d73b391b4
link fe: more informative "empty list" display
...
Displays "Loading..." if the links haven't loaded yet. If there are no
links, tells the user they can save one.
2020-04-13 21:37:42 +02:00
Fang
4da0d636d3
link-view: in pagination logic, only +lent once
...
Also just use +swag instead of chaining +scag and +slag manually.
2020-04-13 21:26:44 +02:00
Fang
8f3d174c94
link: minimal initial view result
...
On initial load, instead of getting the first 25 links for every
collection, only get their totals and unread counts. This drastically
reduces the pageload time.
Updates the frontend to match:
- Handle initial results without link content.
- Dynamically load in collection's links, even for page 0.
2020-04-13 21:26:09 +02:00
Fang
bf42afbd56
link-view: add some hints to aid profiling
2020-04-13 21:15:51 +02:00
Jared Tobin
cc16e905af
Merge branch 'yosoyubik/apt-dup' ( #2417 )
...
* yosoyubik/apt-dup:
hoon: +apt:by check for duplicate keys
2020-04-13 17:43:41 +04:00
Jared Tobin
bf78e71479
Merge branch 'courajs/json-unit-tests' ( #1769 )
...
* courajs/json-unit-tests:
Change at:dejs-soft:format to reject too-long json arrays
Add unit tests for json de/serialization.
2020-04-13 16:38:42 +04:00
Isaac Visintainer
2608dea563
publish: style changes and comments
2020-04-13 00:04:33 -07:00
Isaac Visintainer
d3ab26e57c
publish: restore OS0 -> OS1 transition logic
2020-04-12 23:38:54 -07:00
Isaac Visintainer
277bc8d465
publish: make reducers able to handle duplicate updates now that we send updates both pre and post confirmation
2020-04-12 23:21:43 -07:00
Isaac Visintainer
a40d292bb7
publish: remove or add posts/comments from limbo depending on whether they succeeded or failed
2020-04-12 23:21:42 -07:00
Isaac Visintainer
d2fdae4d4b
publish: immediately store post and comment changes
2020-04-12 23:21:42 -07:00
Isaac Visintainer
f9e17e61a2
publish: update state with limbo field
2020-04-12 23:21:42 -07:00
Isaac Visintainer
20d3c4105d
publish: install mousetrap before we use it....
2020-04-12 23:05:32 -07:00
Liam Fitzgerald
e5634a913d
invite-search: always add search query if valid patp
2020-04-11 10:17:49 +10:00
Logan Allen
fb3111e88a
channel.js: added way to handle event source errors more smoothly, and implemented in chat
2020-04-10 19:38:13 -04:00
Logan Allen
98f4df14a4
chat-js: made scrollback work for new message indexing
2020-04-10 22:22:14 +00:00
Logan Allen
8ffca926e7
chat-js: reverted built files
2020-04-10 17:34:23 -04:00
Logan Allen
6d1efde884
chat-js: fixed scrollback for reverse message chatrooms
2020-04-10 17:29:23 -04:00
Matilde Park
948dbe85e7
chat: scrollToBottom on mount for FF
2020-04-10 16:55:23 -04:00
Matilde Park
a212a5dc69
Merge branch 'master' into mp/chat/firefox-take-2
2020-04-10 16:44:15 -04:00