Commit Graph

123 Commits

Author SHA1 Message Date
Philip Monk
76b917f426
dojo: add tab completion
This is initial support for type-aware tab completion.  When you hit tab, it tries to complete the word you're in the middle of using a face or arm in the subject at that point in the code.  It also shows all possible matches and their associated types.  It's nearly instantaneous.  Notes:

- It advances to the longest common prefix, so if you hit tab on `ab` and the only possible results are `abcde` and `abcdz`, then it'll write `abcd` and print both out (with their types).

- If there are fewer than ten matches, it prints the type along with the face.  Printing types is too slow to use all the time, but with 10 it's essentially instantaneous.

- The match closest in the subject to you (i.e. smallest axis number) is displayed lowest (closest to your focus).

Examples below, where `<TAB>` represents me hitting tab while my cursor is at that position (the line with the `<TAB>` is not preserved in the actual output).

```
~zod:dojo> eth<TAB>
-----
ethereum        #t/<11.qcl {<3.ltb 27.ipf 7.ecf 36.uek 92.bjk 247.ows 51.mvt 126.xjf 41.mac 1.ane $141> <21.yeb 27.ipf 7.ecf 36.uek 92.bjk 247.ows 51.mvt 126.xjf 41.mac 1.ane $141>}>
ethereum-types  #t/<3.ltb 27.ipf 7.ecf 36.uek 92.bjk 247.ows 51.mvt 126.xjf 41.mac 1.ane $141>
~zod:dojo> ethereum
~zod:dojo> |=  zong=@ud  z<TAB>
-----
zing  #t/<1.dqs {* <126.xjf 41.mac 1.ane $141>}>
zap   #t/<1.iot {tub/{p/{p/@ud q/@ud} q/""} <1.rff {daf/@t <247.ows 51.mvt 126.xjf 41.mac 1.ane $141>}>}>
zuse  #t/$309
zong  #t/@ud
~zod:dojo> |=  zong=@ud  zo<TAB>
-----
zong  #t/@ud
~zod:dojo> |=  zong=@ud  zong
~zod:dojo> <TAB>
hoon-version
trel
quip
pole
unit
qual
lone
... about 600 more lines ...
unity
html
zuse
eny
now
our
~zod:dojo>
```

Functionally, this is in a state where I'd be comfortable shipping it.  It doesn't interfere with anything if you don't press tab, and it's perfectly OTA-able.  I do think its output is a little verbose, but that can be tuned over time as people try it and determine what feels good in practice.

Additional notes:

- There are plenty of similar systems for other languages, but my most direct inspiration is Idris's editor tools.  This is implemented for the dojo, but I actually want it in my editor, which is why the meat is all defind in a library.  I've only tested on dojo one-liners, so I don't know the performance on large blocks of code.

- The default type printer isn't great for this use case.  In particular,
	- Cores should not print anything about their context
  - The `#t/` should go away
  - If it looks like a gate, we should print its return value
  - Maybe special handling for molds, but if the above is done, then for example `bone` is  `* -> @ud`.

- The worst part about our wing ordering is that it really screws up tab completion.  You want to do `point.owner-address` instead of `owner-address.point` because that lets you type `point.ow<TAB>`.  I weakly prefer reading it how we do it now, but it's really not great.  You could do an (dojo-specific?) alternate syntax of `point;owner-address`; this is a simple transformation.

- Regardless of the above, this should handle the case where we're in the middle of defining a wing; it doesn't right now.

- When a variable is shadowed, we show both of them.  We should probably show the shadowed one with a `^`.

- We probably shouldn't print out hundreds of results.  Maybe just the closest 50 with ellipses.

- This gets you any face in your subject, regardless of whether its type is reasonable.  We could limit that some by copying the `gol` logic in mint, so that if the pseudo-backward-inference engine happens to know what type it should be, you can filter the tab results according to if they nest in that type.  This would be "strongly type-aware".
2019-10-30 23:19:25 -07:00
Fang
544d636701
chat-cli: minor code style fixes 2019-10-23 20:40:58 +02:00
Fang
10b2643a50
chat-cli: update prompt on ;join
Fixes #1841.
2019-10-18 15:04:34 +02:00
Logan Allen
b12e305c9c apps: added permission hook and chat-view %join action 2019-10-11 14:09:30 -07:00
Fang
4e963ff23a
chat-cli: maintain sane glyph binding state
This ensures that `binds` is updated to match overwrites in `bounds`.
2019-10-10 23:49:36 +02:00
Fang
31b7331e1e
chat-cli: support per-target glyph unbinding 2019-10-10 23:40:08 +02:00
Fang
e01d59ae4c
chat-cli: properly decode double-bound glyphs
Resolves glyph to most recently seen target.
2019-10-10 22:40:37 +02:00
Fang
cf24f4a80e
chat-cli: try not to double-bind glyphs
Try to use the default glyph.
If that is already in use, random available glyph.
If there's none available, the default glyph.
2019-10-10 22:38:36 +02:00
Fang
86f37ede6c
chat-cli: Remove prep printf 2019-10-09 15:04:51 +02:00
Fang
4dea1068b2
chat-cli: Add clarity 2019-10-09 00:06:39 +02:00
Fang
24859907aa
chat-cli: Cosmetic improvements
Better variable naming. Trailing newline.
2019-10-08 23:00:46 +02:00
Fang
0da8e1efb3
chat-cli: Properly support deleting local chats
Since the current implementation of ;leave is silently destroying state
instead of unsubscribing, we disallow running ;leave on local chats and
provide an explicit ;delete instead.
2019-10-08 22:28:56 +02:00
Fang
42aa035530
chat-cli: Subscribe to /updates instead of /all
On first boot (and debug poke) we scry for /all to ensure we know all
messages.
2019-10-08 22:06:45 +02:00
Fang
9532857ef5
chat: Move eval logic into lib 2019-10-08 22:06:28 +02:00
Fang
c7fbad61ee
chat-cli: Simplify message command type & logic
By dropping support for •-separated multi-messaging, we can simplify
the parsing and handling of message sending inputs.
2019-10-08 20:01:46 +02:00
Fang
dac51a9ed8
chat-cli: Implement permission management
Set security type during ;create. Use ;invite and ;banish to dis/allow
ships from reading and/or writing.

Talks to the group-store to modify permission groups. Scries into
permission-store to check for white- vs blacklist.
2019-10-08 20:01:21 +02:00
Fang
9c562f4c62
chat-cli: Match store and hook's path handling
Now prefixes the host ship to the path, and parses it back out, only
when appropriate.
2019-10-08 16:18:20 +02:00
Fang
10b17ff127
chat-cli: Update prompt on-create
Creating a mailbox would refresh the prompt before setting a new
audience, instead of after. This change corrects the behavior.

Also updates glyph binding code and print style.
2019-10-08 16:15:19 +02:00
Fang
12050d44a8
chat-cli: Add debug poke for connecting to store 2019-10-07 20:46:35 +02:00
Fang
03b5a1cd71
chat-cli: Support %url and %me message types 2019-10-07 20:45:58 +02:00
Fang
c0d07fa14a
chat-cli: Clean up code
Renames, refactors, and occasionally rewrites many of the arms used
within the application. Splits +sh into +sh-in and +sh-out, improves
naming for rendering cores, moves arms around for better organization,
and adds descriptions to all arms.
2019-10-07 16:31:10 +02:00
Fang
7911061dab
chat-cli: Make more fully-featured
Brings it largely up to parity with Talk, save for features relating to:
- presence & nicknames
- circle management (permissions, sources)
- deprecated message types

In addition to implementing remaining functionality for basic usage
patterns, makes the following changes:
- glyphs per target, not multiple targets
- assume /~ship/path paths are created/used by the chat-hook

Code cleanup pending.
2019-10-07 16:09:22 +02:00
Fang
07454e2327
apps: Add WIP chat-cli 2019-10-07 16:09:14 +02:00