Commit Graph

44 Commits

Author SHA1 Message Date
Fang
9a29e72560
link fe: prefix ship names in comments with sig 2020-02-11 17:41:32 +01:00
Fang
8d7d1af3aa
link fe: rename members -> contacts and refactor
Renames the somewhat ambiguous "members" property into "contacts", to
more clearly indicate the source/nature of the data within. (Avoid
confusion with "members of a group", which is contained in groups
instead.)

Also refactors the retrieving of appropriately-defaulted contact values
into a utility function.
2020-02-11 17:39:03 +01:00
Fang
e801316368
link fe: display correct member counts
We were passing in a contacts object, which may not always contain all
group members. We now pass in a groups object (set of ships) instead,
and derive contributor count from that.
2020-02-11 17:17:33 +01:00
Fang
94feb5bf2e
link fe: ensure item and page counts
Getting updates for things we hadn't gotten initial data on would leave
us without any counters. This defaults them to zero, if we don't have
any yet.
2020-02-11 16:50:42 +01:00
Fang
5caf5fa00d
link fe: display unread counts for public channels
Was previously only displaying for the private channel.
2020-02-11 16:47:00 +01:00
Fang
5eab689d0a
Merge pull request #2259 from urbit/m/link-unreader
link: unread counters in sidebar
2020-02-10 20:53:07 +01:00
Fang
9c9b1fcaec
link fe: display unseen link counts in sidebar 2020-02-10 20:52:47 +01:00
Fang
789d9719a4
Merge pull request #2246 from urbit/mp/os1/link-previews
links: link previews for images and youtube
2020-02-08 00:22:35 +01:00
Fang
7a5b79b020
link fe: ensure we don't visually truncate titles 2020-02-08 00:21:49 +01:00
Fang
8fee37be56
link fe: indicate unseen status on links 2020-02-07 23:11:13 +01:00
Fang
475bbe0d39
link fe: make image previews clickable 2020-02-07 22:57:41 +01:00
Fang
0abbac2457
link fe: fix image preview sizing
Image should retain its own width if it's smaller than the bound, but
not go beyond them.

Height bounding wasn't being inherited properly through the "100%", so
we're moving the max-height into the embed itself instead.
(Making its container div always contain it rather than overflow also
prevents bleeding the preview down the page in case of sizing error.)
2020-02-07 22:30:13 +01:00
Fang
fec2f51273
link fe: pass time into detail head instead of all data 2020-02-07 22:16:08 +01:00
Matilde Park
f4faef2b6c link: link previews for images and youtube 2020-02-06 20:48:30 -05:00
Matilde Park
112326a939 link: front matter to preview component, imgs 2020-02-06 20:35:47 -05:00
Matilde Park
83a7e45e74 link: add "groupPath" to link-submit.js 2020-02-06 19:42:26 -05:00
Fang
5443a3ec7b
link fe: be consistent about groupPath (vs path)
Prefer "groupPath" name over just "path" consistently to avoid
ambiguity.
2020-02-07 01:07:36 +01:00
Fang
e5337c99c7
link fe: use base64url for encoding URLs
base64 is not actually url-safe, since it includes / (and +). This
includes a simple hand-rolled base64url implementation, and uses that
instead.
2020-02-07 00:18:52 +01:00
Fang
b0759ad8bc
link fe: move @ta encoding into lib 2020-02-07 00:14:54 +01:00
Fang
1490e415c4
Merge branch 'os1-rc' into m/link-fe 2020-02-06 21:38:11 +01:00
Fang
ea70307f29
link fe: copy in contact-update reducer 2020-02-06 21:33:18 +01:00
Fang
f6bbd98200
link fe: make popout links match new route path style
These really should be made based on the current route path instead of
manually reconstructed, but that's slightly less trivial.
2020-02-06 21:22:16 +01:00
Fang
06a33929b4
link fe: consistently use "linkIndex"
As opposed to sometimes using just "link", when referring to literal
index numbers.
2020-02-06 20:38:53 +01:00
Fang
e6fc59f3df
link fe: ensure LinkDetails always uses sane timestamp 2020-02-06 20:37:52 +01:00
Fang
d9f0d44e0c
link fe: make check less confusing
The only thing we care about is whether or not we have (any & all) data
about the submission. Using URL here is confusing because it conflates
with the prop, and checking the prop in the first place always gives the
same result.
2020-02-06 20:15:22 +01:00
Fang
2f1f9b9c56
link fe: remove unused link-initial logic
Also includes up-to-date index.js.
2020-02-06 17:33:34 +01:00
Fang
ecf9dacbc0
link fe: factor out "page"+i indexing, use plain numbers 2020-02-06 17:31:13 +01:00
Fang
2b4667eb86
link fe: fix page loading behavior
Previously, receiving new items could "locally create" pages,
half-filled with whatever items were pushed down into them. Frontend
would see the existence of the page and assume all was well. However,
the page may have contained more items (on the backend) than just what
we pushed down.

This adds a per-page flag, "local", to indicate such pages. When display
logic sees it's set, it will send a request for the full page,
regardless of currently available data, loading in the canonical full
page as a result.
2020-02-06 17:23:32 +01:00
Fang
438d502c89
link fe: remove unused comment loading logic
This never triggers anymore, comments loading always happens in onMount.
2020-02-06 17:06:05 +01:00
Fang
375755f106
link fe: ensure state is initialized where used 2020-02-06 16:56:04 +01:00
Fang
9b9692e7f1
link fe: fully account for the "number as string" case
The Number() usage is sane, but should be scoped around the variable by
itself. Previously a string of "3" would lead to a Number("31") call,
which is not the intended behavior here.

Also stops passing a {} in if the actual number is unknown.
2020-02-06 16:55:32 +01:00
Fang
e74ec92c4c
link fe: more correct totals updating logic 2020-02-06 16:52:40 +01:00
Fang
50695fe78a
link fe: use correct time attribute 2020-02-06 15:32:14 +01:00
Fang
182d2c3a07
link fe: refactor link-view subscriptions api 2020-02-06 15:25:07 +01:00
Fang
4222ebbfb3
link fe: always render up-to-date comment counts 2020-02-06 15:04:47 +01:00
Fang
ab21f67ba6
link: support loading individual submissions
On the frontend, updates the route path to include the (base64-encoded)
url. Uses that and the load-single functionality to support loading
directly into a submission page, which fetches just the requested
submission.

Also ensures we don't open duplicate comment subscriptions.
2020-02-06 14:50:39 +01:00
Matilde Park
21f6be96a1 launch, various: new tiles and launch (but clock) 2020-02-05 18:16:56 -05:00
Fang
3bbff696b5
link frontend: fix loading into submission page 2020-02-05 21:17:47 +01:00
Fang
e26d2537c7
link: remove trailing whitespace 2020-02-05 18:43:27 +01:00
Fang
4e4f005689
link: update frontend ui logic to match api changes
Updates the frontend display & data fetching logic to match the changes
made in e7eef19d7.
2020-02-05 18:43:20 +01:00
Fang
31b6333ef9
link: update frontend api & reducer functions for link-view
Replaces .json requests with channel.js subscriptions. Rewrites reducers
to match, now being more careful about paginated data, and storing
comments in their own structure, at [group][url] indices, rather than
the non-static [page][index] ones used previously.

Note that this requires some changes to the frontend UI code also.
See next commit.
2020-02-05 18:20:50 +01:00
Matilde Park
fb9c775649 links: amend reducer to add new comments locally 2020-02-03 17:52:39 -05:00
Matilde Park
22f1a52e08 link: amend "channels" copy on landing
It should be "collections," as per OS1 discussions.
2020-01-22 22:20:14 -05:00
Matilde Park
d3f57fbf9d interface: add links FE source code 2020-01-22 18:16:44 -05:00