@ixv recently uncovered a bug (#2180) in Ford that caused certain
rebuilds to crash. @Fang- and I believe this change should fix the bug,
and we have confirmed that the reproduction that used to fail about two
thirds of the time now has not failed at all in the ten or so times
we've run it since then. @Fang- is still running more tests to confirm
the fix with more certainty.
It turned out the cause was that (depending on the rebuild order, which
is unspecified and should not need to be specified), Ford could enqueue
a provisional sub-build to be run but then, later in the same +gather
call, discover that the sub-build was in fact an orphan and delete it
from builds.state accordingly. Then when Ford tried to run the
sub-build, it would have already been deleted from the state, so Ford
would crash when trying to process its result in +reduce.
The fix was to make sure that when we discover a provisional sub-build
is orphaned, dequeue it from candidate-builds and next-builds to make
sure we don't try to run it. I'm about 95% sure this fix completely
solves the bug.
* origin/mp/chat-fe-fixing:
chat: smoothen dark theme
chat: [embed] link doesn't break word on mobile
chat: youtube embeds responsively expand
chat: links use white border in dark mode
chat: sidebar switcher retains with on -m
Signed-off-by: Jared Tobin <jared@tlon.io>
It's a UI, not a word -- it should be treated like a button.
This commit preserves it as its own block and pushes it
to the next line when it's overflowing.
The declaration was being stomped out in all viewports because
it wasn't being declared in the initial element.
This adds the XL's padding-bottom to the element's declarations, which
scales it accordingly.
* origin/m/dbug:
dbug: support app state printing
dbug: augment various apps with /lib/dbug
dbug: add agent wrapper for debugging pokes
Signed-off-by: Jared Tobin <jared@tlon.io>
Uses Zuse's previously unused +harden helper function to streamline
+task unwrapping in vanes.
(Arguably, in landlocked vanes like Ford, we should crash if we get a
%soft task, since no events should be coming in directly from the
outside.)
Strictly we just want to test the upgrade path for *Arvo* in this
script. Removing the 'make install' line makes sure that we use
whatever Vere version is accessible on our PATH.
There was a typo in the routing logic that was comparing equality
against a value where it should have been doing a pattern match. The
value compared against contained the literal * gate, which would never
match route.peer-state, so this condition was always true, meaning the
fix that had added this extra condition (5406f06) did not actually
change the behavior from what it been previously.
