Using existing styling classes found in chat, I've edited the Links module to retain an appearance/sizing that is more uniform with our Chat module interfaces
This commit fixes a text and icon alignment issue noted by @matildepark. I've simply appended a class of `lh-solid` to items in module tab bars, and removed one case of v-top.
Basically, this PR includes a collection of edits made to the headers across each of our OS1 modules.
I flattened the font sizing, fixed edge margins/padding, and fixed some button copy in the case of the Contacts app.
If titles were shorter, they would still take up full-width.
I used too many "flex-autos", clearly, and this commit seems to create
the desired behaviour for both title lengths.
Renames the somewhat ambiguous "members" property into "contacts", to
more clearly indicate the source/nature of the data within. (Avoid
confusion with "members of a group", which is contained in groups
instead.)
Also refactors the retrieving of appropriately-defaulted contact values
into a utility function.
We were passing in a contacts object, which may not always contain all
group members. We now pass in a groups object (set of ships) instead,
and derive contributor count from that.
Image should retain its own width if it's smaller than the bound, but
not go beyond them.
Height bounding wasn't being inherited properly through the "100%", so
we're moving the max-height into the embed itself instead.
(Making its container div always contain it rather than overflow also
prevents bleeding the preview down the page in case of sizing error.)
The only thing we care about is whether or not we have (any & all) data
about the submission. Using URL here is confusing because it conflates
with the prop, and checking the prop in the first place always gives the
same result.
Previously, receiving new items could "locally create" pages,
half-filled with whatever items were pushed down into them. Frontend
would see the existence of the page and assume all was well. However,
the page may have contained more items (on the backend) than just what
we pushed down.
This adds a per-page flag, "local", to indicate such pages. When display
logic sees it's set, it will send a request for the full page,
regardless of currently available data, loading in the canonical full
page as a result.
The Number() usage is sane, but should be scoped around the variable by
itself. Previously a string of "3" would lead to a Number("31") call,
which is not the intended behavior here.
Also stops passing a {} in if the actual number is unknown.
