Commit Graph

4550 Commits

Author SHA1 Message Date
André Fincato
4d80c3f2cd groups: wrap bare link in list-item in p node for better typography 2022-04-30 13:03:58 +02:00
rcrdlbl
00de041625
Merge branch 'next/groups' into groups/embed-fix 2022-04-28 18:45:25 -04:00
rcrdlbl
d657dafbd9 applied patch from @arthyn 2022-04-28 18:28:28 -04:00
Patrick O'Sullivan
243ca58f88
Merge pull request #5737 from urbit/po/fix-for-iswriters-func-in-groups
Po/fix for iswriters func in groups
2022-04-28 10:11:07 -05:00
rcrdlbl
d7221f0c66 modified embed state to avoid race condition 2022-04-27 20:04:02 -04:00
David Farrell
759a579fba groups: don't double sig the planet name on copy
The copy function copies ~~zod instead of ~zod to the clipboard. This
removes the extra sig from the copy routine via deSig() incase the ship
string has no leading sig.

Fixes
[urbit/landscape#1434](https://github.com/urbit/landscape/issues/1434).
2022-04-26 21:10:01 -04:00
Patrick O'Sullivan
931040b6e3 groups: bump api version 2022-04-26 13:44:43 -05:00
rcrdlbl
d57acf1b58 useEmbed logic moved up one level 2022-04-22 10:45:39 -04:00
Hunter Miller
d26817d1e1
Merge pull request #5720 from 0x70b1a5/next/groups
Images should use -webkit-optimize-contrast.
2022-04-20 12:54:25 -05:00
Hunter Miller
2cb36bfbfb
Merge pull request #5713 from dnmfarrell/dnmfarrell/set-messages-title
groups: set the right title for messages
2022-04-20 12:50:15 -05:00
Hunter Miller
a0a0a9c2ff
Merge pull request #5728 from dillon/dp/fix-edit-profile
groups: fix edit profile
2022-04-20 12:48:09 -05:00
Hunter Miller
fd6aa680be
Merge pull request #5718 from urbit/hm/s3-v4-signatures
s3: adding v4 signatures for updated compatibility
2022-04-20 11:32:11 -05:00
Hunter Miller
1cb4268851
Merge branch 'next/groups' into next/landscape 2022-04-20 10:31:14 -05:00
André Fincato
2f7bc1e847 groups: fix blockquote to work also in notebook
previous code was assuming too much the context of the data structure.
in chat the AST works on a single node base (?), in notebook on a
multi node base.

this commit move the previous code from inside the single stitch function to
the area where the final AST is stitched together.
2022-04-19 15:16:31 +02:00
tomholford
2d3e803704 devex: improved resize behavior
- only resize when necessary (check the container's height)
- refactor CSS: use position relative / absolute to stack Buffers instead of display:none; this affects the calcuations used by fit()
- fix dark mode styles, tweak viewport height (100vh --> 99vh) to prevent overflow scroller
2022-04-19 03:41:40 -07:00
André Fincato
5634e08da5 groups: set font-size=1 to list block
this set the correct size to a list item which contains for eg only a
link child (as link child has the prop  fontSize="inherit").
2022-04-19 09:04:42 +02:00
André Fincato
db6130146b groups: avoid extra node in plain link URL
This still leaves an empty root node which does not take up visual
space though. A more comprehensive approach would be to filter out
plain URL links from the graph, eg from the function

```
t[1].children.map(c => {
    if (c?.children) {
      let links = [];
      c.children.filter(k => {
        if (k.type === 'link') {
          links.push({
            type: 'root',
            children: [
              {
                type: 'graph-url',
                url: k.url
              }
            ]
          })
        }
      })

      c.children.push(...links);
    }
  });
```
2022-04-19 09:04:19 +02:00
André Fincato
dedacabb53 groups: add graph-url block below plain URL block
this commit suggests a possible UI to put back the rich embed URL
right below (aka in context) the block where the plain URL has been
inserted. in this way when pasting a URL the formatting does not break
and yet a richer UI is still rendered.
2022-04-19 09:03:58 +02:00
André Fincato
96482ca99c groups: correctly display blockquote content in full
as of now, a blockquote would discard any other content after
a URL and would put it on a new line.

eg '> some text https://urbit.org this is urbit' would be rendered as

```
> some text https://urbit.org

this is urbit
```

this commit joins all content inside of a blockquote as one block.
2022-04-19 09:03:41 +02:00
André Fincato
0a03e44632 groups: convert URL from graph-url to plain link
this change removes rich embed URLs in order to not break text flow. eg
when writing a sentence with a URL, before this commit the UI would
display the URL as its own block on a new line, plus anything
afterwards it (originally on the same line of text), would be
displayed on a new line as well.
2022-04-19 09:02:53 +02:00
André Fincato
f03397f301 groups: don't render plain URL 2022-04-19 09:02:12 +02:00
dillon
89498e7b3a groups: fix edit profile
Adds async/await to prevent pokes from being interrupted by a premature route change in the profile  page.
2022-04-18 18:40:24 -04:00
yung calibri
c70ca0ad10 fixup! interface: tweak LinkDetail flex distribution 2022-04-18 15:37:43 -04:00
yung calibri
4481660842 interface: tweak LinkDetail flex distribution 2022-04-18 15:30:09 -04:00
yung calibri
99396e8133 interface: fix double border in LinkDetail 2022-04-18 15:01:03 -04:00
yung calibri
f0a1724d97 interface: fix LinkBlockItem border parameters 2022-04-18 14:56:42 -04:00
yung calibri
2f08d07527 fixup! interface: fix centering in LinkBlockItem summary 2022-04-18 14:52:51 -04:00
yung calibri
72efd56b0b interface: fix centering in LinkBlockItem summary 2022-04-18 14:51:27 -04:00
yung calibri
31db409674 Merge branch 'next/landscape' of https://github.com/urbit/urbit into next/landscape 2022-04-18 13:17:56 -04:00
rcrdlbl
a24bda481c fixes infinite loop in high-embed collections 2022-04-16 18:43:47 -05:00
Liam Fitzgerald
8d939a9ab9 Merge remote-tracking branch 'origin/next/vere' into lf/content-dist-rc 2022-04-15 16:07:15 -05:00
Liam Fitzgerald
2784bedb68 interface: update ChannelPermissions to use arrays
A previous change updated group state to use arrays instead of sets, due
to the ease of (de)serialisation. This was not total, and resulted in a
bug in the ChannelPermissions component
2022-04-15 14:52:49 -05:00
0x70b1a5
3c11cd3064
Images should use -webkit-optimize-contrast. 2022-04-14 13:41:24 -04:00
Hunter Miller
a68342265c s3: adding v4 signatures for updated compatibility 2022-04-14 10:23:44 -05:00
tomholford
dfded5e592 ux: refactor resize behavior
- debounced resize event listener
- new Buffer#onSelect: resize, focus, and pokes `herm` with updated rows / cols
- simplify container ref implementation (no need for a callback ref), remove isOpen hack
- add lodash for debounce
- Tab#onClick no longer handles focus (it's now handled by Buffer#onSelect)
2022-04-14 07:13:09 -07:00
tomholford
37ce741a77 deps: replace deprecated xterm#setOption
See:
https://github.com/xtermjs/xterm.js/blob/4.15.0/typings/xterm.d.ts#L1053
2022-04-14 04:52:43 -07:00
rcrdlbl
3ded98e052 removed false positive embeds 2022-04-14 05:45:39 -04:00
Liam Fitzgerald
a47d4b21d1 Merge remote-tracking branch 'origin/next/groups' 2022-04-13 16:04:55 -05:00
Patrick O'Sullivan
0e0b271cf3 groups: Fix circ. dep issue in safari, remove await in bootstrap 2022-04-13 15:40:18 -05:00
tomholford
349033fb12 ux: detect OS for hotkey instructions
Also, ensure changes from this PR are included in the session branch:
https://github.com/urbit/urbit/pull/5529
2022-04-13 08:47:30 -07:00
David Farrell
e7c42670e4 groups: fix no-case-declarations lint error 2022-04-12 20:27:07 -04:00
Hunter Miller
dcfcafb049 Merge branch 'next/groups' 2022-04-12 13:39:33 -05:00
David Farrell
fa8e800082 groups: set the right title for messages
Replaces the title "Groups" with "Messages" for Messages pane. When the
user selects a DM pane, displays the contact ship's name/nick along with
unread notifications in the title.

Fixes [urbit/landscape#1250](https://github.com/urbit/landscape/issues/1250)
2022-04-12 11:43:19 -04:00
yung calibri
b0fe7ff4eb fix the long link layout issue 2022-04-11 21:06:47 -04:00
tomholford
50d120e3c1 devex: address PR feedback
- move App#initSessions definition outside function component closure
- enhance useAddSessions performance
2022-04-11 12:05:25 -07:00
Hunter Miller
0828ae6296
Merge pull request #5704 from urbit/james/group-notifications
groups: fix join/leave notification toggle
2022-04-08 12:04:20 -05:00
Hunter Miller
a3a1b596f2
Merge pull request #5705 from urbit/james/p3-omnibus
groups: various copy and design fixes
2022-04-08 12:04:06 -05:00
James Acklin
70dcd7ab09 groups: various copy and design fixes
fixes urbit/landscape#1377
fixes urbit/landsacpe#1328
fixes urbit/landscape#1161
fixes urbit/landscape#1045
2022-04-08 11:47:55 -04:00
James Acklin
2c08d2477e groups: fix join/leave notification toggle
fixes urbit/landscape#1012
2022-04-08 10:49:10 -04:00
Patrick O'Sullivan
69062f1700 groups: use path variable for mobile toggling in groupswitcher 2022-04-07 19:39:59 -05:00
Patrick O'Sullivan
9f25f74d93 groups: show group settings menu when pressing settings cog on mobile 2022-04-07 14:25:10 -05:00
James Acklin
bb8d0c6f58 duplicate component, sorry for the messy commit 2022-04-07 10:38:10 -04:00
James Acklin
c623bc6c36 links: image thumbnail fills entire grid item
fixes urbit/landscape#1313
2022-04-07 10:35:45 -04:00
Hunter Miller
8ad3bd7068
Merge pull request #5696 from dnmfarrell/dnmfarrell/rm-share-profile-chat
interface: remove share profile chat button
2022-04-06 16:57:47 -05:00
David Farrell
4f1ebe8416 interface: remove share profile chat button
Removes the "Share private profile?" text and button that appear
at the top of the chat window when the ship has not opted in to sharing
their profile.

fixes urbit/landscape#1195
2022-04-06 09:51:50 -04:00
Hunter Miller
f085c37ecc browser-settings: making types more robust and fixing setting clearing bug 2022-04-05 18:29:29 -05:00
Liam Fitzgerald
0eb1295f7b interface: use object-fit:cover
This aligns image embeds with the wishes of the design team, by zooming
and cropping the image to fill the entire container
2022-04-04 12:24:23 -05:00
fang
064b15e5a0
term: move coordinate origin to top left
Having the origin at the top left instead of the bottom left is more
conventional and ergonomic. The only thing this complicates is
prompt-specific logic, where we care about the coordinates of the
bottom-most line on the screen.

For that reason, the bulk of the changes here are in vere, where we
treat the bottom-most line specially, drawing the spinner onto it.
Webterm is likewise updated to account for the new coordinate system.

Drum now opts to accept clicks anywhere on the screen, and does its best
to move the cursor as close to the clicked location as possible (within
the confines of the prompt).
2022-04-03 21:38:09 +02:00
Patrick O'Sullivan
a6e196a0fd groups: fix sort order in notifications 2022-04-01 17:18:32 -05:00
Patrick O'Sullivan
c650d1d477 groups: fix issue with wrapping urls in notes 2022-04-01 14:23:23 -05:00
Hunter Miller
c3b491ddb0 groups-pane: refining loading strategy to be more efficient 2022-04-01 12:18:43 -05:00
tomholford
531fd61ace ux: add info modal
Add a new tab to the top bar that shows an alert with a brief usage guide.
2022-04-01 06:59:39 -07:00
Hunter Miller
65e05fbf25 api: turn off verbose 2022-03-31 17:26:06 -05:00
Liam Fitzgerald
185ee5f661 interface: fix reconnect logic 2022-03-31 14:55:03 -06:00
Hunter Miller
1d1b9ae863
Merge branch 'next/groups' into lf/landscape-floor 2022-03-31 12:28:29 -05:00
Liam Fitzgerald
58cd0bd4f3 interface: address hunter review 2022-03-31 10:56:45 -06:00
Patrick O'Sullivan
7108bfa7c7 groups: remove debug statement from chatinput 2022-03-31 11:39:54 -05:00
Hunter Miller
1949174f63
Merge pull request #5682 from urbit/po/fix-silent-s3-failures
groups: fix silent s3 failures
2022-03-31 11:26:40 -05:00
Patrick O'Sullivan
0d3f4ec554 groups: clear s3 error state on succesful upload 2022-03-31 11:23:52 -05:00
Hunter Miller
9b59f26c6c bootstrap: moving data calls to relevant component so it always loads 2022-03-31 11:07:08 -05:00
Hunter Miller
687b23e519 useFileUpload: fixing stale closure 2022-03-31 11:06:38 -05:00
Patrick O'Sullivan
846fe48e7a groups: lift uploadError state to ChatPane, refactor nested ternary 2022-03-31 11:04:24 -05:00
Patrick O'Sullivan
cc1048dd21 groups: add padding to error box in collections 2022-03-31 10:52:31 -05:00
Patrick O'Sullivan
ff65c17376 groups: remove fixed height from s3 error portal 2022-03-31 10:50:10 -05:00
Hunter Miller
6dc763a7d1 s3client: adding missing promise call to trigger 2022-03-31 09:42:10 -05:00
Hunter Miller
b1aab5bc36 Merge branch 'next/groups' into hm/fix-missing-channel-state 2022-03-30 15:29:32 -05:00
Patrick O'Sullivan
9db2024676 groups: handle s3 upload failures in chat 2022-03-30 15:04:01 -05:00
Patrick O'Sullivan
836cdb2478 groups: handle s3 upload failures in collections 2022-03-30 14:12:13 -05:00
Patrick O'Sullivan
2b784caffc groups: remove TODO about harkbody def, fix in separate PR 2022-03-29 09:18:57 -05:00
Liam Fitzgerald
75a2c2b979 interface: static height for embedded images 2022-03-28 14:44:02 -06:00
Liam Fitzgerald
41d42da34c interface: fix group feed unread count
Fixes urbit/landscape#1258
2022-03-28 13:54:37 -06:00
Patrick O'Sullivan
952a05a901 groups: fix notification order 2022-03-28 14:52:28 -05:00
Liam Fitzgerald
e31c194a20 interface: fix group chat join overflow
fixes urbit/landscape#1105
2022-03-28 12:49:43 -06:00
Liam Fitzgerald
a7906641a7 interface: cap maxHeight of ShipSearch
Fixes urbit/landscape#1393
2022-03-28 12:30:19 -06:00
Liam Fitzgerald
7a6cb8ae6d interface: do not show recently joined if already left
Fixes urbit/landscape#1407
2022-03-28 12:19:19 -06:00
Patrick O'Sullivan
de493a6482 groups:Remove useEffect for setting prot. handler from Content 2022-03-28 09:24:51 -05:00
Patrick O'Sullivan
c896349246 groups:Remove button for registering prot. handler in settings 2022-03-28 09:23:44 -05:00
Patrick O'Sullivan
ef77aaf802 groups: Use garden's prot. hand. prefs to determine app link 2022-03-25 14:30:26 -05:00
Patrick O'Sullivan
1399ef9fa5 groups: Add useGardenSettings store to groups 2022-03-25 14:28:07 -05:00
Patrick O'Sullivan
df280daee3 groups: Set browserId in local state on mount of app 2022-03-25 14:27:30 -05:00
Patrick O'Sullivan
0a5cd0041d groups: Add browserId to local state 2022-03-25 14:26:18 -05:00
Patrick O'Sullivan
66451c9089 groups: Add fingerprintjs 2022-03-25 14:25:07 -05:00
Hunter Miller
60d5d4ffcf bootstrap: optimizing order a little more 2022-03-25 12:55:54 -05:00
Hunter Miller
78a0796a74 bootstrap: removing unnecessary clear and moving hark a little higher 2022-03-25 11:42:42 -05:00
fang
60ed368bc4
webterm: fix bell icon in tabs
Presumably due to how js non-objects work in closures, the selected prop
we were reading out whenever a blit came in was stale.

Also, it was possible that a bell was hiding inside a %mor blit, so we
add a small helper for checking properly.
2022-03-25 15:38:56 +01:00
fang
890e5f1e9b
webterm: do not warn on session creation cancel 2022-03-25 14:41:53 +01:00
fang
01de5a06b0
term: consistently use x/y coordinate ordering
%rez has always used "width & height". Certainly, "x & y" is more
standard than "row & column". As such, we settle on making %hop and %hit
respect the more natural ordering. This change is safe because these
interfaces haven't made it to livenet yet.
2022-03-25 13:45:29 +01:00
Hunter Miller
a93c3975d7 any-ascii: lazy load for code-splitting 2022-03-24 19:22:47 -05:00
Hunter Miller
6a5b0e3a83 s3: lazy load aws sdk for code splitting 2022-03-24 19:21:56 -05:00
Hunter Miller
e3b2e166d7 bootstrap: moving and reordering, adding scries
This undoes some of the code-splitting done previously as it didn't
affect performance enough, and was actively hurting it in some ways.
Instead this moves the subscription initiation higher and adds scries
for critical data. This also shuffles the calls in App's useEffect so
that they are more colocated with relevant concerns.
2022-03-24 19:18:45 -05:00