Commit Graph

31119 Commits

Author SHA1 Message Date
Joe Bryan
12229a50e8 u3: adds snapshot facade to manage.c 2022-12-13 00:07:52 -05:00
Hunter Miller
36deb95411
Merge pull request #6150 from urbit/philip/contact-fix
contact-store: no-op if adding old contact
2022-12-12 14:28:52 -06:00
Philip Monk
e1419d1787 contact-store: no-op if adding old contact
%contact-store is responsible for sending updates about contacts, eg
profile color.  When it hears an update, it fans that out to its
subsribers, unless that update is stale.  If you reguarly fan out stale
updates, then they reverberate across the network indefinitely -- we
call this "echoing".

To cut off this echoing, all edits have a timestamp, and we consider any
updates from before this timestamp to be stale.  Additions are separate
from edits, and for them we instead do a value comparison on the contact
-- if it didn't change, we consider the update stale.

The problem with this scheme is that if an addition and edit happen one
after the other in quick succession, you might have the following
sequence:

- add comes in with timestamp T1
- edit comes in with timestamp T2 after T1
- we hear an echo of the add, and that errantly applies because it
  passes our "did the contact actually change" check
- we hear an echo of the edit, which applies because T2 is after T1
- GOTO 3

Each time we apply the stale update, we fan that out to our subscribers,
and if any two hosts subscribe to each other, this will loop.  This may
even loop unconditionally because the ship that made the profile changes
seems like it might not recognize that those changes didn't come from
itself, so it sends them to all the groups it's in.  If so, that's an
important issue to fix.

Fixes tloncorp/landscape-issues#1442
2022-12-12 13:03:41 -07:00
Jared Tobin
716281cb0d
meta: target ota workflow at ~binnec-dozzod-marzod 2022-12-12 13:53:37 -03:30
Jared Tobin
a51353c4b6
Merge branch 'next/arvo' into jt/merge-ota 2022-12-12 05:29:30 -03:30
Jared Tobin
6764130504
meta: give ota workflow live args 2022-12-12 05:20:48 -03:30
Jared Tobin
0631b67907
meta: remove breaking comment 2022-12-12 05:15:23 -03:30
Jared Tobin
882b82b5ea
meta: target jt/merge-ota for testing 2022-12-12 05:07:47 -03:30
Jared Tobin
4f6ca764cc
meta: add ota workflow 2022-12-12 05:04:05 -03:30
Jared Tobin
a8fc001cdf
meta: add ota action 2022-12-12 05:03:57 -03:30
Joe Bryan
5726f08da8 u3: simplifies road stack adjustment after snapshot load 2022-12-09 23:41:45 -05:00
Joe Bryan
f5fdaa2781 u3: automatically place the guard page in u3e_live() 2022-12-09 23:41:45 -05:00
Joe Bryan
39d0250afa u3: move directory creation out of events.c 2022-12-09 23:41:42 -05:00
Joe Bryan
bceb9cde4a u3: stop using u3P.dir_c outside of events.c 2022-12-09 23:41:42 -05:00
Joe Bryan
4620212260 u3: removes u3e_foul() 2022-12-09 23:41:38 -05:00
Hunter Miller
cec4e11448
Merge pull request #6141 from urbit/hm/change-ota-source
migration: set official ota source
2022-12-09 12:22:50 -06:00
Hunter Miller
ff0231e761 migration: set official ota source 2022-12-09 12:22:04 -06:00
Hunter Miller
9b4ac97756
Merge pull request #6140 from urbit/hm/add-migration-fix
migration: adding crash fix
2022-12-09 11:37:54 -06:00
Hunter Miller
38919352c8 migration: adding crash fix 2022-12-09 11:07:51 -06:00
Liam Fitzgerald
4584067e7d Merge branch 'lf/gladio-2' 2022-12-09 15:23:18 +10:00
Liam Fitzgerald
cf2c73a0e1 group-store: make %migrate idempotent 2022-12-09 12:39:47 +10:00
Liam Fitzgerald
eedc50f9e4 group-store: add /wait endpoints 2022-12-09 12:22:22 +10:00
Liam Fitzgerald
1a1dec6268 group-store: handle alpha correctly 2022-12-09 09:34:56 +10:00
Hunter Miller
9fc6cf7a40 kelvin: update 2022-12-08 11:01:48 -06:00
Hunter Miller
8ac999593a migration: update source 2022-12-08 10:55:03 -06:00
Hunter Miller
d4cce14ff4 bill: removing notify 2022-12-08 07:56:21 -06:00
Hunter Miller
e4560339ec migration: fixing state versions 2022-12-08 07:53:00 -06:00
Liam Fitzgerald
6633603469 Merge remote-tracking branch 'origin/lf/drop-docket' 2022-12-08 16:44:56 +10:00
Liam Fitzgerald
42996f14cc docket: remove charge if docket file no longer exists 2022-12-07 08:54:53 +10:00
Liam Fitzgerald
45b9686b06 migration: remove docket for landscape 2022-12-07 08:41:01 +10:00
Liam Fitzgerald
fbb2bd865e migration: uninstall through %docket 2022-12-07 08:36:35 +10:00
Liam Fitzgerald
d9a895c214 Merge remote-tracking branch 'origin/master' into lf/migration-prep 2022-12-07 08:32:05 +10:00
Liam Fitzgerald
e600ded69c migration: install %talk 2022-12-07 08:30:04 +10:00
Philip Monk
e5017ac12a Merge branch 'master' into next/arvo 2022-12-06 11:25:21 -07:00
Philip Monk
287b2f132c Merge remote-tracking branch 'origin/master' into next/417 2022-12-06 11:21:57 -07:00
Philip Monk
7c115c16c9 pill: update 2022-12-05 17:14:59 -07:00
Zach Alberico
da8496e01a
Merge pull request #6132 from urbit/philip/grid-copy
grid: only block on live apps
2022-12-05 16:14:40 -08:00
Philip Monk
36514b21d4 grid: only block on live apps 2022-12-05 17:12:10 -07:00
Zach Alberico
785d581df0
Merge pull request #6131 from urbit/philip/grid-copy
grid: improve copy and fix system update dismissal
2022-12-05 15:16:57 -08:00
Philip Monk
44ca16d0e7 grid: improve copy and fix system update dismissal
For blocked kelvin updates, we clarified the copy, including deleting a
broken link and reference to a system preferences button that doesn't
exist, and standardized on "suspend" instead of "archive" (as in the
rest of the UI).

Also don't delete OTA source when dismissing the notification.
2022-12-05 16:11:53 -07:00
Philip Monk
4132a00cbf Merge remote-tracking branch 'origin/next/417' into next/417 2022-12-05 14:36:42 -07:00
Philip Monk
4a07be3904 Merge remote-tracking branch 'origin/t/grid-bump-flow' into next/417 2022-12-05 14:36:33 -07:00
Liam Fitzgerald
6841f726a7 metadata-pull-hook: disabling remove on nack 2022-12-05 13:09:30 +10:00
Liam Fitzgerald
e4827915d8 group-pull-hook: disabling remove on nack 2022-12-05 13:08:51 +10:00
Liam Fitzgerald
a4c597d281 graph-pull-hook: do not archive on nack 2022-12-05 11:07:40 +10:00
Joe Bryan
1ac2264a49 test: renames nock-tests to meme-tests 2022-12-02 22:58:07 -05:00
Joe Bryan
7870024df9 test: re-disables failing grq test 2022-12-02 16:56:00 -05:00
Joe Bryan
95a2e06f44 test: re-disables ames decryption test to avoid bail:evil in ci 2022-12-02 16:55:08 -05:00
Joe Bryan
15c4ae7fa7 u3: updates guard-page assertion to account for variable loom sizes 2022-12-02 16:54:27 -05:00
Joe Bryan
867f0621a7
Merge pull request #6127 from urbit/jb/guard-always-again
u3: re-enforce guard page invariants.
2022-12-02 16:42:11 -05:00