urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2024-12-21 01:41:37 +03:00
Code Issues Packages Projects Releases Wiki Activity
18,793 Commits 768 Branches 10 Tags 215 MiB
a7168478f3
Commit Graph

3672 Commits

Author SHA1 Message Date
Liam Fitzgerald
1b90328f39 chat-fe: fix index issue with pending messages 
To produce message elements we iterate over pendingMessage ++ messages,
but to check whether they're adjacent to a message by the same author,
we index back into messages, which produces incorrect results when
pendingMessages is nonEmpty
 2020-04-17 14:20:28 +10:00
Liam Fitzgerald
41be649764 Merge branch 'master' into mp/chat/firefox-take-2 2020-04-17 12:06:34 +10:00
Fang
6f13546e2d
chat-cli: account for reverse message ordering 
#2618 changed the way chat-store orders messages. We need to account for that
when processing/printing. This is the minimum viable fix.
 2020-04-16 16:52:40 +02:00
Jared Tobin
18878727b0
Merge branch 'liam-fitzgerald/lf/links-autoleave' (#2754) 
* liam-fitzgerald/lf/links-autoleave:
  link: leave collection on leaving associated group

Signed-off-by: Jared Tobin <jared@tlon.io>
 2020-04-16 16:54:32 +04:00
Jared Tobin
e7984324be
Merge branch 'fix-pending' (#2751) 
* origin/fix-pending:
  chat-js: fix chat ordering and pending messages

Signed-off-by: Jared Tobin <jared@tlon.io>
 2020-04-16 16:54:12 +04:00
Jared Tobin
6ef155b82b
Merge branch 'fix-chat-autojoin' (#2749) 
* origin/fix-chat-autojoin:
  chat-js: fix auto-join and a chatSynced error
  chat-js: fix issue with autojoining

Signed-off-by: Jared Tobin <jared@tlon.io>
 2020-04-16 16:53:59 +04:00
Jared Tobin
b655105a38
Merge branch 'liam-fitzgerald/lf/link-ios-crash' (#2742) 
* liam-fitzgerald/lf/link-ios-crash:
  link-js: fix pages disappearing on small screens

Signed-off-by: Jared Tobin <jared@tlon.io>
 2020-04-16 16:53:36 +04:00
Liam Fitzgerald
a7a539bb24 link: leave collection on leaving associated group 
Automatically leaves a collection when the user is removed from a group
 2020-04-16 21:45:58 +10:00
Liam Fitzgerald
945fb3fca6 chat-js: render markdown in messages 
Renders markdown in text messages but not url or code messages.
 2020-04-16 20:21:29 +10:00
Liam Fitzgerald
9574765de6 chat-js: use CodeMirror for chat input 
swaps out the textarea for a CodeMirror in markdown mode. Resolves an
issue related to the input shrinking with the content.
 2020-04-16 20:21:29 +10:00
Liam Fitzgerald
a424312d12 chat-js: add CodeMirror dependency 
Adds CodeMirror dependency and related css
 2020-04-16 20:21:27 +10:00
Fang
4c4858f198
chat-hook: clarify backlog wire handling logic 2020-04-16 01:44:36 +02:00
Fang
d1feabd1fb
dbug: print result with priority 
To give it some color, making it less easy to miss.
 2020-04-15 23:50:53 +02:00
Logan Allen
e98605c1bb chat-js: fix chat ordering and pending messages 2020-04-15 16:48:33 -04:00
Fang
e2034eca19
dbug: avoid printing nothing at all 
Previously, if filtering subscriptions turned up no results, nothing was
printed. With this change, we explicitly print "no matching subscriptions"
instead.
 2020-04-15 22:28:59 +02:00
Logan Allen
c497d5a6a6 chat-js: fix auto-join and a chatSynced error 2020-04-15 15:58:03 -04:00
Logan Allen
f035070387 chat-js: fix issue with autojoining 2020-04-15 15:04:54 -04:00
Fang
0f05ed3149
chat-hook: consistently pull backlog subs 
We weren't accounting for backlog subscriptions with non-zero message
indexes in their wires. Now, we look through all of our outgoing
subscriptions to identify relevant backlog subscriptions, and leave all
of those.

The more proper fix here is to not include message indexes in the wire
in the first place, since we don't ever reuse that anywhere. But that's
a more invasive change, so we just leave a TODO for it instead.
 2020-04-15 19:26:58 +02:00
Jared Tobin
65cad93b1b
Merge branch 'liam-fitzgerald/lf/chat-input-line-height' (#2743) 
* liam-fitzgerald/lf/chat-input-line-height:
  chat-js: adjust line height in chat input

Signed-off-by: Jared Tobin <jared@tlon.io>
 2020-04-15 20:18:14 +04:00
Fang
084ce356a8
chat-hook: on %remove, try our best to pull subs 
Previously, we were removing the relevant entry from the `synced` map
before calling `+pull-wire`, which requires an entry to still be there.
This lead to subscriptions not actually being pulled, commonly leading
to "subscribe wire not unique" errors on re-join.

In addition to fixing that, `%remove` actions now try to pull the
subscription regardless of whether they have an entry in the `synced`
map or not. `%leave` is always safe, and we might want to clean up
subscriptions that shouldn't be there anymore in the first place.
 2020-04-15 16:29:26 +02:00
Liam Fitzgerald
8b48f3fa0f chat-js: adjust line height in chat input 
Set the line height of the input to be the same as a sent message.
Additionally fixes an issue that would cause unnecessary scrollbars to
be shown.
 2020-04-15 15:08:42 +10:00
Liam Fitzgerald
536e3121b6 link-js: fix pages disappearing on small screens 
The rightPanelHide prop was being improperly set on the home, settings
and members screens, causing them to be blank on small screen sizes

Fixes #2727
 2020-04-15 14:27:29 +10:00
Liam Fitzgerald
50dca97b07 publish: increase legibility for code in dark mode 
Makes the rules that set both a background and foreground color come
last in the CSS, increasing their specificity. Changes the highlight to a
lighter grey, to better stand out. Correctly aligns highlights with code
block backgrounds.

Fixes #2684
 2020-04-15 13:45:22 +10:00
Liam Fitzgerald
ba18737b5e chat-fe: move cancel button below comment edit 2020-04-15 10:59:56 +10:00
Liam Fitzgerald
b538cfd3ea chat-fe: address review comments 2020-04-15 10:48:46 +10:00
Liam Fitzgerald
963d04831d Merge branch 'master' into lf/publish-del-edit 2020-04-15 10:07:29 +10:00
Liam Fitzgerald
595acd17ff publish-js: lift editing state to comment list 2020-04-15 09:57:43 +10:00
Liam Fitzgerald
c46642af8d publish: fix check on edit-comment delta 
An incorrect check caused comment editing to never be propagated.
 2020-04-15 09:57:07 +10:00
ixv
b978d4f824
Merge pull request #2736 from urbit/ixv/fix-comment-grow 
publish: fix bug in comment mark
 2020-04-14 15:53:26 -07:00
Logan Allen
0145981542 contact-js: made channel handle onChannelError 2020-04-14 18:16:44 -04:00
Logan Allen
bfcaf6468e contact-hook: tested it, got /synced path working, and subscriptions loading 2020-04-14 18:05:32 -04:00
Logan Allen
b6e4566e61 contacts: fix group deletion and do some quality of life fixes 2020-04-14 21:33:01 +00:00
ixv
5bb9776b70
Merge pull request #2730 from liam-fitzgerald/lf/chat-synced-fix 
chat-fe: resubscribe message iff chatSynced is populated
 2020-04-14 11:40:45 -07:00
ixv
e5cf4fb813
Merge pull request #2720 from urbit/la-channel-err 
channel.js: added way to handle event source errors more smoothly, and implemented in chat
 2020-04-14 11:40:02 -07:00
Isaac Visintainer
113c86037c publish: fix bug in comment mark 2020-04-14 11:23:06 -07:00
Fang
7b5f7cde6b
link-listen-hook: partially revert 05e6519 
We still want to auto-opt-in to new collections for _unmanaged groups_,
because we have no other way to join them.
 2020-04-14 16:12:09 +02:00
Liam Fitzgerald
a3fed45af1 publish-js: avoid unnecessary scrollbars on note view 
the root container had height: 100% but also a margin-top set on it. This
caused unnecessary scrollbars to appear when the content did not
actually overflow the container.
 2020-04-14 20:38:35 +10:00
Liam Fitzgerald
d63cc0d7de publish-js: allow deletion and editing of comments 
Adds interface affordances for the addition and removal of comments.
 2020-04-14 20:20:59 +10:00
Liam Fitzgerald
fa92d1cb7f publish: use @tas for comment ref in marks 
Comment references in publish actions are @tas of a rendered @da. The
mark expected @da, causing a mismatch.
 2020-04-14 20:15:57 +10:00
Liam Fitzgerald
9ddf06d2a1 chat-fe: correct FF scroll behaviour 
Firefox treats the reflow in the scroll container weirdly so for the
scrollback case, we save the position to restore later, when the backlog
messages come in. For the 'locked at bottom' case we add a new state
variable and rescroll based on that.
 2020-04-14 16:34:10 +10:00
Isaac Visintainer
d8cdbfdeb8 release: urbit-os-v1.0.13 2020-04-13 19:26:13 -07:00
ixv
2c56937f0d
Merge pull request #2701 from lukechampine/syntax-error-src 
ford: print source line on syntax error
 2020-04-13 19:03:05 -07:00
Liam Fitzgerald
a6c5e96902 chat-fe: don't redirect if creating group 2020-04-14 11:50:47 +10:00
Liam Fitzgerald
786f2518e7 chat-fe: resubscribe message iff chatSynced is populated 
Previously, if a room was navigated to directly, the resubscribe message
would show before the chatSynced state was loaded. Initialises
chatSynced as null and checks it is not null before showing the
resubscribe message.
 2020-04-14 11:41:38 +10:00
Matilde Park
a4d37c0313 Merge branch 'master' into mp/chat/firefox-take-2 2020-04-13 21:38:27 -04:00
Liam Fitzgerald
1d81107d72 Merge branch 'master' into lf/profile-overlay 2020-04-14 11:04:52 +10:00
Liam Fitzgerald
a2998bdc41 chat-fe: redirect to DMs on trivial new group case 
Create or view a DM upon trying to create an invite-only group with one invitee.
 2020-04-14 11:01:31 +10:00
ixv
a7f20c37c1
Merge pull request #2700 from liam-fitzgerald/lf/invite-search-short 
invite-search: handle suggestions for short searches
 2020-04-13 16:56:26 -07:00
ixv
2d30886b65
Merge pull request #2724 from urbit/ixv/install-mousetrap 
publish: install mousetrap before we use it....
 2020-04-13 16:55:40 -07:00
ixv
228bee42e4
Merge pull request #2707 from urbit/ixv/cache-posts 
publish: eagerly store your own changes
 2020-04-13 16:54:41 -07:00
ixv
3526cfa4e6
Merge pull request #2618 from urbit/chat-reverse-messages 
chat: reversed order that messages are stored in for faster performance
 2020-04-13 16:54:16 -07:00
Isaac Visintainer
78023b8eff publish: ignore edit updates if they originated with us 2020-04-13 13:34:50 -07:00
Isaac Visintainer
7edcd65699 publish: add facilities for managing limbo state 2020-04-13 13:33:34 -07:00
Fang
7aebcad25b
link fe: refactor message display into component 2020-04-13 21:54:50 +02:00
Fang
0d73b391b4
link fe: more informative "empty list" display 
Displays "Loading..." if the links haven't loaded yet. If there are no
links, tells the user they can save one.
 2020-04-13 21:37:42 +02:00
Fang
4da0d636d3
link-view: in pagination logic, only +lent once 
Also just use +swag instead of chaining +scag and +slag manually.
 2020-04-13 21:26:44 +02:00
Fang
8f3d174c94
link: minimal initial view result 
On initial load, instead of getting the first 25 links for every
collection, only get their totals and unread counts. This drastically
reduces the pageload time.

Updates the frontend to match:
- Handle initial results without link content.
- Dynamically load in collection's links, even for page 0.
 2020-04-13 21:26:09 +02:00
Fang
bf42afbd56
link-view: add some hints to aid profiling 2020-04-13 21:15:51 +02:00
Jared Tobin
cc16e905af
Merge branch 'yosoyubik/apt-dup' (#2417) 
* yosoyubik/apt-dup:
  hoon: +apt:by check for duplicate keys
 2020-04-13 17:43:41 +04:00
Jared Tobin
bf78e71479
Merge branch 'courajs/json-unit-tests' (#1769) 
* courajs/json-unit-tests:
  Change at:dejs-soft:format to reject too-long json arrays
  Add unit tests for json de/serialization.
 2020-04-13 16:38:42 +04:00
Isaac Visintainer
2608dea563 publish: style changes and comments 2020-04-13 00:04:33 -07:00
Isaac Visintainer
d3ab26e57c publish: restore OS0 -> OS1 transition logic 2020-04-12 23:38:54 -07:00
Isaac Visintainer
277bc8d465 publish: make reducers able to handle duplicate updates now that we send updates both pre and post confirmation 2020-04-12 23:21:43 -07:00
Isaac Visintainer
a40d292bb7 publish: remove or add posts/comments from limbo depending on whether they succeeded or failed 2020-04-12 23:21:42 -07:00
Isaac Visintainer
d2fdae4d4b publish: immediately store post and comment changes 2020-04-12 23:21:42 -07:00
Isaac Visintainer
f9e17e61a2 publish: update state with limbo field 2020-04-12 23:21:42 -07:00
Isaac Visintainer
20d3c4105d publish: install mousetrap before we use it.... 2020-04-12 23:05:32 -07:00
Liam Fitzgerald
2c870cdfc0 chat-fe: resuscitate scrollback 
If the initial 20 messages doesn't cause the messages container to
overflow then the backlog will never be requested, making scrollback
impossible. This is due to making the container have position:relative
in order to display an overlay inside it.  Fixed by unconditionally
requesting the first page of backlog on load.
 2020-04-11 20:07:01 +10:00
Liam Fitzgerald
d2d9158ea3 chat-fe: hide profile overlay on click outside 
Hides the profile overlay when the users clicks outside the overlay.
 2020-04-11 19:34:11 +10:00
Liam Fitzgerald
966155088c chat-fe: move new DMs to ship select popover 
Refactored the patp autocomplete into a reusable component, and then
used that to add the DM popover interface. Also introduces some
performance improvements for the popover.
 2020-04-11 17:47:11 +10:00
Liam Fitzgerald
803c7b4816 chat-fe: edit group identity if own profile overlay 
Shows an "Edit Group Identity" button instead of "Send Message" if the
profile overlay being shown is the user's own.
 2020-04-11 10:44:57 +10:00
Liam Fitzgerald
e5634a913d invite-search: always add search query if valid patp 2020-04-11 10:17:49 +10:00
Logan Allen
fb3111e88a channel.js: added way to handle event source errors more smoothly, and implemented in chat 2020-04-10 19:38:13 -04:00
Logan Allen
98f4df14a4 chat-js: made scrollback work for new message indexing 2020-04-10 22:22:14 +00:00
Logan Allen
8ffca926e7 chat-js: reverted built files 2020-04-10 17:34:23 -04:00
Logan Allen
6d1efde884 chat-js: fixed scrollback for reverse message chatrooms 2020-04-10 17:29:23 -04:00
Matilde Park
948dbe85e7 chat: scrollToBottom on mount for FF 2020-04-10 16:55:23 -04:00
Matilde Park
a212a5dc69 Merge branch 'master' into mp/chat/firefox-take-2 2020-04-10 16:44:15 -04:00
Matilde Park
1ddbc77157 chat: only scrolltobottom if first backlog grab 2020-04-10 16:42:05 -04:00
Matilde Park
3dc6a0bc9a chat: add firefox-specific chat window 2020-04-10 16:34:27 -04:00
ixv
e253ec1860
Merge pull request #2562 from nijynot/chore/interface-lint 
interface: add eslint to interface and lint `launch` and `chat`
 2020-04-10 13:04:58 -07:00
Logan Allen
b85697cbec chat-hook: respect backlog index, no longer truncate 2020-04-10 15:25:58 -04:00
Logan Allen
be1d5cee56 chat-store: flop envelopes in handle-messages so backlog comes in correct order 2020-04-10 15:25:58 -04:00
Logan Allen
8cdfb559f6 chat-view and hook: style pass and backlog truncation 2020-04-10 15:25:58 -04:00
Logan Allen
ecc8942eaf chat: reversed order that messages are stored in for faster performance 2020-04-10 15:25:58 -04:00
Liam Fitzgerald
e7887b34c3 invite-search: handle suggestions for short searches 
Triggers invitee suggestions after one character of input. To
compensate for the potential explosion of suggestions, we
tighten our group searching criteria and truncate the
ship suggestions on short searches. Also addresses a bug where names of
groups were not being downcased before search.

Fixes #2635
 2020-04-10 19:57:50 +10:00
Liam Fitzgerald
c162f0f212 chat-fe: add DMs and related screens 
Adds DMs, which are just unmanaged chats whose last path component
starts with dm-- followed by the patp of the other user.
 2020-04-10 19:45:25 +10:00
Liam Fitzgerald
1bca495d8a chat-fe: reflow profile overlay near edges of screen 
Polls for the distance between the top of the container and reflows the
overlay accordingly.
 2020-04-10 17:59:04 +10:00
Liam Fitzgerald
188a1e8dcf chat-fe: hide/show profile overlay on sigil click 
Hide and shows profile overlay on sigil click. Shows the overlay for 2
seconds after click. If the user moves their mouse into the overlay then
it will remain open as long as the mouse is inside the overlay.
 2020-04-10 17:59:04 +10:00
Liam Fitzgerald
f3c21fae36 chat-fe: add profile overlay 
Adds a profile overlay to display information about the user on hover.
Also adds the svgClass prop to the sigil component, to allow setting
classes directly on the sigil svg.
 2020-04-10 17:58:46 +10:00
Isaac Visintainer
eef6e56dca release: urbit-os-v1.0.12 2020-04-09 17:47:55 -07:00
ixv
12b6a5ccc5
Merge pull request #2600 from urbit/dk-help-generator 
completed +help comments for places they were missing
 2020-04-09 16:51:22 -07:00
ixv
b43f4d9d39
Merge pull request #2709 from urbit/mp/chat/namespace-group-chats 
chat: add unique ID to grouped chat paths
 2020-04-09 15:54:53 -07:00
ixv
f0d702002a
Merge pull request #2708 from urbit/m/link-opt-in 
link: require explicit opt-in for new collections
 2020-04-09 15:54:41 -07:00
ixv
c65b896a2c
Merge pull request #2705 from liam-fitzgerald/lf/publish-loading-fix 
publish-fe: improve UX of loading spinner on new note
 2020-04-09 15:54:04 -07:00
ixv
d376fd6998
Merge pull request #2704 from liam-fitzgerald/lf/chat-padding-sidebar 
chat-fe: filter empty groups in sidebar
 2020-04-09 15:53:55 -07:00
ixv
8e480b611d
Merge pull request #2703 from liam-fitzgerald/lf/chat-patp-copy 
chat-fe: copy patp to clipboard on author name click
 2020-04-09 15:53:46 -07:00
ixv
c5eb540c71
Merge pull request #2702 from liam-fitzgerald/lf/chat-join-spinner 
chat-fe: show spinner on join
 2020-04-09 15:53:35 -07:00
ixv
bc5358c0fd
Merge pull request #2695 from liam-fitzgerald/lf/sanitise-md-publish 
publish: sanitise markdown snippets in preview
 2020-04-09 15:52:52 -07:00
ixv
a41096153d
Merge pull request #2694 from liam-fitzgerald/lf/invite-search-arrow-keys 
invite-search: allow keyboard nav + selection
 2020-04-09 15:52:36 -07:00
ixv
77933e992a
Merge pull request #2693 from urbit/mp/re-alphabetise 
various: alphabetise associations accesses the object
 2020-04-09 15:52:18 -07:00
ixv
5fe16a7f47
Merge pull request #2687 from urbit/la-resub-on-err 
chat-js: resubscribe on error, not just on quit
 2020-04-09 15:52:03 -07:00
Isaac Visintainer
1fdf8a9789 Merge branch 'gall-hack-new-deal' 2020-04-09 15:39:49 -07:00
ixv
43484d613c
Merge pull request #2683 from urbit/mp/invite-search/associations 
invite search: populate group index from contacts
 2020-04-09 15:37:56 -07:00
ixv
8d32d49daf
Merge pull request #2668 from urbit/mp/link/dib-ing 
link: line up link info on same line height
 2020-04-09 15:37:38 -07:00
Logan Allen
a5d6403f39 gall: updated to soft properly 2020-04-09 14:53:12 -04:00
Matilde Park
9881fb2a2b chat: add unique ID to grouped chat paths 2020-04-09 14:37:21 -04:00
Fang
05e651970e
link: require explicit opt-in for new collections 
Instead of auto-watching a new collection when it gets added to group
associations, require that the user explicitly choose to view it.

Of course, creation counts as opting in, so watch the collections we
create by default.
 2020-04-09 19:01:58 +02:00
nijynot
6536054b91 interface: add eslint and update contrib docs 2020-04-09 12:08:23 +02:00
Logan Allen
7edc183ded gall: soft cast chat-action, and remove the chat-update hack 2020-04-09 02:09:51 -04:00
Liam Fitzgerald
0c062104a5 publish-fe: improve UX of loading spinner on new note 
Improve the UX of the loading spinner that shows when you have a new
note, by displaying it until we receive the new note in the
subscription, instead of until the poke succeeds.
 2020-04-09 16:06:10 +10:00
Liam Fitzgerald
6586aa98e3 chat-fe: filter empty groups in sidebar 
Empty groups caused the padding on the first group to be too large.
Filter the groups before we map over them so that we can set padding
properly.

Fixes #2674
 2020-04-09 15:08:06 +10:00
Liam Fitzgerald
e2f8be20de chat-fe: make copy status text inter 2020-04-09 14:13:23 +10:00
Liam Fitzgerald
648eced4ff chat-fe: copy patp to clipboard on author name click 2020-04-09 13:12:48 +10:00
Liam Fitzgerald
b4fb8d5163 chat-fe: show spinner on join 
Shows the spinner whilst joining a channel, both manually and from a
url. Also fixes an issue where a newly joined channel may be navigated
away from automatically.
 2020-04-09 12:48:55 +10:00
lukechampine
cb4cae01c8 ford: print source line on syntax error 2020-04-08 21:11:15 -04:00
Fang
c570def06a
Merge pull request #2680 from mhartl/master 
Fix spelling of "existent"
 2020-04-09 00:32:34 +02:00
Liam Fitzgerald
3801056d3c invite-search: allow keyboard nav + selection 
Allows the user to navigate potential invitees with the arrow keys and
with shift+tab and tab. Enter adds the currently selected invitee.
 2020-04-09 08:03:21 +10:00
Liam Fitzgerald
ff70a2be89 publish: sanitise markdown snippets in preview 
Runs the snippet through ReactMarkdown instead of rendering it as text.
We restrict the allowed nodes in the render to pure text, so the snippet is not
overly visually heavy.
 2020-04-09 07:56:44 +10:00
Elliot Glaysher
81fb798bfb king: handle IOError from recvFrom in ames. 
This is an attempt to fix the ames driver so that it reestablishes
a socket after a socket error. This should theoretically fix the
"ames dcoesn't work after computer sleeps" issue, so that when the
os closses a socket, we detect this in waitPacket and attempt to
reestablish the socket.

Closes #2190
 2020-04-08 13:33:33 -07:00
Elliot Glaysher
238f6db097 king: increment version for new pill 2020-04-08 13:33:16 -07:00
Matilde Park
839f9090bb various: alphabetise associations accesses obj 
Previously we were checking for a title for the association by accessing
a non-existent property of the key we were using to iterate through
the object. What we want to do is access the iterated object to find
that title, and so this commit does that.
 2020-04-07 17:35:02 -04:00
Fang
e9233b1a50
link fe: fix "mark all as read" button 
This wasn't bound, nor calling, correctly.
 2020-04-07 20:45:27 +02:00
Fang
9f47cbd568
dbug: document "all subscriptions" option in gen 2020-04-07 11:21:17 +02:00
Logan Allen
7a41f2dcab chat-js: resubscribe on error, not just on quit 2020-04-06 23:24:13 -04:00
Logan Allen
4d8e0cf26b gall: added hack to reduce processing time for chat messages by 30% 2020-04-06 22:58:06 -04:00
Matilde Park
00ed295d48 invite search: populate group index from contacts 2020-04-06 19:45:40 -04:00
Aaron Sikes
eb0ce2daba Change at:dejs-soft:format to reject too-long json arrays 
`at` is for when you expect an array of a certain exact structure. If it
has extra elements, that indicates you were mistaken about the strucutre,
so it should fail to match.
 2020-04-06 14:05:35 -04:00
Aaron Sikes
ecc8d0ee29 Add unit tests for json de/serialization. 
This tests enjs:format, dejs:format, dejs-soft:format,
en-json:html, and de-json:html.
 2020-04-06 13:35:21 -04:00
Michael Hartl
3e203634e3 Fix spelling of "existent" 2020-04-06 08:18:22 -07:00
édouard
6ed7520444 contributing.md: removed interface dev instructions from root-level doc, integrated into existing interface-specific doc 
I've moved the slightly edited interface development instructions from the root controbuting.md doc, over to the one located in pkg/interface. I've made sure to ensure any precvious information in the interface contributing doc has been matched or expanded upon in the new writing, which is a incrementally more thorough, and assumes a lower level of build-tooling knowledge.
 2020-04-03 15:37:42 -04:00
ixv
482e87f8fc
Merge pull request #2662 from urbit/la-app-hints 
apps: added hints to the top of many networked apps
 2020-04-03 10:22:23 -07:00
ixv
58b7f94e86
Merge pull request #2667 from urbit/la-chat-loading 
chat-js: transition to new chat upon chatSynced changing in join or new chat screen
 2020-04-03 10:21:36 -07:00
Matilde Park
e2cc01445b link: line up link info on same line height 2020-04-02 23:09:10 -04:00
Logan Allen
7eb499abda chat-js: transition to new chat upon chatSynced changing in join or new chat screen 2020-04-02 23:03:28 -04:00
ixv
118c20856d
Merge pull request #2666 from urbit/mp/publish-build 
publish: add rollupReplace to gulpfile
 2020-04-02 19:50:25 -07:00
Matilde Park
d943ed353e publish: add rollup-plugin-json to production imports 2020-04-02 22:46:12 -04:00
Matilde Park
f4c3b73346 publish: add rollupReplace to gulpfile 2020-04-02 22:33:04 -04:00
Isaac Visintainer
b5b19adb8c launch: handle change in url parsing 2020-04-02 19:01:36 -07:00
Fang
f494854dc0
Merge pull request #2641 from urbit/m/eth-watcher-timeout 
eth-watcher: separate timeout from refresh-rate
 2020-04-03 02:00:07 +02:00
Isaac Visintainer
5faaa6c710 release: urbit-os-v1.0.10 2020-04-02 15:54:24 -07:00
Isaac Visintainer
2ad8264c52 Merge branch 'philip/gall-clear' 2020-04-02 15:32:43 -07:00
ixv
35fa913113
Merge pull request #2661 from urbit/ed/groups-add-channel-icons 
groups: add channel type icons
 2020-04-02 15:30:13 -07:00
Matilde Park
e358c1dbfb Merge branch 'master' into mp/invites-to-group-filter 2020-04-02 18:25:59 -04:00
Matilde Park
e2c36cda0b publish: propagate meta key for comment posting 2020-04-02 18:20:20 -04:00
Matilde Park
e51bd46224 link: fix meta key propagation for comment posting 2020-04-02 18:20:15 -04:00
Matilde Park
d03dcd8289 groups: preload spinner asset 2020-04-02 18:19:50 -04:00
Matilde Park
c873c4d01b chat: add spinner component and behaviours 2020-04-02 18:19:50 -04:00
Matilde Park
afec74cb2e groups: add componentised spinner and behaviours 2020-04-02 18:19:48 -04:00
Matilde Park
48e65499e2 groups: set sigil color on blur, not automatically 2020-04-02 18:18:42 -04:00
Matilde Park
7dbd2a09f0 soto: fix purple back arrows 2020-04-02 18:18:40 -04:00
Matilde Park
d49ace002d soto: add componentised spinner 2020-04-02 18:18:14 -04:00
Matilde Park
1bc973c520 link: reimplement spinner as component 2020-04-02 18:18:10 -04:00
Matilde Park
ef69ad6853 link: fix api call to change description 
When changing description, some pre-metadata refactors were resulting in
permanently broken calls to the API. This accesses our resource object
correctly.
 2020-04-02 18:17:12 -04:00
Matilde Park
6e0a29b79d links: move 'mark all as seen' to settings 2020-04-02 18:17:11 -04:00
Matilde Park
93587dd84d links: show pending comments 2020-04-02 18:17:11 -04:00
Matilde Park
48c9bdc702 publish: componentise spinner as part of layout 
This commit pulls the spinner out of the header bar -- and
reincorporates it as a component that hooks into local state when
awaiting a new prop, or disabling an input.
 2020-04-02 18:17:11 -04:00
Matilde Park
a21294f02e publish: atomically refresh our settings inputs 
Before, when we got new props for the metadata of the notebook, all the
fields would flash blank or to previous inputs. This rewrites the
update function to be more atomic with how it edits state,
which seems to correct the behaviour to avoid blank fields and disable fields
correctly.
 2020-04-02 18:17:11 -04:00
édouard
4cd7c77ad3 groups: add channel type icons 
Adding three new icons for group channels (as seen in the groups view)
 2020-04-02 18:15:51 -04:00
Logan Allen
99878eb65d apps: added hints to the top of many networked apps 2020-04-02 17:49:46 -04:00
Logan Allen
717b02ad6f chat: added jet hints 2020-04-02 17:43:03 -04:00
Matilde Park
c91ec10e78 link: fix skeleton border css class 2020-04-02 16:46:21 -04:00
Matilde Park
7cde503f80 groups: fix skeleton css 2020-04-02 16:43:33 -04:00
Matilde Park
06cf5a0ce6 group filter: enumerate and show invites correctly 2020-04-02 16:36:50 -04:00
Matilde Park
d8fbd75dbf launch: pass invites correctly to group filter 2020-04-02 16:36:50 -04:00
Matilde Park
f4c63b25c6 publish: pass invites to group filter 2020-04-02 16:36:50 -04:00
Matilde Park
0aff179e71 groups: pass invites to group filter 2020-04-02 16:36:50 -04:00
Matilde Park
8a43f7fc44 link: pass "/contacts" to group-filter 2020-04-02 16:36:50 -04:00
Matilde Park
a500038bed chat: pass full invites object 2020-04-02 16:36:41 -04:00
Fang
0578dc5643
Merge pull request #2658 from urbit/mp/invite-search-lenience 
invite search: avoid crashing with no associations
 2020-04-02 21:25:09 +02:00
Matilde Park
65f8991ac8 invite search: avoid crashing with no associations 
By using an array, not a set, we stop deduplicating our group index,
pushing redundant information instead. When searching, this prevents a
component fail state where it cannot search a non-existent index for
matches.
 2020-04-02 14:50:29 -04:00
Fang
ca4a5af4e3
Merge pull request #2656 from urbit/m/url-segments 
zuse: allow empty segments in de-purl url parsing
 2020-04-02 20:47:30 +02:00
ixv
1d59ca7a16
Merge pull request #2640 from urbit/mp/groupify-2-dms-below 
chat: DMs repositioned below grouped chats
 2020-04-02 10:48:25 -07:00
ixv
75922dd017
Merge pull request #2654 from urbit/mp/ctrl-enter 
link, publish: submit comment on ctrl+enter
 2020-04-02 07:34:47 -07:00
ixv
d61c2831e8
Merge pull request #2637 from urbit/mp/new-ui-dark-header 
os1: add dark mode style for app name in headers
 2020-04-02 07:25:35 -07:00
ixv
275b0e65c5
Merge pull request #2652 from urbit/scrollback-fix-2 
chat-js: fix scrollback for small chat channels
 2020-04-02 07:23:59 -07:00
Isaac Visintainer
0eebd0a579 undo js build 2020-04-02 07:21:46 -07:00
ixv
f6954e6a55
Merge pull request #2644 from urbit/mp/group-typing 
groups: show tile icon, not full color; alphabetically sort group channels
 2020-04-02 07:18:05 -07:00
ixv
42f9fa4f8b
Merge pull request #2642 from urbit/mp/new-borders 
os1: skeleton uses b--gray4, not b--gray2
 2020-04-02 07:17:50 -07:00
ixv
d1a440fab9
Merge pull request #2636 from liam-fitzgerald/lf/dojo-gen-autocomplete 
dojo: add autocomplete for various dojo syntaxes
 2020-04-02 07:17:02 -07:00
ixv
e2022ed3a6
Merge pull request #2619 from liam-fitzgerald/lf/who-endpoint 
/who JSON endpoint
 2020-04-02 07:16:50 -07:00
Fang
d1894cdbe6
zuse: allow empty segments in de-purl url parsing 
RFC 2396 specifies that segments must be zero or more pchars.[1] We were
deviating from this by requiring at least one pchar per segment.

With this change, we support /some//path, and no longer lose the
trailing slash in /some/path/.

[1]: https://tools.ietf.org/html/rfc2396#section-3.3
 2020-04-02 14:44:45 +02:00
Matilde Park
8bafdea10c links: submit comment on ctrl+enter 2020-04-01 22:36:11 -04:00
Matilde Park
7a796549bd publish: submit comment on ctrl+enter 2020-04-01 22:33:56 -04:00
Logan
0ce28806a9
Merge branch 'master' into matilde/interface-prod 2020-04-01 22:24:33 -04:00
Logan Allen
72fbe18aff chat-js: fix scrollback for small chat channels 2020-04-01 22:14:33 -04:00
Matilde Park
8c7898786e groups: add slight background overlay to channel tiles 2020-04-01 21:08:00 -04:00
Liam Fitzgerald
0115177eea launch: create new state-version for %serve 2020-04-02 09:12:39 +10:00
Liam Fitzgerald
ed7d9fb164 launch: move %serve card to types core 2020-04-02 08:52:59 +10:00
Liam Fitzgerald
eeebfc0114 launch: address review comments for /who endpoint 2020-04-02 08:50:01 +10:00
Matilde Park
e5c7539106 chat: sort DMs by most recent, sort grouped by alphabetical 2020-04-01 18:18:56 -04:00
Liam Fitzgerald
253187001b launch: add CORS headers to /who endpoint 
Necessary to allow bridge to make a cross-origin request via
javascript.
 2020-04-02 08:16:10 +10:00
Liam Fitzgerald
e16c999c76 launch: add /who endpoint 
The /who endpoint responds with the name of the ship in JSON
 2020-04-02 08:16:08 +10:00
Fang
809befb6fc
clock: ensure launch is listening correctly 
In the wild, ships that were live pre-OS1 still had launch subscriptions
open to the clock on the /tile path, instead of the currently-used
/clocktile path. Additionally, launch state for the clock tile seemed
incomplete.

Here, we simply re-%add the clock to launch.

Note that launch currently does not clean up old subscriptions on
path change. For the pre-OS1 case, the old path is no longer in use,
rendering the subscription harmless. For cases where the correct
subscription was already in place, it'll print a %watch-wire-not-unique,
but doesn't do any harm besides that.
 2020-04-01 23:13:57 +02:00
Fang
b62105cce4
clock: add dbug 2020-04-01 22:26:07 +02:00
Fang
6fef6a996a
weather: add verb 2020-04-01 22:25:54 +02:00
Matilde Park
e70643b44d groups: default to coloured tile if unknown app 2020-04-01 15:46:59 -04:00
Matilde Park
e1af036f1c groups: show tile icon, not full color 2020-04-01 15:26:47 -04:00
Matilde Park
922318e072 os1: skeleton uses b--gray4, not b--gray2 2020-04-01 12:06:36 -04:00
Fang
2223a85666
eth-watcher: separate timeout from refresh-rate 
Previously, when the refresh-rate timer activated, and the thread from
the previous activation was still running, we would kill it and start
a new one. For low refresh rates, on slower machines, nodes, or network
connections, this could cause the update to never conclude.

Here we add a timeout-time to eth-watcher's config. If the refresh-rate
timer activates, and a thread exists, but hasn't been running for at
least the specified timeout-time yet, we simply take no action, and wait
for the next refresh timer.

Note that we opted for "at least timeout-time", instead of killing &
restarting directly after the specified timeout-time has passed, to
avoid having to handle an extra timer flow.

In the +on-load logic, we configure the timeout-time for existing
watchdogs as six times the refresh-rate. We want to set
azimuth-tracker's timeout-time to ~m30, and don't care much about other,
less-likely-to-be-active use cases of eth-watcher.
 2020-04-01 12:47:38 +02:00
Matilde Park
04b3a2a8cf chat: DMs repositioned below grouped chats 2020-04-01 01:07:32 -04:00
Matilde Park
0c87c2c186 link, publish: fix sidebar for multi-item groups 
A syntax typo led the array for nested notebooks to not have paths
pushed into it. Only the last item in the group would be pushed into the
array. This commit fixes that typo.
 2020-04-01 00:53:49 -04:00
Liam Fitzgerald
4433b99011 dojo: change autocomplete to use sell 
Change autocomplete to prettyprint variables with sell instead of
xsell
 2020-04-01 14:22:04 +10:00
Liam Fitzgerald
ff8c7a61d5 dojo: fix hood shortcut 2020-04-01 12:29:14 +10:00
Matilde Park
bfeb481b80 os1: add dark mode style for app name in headers 2020-03-31 22:01:08 -04:00
Liam Fitzgerald
ed7f8be424 dojo: add autocomplete for various dojo syntaxes 
Adds autocomplete for
- :app poke syntax
- :app|gen poke generator syntax
- +gen naked generator syntax
- =var variable syntax
 2020-04-01 11:28:27 +10:00
Isaac Visintainer
93c881cec9 release: urbit-os-v1.0.9 2020-03-31 16:45:40 -07:00
ixv
e76fe83ea1
Merge pull request #2615 from urbit/mp/grouping-take-2 
os1: reintegrating groups into all Landscape applications
 2020-03-31 15:17:57 -07:00
ixv
5791f8b86d
Merge pull request #2630 from urbit/mp/chat/fix-settings-invitesearch 
chat: settings pass 'groups' prop from permissions
 2020-03-31 14:18:25 -07:00
édouard
d40ce1a233 Merge branch 'mp/grouping-take-2' of https://github.com/urbit/urbit into mp/grouping-take-2 2020-03-31 17:18:22 -04:00
ixv
e5c06f2549
Merge pull request #2632 from liam-fitzgerald/lf/patp-validate 
various: bump urbit-ob version
 2020-03-31 14:18:10 -07:00
édouard
9851b58d1c os1: numerous cross-module padding changes 
Across every OS1 module (including the launch/home screen context) I edited some padding/margin/sizing for navigational elements for consistency across paging.
 2020-03-31 17:18:09 -04:00
ixv
a14fbc1eb8
Merge pull request #2633 from urbit/philip/clay-dec 
clay: don't underflow when patch produces empty file
 2020-03-31 14:17:42 -07:00
Isaac Visintainer
64a6e89be6 launch: remove groups tile here rather than in contact-view 2020-03-31 11:49:57 -07:00
Philip Monk
5a4786169d
clay: don't underflow when patch produces empty file 
Fixes #2602

I haven't been able to reproduce this bug, but I can see how it could
happen in theory.  This should resolve the issue.
 2020-03-31 11:37:58 -07:00
Matilde Park
25e279ed82 chat, launch: style fixes post-#2615 code review 2020-03-31 14:03:12 -04:00
Liam Fitzgerald
81efbd1357 various: bump urbit-ob version 
The new version of urbit-ob includes stricter isValidPatp checks.

Fixes #2556
 2020-04-01 03:32:57 +10:00
Fang
56df6dc94f
link-listen-hook: recover neglected collections 
During the #2607 upgrade, strictly local collections got left out of the
listening set. (Because they did not have any outgoing subscriptions.)
This led to personal collections not being available on the frontend.

Here, we add upgrade logic for adding those back to our listening set again.
If a user had explicitly left a personal collection (instead of deleted it, for
whatever reason), they will have to leave it again. This case seems much more
rare than the "my collection is gone" one.
 2020-03-31 19:10:07 +02:00
Matilde Park
23ca02dd38 chat: settings pass 'groups' prop from permissions 2020-03-31 11:50:37 -04:00
Isaac Visintainer
12f150659b release: urbit-os-v1.0.8 2020-03-30 20:28:35 -07:00
ixv
c0b4de176a
Merge pull request #2627 from urbit/mp/publish/dark-syntax 
publish: dark mode syntax css
 2020-03-30 19:39:43 -07:00
ixv
31794ebacf
Merge pull request #2609 from urbit/m/group-kick-fix 
group-hook: fix resubscribe bug
 2020-03-30 17:59:51 -07:00
ixv
8f1655171d
Merge pull request #2616 from urbit/two-round 
chat-js: improve subscription speed by doing two rounds of subscriptions and no longer subscribing to groups
 2020-03-30 17:48:39 -07:00
ixv
d27329c45d
Merge pull request #2626 from lukechampine/patch-1 
eyre: Remove leading sig from password placeholder
 2020-03-30 17:48:13 -07:00
ixv
f98557aba9
Merge pull request #2617 from urbit/channel-caching 
apps: added a duplicate channel.js for caching, updated script tags to point to it
 2020-03-30 17:47:52 -07:00
Matilde Park
34528ff3d8 publish: dark mode syntax css 2020-03-30 18:31:58 -04:00
Logan Allen
49476aac66 chat-js: refactored subscriptions to auto-resubscribe 2020-03-30 18:07:33 -04:00
Logan Allen
c2070dbcc6 chat-js: pass in groups property, convert from permissions 2020-03-30 17:59:52 -04:00
Matilde Park
57d3f5327d os1: store.selected -> store.selectedGroups 2020-03-30 16:45:34 -04:00
Matilde Park
660cabf074 launch: link color unsetting agnostically 2020-03-30 15:57:09 -04:00
matildepark
2f3d681975
launch, link: apply @Fang- suggestions to #2615 review 
Co-Authored-By: Fang <git@fang.io>
 2020-03-30 15:50:16 -04:00
Luke Champine
b3d78b5d71
eyre: Remove leading sig from password placeholder 2020-03-30 13:32:21 -04:00
Fang
87e61da99a
lib: !. on dbug and verb wrapper agent cores 
Events always pass through these, adding to the stack trace on-crash.
This information is practically never useful, however. Adding !. leaves
these cores out of the traces.
 2020-03-28 13:26:56 +01:00
Logan Allen
f1a0b30c1f apps: added a duplicate channel.js for caching, updated script tags to point to it 2020-03-27 20:08:44 -04:00
Isaac Visintainer
6443424012 contact-view: remove tile 2020-03-27 14:18:03 -07:00
Matilde Park
1c45d4c46c publish: handle 'no notebooks' case 2020-03-27 16:44:15 -04:00
Matilde Park
952ea831d9 chat: handle 'no chats' case 2020-03-27 16:42:29 -04:00
Matilde Park
5b6902e065 soto: update header bar 2020-03-27 16:30:17 -04:00
Matilde Park
003089bf11 soto: add %add launch-action 2020-03-27 15:30:55 -04:00
Matilde Park
21c989fee1 publish: incorporate group filter component 2020-03-27 15:09:27 -04:00
Matilde Park
9cb90405c1 link: incorporate group filter component 2020-03-27 14:57:25 -04:00
Matilde Park
8335ae059c groups: incorporate group filter component 2020-03-27 14:39:01 -04:00
Matilde Park
612a88272f chat: incorporate group filter component 2020-03-27 14:26:23 -04:00
David Kerschner
eeacf4543f removed gen/ph per @philipcmonk 2020-03-27 10:06:27 -07:00
David Kerschner
12662675f4
Update pkg/arvo/gen/azimuth-tracker/watch.hoon 
Co-Authored-By: Philip Monk <phil@pcmonk.me>
 2020-03-27 10:04:31 -07:00
David Kerschner
290ce453eb
Update pkg/arvo/gen/aqua/pill.hoon 
Co-Authored-By: Philip Monk <phil@pcmonk.me>
 2020-03-27 10:04:25 -07:00
Matilde Park
891018159a launch: add group filter dropdown, header redesign 2020-03-27 12:45:51 -04:00
Matilde Park
09eec6ea65 launch: prevent dismissed welcome affecting mobile 
Flexbox would provide the empty <div> some space in our mobile layout.
This replaces the div with null.
 2020-03-27 12:45:51 -04:00
Matilde Park
744dc47be9 link: sidebar redesign with grouped collections 2020-03-27 12:45:51 -04:00
Matilde Park
e7a29dc628 publish: sidebar redesign with grouped notebooks 2020-03-27 12:45:49 -04:00