urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2024-12-20 17:32:11 +03:00
Code Issues Packages Projects Releases Wiki Activity
23,888 Commits 768 Branches 10 Tags 215 MiB
c1b259af5b
Commit Graph

2736 Commits

Author SHA1 Message Date
J
c1b259af5b interface, gcp: don't spam the console with 500s 
Options here were: make the get-token thread try to return a unit, or
write a different thread to check whether GCP Storage seemed to be
configured and poll on that thread, or move the whole thing into a Gall
app.

The compromise between time-to-implement and overall cleanliness seemed
to be to write a different thread that just checks whether the settings
fields have been poked. Unfortunately this means GcpManager is now a
somewhat hefty JavaScript state machine.

Took out the logic to check whether S3 was configured in GcpManager,
since it was really only there to prevent spamming the console with
500s. If you have both S3 and GCP Storage configured for some reason,
you will now use GCP per the logic in useStorage.
 2021-02-26 23:42:57 +00:00
J
040d8c06ae interface: fix S3 canUpload logic 
s3.credentials is always set, but the fields are all '' if s3 is not
configured. So prior to this change, if the user had configured an
active bucket, they would always be shown an upload dialog even if they
had no storage configured.
 2021-02-26 22:12:52 +00:00
J
347d51fde9 interface: cleaner API, robust GcpManager retry 
GcpApi now acts like other APIs.

Since GcpManager can no longer get at the token exipry by inspecting the
raw update, it must depend on the global store instead. This also means
it can check whether the user has configured S3, and not try to refresh
the token in that case.

In the case where no storage is configured, this will spam the console
with request failures since the thread returns 500 if there is no token.
Perhaps this is a good argument for making  the thread return a unit.
 2021-02-26 22:10:15 +00:00
J
723a5a050e interface: check accessKey !== undefined 
Also make it type-level optional rather than using explicit null.

Perhaps one day we will want to use undefined to denote "the thread
hasn't returned yet" and null for "GCP Storage is not configured."
Perhaps.
 2021-02-26 20:29:05 +00:00
J
6b3397bd9f interface: supports both S3 and GCP Storage 
The S3 client has another layer of indirection we missed. To support it
expediently, we just make the promise() method on GcpUpload do all the
work in GcpClient.
 2021-02-26 20:18:40 +00:00
J
6ec574d32b interface: GcpManager fixes 2021-02-26 20:18:07 +00:00
J
92dd46b176 GcpClient: remove unused BASE_URL 2021-02-26 00:49:57 +00:00
J
1c0d8e524e interface: thread gcp through props 
Basically just a grep for 's3', and I added gcp wherever it looked like
I ought to.
 2021-02-26 00:38:01 +00:00
J
11a58115b0 interface: implement useStorage and withStorage 
useS3 and withS3 are now gone. Storage should work with both GCP and S3,
preferring GCP if available and falling back.
 2021-02-26 00:07:15 +00:00
J
4814d61c48 interface: unnecessary const 2021-02-25 23:08:41 +00:00
J
a6d4c3a431 interface: proof-of-concept GCP upload 
As of this commit, the Links app uploads files to GCP storage.

(Note that it no longer uploads to S3. Still need to support both.)
 2021-02-25 22:52:18 +00:00
J
c718894eb3 interface: explicitly depend on querystring 
It will be used by GcpClient.
 2021-02-25 22:50:50 +00:00
J
efea38f842 interface: GcpReducer 
Now we are correctly storing the GCP accessKey in state.
 2021-02-25 00:41:47 +00:00
J
9fa086e0d3 interface: extract GcpManager 
Now the API is just an API. (I did still have it produce an expiry time,
since it makes the refresh loop easier to do.)

Not yet storing the token now.
 2021-02-25 00:31:39 +00:00
J
3c2ce636e7 interface: storing the gcp token 2021-02-25 00:31:16 +00:00
J
a80c3504a8 interface: refresh loop 
Still not actually storing the token anywhere...
 2021-02-24 21:22:28 +00:00
J
94556ce936 interface: GCP skeleton 2021-02-24 20:42:57 +00:00
Liam Fitzgerald
38dcd49630
Merge branch 'lf/dropdown-bubbling' into release/hot-21-2-17 2021-02-17 14:29:22 +10:00
Liam Fitzgerald
b6513d7f49
Merge branch 'lf/landscape-fixesx' into release/hot-21-2-17 2021-02-17 14:28:53 +10:00
Liam Fitzgerald
57dfc24882
AddChannel: fix sig mismatch 2021-02-17 11:36:00 +10:00
matildepark
319efc829c
Merge pull request #4447 from urbit/mp/links/add-import 
LinkWindow: add missing 'text' import
 2021-02-16 16:41:22 -05:00
Matilde Park
240e9b5c5c chat: render all code output, not just first line 2021-02-16 15:35:47 -05:00
matildepark
31e97a368a
Merge pull request #4397 from urbit/lf/markdown-linebreaks 
TextContent: handle linebreaks before feeding parsing
 2021-02-16 15:04:35 -05:00
Matilde Park
c7d818ab49 LinkWindow: add missing 'text' import 
Fixes urbit/landscape#433
 2021-02-16 14:56:24 -05:00
Liam Fitzgerald
3548c984a9
Dropdown: fix event propagation 
Fixes urbit/landscape#427
 2021-02-16 13:04:12 +10:00
Liam Fitzgerald
899ead25fb
hark-store: give %read-all fact 
Fixes urbit/landscape#402
 2021-02-16 12:29:17 +10:00
Liam Fitzgerald
a9d2381d0e
SidebarListHeader: look in %groups not %contacts assocs 
Fixes urbit/landscape#405
 2021-02-16 12:29:17 +10:00
Liam Fitzgerald
ba57ad2222
AddGroup: fix activation from leap 
Fixes urbit/landscape#439
 2021-02-16 12:29:17 +10:00
Matilde Park
a91f96751b invite: prevent interface crash 
We're accessing invite.ship when we don't have invite. This stubs that
out.
 2021-02-12 22:37:12 -05:00
Matilde Park
115dacfeec statusbar: fix flexing on dev stream mobile 2021-02-12 17:26:08 -05:00
Matilde Park
5b636b7bef profile: pad foreign statuses 
Fixes urbit/landscape#413
 2021-02-12 17:15:11 -05:00
Matilde Park
57f8963b36 meta: revert ba839646c8 2021-02-12 17:08:43 -05:00
Matilde Park
8f0b8b2101 profile: linkify statuses 
Also fixes an unfiled bug where disableRemoteContent was ignored

Fixes urbit/landscape#418
 2021-02-12 16:42:34 -05:00
Matilde Park
ec702d43a0 profile: force status to flush right on view 2021-02-12 16:28:25 -05:00
Matilde Park
5b62417e49 groups: pass new contacts obj, fix pending 
Also uncovers why pending array wasn't matching.

Fixes urbit/landscape#422
Fixes urbit/landscape#312
 2021-02-12 16:24:46 -05:00
Matilde Park
6c2d935913 NewChannel: redirect DM creation from DM routes 
We were redirecting based on our parent path, so if we were in a DM
while making a DM, we used that DM as our parent path.

Fixes urbit/landscape#421
 2021-02-12 14:39:23 -05:00
Matilde Park
5db4c1307b invites: redirect multiple member DMs to messages 2021-02-12 14:30:24 -05:00
Logan Allen
144178165c interface: simplify edit reducer 2021-02-12 12:02:52 -06:00
Logan Allen
1c4baea62f interface: profiles would intermittently show contact information when they should not, fixes this 2021-02-12 11:48:50 -06:00
Matilde Park
63cfde673b SetStatusBarModal: prevent flexShrink on mobile 2021-02-11 21:02:40 -05:00
Matilde Park
e868ea2db2 StatusBar: prevent sigil flexing offscreen 2021-02-11 20:34:34 -05:00
Liam Fitzgerald
850d78af56
Merge remote-tracking branch 'origin/la/work' 2021-02-12 11:01:52 +10:00
Liam Fitzgerald
cefa80cee5
Omnibox: Add Messages to results 2021-02-12 11:00:24 +10:00
Liam Fitzgerald
eb082decf3
ImageInput: mark explicitly as type="button" 2021-02-12 10:55:17 +10:00
Logan Allen
1ddf9f5b84 contact-store: set last-updated appropriately and send last-updated in JS 2021-02-11 18:47:36 -06:00
Matilde Park
34a9d9660f profile: safely access status 2021-02-11 18:58:39 -05:00
Matilde Park
d197a0e766 chat: wrap chatWindow in position='relative' 
Fixes the banner overlapping the share banner.
 2021-02-11 18:38:40 -05:00
ixv
a4f14119e2
Merge pull request #4418 from urbit/lf/disable-tutorila 
Tutorial: disable
 2021-02-11 14:19:00 -08:00
Liam Fitzgerald
a8f560f952
Tutorial: disable 2021-02-12 08:04:22 +10:00
Matilde Park
ab114980ec Profile: amend design 2021-02-11 17:02:30 -05:00