Commit Graph

30674 Commits

Author SHA1 Message Date
fang
07c32ae701
Merge pull request #5962 from urbit/m/gall-lying-is-bad-kids
gall: don't inject potentially-fake acks
2022-08-19 23:20:56 +02:00
Philip Monk
ca0a00cb3c Merge remote-tracking branch 'origin/master' into philip/snap 2022-08-19 12:37:25 -08:00
fang
8108595b2b
gall: don't inject potentially-fake acks
We shouldn't be hitting this case anymore. Injecting events into agents
which they might not expect, and might not even be real, is bad.
2022-08-19 21:39:44 +02:00
fang
59f0556e3b
Merge pull request #5958 from urbit/ted/rake
gall: %rake task to clean up dead %leave's
2022-08-19 21:29:08 +02:00
fang
de6f525f02
Merge pull request #5956 from urbit/ted/gen-ames-flows
+ames-flows: diagnostic generator to count ames flows
2022-08-19 21:23:38 +02:00
fang
a79f2f27e5
Merge pull request #5961 from urbit/m/ames-stir-thoroughly
ames: don't skip closing flows in +on-stir
2022-08-19 21:22:49 +02:00
fang
a9a8619daa
Merge pull request #5947 from urbit/ted/staying-alive-rebase
gall: revive %hood and %dojo on keypress
2022-08-19 21:22:28 +02:00
fang
fc019157b8
Merge branch 'master' into next/arvo 2022-08-19 21:21:38 +02:00
fang
01694444a7
Merge pull request #5960 from urbit/m/gall-outstanding-cork
gall: when kicked, register %cork as outstanding
2022-08-19 20:29:47 +02:00
fang
ce2e433a8a
ames: don't skip closing flows in +on-stir
Yes, there is a global timer for closing flows, but all that does is
enqueue a cork message. +on-stir needs to set _pump_ timers for all
flows that might still have messages to send, which includes closing
flows.
2022-08-19 20:26:08 +02:00
fang
cfa18b1f1f
gall: when kicked, register %cork as outstanding
When ames notifies us that our subscription has been kicked, we enqueue
a cork to clean up the flow. Unlike the %leave case, however, we were
not registering the cork in the queue of outstanding comms. We would
eventually get an ack, but not know what for, and erroneously inject
%poke-acks and %watch-acks.

Here we simply add a %cork entry to the queue before sending it.
2022-08-19 16:04:36 +02:00
fang
c8a163fedb
gall: clean up big wire construction 2022-08-18 22:46:58 +02:00
fang
a5335f5851
gall: improve match detection in +ap-rake
Making sure to stringify the nonce and including all the target details in the
wire, and excluding flows that are already closing.
2022-08-18 22:39:54 +02:00
fang
f0620b145b
ames-flows: more fine-grained open flow counting 2022-08-18 22:24:20 +02:00
Ted Blackman
d8df2787a0 gall: %rake task to clean up dead %leave's 2022-08-18 20:34:42 +03:00
tacryt-socryp
07ae55a16b
Merge pull request #5955 from hosted-fornet/hf/agentio-typo
agentio: fix `+rest` typo, attempt 2
2022-08-18 09:20:17 -05:00
Tinnus Napbus
4016211bc0 -dns-address: fix wire mismatch 2022-08-18 23:22:57 +12:00
Ted Blackman
82aea06c02 +ames-flows: diagnostic generator to count ames flows 2022-08-18 12:40:49 +03:00
hosted-fornet
00dc78402a agentio: fix +rest typo 2022-08-17 18:08:37 -07:00
Pyry Kovanen
3135eb6137
dns-address: subscribe before poke 2022-08-17 14:08:33 +03:00
fang
b4331d564e
Merge pull request #5949 from urbit/m/gall-redoff
gall: re-enable doff, only for old-style subs
2022-08-17 10:39:31 +02:00
fang
a10fa82c39
Merge pull request #5950 from urbit/m/gall-nonces-generator
gen: add +gall-nonces for reading all next nonces
2022-08-17 10:39:16 +02:00
Philip Monk
50c22343b6 clay: wip 2022-08-16 20:33:25 -08:00
fang
497d790e59
gen: remove printf from +gall-nonces 2022-08-16 23:53:18 +02:00
fang
24cf4497e9
gen: add +gall-nonces for reading all next nonces 2022-08-16 23:24:32 +02:00
fang
18019d6d83
gall: re-enable doff, only for old-style subs
This is sufficient to bring the normal (non-prerelease-bugged) cases
into the new world.

For the prerelease ships that ran a buggier version of the new gall
subscription logic, we note that the conditional may trigger for the
nonce=1 case where it had already triggered for their
(shouldn't-be-possible) nonce=0 case. This results in a %leave on a wire
that wasn't in use. This no-ops on the publisher side though, and the
flow gets corked right away, so this is considered harmless.
2022-08-16 23:02:59 +02:00
Ted Blackman
c972c0fbe2 gall: roundtrip through arvo to revive %hood and %dojo 2022-08-16 01:37:35 +03:00
Ted Blackman
95580f7e83 gall: revive %hood and %dojo on poke 2022-08-16 00:40:38 +03:00
Ted Blackman
a70c2ffe1a gall: now restarts %hood, but not %dojo yet 2022-08-16 00:40:38 +03:00
Ted Blackman
ac072729c2 gall: force load %hood and %dojo on poke 2022-08-16 00:40:38 +03:00
fang
81f18d13ad
gall: remove outdated fixme comment
This is part of the %doff work, which is getting integrated elsewhere.
2022-08-15 12:24:18 +02:00
fang
5e43a9de56
Merge pull request #5941 from urbit/ted/nodoff
gall: disable %doff for now
2022-08-12 19:57:22 +02:00
fang
68ec0a5aee
Merge pull request #5942 from urbit/jb/ames-timers
base: adds generator for getting %ames timer counts
2022-08-12 19:55:58 +02:00
Joe Bryan
205b5013e4 base: adds generator for getting %ames timer counts 2022-08-11 21:45:09 -04:00
Ted Blackman
1898483a45 gall: disable %doff for now 2022-08-12 00:55:19 +03:00
fang
b07b8a4ec1
Merge pull request #5938 from urbit/ted/gall-scry-for-nonces
gall: scry for nonces
2022-08-11 22:55:33 +02:00
Ted Blackman
b1bab79f58 gall: add %f scry for sub-nonce's 2022-08-11 22:33:57 +03:00
Ted Blackman
7f35429e22
Merge pull request #5937 from urbit/ted/grq-test
ames: fix comet test
2022-08-11 22:27:15 +03:00
Ted Blackman
6b43d30d3d
Merge pull request #5934 from urbit/ted/doff-6
gall: kill old subscriptions on %doff
2022-08-11 22:26:19 +03:00
fang
350f33d6ba
Merge branch 'next/arvo' into ted/doff-6 2022-08-11 21:06:30 +02:00
Ted Blackman
91d6956388 tests: fix ames comet test 2022-08-11 20:49:09 +03:00
fang
5b4a964cdf
gall: fix the %doff conditional
No comment.
2022-08-11 19:48:27 +02:00
fang
3bbe0436d8
Merge pull request #5936 from urbit/m/gall-sys-wire
gall: use a fully-formed wire when sending %cork
2022-08-11 17:12:52 +02:00
fang
06b7f52755
gall: print less during %doff 2022-08-11 17:04:44 +02:00
fang
cd0ea06ad4
gall: use a fully-formed wire when sending %cork
In response to clog notification from remote ames, we were sending a
%cork to clean up the flow. However, the wire we were using had the /sys
prefix already stripped off. Here, we put it back in.
2022-08-11 16:53:45 +02:00
fang
39cd895a55
gall: in +ap-doff, process oldest subs first
Start by killing subscription nonce 0, then work our way up instead of
down. We enhance the printf with a "total nonces" indicator so we can
still easily see the progress being made.
2022-08-10 22:51:38 +02:00
fang
8033fe760e
doff: improve generator interface slightly
No longer need to give units as named arguments, instead just the bare
values. The defaults get recognized as the "no filter" case.
2022-08-10 22:51:36 +02:00
fang
2fe27bd8d7
gall: simplify +ap-doff filter conditional 2022-08-10 22:25:01 +02:00
fang
04b7b86cae
gall: support %doff-ing specific apps and/or ships
This gives us more control over exactly which subscriptions get culled,
which is useful in debugging and targetted recovery scenarios.
2022-08-10 20:33:07 +02:00
Ted Blackman
6b836bb56d ames: fix no-op for messages on closing bones 2022-08-10 20:18:57 +03:00