Commit Graph

2151 Commits

Author SHA1 Message Date
Liam Fitzgerald
c925665cb8 drum: address review comments 2020-04-28 12:20:59 +10:00
Liam Fitzgerald
5f4fc28bc9 chat: improve namespacing of chat-* types
Improved the namespacing by dropping the app prefix on types, e.g.
chat-hook-action -> action. Compensated for shadowing by importing the
/sur files behind a face. End result is that a chat-hook-action becomes
an action:hook. Splits chat-json into lib/chat-{hook,store,view}. Uses
^? on changes files in /lib and /sur to discourage deeply nested
importing.
2020-04-28 12:01:13 +10:00
Logan Allen
003c4676b1 hood: added version %4 of hood state 2020-04-27 18:28:31 -04:00
Logan Allen
9b4f070f3e s3: style cleanup, response to comments 2020-04-27 15:31:04 -04:00
Logan Allen
28c707b300 hood: updated drum to version %3 2020-04-27 15:12:51 -04:00
Logan Allen
d2e2590cce chat-js: implemented S3 image upload 2020-04-27 15:02:48 -04:00
Logan Allen
7beb575551 groups: fixed error states and visual styling around image upload 2020-04-27 14:47:55 -04:00
Liam Fitzgerald
37cd90a42b drum: sort cli connections
Sorts cli connections so that the user always boots into %dojo
regardless of their @p

Fixes: #2248
2020-04-25 07:21:41 +10:00
Liam Fitzgerald
2e3947e3c0 drum: account for app dependencies on boot
Changes drum's boot order to be deterministic regardless of the ship
you're on.

Fixes #2681
2020-04-25 07:20:42 +10:00
Logan Allen
ff313fb720 groups-js: initial s3 work 2020-04-24 12:19:01 -04:00
Logan Allen
9c6cb61d61 s3: got tests passing and added the rest of the generators 2020-04-24 12:19:01 -04:00
Logan Allen
285f0bd5e3 s3: integrated with store and reducers 2020-04-24 12:19:01 -04:00
Logan Allen
bec650957c s3: added configuration settings for setting current bucket and adding / removing buckets from list 2020-04-24 12:19:01 -04:00
Logan Allen
ab3a759ce2 s3-store: poke functionality, updated credentials, added generators 2020-04-24 12:19:01 -04:00
Logan Allen
daf32fd0f9 s3-store: initial commit 2020-04-24 12:19:01 -04:00
Jared Tobin
0bcd971c5f
release: urbit-os-v1.0.14.rc1 2020-04-24 12:15:39 +04:00
Logan Allen
d29ea5703e channel-js: fixed long-standing issue with subscription errors not being propagated 2020-04-23 16:51:53 -04:00
Liam Fitzgerald
ec03c29b72 chat-hook: fix variable name 2020-04-23 23:12:30 +10:00
Jared Tobin
413ae72164
Merge branch 'ted/sloe' (#2764)
* ted/sloe:
  pill: update solid
  fix +sloe for %hint'ed cores

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-23 15:05:57 +04:00
Fang
a810468dcf
Merge pull request #2777 from urbit/ixv/publish-groupify
publish: groupify notebooks
2020-04-23 02:00:24 +02:00
matildepark
5ccfd0537b
Merge pull request #2740 from liam-fitzgerald/lf/chat-group-autoleave
chat: leave chats associated with group on group leave
2020-04-22 18:41:10 -04:00
Isaac Visintainer
f46bc4b397 publish: addressed review, fixed issue with metadata 2020-04-22 15:14:24 -07:00
Logan Allen
c374e17ba5 contact-view: redirect upon url case of avatar 2020-04-22 18:08:59 -04:00
Logan
c36c5a9bd3
Merge branch 'master' into os1-avatar 2020-04-22 11:42:33 -04:00
Jared Tobin
5b9887ca19
Merge branch 'la-contact-delete-fix' (#2738)
* origin/la-contact-delete-fix:
  t groups + contacts: make removes completely clean up state
  contact-js: made channel handle onChannelError
  contact-hook: tested it, got /synced path working, and subscriptions loading
  contacts: fix group deletion and do some quality of life fixes

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-22 14:04:19 +04:00
Logan Allen
f6a2f7f83c contact: finish %octt implementation 2020-04-21 19:59:03 -04:00
Isaac Visintainer
49463197f5 publish: add groupify action 2020-04-21 14:34:40 -07:00
Logan Allen
2f7e8fd811 contacts: added "url" avatar support and finished "octet" avatar
fetching support
2020-04-21 15:29:47 -04:00
Logan Allen
6d4a694aeb t groups + contacts: make removes completely clean up state 2020-04-21 15:00:43 -04:00
Jared Tobin
358aa5025f
Merge branch 'liam-fitzgerald/lf/chat-markdown-input' (#2756)
* liam-fitzgerald/lf/chat-markdown-input:
  chat-js: revive # prefix for code messages
  chat-js: toggle code editor on icon click
  chat-js: disabled block level elements in messages
  chat-js: render markdown in messages
  chat-js: use CodeMirror for chat input
  chat-js: add CodeMirror dependency

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:06:18 +04:00
Jared Tobin
a9d10a5471
Merge branch 'liam-fitzgerald/lf/publish-del-edit' (#2734)
* liam-fitzgerald/lf/publish-del-edit:
  chat-fe: move cancel button below comment edit
  publish-js: lift editing state to comment list
  publish: fix check on edit-comment delta
  publish-js: avoid unnecessary scrollbars on note view
  publish-js: allow deletion and editing of comments
  publish: use @tas for comment ref in marks

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:05:57 +04:00
Liam Fitzgerald
4083af515e Merge branch 'master' into lf/chat-markdown-input 2020-04-21 13:56:30 +10:00
Liam Fitzgerald
a978ca2b5a chat: autoleave on watch-ack 2020-04-21 07:50:27 +10:00
Liam Fitzgerald
e21f9d772a chat: leave chats associated with group on group leave
When a group is left, the permissions no longer exist and the mailbox
subscription is kicked. Before attempting to resubscribe, we simply
check if we still have permissions and if not, leave the chat.
2020-04-21 07:47:48 +10:00
Jared Tobin
a2eaec6d6f
Merge branch 'm/link-perf' (#2728)
* origin/m/link-perf:
  link-listen-hook: partially revert 05e6519
  link fe: refactor message display into component
  link fe: more informative "empty list" display
  link-view: in pagination logic, only +lent once
  link: minimal initial view result
  link-view: add some hints to aid profiling

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-20 12:40:58 +04:00
Fang
dbc172af29
Merge pull request #2758 from urbit/m/chat-cli-order
chat-cli: account for reverse message ordering
2020-04-18 13:16:54 +02:00
Fang
0815c56d1d
Merge pull request #2746 from urbit/m/chat-hook-leave
chat-hook: on %remove, try our best to pull subs
2020-04-18 13:13:53 +02:00
Fang
9f42d420b3
chat-hook: remove incorrect comment
We do, in fact, use it. Implicitly, when reestablishing the subscription during
kick handling.
2020-04-18 13:13:08 +02:00
Ted Blackman
7b19580503 fix +sloe for %hint'ed cores 2020-04-18 02:11:34 -04:00
Liam Fitzgerald
4d118ce6c4 chat-js: revive # prefix for code messages 2020-04-18 15:10:19 +10:00
Fang
6f13546e2d
chat-cli: account for reverse message ordering
#2618 changed the way chat-store orders messages. We need to account for that
when processing/printing. This is the minimum viable fix.
2020-04-16 16:52:40 +02:00
Jared Tobin
18878727b0
Merge branch 'liam-fitzgerald/lf/links-autoleave' (#2754)
* liam-fitzgerald/lf/links-autoleave:
  link: leave collection on leaving associated group

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:54:32 +04:00
Liam Fitzgerald
a7a539bb24 link: leave collection on leaving associated group
Automatically leaves a collection when the user is removed from a group
2020-04-16 21:45:58 +10:00
Fang
4c4858f198
chat-hook: clarify backlog wire handling logic 2020-04-16 01:44:36 +02:00
Fang
d1feabd1fb
dbug: print result with priority
To give it some color, making it less easy to miss.
2020-04-15 23:50:53 +02:00
Fang
e2034eca19
dbug: avoid printing nothing at all
Previously, if filtering subscriptions turned up no results, nothing was
printed. With this change, we explicitly print "no matching subscriptions"
instead.
2020-04-15 22:28:59 +02:00
Fang
0f05ed3149
chat-hook: consistently pull backlog subs
We weren't accounting for backlog subscriptions with non-zero message
indexes in their wires. Now, we look through all of our outgoing
subscriptions to identify relevant backlog subscriptions, and leave all
of those.

The more proper fix here is to not include message indexes in the wire
in the first place, since we don't ever reuse that anywhere. But that's
a more invasive change, so we just leave a TODO for it instead.
2020-04-15 19:26:58 +02:00
Fang
084ce356a8
chat-hook: on %remove, try our best to pull subs
Previously, we were removing the relevant entry from the `synced` map
before calling `+pull-wire`, which requires an entry to still be there.
This lead to subscriptions not actually being pulled, commonly leading
to "subscribe wire not unique" errors on re-join.

In addition to fixing that, `%remove` actions now try to pull the
subscription regardless of whether they have an entry in the `synced`
map or not. `%leave` is always safe, and we might want to clean up
subscriptions that shouldn't be there anymore in the first place.
2020-04-15 16:29:26 +02:00
Liam Fitzgerald
963d04831d Merge branch 'master' into lf/publish-del-edit 2020-04-15 10:07:29 +10:00
Liam Fitzgerald
c46642af8d publish: fix check on edit-comment delta
An incorrect check caused comment editing to never be propagated.
2020-04-15 09:57:07 +10:00
ixv
b978d4f824
Merge pull request #2736 from urbit/ixv/fix-comment-grow
publish: fix bug in comment mark
2020-04-14 15:53:26 -07:00
Logan Allen
bfcaf6468e contact-hook: tested it, got /synced path working, and subscriptions loading 2020-04-14 18:05:32 -04:00
Logan Allen
b6e4566e61 contacts: fix group deletion and do some quality of life fixes 2020-04-14 21:33:01 +00:00
ixv
e5cf4fb813
Merge pull request #2720 from urbit/la-channel-err
channel.js: added way to handle event source errors more smoothly, and implemented in chat
2020-04-14 11:40:02 -07:00
Isaac Visintainer
113c86037c publish: fix bug in comment mark 2020-04-14 11:23:06 -07:00
Fang
7b5f7cde6b
link-listen-hook: partially revert 05e6519
We still want to auto-opt-in to new collections for _unmanaged groups_,
because we have no other way to join them.
2020-04-14 16:12:09 +02:00
Liam Fitzgerald
fa92d1cb7f publish: use @tas for comment ref in marks
Comment references in publish actions are @tas of a rendered @da. The
mark expected @da, causing a mismatch.
2020-04-14 20:15:57 +10:00
Isaac Visintainer
d8cdbfdeb8 release: urbit-os-v1.0.13 2020-04-13 19:26:13 -07:00
ixv
2c56937f0d
Merge pull request #2701 from lukechampine/syntax-error-src
ford: print source line on syntax error
2020-04-13 19:03:05 -07:00
ixv
228bee42e4
Merge pull request #2707 from urbit/ixv/cache-posts
publish: eagerly store your own changes
2020-04-13 16:54:41 -07:00
ixv
3526cfa4e6
Merge pull request #2618 from urbit/chat-reverse-messages
chat: reversed order that messages are stored in for faster performance
2020-04-13 16:54:16 -07:00
Isaac Visintainer
78023b8eff publish: ignore edit updates if they originated with us 2020-04-13 13:34:50 -07:00
Isaac Visintainer
7edcd65699 publish: add facilities for managing limbo state 2020-04-13 13:33:34 -07:00
Fang
4da0d636d3
link-view: in pagination logic, only +lent once
Also just use +swag instead of chaining +scag and +slag manually.
2020-04-13 21:26:44 +02:00
Fang
8f3d174c94
link: minimal initial view result
On initial load, instead of getting the first 25 links for every
collection, only get their totals and unread counts. This drastically
reduces the pageload time.

Updates the frontend to match:
- Handle initial results without link content.
- Dynamically load in collection's links, even for page 0.
2020-04-13 21:26:09 +02:00
Fang
bf42afbd56
link-view: add some hints to aid profiling 2020-04-13 21:15:51 +02:00
Jared Tobin
cc16e905af
Merge branch 'yosoyubik/apt-dup' (#2417)
* yosoyubik/apt-dup:
  hoon: +apt:by check for duplicate keys
2020-04-13 17:43:41 +04:00
Jared Tobin
bf78e71479
Merge branch 'courajs/json-unit-tests' (#1769)
* courajs/json-unit-tests:
  Change at:dejs-soft:format to reject too-long json arrays
  Add unit tests for json de/serialization.
2020-04-13 16:38:42 +04:00
Isaac Visintainer
2608dea563 publish: style changes and comments 2020-04-13 00:04:33 -07:00
Isaac Visintainer
d3ab26e57c publish: restore OS0 -> OS1 transition logic 2020-04-12 23:38:54 -07:00
Isaac Visintainer
a40d292bb7 publish: remove or add posts/comments from limbo depending on whether they succeeded or failed 2020-04-12 23:21:42 -07:00
Isaac Visintainer
d2fdae4d4b publish: immediately store post and comment changes 2020-04-12 23:21:42 -07:00
Isaac Visintainer
f9e17e61a2 publish: update state with limbo field 2020-04-12 23:21:42 -07:00
Logan Allen
fb3111e88a channel.js: added way to handle event source errors more smoothly, and implemented in chat 2020-04-10 19:38:13 -04:00
Logan Allen
8ffca926e7 chat-js: reverted built files 2020-04-10 17:34:23 -04:00
Logan Allen
6d1efde884 chat-js: fixed scrollback for reverse message chatrooms 2020-04-10 17:29:23 -04:00
Logan Allen
b85697cbec chat-hook: respect backlog index, no longer truncate 2020-04-10 15:25:58 -04:00
Logan Allen
be1d5cee56 chat-store: flop envelopes in handle-messages so backlog comes in correct order 2020-04-10 15:25:58 -04:00
Logan Allen
8cdfb559f6 chat-view and hook: style pass and backlog truncation 2020-04-10 15:25:58 -04:00
Logan Allen
ecc8942eaf chat: reversed order that messages are stored in for faster performance 2020-04-10 15:25:58 -04:00
Isaac Visintainer
eef6e56dca release: urbit-os-v1.0.12 2020-04-09 17:47:55 -07:00
ixv
12b6a5ccc5
Merge pull request #2600 from urbit/dk-help-generator
completed +help comments for places they were missing
2020-04-09 16:51:22 -07:00
ixv
f0d702002a
Merge pull request #2708 from urbit/m/link-opt-in
link: require explicit opt-in for new collections
2020-04-09 15:54:41 -07:00
Isaac Visintainer
1fdf8a9789 Merge branch 'gall-hack-new-deal' 2020-04-09 15:39:49 -07:00
Logan Allen
a5d6403f39 gall: updated to soft properly 2020-04-09 14:53:12 -04:00
Fang
05e651970e
link: require explicit opt-in for new collections
Instead of auto-watching a new collection when it gets added to group
associations, require that the user explicitly choose to view it.

Of course, creation counts as opting in, so watch the collections we
create by default.
2020-04-09 19:01:58 +02:00
Logan Allen
7edc183ded gall: soft cast chat-action, and remove the chat-update hack 2020-04-09 02:09:51 -04:00
lukechampine
cb4cae01c8 ford: print source line on syntax error 2020-04-08 21:11:15 -04:00
Fang
c570def06a
Merge pull request #2680 from mhartl/master
Fix spelling of "existent"
2020-04-09 00:32:34 +02:00
Fang
9f47cbd568
dbug: document "all subscriptions" option in gen 2020-04-07 11:21:17 +02:00
Logan Allen
4d8e0cf26b gall: added hack to reduce processing time for chat messages by 30% 2020-04-06 22:58:06 -04:00
Aaron Sikes
eb0ce2daba Change at:dejs-soft:format to reject too-long json arrays
`at` is for when you expect an array of a certain exact structure. If it
has extra elements, that indicates you were mistaken about the strucutre,
so it should fail to match.
2020-04-06 14:05:35 -04:00
Aaron Sikes
ecc8d0ee29 Add unit tests for json de/serialization.
This tests enjs:format, dejs:format, dejs-soft:format,
en-json:html, and de-json:html.
2020-04-06 13:35:21 -04:00
Michael Hartl
3e203634e3 Fix spelling of "existent" 2020-04-06 08:18:22 -07:00
ixv
482e87f8fc
Merge pull request #2662 from urbit/la-app-hints
apps: added hints to the top of many networked apps
2020-04-03 10:22:23 -07:00
Isaac Visintainer
b5b19adb8c launch: handle change in url parsing 2020-04-02 19:01:36 -07:00
Fang
f494854dc0
Merge pull request #2641 from urbit/m/eth-watcher-timeout
eth-watcher: separate timeout from refresh-rate
2020-04-03 02:00:07 +02:00
Isaac Visintainer
5faaa6c710 release: urbit-os-v1.0.10 2020-04-02 15:54:24 -07:00
Isaac Visintainer
2ad8264c52 Merge branch 'philip/gall-clear' 2020-04-02 15:32:43 -07:00
ixv
35fa913113
Merge pull request #2661 from urbit/ed/groups-add-channel-icons
groups: add channel type icons
2020-04-02 15:30:13 -07:00
Matilde Park
c873c4d01b chat: add spinner component and behaviours 2020-04-02 18:19:50 -04:00
Matilde Park
afec74cb2e groups: add componentised spinner and behaviours 2020-04-02 18:19:48 -04:00
Matilde Park
d49ace002d soto: add componentised spinner 2020-04-02 18:18:14 -04:00
Matilde Park
1bc973c520 link: reimplement spinner as component 2020-04-02 18:18:10 -04:00
Matilde Park
48c9bdc702 publish: componentise spinner as part of layout
This commit pulls the spinner out of the header bar -- and
reincorporates it as a component that hooks into local state when
awaiting a new prop, or disabling an input.
2020-04-02 18:17:11 -04:00
édouard
4cd7c77ad3 groups: add channel type icons
Adding three new icons for group channels (as seen in the groups view)
2020-04-02 18:15:51 -04:00
Logan Allen
99878eb65d apps: added hints to the top of many networked apps 2020-04-02 17:49:46 -04:00
Logan Allen
717b02ad6f chat: added jet hints 2020-04-02 17:43:03 -04:00
Fang
ca4a5af4e3
Merge pull request #2656 from urbit/m/url-segments
zuse: allow empty segments in de-purl url parsing
2020-04-02 20:47:30 +02:00
ixv
f6954e6a55
Merge pull request #2644 from urbit/mp/group-typing
groups: show tile icon, not full color; alphabetically sort group channels
2020-04-02 07:18:05 -07:00
ixv
d1a440fab9
Merge pull request #2636 from liam-fitzgerald/lf/dojo-gen-autocomplete
dojo: add autocomplete for various dojo syntaxes
2020-04-02 07:17:02 -07:00
ixv
e2022ed3a6
Merge pull request #2619 from liam-fitzgerald/lf/who-endpoint
/who JSON endpoint
2020-04-02 07:16:50 -07:00
Fang
d1894cdbe6
zuse: allow empty segments in de-purl url parsing
RFC 2396 specifies that segments must be zero or more pchars.[1] We were
deviating from this by requiring at least one pchar per segment.

With this change, we support /some//path, and no longer lose the
trailing slash in /some/path/.

[1]: https://tools.ietf.org/html/rfc2396#section-3.3
2020-04-02 14:44:45 +02:00
Logan
0ce28806a9
Merge branch 'master' into matilde/interface-prod 2020-04-01 22:24:33 -04:00
Liam Fitzgerald
0115177eea launch: create new state-version for %serve 2020-04-02 09:12:39 +10:00
Liam Fitzgerald
ed7d9fb164 launch: move %serve card to types core 2020-04-02 08:52:59 +10:00
Liam Fitzgerald
eeebfc0114 launch: address review comments for /who endpoint 2020-04-02 08:50:01 +10:00
Liam Fitzgerald
253187001b launch: add CORS headers to /who endpoint
Necessary to allow bridge to make a cross-origin request via
javascript.
2020-04-02 08:16:10 +10:00
Liam Fitzgerald
e16c999c76 launch: add /who endpoint
The /who endpoint responds with the name of the ship in JSON
2020-04-02 08:16:08 +10:00
Fang
809befb6fc
clock: ensure launch is listening correctly
In the wild, ships that were live pre-OS1 still had launch subscriptions
open to the clock on the /tile path, instead of the currently-used
/clocktile path. Additionally, launch state for the clock tile seemed
incomplete.

Here, we simply re-%add the clock to launch.

Note that launch currently does not clean up old subscriptions on
path change. For the pre-OS1 case, the old path is no longer in use,
rendering the subscription harmless. For cases where the correct
subscription was already in place, it'll print a %watch-wire-not-unique,
but doesn't do any harm besides that.
2020-04-01 23:13:57 +02:00
Fang
b62105cce4
clock: add dbug 2020-04-01 22:26:07 +02:00
Fang
6fef6a996a
weather: add verb 2020-04-01 22:25:54 +02:00
Matilde Park
e1af036f1c groups: show tile icon, not full color 2020-04-01 15:26:47 -04:00
Fang
2223a85666
eth-watcher: separate timeout from refresh-rate
Previously, when the refresh-rate timer activated, and the thread from
the previous activation was still running, we would kill it and start
a new one. For low refresh rates, on slower machines, nodes, or network
connections, this could cause the update to never conclude.

Here we add a timeout-time to eth-watcher's config. If the refresh-rate
timer activates, and a thread exists, but hasn't been running for at
least the specified timeout-time yet, we simply take no action, and wait
for the next refresh timer.

Note that we opted for "at least timeout-time", instead of killing &
restarting directly after the specified timeout-time has passed, to
avoid having to handle an extra timer flow.

In the +on-load logic, we configure the timeout-time for existing
watchdogs as six times the refresh-rate. We want to set
azimuth-tracker's timeout-time to ~m30, and don't care much about other,
less-likely-to-be-active use cases of eth-watcher.
2020-04-01 12:47:38 +02:00
Liam Fitzgerald
4433b99011 dojo: change autocomplete to use sell
Change autocomplete to prettyprint variables with sell instead of
xsell
2020-04-01 14:22:04 +10:00
Liam Fitzgerald
ff8c7a61d5 dojo: fix hood shortcut 2020-04-01 12:29:14 +10:00
Liam Fitzgerald
ed7f8be424 dojo: add autocomplete for various dojo syntaxes
Adds autocomplete for
- :app poke syntax
- :app|gen poke generator syntax
- +gen naked generator syntax
- =var variable syntax
2020-04-01 11:28:27 +10:00
Isaac Visintainer
93c881cec9 release: urbit-os-v1.0.9 2020-03-31 16:45:40 -07:00
ixv
e76fe83ea1
Merge pull request #2615 from urbit/mp/grouping-take-2
os1: reintegrating groups into all Landscape applications
2020-03-31 15:17:57 -07:00
ixv
a14fbc1eb8
Merge pull request #2633 from urbit/philip/clay-dec
clay: don't underflow when patch produces empty file
2020-03-31 14:17:42 -07:00
Isaac Visintainer
64a6e89be6 launch: remove groups tile here rather than in contact-view 2020-03-31 11:49:57 -07:00
Philip Monk
5a4786169d
clay: don't underflow when patch produces empty file
Fixes #2602

I haven't been able to reproduce this bug, but I can see how it could
happen in theory.  This should resolve the issue.
2020-03-31 11:37:58 -07:00
Fang
56df6dc94f
link-listen-hook: recover neglected collections
During the #2607 upgrade, strictly local collections got left out of the
listening set. (Because they did not have any outgoing subscriptions.)
This led to personal collections not being available on the frontend.

Here, we add upgrade logic for adding those back to our listening set again.
If a user had explicitly left a personal collection (instead of deleted it, for
whatever reason), they will have to leave it again. This case seems much more
rare than the "my collection is gone" one.
2020-03-31 19:10:07 +02:00
Isaac Visintainer
12f150659b release: urbit-os-v1.0.8 2020-03-30 20:28:35 -07:00
ixv
31794ebacf
Merge pull request #2609 from urbit/m/group-kick-fix
group-hook: fix resubscribe bug
2020-03-30 17:59:51 -07:00
ixv
8f1655171d
Merge pull request #2616 from urbit/two-round
chat-js: improve subscription speed by doing two rounds of subscriptions and no longer subscribing to groups
2020-03-30 17:48:39 -07:00
ixv
d27329c45d
Merge pull request #2626 from lukechampine/patch-1
eyre: Remove leading sig from password placeholder
2020-03-30 17:48:13 -07:00
ixv
f98557aba9
Merge pull request #2617 from urbit/channel-caching
apps: added a duplicate channel.js for caching, updated script tags to point to it
2020-03-30 17:47:52 -07:00
Logan Allen
49476aac66 chat-js: refactored subscriptions to auto-resubscribe 2020-03-30 18:07:33 -04:00
Logan Allen
c2070dbcc6 chat-js: pass in groups property, convert from permissions 2020-03-30 17:59:52 -04:00
matildepark
2f3d681975
launch, link: apply @Fang- suggestions to #2615 review
Co-Authored-By: Fang <git@fang.io>
2020-03-30 15:50:16 -04:00
Luke Champine
b3d78b5d71
eyre: Remove leading sig from password placeholder 2020-03-30 13:32:21 -04:00
Fang
87e61da99a
lib: !. on dbug and verb wrapper agent cores
Events always pass through these, adding to the stack trace on-crash.
This information is practically never useful, however. Adding !. leaves
these cores out of the traces.
2020-03-28 13:26:56 +01:00
Logan Allen
f1a0b30c1f apps: added a duplicate channel.js for caching, updated script tags to point to it 2020-03-27 20:08:44 -04:00
Isaac Visintainer
6443424012 contact-view: remove tile 2020-03-27 14:18:03 -07:00
Matilde Park
003089bf11 soto: add %add launch-action 2020-03-27 15:30:55 -04:00
David Kerschner
eeacf4543f removed gen/ph per @philipcmonk 2020-03-27 10:06:27 -07:00
David Kerschner
12662675f4
Update pkg/arvo/gen/azimuth-tracker/watch.hoon
Co-Authored-By: Philip Monk <phil@pcmonk.me>
2020-03-27 10:04:31 -07:00
David Kerschner
290ce453eb
Update pkg/arvo/gen/aqua/pill.hoon
Co-Authored-By: Philip Monk <phil@pcmonk.me>
2020-03-27 10:04:25 -07:00
Matilde Park
891018159a launch: add group filter dropdown, header redesign 2020-03-27 12:45:51 -04:00
Matilde Park
5516d2ebdb launch: add %remove launch-action 2020-03-27 12:44:49 -04:00
Fang
058dcdf100
contact-hook: less destructive catch-up on-sub
(Re)subscribing gets us a %contacts update, containing the full set of
contacts as it currently exists.

Previously, we would fully delete our local state, only to recreate it
using the data from the update.

Now, we never delete existing data, instead only creating if we don't
have it yet, and adding, removing or recreating contacts if they
changed.

In the future, we'll want an easy way to turn two contacts into an %edit
diff, to let us apply correct semantics to individual contacts, too.
2020-03-27 14:21:03 +01:00
Fang
4551c74e3a
group-hook: on %path group-update, don't %unbundle
Instead, %bundle and %add if we don't have the group locally yet,
or %add and %remove whatever the difference is between the local group
and the group as specified in the %path update.
2020-03-27 12:38:08 +01:00
Fang
4220b91fae
metadata-hook: use dbug agent wrapper 2020-03-27 01:30:30 +01:00
Fang
4940501f3b
group-hook: use actual synced data in +on-load
It's gonna be ~ if we pull it from the app core during +on-load.
2020-03-26 23:58:15 +01:00
Logan Allen
221238c0fa chat-js: improve subscription speed by doing two rounds of subscriptions and no longer subscribing to groups 2020-03-26 17:41:11 -04:00
Fang
22bb2a0d86
group-hook: on-load, re-establish subscriptions
For every item in the synced map that doesn't have a matching outgoing
subscription, re-establish the subscription we expect to have.
2020-03-26 20:19:18 +01:00
Fang
ea48161334
group-hook: touch up watch-nack and kick logic
In both, we make clear that the wire is always of the /@/group/^ form,
and alias the "group path" portion of the wire for clarity.

For kick, more obviously reuse the same wire, don't reconstruct it.

For watch-nack, only delete from the synced map if the source of the
watch-nack is still relevant. While we don't expect this to be relevant
considering current mode of operation, this does protect us against
strange cases.
2020-03-26 20:18:45 +01:00
Fang
bf912f6aac
group-hook: fix incorrect on-kick logic
It was checking and resubscribing on the full wire, instead of the
part of the wire that represents the group path.
2020-03-26 20:06:31 +01:00
Isaac Visintainer
0d3e409f7c release: urbit-os-v1.0.7 2020-03-26 09:25:02 -07:00
ixv
b5e3b4ceac
Merge pull request #2608 from urbit/philip/verb
arvo: add wire to %give verb message
2020-03-26 09:02:51 -07:00
ixv
b8a222ea75
Merge pull request #2606 from urbit/la-scrollback
Scrollback fixed and tested in Brave, Safari, and Chrome
2020-03-26 09:02:24 -07:00
Philip Monk
0349cf3818
arvo: add wire to %give verb message
This must have been removed on accident recently.
2020-03-25 20:13:24 -07:00
Logan Allen
2719a24dcc chat: decreased message limit to 20, now asking for more messages upon navigating to a chat channel when we have < 100 messages for that channel 2020-03-25 19:48:35 -04:00
ixv
755fbb7d14
Merge pull request #2583 from urbit/mp/os1/welcome
os1: add startup content
2020-03-25 16:26:01 -07:00
Fang
5f94fe0cf4
link-listen-hook: explicitly track subscriptions
Instead of going purely off metadata, we now track the collections we're
listening to, and allow the user to remove collections from that list.

This allows us to remove/ignore collections, without mutilating group
assocations locally.
2020-03-25 22:41:20 +01:00
Logan Allen
a787eceae9 chat-js: turned off perf testing 2020-03-25 17:36:51 -04:00
Logan Allen
eb51ff693c chat: changed initial scrollback to 50 because 25 short messages wouldn't trigger any scrollbar at all, and fixed scrollback condition 2020-03-25 17:35:51 -04:00
Logan Allen
8d64d9d253 chat: fixed indentation
logging for scrollback
2020-03-25 17:34:59 -04:00
Fang
073b86be15
link-store: don't send update if not new
We were taking care not to re-add something to our data store if we
already had it in there, but were still sending out an update
regardless.

With this, we only send out an update if we weren't previously aware
of the content.
2020-03-25 22:12:49 +01:00
ixv
16b4e2e8e4
Merge pull request #2605 from urbit/la-cache-control
server: add basic cache-control for faster load speeds
2020-03-25 11:33:52 -07:00
Logan Allen
39500f2036 server: add basic cache-control for faster load speeds 2020-03-25 01:02:27 -04:00
Isaac Visintainer
f7133f77e0 release: urbit-os-v1.0.6 2020-03-24 15:45:34 -07:00
David Kerschner
123122b755 completed +help comments for places they were missing 2020-03-24 15:14:24 -07:00
ixv
c94ba12c08
Merge pull request #2595 from urbit/philip/clay-cancel-all
clay: add option to skip queue
2020-03-24 15:03:25 -07:00
ixv
375cb9ba1b
Merge pull request #2591 from urbit/m/eth-abi-etyp
zuse: better ethereum abi data type
2020-03-24 15:02:17 -07:00
Fang
2186dd8050
dbug: print %state's value, not whole vase 2020-03-24 22:12:28 +01:00
Jared Tobin
cd9f23d6db
Merge branch 'liam-fitzgerald/lf/chat-patp-autocomplete' (#2571)
* liam-fitzgerald/lf/chat-patp-autocomplete:
  chat-fe: fix incorrect property in css
  chat-fe: improve name legibility in autocomplete
  chat-fe: match autocomplete to designs
  chat-fe: autocomplete nicknames in message input
  chat-fe: ignore comets in autocomplete
  chat-fe: correct light mode autocomplete styling
  chat-fe: add patp autocomplete to message input

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-03-24 17:37:51 +04:00
Fang
a155da6dec
Merge pull request #2587 from urbit/m/dbug-cleaner-subs
dbug: subscription searching & printing improvements
2020-03-24 10:40:45 +01:00
Liam Fitzgerald
ca8f436fd0 chat-fe: fix incorrect property in css 2020-03-24 11:01:46 +10:00
Liam Fitzgerald
302c3dc4cc chat-fe: improve name legibility in autocomplete 2020-03-24 10:50:53 +10:00
Philip Monk
1599937c81
clay: add option to skip queue
Makes it so that |cancel %force skips the next thing in the queue if
you're not in the middle of something.  If you are in the middle of
something, it skips the thing you're in the middle of (just like naked
|cancel).

This should resolve issues where |cancel doesn't drain the queue.
2020-03-23 15:53:18 -07:00
Fang
7415a2f66a
Merge pull request #2589 from urbit/m/de-purl-com
zuse: allow com in de-purl query parsing
2020-03-23 20:20:05 +01:00
Fang
f2986af4b3
Merge pull request #2582 from urbit/m/chat-backlog-limit
chat-view: limit initial scrollback to 25 msgs
2020-03-23 19:14:26 +01:00
Fang
303b4b2756
zuse: better ethereum abi data type
Considering some of the options here were atoms, not cells, $% wasn't
appropriate, and led to *etyp:abi:ethereum resulting in ford %ride execution
failure. Simply using $? instead would result in a fish-loop, so here we split
the atom cases from the tagged union ones with a $@.
2020-03-23 12:43:40 +01:00
Fang
87dd953136
zuse: allow com in de-purl query parsing 2020-03-22 01:21:03 +01:00
Fang
c0f93c7306
dbug: allow easily printing all subs
We had no easy way to print all %incoming or %outgoing subscriptions.
Now, passing ~ instead of [%ship ~zod] or similar, will match all.
2020-03-21 18:32:39 +01:00
Fang
50f7dc85fa
dbug: cleaner subscription printing
Previously, the pretty-printing for %incoming and %outgoing results was hanging
on to and displaying irrelevant type information: "_list_ of subscriptions",
"wire with _head and tail_", and so on.

Here, we move to producing tangs, instead of vases, and print those. For the
%incoming and %outgoing cases, we print a line for every subscription, sorting
them by path and wire respectively, and giving clean, easily readable output.
2020-03-21 18:29:33 +01:00
Liam Fitzgerald
6c403f5135 chat-fe: match autocomplete to designs 2020-03-21 13:52:41 +10:00
Liam Fitzgerald
9c759a7e68 chat-fe: autocomplete nicknames in message input 2020-03-21 13:49:57 +10:00
Philip Monk
184a0f52a5
gall: add |gall-sear 2020-03-20 15:32:23 -07:00
Fang
376af254af
chat-view: limit initial scrollback to 25 msgs
Provided "load backlog on-scroll" actually works, you don't really need
all that much on initial load.
2020-03-20 20:47:15 +01:00
Isaac Visintainer
e5f701e4a5 launch: add startup bool 2020-03-20 12:06:10 -07:00
ixv
9f997fb5b8
Merge pull request #2579 from urbit/m/chat-hook-cleanup-subs
chat-hook: clean up pre-OS1 subscriptions
2020-03-20 11:35:15 -07:00
Fang
1e1c26e306
chat-hook: clean up pre-OS1 subscriptions
If chats with identical resource paths were created, that would result
in chat-hook seeing updates twice.

These "/mailbox wire sub to local chat-store" subscriptions aren't
created by the current logic anymore, and as such any existing ones
should be eradicated.
2020-03-20 17:56:17 +01:00
Liam Fitzgerald
14399777e0 chat-fe: ignore comets in autocomplete 2020-03-20 15:30:04 +10:00
Isaac Visintainer
a645f939ad release: urbit-os-v1.0.5 2020-03-19 16:40:17 -07:00
Philip Monk
5972dc50a3
gall: remove printf and add pill 2020-03-19 11:34:19 -07:00
Isaac Visintainer
83fc700d41 release: urbit-os-v1.0.4 2020-03-19 11:19:30 -07:00
Fang
bee7f67d45
Merge pull request #2518 from urbit/m/chat-hook-watch-nack
chat-hook: clear all subscriptions on watch-nack
2020-03-19 15:35:26 +01:00
Fang
a162ab0e73
chat-hook: handle watch-nack for /store wires too
Similar to /backlog wires, we want to emulate %remove behavior on-nack.
2020-03-19 15:32:40 +01:00
Jared Tobin
7a7fe45677
Merge branch 'm/chat-groupify-extra' (#2546)
* origin/m/chat-groupify-extra:
  chat-view: %delete even without association
  frontend: apply ec6c2ed69 to link, publish, groups
  chat fe: clarify copy
  chat fe: support adding chat to existing group
  chat fe: invite search with/out ships
  chat-view: allow %groupify into existing group
  chat-view: add docs for %create action

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-03-19 14:35:59 +04:00
Jared Tobin
2b794da987
Merge branch 'philip/goad-force' (#2539)
* origin/philip/goad-force:
  goad: run with %force on kernel change

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-03-19 14:34:07 +04:00
Philip Monk
cf9ef764f1
gall: remove pending messages from breached ship
When a ship breaches, we remove all messages that have yet to be
delivered to an app (eg if it's not yet started).  We also add
|gall-sear to do this manually, but this shouldn't be needed in normal
operation.

Finally, to unblock ~zod and ~bus on mainnet, we sear one particular
ship automatically on loading hood.  It cannot be done manually because
no userpace changes can be made until it's unblocked.
2020-03-18 21:05:06 -07:00
Fang
d823448635
chat-view: %delete even without association
Previously, running %delete had a hard dependency on a (metadata-store)
association being present for the chat. If a remotely-hosted chat got
deleted, that would delete the association, preventing us from deleting
the chat for ourselves.

Now, we simply neglect to do related metadata deletions if no
association was present in the first place.
2020-03-19 01:33:33 +01:00
Fang
54eece11af
chat-view: allow %groupify into existing group
Will add the chat to an existing group, optionally adding chat members
who aren't part of the group yet to the group.
2020-03-18 21:54:28 +01:00
Fang
64e60b6b57
chat-view: add docs for %create action 2020-03-18 21:40:14 +01:00
Isaac Visintainer
a9f8a2bd88 release: urbit-os-v1.0.3 2020-03-17 18:04:34 -07:00
ixv
867dbe08ab
Merge pull request #2538 from urbit/philip/bar-stack
arvo: Multi-stack drifting
2020-03-17 17:38:14 -07:00
ixv
4cb9d64623
Merge pull request #2534 from urbit/philip/ames-verb
ames: print num-fragments in packet verbage
2020-03-17 17:07:08 -07:00
Philip Monk
b830cf1486
goad: run with %force on kernel change
In many cases running without %force is insufficient because ford
crashes while unsubscribing.  This should fix some cases of OTAs being
received but not processed.
2020-03-17 17:06:48 -07:00
Fang
04b6ff9704
Merge pull request #2510 from urbit/m/chat-update-numbers
chat-store: include msg sequence nrs in update
2020-03-18 01:02:31 +01:00
Philip Monk
7d7f4133a6
arvo: add bar stack to hoon stack trace
We have three stacks: the hoon stack, bar stack, and duct stack.  This
turns the bar stack to a list of ducts and adds it to the hoon stack.
This tells you the ducts of the moves that caused the move where you
crashed.

See:

recover: dig: intr
crud: %belt event failed
bail: intr
  bar-stack
~[
  ~[/g/use/spider/~zod/build/~.dojo_0v5ogno.5anji.vn3f6.4gs7t.6r2ft /d //term/1]
  ~[/d //term/1]
  ~[/g/use/spider/~zod/find/~.dojo_0v5ogno.5anji.vn3f6.4gs7t.6r2ft /d //term/1]
  ~[/g/use/dojo/~zod/out/~zod/spider/drum/wool /d //term/1]
  ~[/d //term/1]
  ~[/g/use/dojo/~zod/drum/hand /d //term/1]
  ~[/g/use/hood/~zod/out/~zod/dojo/drum/phat/~zod/dojo /d //term/1]
  ~[/d //term/1]
  ~[//term/1]
]
call: failed
/~zod/home/~2020.3.17..23.14.11..50e0/sys/vane/ford:<[6.128 3].[6.220 5]>
/~zod/home/~2020.3.17..23.14.11..50e0/sys/vane/ford:<[6.129 3].[6.220 5]>
/~zod/home/~2020.3.17..23.14.11..50e0/sys/vane/ford:<[6.132 3].[6.220 5]>
...
2020-03-17 16:31:38 -07:00
Philip Monk
3b9f7249d3
ames: print num-fragments in packet verbage
Gives you a poor man's progress bar.  For example, to determine how much
of an OTA you've downloaded from your sponsor, run:

|ames-sift (sein:title our now our)
|ames-verb %rcv

and then to turn it off:

|ames-verb
2020-03-17 14:03:48 -07:00
Fang
9498d9afa5
chat-cli: skip catch-up if chat-store not booted
This way we don't just crash on the scry that follows.
2020-03-17 15:49:01 +01:00
Jared Tobin
80ab15e7b6
Merge branch 'pkova/master' (#2423)
* pkova/master:
  hoon: fix ket not working past tistar
2020-03-17 16:56:39 +04:00
Isaac Visintainer
9c495aa38a release: urbit-os-v1.0.2 2020-03-16 17:55:56 -07:00
ixv
254c3cf3a7
Merge pull request #2527 from urbit/ixv/publish-foreign-group-fix
publish: fix permissions issue
2020-03-16 17:28:46 -07:00
ixv
abc39cdc04
Apply suggestions from code review
Co-Authored-By: Fang <git@fang.io>
2020-03-16 17:05:23 -07:00
Isaac Visintainer
3f882b5a90 publish: fix permissions bug when notebook is associated with a foreign hosted group 2020-03-16 16:45:00 -07:00
Fang
be53e26d15
Merge pull request #2524 from urbit/m/chat-cli-shortcode
chat-cli: absolute parity wrt "shortcodes"
2020-03-17 00:38:27 +01:00
Fang
4b5a02fac8
Merge pull request #2480 from urbit/m/chat-groupify
chat: groupify
2020-03-16 18:37:29 +01:00
Fang
db5475b1ae
chat-cli: absolute parity wrt "shortcodes"
Downgrades unmanaged chat paths to their uglified versions, as used by
web chat. Removes "group-based" indicators and makes them implicit in
shorter paths instead.
2020-03-16 17:46:58 +01:00
Fang
6ac52b5523
chat-cli: set sane display width, if zero
Under mysterious conditions, chat-cli might get into a state where its
rendering width is set to zero. This makes sure we set it back to 80
if that's the case.

This commit is mostly just precaution.
2020-03-16 17:43:46 +01:00
Jared Tobin
1dd2b77222
release: urbit-os-v1.0.1 2020-03-16 15:10:58 +04:00
Jared Tobin
c0cc4a1db8
Revert "Merge branch 'liam-fitzgerald/hoon-spot' (#2247)"
This reverts commit 046506f9d4, reversing
changes made to 6ef08962ef.

I'm reverting this as we're moving to a new branch/release model in
which breaching changes (as this one is) will live on a long-running
'next' branch, rather than alongside non-breaching changes in master.

This revert should itself be reverted on the 'next' branch.
2020-03-16 10:51:00 +04:00
Fang
62dfc5fd3c
chat-hook: clear all subscriptions on watch-nack
We would remove the entry from state, but not clean up its mailbox subscription.
2020-03-15 17:37:57 +01:00
Fang
9b5bc80016
chat-store: include msg sequence nrs in update
It was filling the number.envelope prior to adding the envelope to the
mailbox, but wasn't actually including that change in the %message(s)
update that was getting sent out.

This makes +append-envelope return both the updated mailbox _and_ the
modified envelope, which we then use in our outgoing update.
2020-03-14 23:15:41 +01:00
Fang
123213b3be
chat-cli: ensure bound map is sorted
During upgrade, we gassed _in_ a map, instead of _by_, causing it to use
set-style sorting, leading to incorrect lookups.

This fixes that upgrade logic, and re-builds the map for existing instances.
2020-03-13 21:45:49 +01:00
Logan Allen
43e4ca149e contact-hook: re-establish connection to group-store if subscription failed during ota 2020-03-13 19:32:28 +00:00
Fang
9793dccef0
chat-view: support %groupify
This upgrades an existing, unmanaged village chat into a full-fledged
group plus chat.
2020-03-13 18:15:34 +01:00
Fang
b77ab0f122
chat-view: add scry helper 2020-03-13 18:15:34 +01:00
yosoyubik
b8d5227c21 hoon: +apt:by check for duplicate keys
Fixes https://github.com/urbit/urbit/issues/2413
2020-03-13 05:19:10 +01:00
pkova
0d079b537c hoon: fix ket not working past tistar 2020-03-13 00:37:33 +02:00
ixv
54d1e7eb63
Merge pull request #2450 from urbit/m/dbug-state-slapper
dbug: allow complex, hoon-based state queries
2020-03-12 11:09:26 -07:00
Philip Monk
2ea8800710
behn: drop drip failures
Restores previous behavior.  This is wrong, but without it we fail when
vanes (specifically Ford) crash on goof.
2020-03-12 09:39:27 -07:00
Fang
9a6bde765b
dbug: allow complex, hoon-based state queries
+dbug [%state 'some-hoon'] now allows you to run some-hoon against the
application's state. That hoon has access to the bowl and stdlib for
more dbugging convenience.
2020-03-12 16:40:35 +01:00
Jared Tobin
3d40f3196c
Merge branch 'philip/breach-time' (#2433)
* origin/philip/breach-time:
  eth-watcher: reduce required number of confirmations

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-03-12 11:24:10 +04:00
Jared Tobin
edbc9ba553
Merge branch 'arvo-no-print-loop' (#2422)
* origin/arvo-no-print-loop:
  arvo: removes looping crash printf

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-03-12 11:24:10 +04:00
ixv
33c422fca6
Merge pull request #2447 from urbit/la-unsubscribed-state
chat-hook: added ability to subscribe to chat-hook state from the front-end
2020-03-11 23:36:42 -07:00
Logan Allen
a0a39b87dc chat-hook: watch-ack successfully for store subscripttion kills 2020-03-11 23:13:31 -07:00
Isaac Visintainer
ba43f03726 chat-hook: resubscribe when kicked from chat-store 2020-03-11 22:21:56 -07:00
Logan Allen
84a9f23af6 chat-hook: fix ota chat backlog duplication 2020-03-11 20:43:41 -07:00
Logan Allen
cac98b2284 chat-hook: don't send invites upon on-load 2020-03-11 20:33:38 -07:00
Logan Allen
872c620c5a chat-js: styled the resubscribe element 2020-03-11 20:33:01 -07:00
Fang
55aa0cb610
apps: augment with /lib/dbug 2020-03-12 01:33:48 +01:00
Logan Allen
64a62df461 chat-hook: removed comments 2020-03-11 16:45:03 -07:00
Logan Allen
51eebf3407 chat-hook: send updates to synced every time the object changes 2020-03-11 16:45:01 -07:00
Logan Allen
64938e24e9 chat-hook: added ability to subscribe to chat-hook state from the frontend 2020-03-11 16:44:15 -07:00
ixv
d835cdbe0d
Merge pull request #2445 from urbit/m/link-proxy-initial
link-proxy-hook: correctly scry initial response
2020-03-11 16:31:19 -07:00