Commit Graph

964 Commits

Author SHA1 Message Date
Liam Fitzgerald
5fbe955874 chat-fe: more FF scrollback fixes 2020-04-17 15:17:52 +10:00
Liam Fitzgerald
1b90328f39 chat-fe: fix index issue with pending messages
To produce message elements we iterate over pendingMessage ++ messages,
but to check whether they're adjacent to a message by the same author,
we index back into messages, which produces incorrect results when
pendingMessages is nonEmpty
2020-04-17 14:20:28 +10:00
Liam Fitzgerald
41be649764 Merge branch 'master' into mp/chat/firefox-take-2 2020-04-17 12:06:34 +10:00
Jared Tobin
e7984324be
Merge branch 'fix-pending' (#2751)
* origin/fix-pending:
  chat-js: fix chat ordering and pending messages

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:54:12 +04:00
Jared Tobin
6ef155b82b
Merge branch 'fix-chat-autojoin' (#2749)
* origin/fix-chat-autojoin:
  chat-js: fix auto-join and a chatSynced error
  chat-js: fix issue with autojoining

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:53:59 +04:00
Jared Tobin
b655105a38
Merge branch 'liam-fitzgerald/lf/link-ios-crash' (#2742)
* liam-fitzgerald/lf/link-ios-crash:
  link-js: fix pages disappearing on small screens

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:53:36 +04:00
Liam Fitzgerald
945fb3fca6 chat-js: render markdown in messages
Renders markdown in text messages but not url or code messages.
2020-04-16 20:21:29 +10:00
Liam Fitzgerald
9574765de6 chat-js: use CodeMirror for chat input
swaps out the textarea for a CodeMirror in markdown mode. Resolves an
issue related to the input shrinking with the content.
2020-04-16 20:21:29 +10:00
Liam Fitzgerald
a424312d12 chat-js: add CodeMirror dependency
Adds CodeMirror dependency and related css
2020-04-16 20:21:27 +10:00
Logan Allen
e98605c1bb chat-js: fix chat ordering and pending messages 2020-04-15 16:48:33 -04:00
Logan Allen
c497d5a6a6 chat-js: fix auto-join and a chatSynced error 2020-04-15 15:58:03 -04:00
Logan Allen
f035070387 chat-js: fix issue with autojoining 2020-04-15 15:04:54 -04:00
Jared Tobin
65cad93b1b
Merge branch 'liam-fitzgerald/lf/chat-input-line-height' (#2743)
* liam-fitzgerald/lf/chat-input-line-height:
  chat-js: adjust line height in chat input

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-15 20:18:14 +04:00
Liam Fitzgerald
8b48f3fa0f chat-js: adjust line height in chat input
Set the line height of the input to be the same as a sent message.
Additionally fixes an issue that would cause unnecessary scrollbars to
be shown.
2020-04-15 15:08:42 +10:00
Liam Fitzgerald
536e3121b6 link-js: fix pages disappearing on small screens
The rightPanelHide prop was being improperly set on the home, settings
and members screens, causing them to be blank on small screen sizes

Fixes #2727
2020-04-15 14:27:29 +10:00
Liam Fitzgerald
50dca97b07 publish: increase legibility for code in dark mode
Makes the rules that set both a background and foreground color come
last in the CSS, increasing their specificity. Changes the highlight to a
lighter grey, to better stand out. Correctly aligns highlights with code
block backgrounds.

Fixes #2684
2020-04-15 13:45:22 +10:00
Liam Fitzgerald
ba18737b5e chat-fe: move cancel button below comment edit 2020-04-15 10:59:56 +10:00
Liam Fitzgerald
b538cfd3ea chat-fe: address review comments 2020-04-15 10:48:46 +10:00
Liam Fitzgerald
963d04831d Merge branch 'master' into lf/publish-del-edit 2020-04-15 10:07:29 +10:00
Liam Fitzgerald
595acd17ff publish-js: lift editing state to comment list 2020-04-15 09:57:43 +10:00
Logan Allen
0145981542 contact-js: made channel handle onChannelError 2020-04-14 18:16:44 -04:00
Logan Allen
bfcaf6468e contact-hook: tested it, got /synced path working, and subscriptions loading 2020-04-14 18:05:32 -04:00
Logan Allen
b6e4566e61 contacts: fix group deletion and do some quality of life fixes 2020-04-14 21:33:01 +00:00
ixv
5bb9776b70
Merge pull request #2730 from liam-fitzgerald/lf/chat-synced-fix
chat-fe: resubscribe message iff chatSynced is populated
2020-04-14 11:40:45 -07:00
ixv
e5cf4fb813
Merge pull request #2720 from urbit/la-channel-err
channel.js: added way to handle event source errors more smoothly, and implemented in chat
2020-04-14 11:40:02 -07:00
Liam Fitzgerald
a3fed45af1 publish-js: avoid unnecessary scrollbars on note view
the root container had height: 100% but also a margin-top set on it. This
caused unnecessary scrollbars to appear when the content did not
actually overflow the container.
2020-04-14 20:38:35 +10:00
Liam Fitzgerald
d63cc0d7de publish-js: allow deletion and editing of comments
Adds interface affordances for the addition and removal of comments.
2020-04-14 20:20:59 +10:00
Liam Fitzgerald
9ddf06d2a1 chat-fe: correct FF scroll behaviour
Firefox treats the reflow in the scroll container weirdly so for the
scrollback case, we save the position to restore later, when the backlog
messages come in. For the 'locked at bottom' case we add a new state
variable and rescroll based on that.
2020-04-14 16:34:10 +10:00
Liam Fitzgerald
a6c5e96902 chat-fe: don't redirect if creating group 2020-04-14 11:50:47 +10:00
Liam Fitzgerald
786f2518e7 chat-fe: resubscribe message iff chatSynced is populated
Previously, if a room was navigated to directly, the resubscribe message
would show before the chatSynced state was loaded. Initialises
chatSynced as null and checks it is not null before showing the
resubscribe message.
2020-04-14 11:41:38 +10:00
Matilde Park
a4d37c0313 Merge branch 'master' into mp/chat/firefox-take-2 2020-04-13 21:38:27 -04:00
Liam Fitzgerald
1d81107d72 Merge branch 'master' into lf/profile-overlay 2020-04-14 11:04:52 +10:00
Liam Fitzgerald
a2998bdc41 chat-fe: redirect to DMs on trivial new group case
Create or view a DM upon trying to create an invite-only group with one invitee.
2020-04-14 11:01:31 +10:00
ixv
a7f20c37c1
Merge pull request #2700 from liam-fitzgerald/lf/invite-search-short
invite-search: handle suggestions for short searches
2020-04-13 16:56:26 -07:00
ixv
2d30886b65
Merge pull request #2724 from urbit/ixv/install-mousetrap
publish: install mousetrap before we use it....
2020-04-13 16:55:40 -07:00
ixv
228bee42e4
Merge pull request #2707 from urbit/ixv/cache-posts
publish: eagerly store your own changes
2020-04-13 16:54:41 -07:00
ixv
3526cfa4e6
Merge pull request #2618 from urbit/chat-reverse-messages
chat: reversed order that messages are stored in for faster performance
2020-04-13 16:54:16 -07:00
Fang
7aebcad25b
link fe: refactor message display into component 2020-04-13 21:54:50 +02:00
Fang
0d73b391b4
link fe: more informative "empty list" display
Displays "Loading..." if the links haven't loaded yet. If there are no
links, tells the user they can save one.
2020-04-13 21:37:42 +02:00
Fang
8f3d174c94
link: minimal initial view result
On initial load, instead of getting the first 25 links for every
collection, only get their totals and unread counts. This drastically
reduces the pageload time.

Updates the frontend to match:
- Handle initial results without link content.
- Dynamically load in collection's links, even for page 0.
2020-04-13 21:26:09 +02:00
Isaac Visintainer
277bc8d465 publish: make reducers able to handle duplicate updates now that we send updates both pre and post confirmation 2020-04-12 23:21:43 -07:00
Isaac Visintainer
20d3c4105d publish: install mousetrap before we use it.... 2020-04-12 23:05:32 -07:00
Liam Fitzgerald
2c870cdfc0 chat-fe: resuscitate scrollback
If the initial 20 messages doesn't cause the messages container to
overflow then the backlog will never be requested, making scrollback
impossible. This is due to making the container have position:relative
in order to display an overlay inside it.  Fixed by unconditionally
requesting the first page of backlog on load.
2020-04-11 20:07:01 +10:00
Liam Fitzgerald
d2d9158ea3 chat-fe: hide profile overlay on click outside
Hides the profile overlay when the users clicks outside the overlay.
2020-04-11 19:34:11 +10:00
Liam Fitzgerald
966155088c chat-fe: move new DMs to ship select popover
Refactored the patp autocomplete into a reusable component, and then
used that to add the DM popover interface. Also introduces some
performance improvements for the popover.
2020-04-11 17:47:11 +10:00
Liam Fitzgerald
803c7b4816 chat-fe: edit group identity if own profile overlay
Shows an "Edit Group Identity" button instead of "Send Message" if the
profile overlay being shown is the user's own.
2020-04-11 10:44:57 +10:00
Liam Fitzgerald
e5634a913d invite-search: always add search query if valid patp 2020-04-11 10:17:49 +10:00
Logan Allen
fb3111e88a channel.js: added way to handle event source errors more smoothly, and implemented in chat 2020-04-10 19:38:13 -04:00
Logan Allen
98f4df14a4 chat-js: made scrollback work for new message indexing 2020-04-10 22:22:14 +00:00
Logan Allen
6d1efde884 chat-js: fixed scrollback for reverse message chatrooms 2020-04-10 17:29:23 -04:00
Matilde Park
948dbe85e7 chat: scrollToBottom on mount for FF 2020-04-10 16:55:23 -04:00
Matilde Park
a212a5dc69 Merge branch 'master' into mp/chat/firefox-take-2 2020-04-10 16:44:15 -04:00
Matilde Park
1ddbc77157 chat: only scrolltobottom if first backlog grab 2020-04-10 16:42:05 -04:00
Matilde Park
3dc6a0bc9a chat: add firefox-specific chat window 2020-04-10 16:34:27 -04:00
ixv
e253ec1860
Merge pull request #2562 from nijynot/chore/interface-lint
interface: add eslint to interface and lint `launch` and `chat`
2020-04-10 13:04:58 -07:00
Logan Allen
ecc8942eaf chat: reversed order that messages are stored in for faster performance 2020-04-10 15:25:58 -04:00
Liam Fitzgerald
e7887b34c3 invite-search: handle suggestions for short searches
Triggers invitee suggestions after one character of input. To
compensate for the potential explosion of suggestions, we
tighten our group searching criteria and truncate the
ship suggestions on short searches. Also addresses a bug where names of
groups were not being downcased before search.

Fixes #2635
2020-04-10 19:57:50 +10:00
Liam Fitzgerald
c162f0f212 chat-fe: add DMs and related screens
Adds DMs, which are just unmanaged chats whose last path component
starts with dm-- followed by the patp of the other user.
2020-04-10 19:45:25 +10:00
Liam Fitzgerald
1bca495d8a chat-fe: reflow profile overlay near edges of screen
Polls for the distance between the top of the container and reflows the
overlay accordingly.
2020-04-10 17:59:04 +10:00
Liam Fitzgerald
188a1e8dcf chat-fe: hide/show profile overlay on sigil click
Hide and shows profile overlay on sigil click. Shows the overlay for 2
seconds after click. If the user moves their mouse into the overlay then
it will remain open as long as the mouse is inside the overlay.
2020-04-10 17:59:04 +10:00
Liam Fitzgerald
f3c21fae36 chat-fe: add profile overlay
Adds a profile overlay to display information about the user on hover.
Also adds the svgClass prop to the sigil component, to allow setting
classes directly on the sigil svg.
2020-04-10 17:58:46 +10:00
ixv
b43f4d9d39
Merge pull request #2709 from urbit/mp/chat/namespace-group-chats
chat: add unique ID to grouped chat paths
2020-04-09 15:54:53 -07:00
ixv
c65b896a2c
Merge pull request #2705 from liam-fitzgerald/lf/publish-loading-fix
publish-fe: improve UX of loading spinner on new note
2020-04-09 15:54:04 -07:00
ixv
d376fd6998
Merge pull request #2704 from liam-fitzgerald/lf/chat-padding-sidebar
chat-fe: filter empty groups in sidebar
2020-04-09 15:53:55 -07:00
ixv
8e480b611d
Merge pull request #2703 from liam-fitzgerald/lf/chat-patp-copy
chat-fe: copy patp to clipboard on author name click
2020-04-09 15:53:46 -07:00
ixv
c5eb540c71
Merge pull request #2702 from liam-fitzgerald/lf/chat-join-spinner
chat-fe: show spinner on join
2020-04-09 15:53:35 -07:00
ixv
bc5358c0fd
Merge pull request #2695 from liam-fitzgerald/lf/sanitise-md-publish
publish: sanitise markdown snippets in preview
2020-04-09 15:52:52 -07:00
ixv
a41096153d
Merge pull request #2694 from liam-fitzgerald/lf/invite-search-arrow-keys
invite-search: allow keyboard nav + selection
2020-04-09 15:52:36 -07:00
ixv
77933e992a
Merge pull request #2693 from urbit/mp/re-alphabetise
various: alphabetise associations accesses the object
2020-04-09 15:52:18 -07:00
ixv
5fe16a7f47
Merge pull request #2687 from urbit/la-resub-on-err
chat-js: resubscribe on error, not just on quit
2020-04-09 15:52:03 -07:00
ixv
43484d613c
Merge pull request #2683 from urbit/mp/invite-search/associations
invite search: populate group index from contacts
2020-04-09 15:37:56 -07:00
ixv
8d32d49daf
Merge pull request #2668 from urbit/mp/link/dib-ing
link: line up link info on same line height
2020-04-09 15:37:38 -07:00
Matilde Park
9881fb2a2b chat: add unique ID to grouped chat paths 2020-04-09 14:37:21 -04:00
nijynot
6536054b91 interface: add eslint and update contrib docs 2020-04-09 12:08:23 +02:00
Liam Fitzgerald
0c062104a5 publish-fe: improve UX of loading spinner on new note
Improve the UX of the loading spinner that shows when you have a new
note, by displaying it until we receive the new note in the
subscription, instead of until the poke succeeds.
2020-04-09 16:06:10 +10:00
Liam Fitzgerald
6586aa98e3 chat-fe: filter empty groups in sidebar
Empty groups caused the padding on the first group to be too large.
Filter the groups before we map over them so that we can set padding
properly.

Fixes #2674
2020-04-09 15:08:06 +10:00
Liam Fitzgerald
e2f8be20de chat-fe: make copy status text inter 2020-04-09 14:13:23 +10:00
Liam Fitzgerald
648eced4ff chat-fe: copy patp to clipboard on author name click 2020-04-09 13:12:48 +10:00
Liam Fitzgerald
b4fb8d5163 chat-fe: show spinner on join
Shows the spinner whilst joining a channel, both manually and from a
url. Also fixes an issue where a newly joined channel may be navigated
away from automatically.
2020-04-09 12:48:55 +10:00
Liam Fitzgerald
3801056d3c invite-search: allow keyboard nav + selection
Allows the user to navigate potential invitees with the arrow keys and
with shift+tab and tab. Enter adds the currently selected invitee.
2020-04-09 08:03:21 +10:00
Liam Fitzgerald
ff70a2be89 publish: sanitise markdown snippets in preview
Runs the snippet through ReactMarkdown instead of rendering it as text.
We restrict the allowed nodes in the render to pure text, so the snippet is not
overly visually heavy.
2020-04-09 07:56:44 +10:00
Matilde Park
839f9090bb various: alphabetise associations accesses obj
Previously we were checking for a title for the association by accessing
a non-existent property of the key we were using to iterate through
the object. What we want to do is access the iterated object to find
that title, and so this commit does that.
2020-04-07 17:35:02 -04:00
Fang
e9233b1a50
link fe: fix "mark all as read" button
This wasn't bound, nor calling, correctly.
2020-04-07 20:45:27 +02:00
Logan Allen
7a41f2dcab chat-js: resubscribe on error, not just on quit 2020-04-06 23:24:13 -04:00
Matilde Park
00ed295d48 invite search: populate group index from contacts 2020-04-06 19:45:40 -04:00
édouard
6ed7520444 contributing.md: removed interface dev instructions from root-level doc, integrated into existing interface-specific doc
I've moved the slightly edited interface development instructions from the root controbuting.md doc, over to the one located in pkg/interface. I've made sure to ensure any precvious information in the interface contributing doc has been matched or expanded upon in the new writing, which is a incrementally more thorough, and assumes a lower level of build-tooling knowledge.
2020-04-03 15:37:42 -04:00
ixv
58b7f94e86
Merge pull request #2667 from urbit/la-chat-loading
chat-js: transition to new chat upon chatSynced changing in join or new chat screen
2020-04-03 10:21:36 -07:00
Matilde Park
e2cc01445b link: line up link info on same line height 2020-04-02 23:09:10 -04:00
Logan Allen
7eb499abda chat-js: transition to new chat upon chatSynced changing in join or new chat screen 2020-04-02 23:03:28 -04:00
Matilde Park
d943ed353e publish: add rollup-plugin-json to production imports 2020-04-02 22:46:12 -04:00
Matilde Park
f4c3b73346 publish: add rollupReplace to gulpfile 2020-04-02 22:33:04 -04:00
Isaac Visintainer
5faaa6c710 release: urbit-os-v1.0.10 2020-04-02 15:54:24 -07:00
Matilde Park
e358c1dbfb Merge branch 'master' into mp/invites-to-group-filter 2020-04-02 18:25:59 -04:00
Matilde Park
e2c36cda0b publish: propagate meta key for comment posting 2020-04-02 18:20:20 -04:00
Matilde Park
e51bd46224 link: fix meta key propagation for comment posting 2020-04-02 18:20:15 -04:00
Matilde Park
d03dcd8289 groups: preload spinner asset 2020-04-02 18:19:50 -04:00
Matilde Park
c873c4d01b chat: add spinner component and behaviours 2020-04-02 18:19:50 -04:00
Matilde Park
afec74cb2e groups: add componentised spinner and behaviours 2020-04-02 18:19:48 -04:00
Matilde Park
48e65499e2 groups: set sigil color on blur, not automatically 2020-04-02 18:18:42 -04:00
Matilde Park
7dbd2a09f0 soto: fix purple back arrows 2020-04-02 18:18:40 -04:00