mirror of
https://github.com/urbit/shrub.git
synced 2024-11-29 14:57:12 +03:00
9ddc04143a
Until now, clients of Jael have had to store the first-seen rift if they want to reliably detect breaches. Otherwise, they would get a false positive if they heard an old message about a breach (eg if you kick azimuth-tracker). Clay and Gall did this correctly, but Ames did not. Jael already maintains this state, so I added a notification to the existing subscription that happens whenever it notices a breach (a diff or full where the new rift is greater than the old one). Because this is an issue on the live network, I wrote state adapters for Gall and Clay. The Gall one just removes the rift from our state, but the Clay one is much more involved because we have to upgrade instances of the clad monad that are possibly in progress. Specifically, since more input is possible than before, we must wrap any in-progress instances of the monad in a function that handles the potential new input from Jael. This temporarily preservers a copy of the old kernel, but only until the current commit/merge/update has completed. The real solution for Clay is to factor out those IO-heavy instances to userspace tapp/async/imp/threads, and if an upgrade happens in the middle, you should simply restart them. Fixes #1852 |
||
|---|---|---|
| .. | ||
| arvo | ||
| ent | ||
| ge-additions | ||
| herb | ||
| interface | ||
| urbit | ||