@@ -1,4 +1,5 @@
1use crate::session_manager::{GLOBAL_CACHE_DIR_NAME, INSTANCE_DIR_NAME};
1use crate::session_manager::{GLOBAL_CACHE_DIR_NAME, INSTANCE_DIR_NAME};
2+use anyhow::{Context, Error, Result, bail};
4 io::{self, Write},
5 io::{self, Write},
@@ -22,6 +23,7 @@ use std::{
24use block2::RcBlock;
25use block2::RcBlock;
26+use bytesize::ByteSize;
25use dispatch2::DispatchQueue;
27use dispatch2::DispatchQueue;
26use objc2::{AnyThread, rc::Retained, runtime::ProtocolObject};
28use objc2::{AnyThread, rc::Retained, runtime::ProtocolObject};
27use objc2_foundation::*;
29use objc2_foundation::*;
@@ -31,42 +33,46 @@ const DEBIAN_COMPRESSED_DISK_URL: &str = "https://cloud.debian.org/images/cloud/
31const DEBIAN_COMPRESSED_SHA: &str = "6ab9be9e6834adc975268367f2f0235251671184345c34ee13031749fdfbf66fe4c3aafd949a2d98550426090e9ac645e79009c51eb0eefc984c15786570bb38";
33const DEBIAN_COMPRESSED_SHA: &str = "6ab9be9e6834adc975268367f2f0235251671184345c34ee13031749fdfbf66fe4c3aafd949a2d98550426090e9ac645e79009c51eb0eefc984c15786570bb38";
32const DEBIAN_COMPRESSED_SIZE_BYTES: u64 = 280901576;
34const DEBIAN_COMPRESSED_SIZE_BYTES: u64 = 280901576;
33const SHARED_DIRECTORIES_TAG: &str = "shared";
35const SHARED_DIRECTORIES_TAG: &str = "shared";
36+pub const PROJECT_GUEST_BASE: &str = "/usr/local/vibebox-mounts";
35−const BYTES_PER_MB: u64 = 1024 * 1024;
36−const DEFAULT_CPU_COUNT: usize = 2;
37−const DEFAULT_RAM_MB: u64 = 2048;
38−const DEFAULT_RAM_BYTES: u64 = DEFAULT_RAM_MB * BYTES_PER_MB;
39const START_TIMEOUT: Duration = Duration::from_secs(60);
38const START_TIMEOUT: Duration = Duration::from_secs(60);
40const LOGIN_EXPECT_TIMEOUT: Duration = Duration::from_secs(120);
39const LOGIN_EXPECT_TIMEOUT: Duration = Duration::from_secs(120);
40+const PROVISION_EXPECT_TIMEOUT: Duration = Duration::from_secs(900);
42+const ERROR_REPORT_SCRIPT: &str = include_str!("error_report.sh");
41const PROVISION_SCRIPT: &str = include_str!("provision.sh");
43const PROVISION_SCRIPT: &str = include_str!("provision.sh");
42−const PROVISION_SCRIPT_NAME: &str = "provision.sh";
44+const RESIZE_DISK_SCRIPT: &str = include_str!("resize_disk.sh");
43const DEFAULT_RAW_NAME: &str = "default.raw";
45const DEFAULT_RAW_NAME: &str = "default.raw";
44const INSTANCE_RAW_NAME: &str = "instance.raw";
46const INSTANCE_RAW_NAME: &str = "instance.raw";
45const BASE_DISK_RAW_NAME: &str = "disk.raw";
47const BASE_DISK_RAW_NAME: &str = "disk.raw";
47#[derive(Clone)]
49#[derive(Clone)]
48−pub(crate) enum LoginAction {
50+pub enum LoginAction {
49− Expect { text: String, timeout: Duration },
53+ timeout: Duration,
50 Send(String),
60 Send(String),
51− Script { path: PathBuf, index: usize },
62+use crate::config::BoxConfig;
53use LoginAction::*;
63use LoginAction::*;
55#[derive(Clone)]
65#[derive(Clone)]
56−pub(crate) struct DirectoryShare {
66+pub struct DirectoryShare {
57 host: PathBuf,
67 host: PathBuf,
58 guest: PathBuf,
68 guest: PathBuf,
59 read_only: bool,
69 read_only: bool,
62impl DirectoryShare {
72impl DirectoryShare {
65− mut guest: PathBuf,
73+ pub fn new(host: PathBuf, mut guest: PathBuf, read_only: bool) -> Result<Self> {
67− ) -> Result<Self, Box<dyn std::error::Error>> {
68 if !host.exists() {
74 if !host.exists() {
69− return Err(format!("Host path does not exist: {}", host.display()).into());
75+ bail!(format!("host path does not exist: {}", host.display()));
71 if !guest.is_absolute() {
77 if !guest.is_absolute() {
72 guest = PathBuf::from("/root").join(guest);
78 guest = PathBuf::from("/root").join(guest);
@@ -78,10 +84,10 @@ impl DirectoryShare {
81− pub(crate) fn from_mount_spec(spec: &str) -> Result<Self, Box<dyn std::error::Error>> {
87+ pub fn from_mount_spec(spec: &str) -> Result<Self> {
82 let parts: Vec<&str> = spec.split(':').collect();
88 let parts: Vec<&str> = spec.split(':').collect();
83 if parts.len() < 2 || parts.len() > 3 {
89 if parts.len() < 2 || parts.len() > 3 {
84− return Err(format!("Invalid mount spec: {spec}").into());
90+ bail!(format!("invalid mount spec: {spec}"));
86 let host = expand_tilde_path(parts[0]);
92 let host = expand_tilde_path(parts[0]);
87 let guest = PathBuf::from(parts[1]);
93 let guest = PathBuf::from(parts[1]);
@@ -90,11 +96,10 @@ impl DirectoryShare {
90 "read-only" => true,
96 "read-only" => true,
91 "read-write" => false,
97 "read-write" => false,
93− return Err(format!(
99+ bail!(format!(
94 "Invalid mount mode '{}'; expected read-only or read-write",
100 "Invalid mount mode '{}'; expected read-only or read-write",
@@ -122,10 +127,10 @@ fn expand_tilde_path(value: &str) -> PathBuf {
122 if let Ok(home) = env::var("HOME") {
127 if let Ok(home) = env::var("HOME") {
123 return PathBuf::from(home).join(stripped);
128 return PathBuf::from(home).join(stripped);
125− } else if value == "~" {
130+ } else if value == "~"
126− if let Ok(home) = env::var("HOME") {
131+ && let Ok(home) = env::var("HOME")
127− return PathBuf::from(home);
133+ return PathBuf::from(home);
130 PathBuf::from(value)
135 PathBuf::from(value)
@@ -133,23 +138,33 @@ fn expand_tilde_path(value: &str) -> PathBuf {
133pub struct VmArg {
138pub struct VmArg {
134 pub cpu_count: usize,
139 pub cpu_count: usize,
135 pub ram_bytes: u64,
140 pub ram_bytes: u64,
141+ pub disk_bytes: u64,
136 pub no_default_mounts: bool,
142 pub no_default_mounts: bool,
137 pub mounts: Vec<String>,
143 pub mounts: Vec<String>,
146+type StatusEmitter<'a> = dyn Fn(&str) + std::marker::Send + Sync + 'a;
148+fn emit_status(status: Option<&StatusEmitter<'_>>, message: &str) {
149+ if let Some(status) = status {
140−pub fn run_with_args<F>(args: VmArg, io_handler: F) -> Result<(), Box<dyn std::error::Error>>
154+pub fn run_with_args<F>(args: VmArg, io_handler: F) -> Result<()>
142 F: FnOnce(Arc<OutputMonitor>, OwnedFd, OwnedFd) -> IoContext,
156 F: FnOnce(Arc<OutputMonitor>, OwnedFd, OwnedFd) -> IoContext,
144− run_with_args_and_extras(args, io_handler, Vec::new(), Vec::new())
158+ run_with_args_and_extras(args, io_handler, Vec::new(), Vec::new(), None)
147−pub(crate) fn run_with_args_and_extras<F>(
161+pub fn run_with_args_and_extras<F>(
148 args: VmArg,
162 args: VmArg,
149 io_handler: F,
163 io_handler: F,
150 extra_login_actions: Vec<LoginAction>,
164 extra_login_actions: Vec<LoginAction>,
151 extra_directory_shares: Vec<DirectoryShare>,
165 extra_directory_shares: Vec<DirectoryShare>,
152−) -> Result<(), Box<dyn std::error::Error>>
166+ status: Option<&StatusEmitter<'_>>,
154 F: FnOnce(Arc<OutputMonitor>, OwnedFd, OwnedFd) -> IoContext,
169 F: FnOnce(Arc<OutputMonitor>, OwnedFd, OwnedFd) -> IoContext,
@@ -158,7 +173,7 @@ where
158 let project_root = env::current_dir()?;
173 let project_root = env::current_dir()?;
159 let project_name = project_root
174 let project_name = project_root
160 .file_name()
175 .file_name()
161− .ok_or("Project directory has no name")?
176+ .with_context(|| "Project directory has no name")?
162 .to_string_lossy()
177 .to_string_lossy()
163 .into_owned();
178 .into_owned();
@@ -170,6 +185,10 @@ where
170 let guest_mise_cache = cache_dir.join(".guest-mise-cache");
185 let guest_mise_cache = cache_dir.join(".guest-mise-cache");
172 let instance_dir = project_root.join(INSTANCE_DIR_NAME);
187 let instance_dir = project_root.join(INSTANCE_DIR_NAME);
188+ fs::create_dir_all(&instance_dir)?;
189+ emit_status(status, "preparing VM image...");
190+ tracing::info!("preparing VM image...");
191+ let provision_log = instance_dir.join("provision.log");
174 let basename_compressed = DEBIAN_COMPRESSED_DISK_URL.rsplit('/').next().unwrap();
193 let basename_compressed = DEBIAN_COMPRESSED_DISK_URL.rsplit('/').next().unwrap();
175 let base_compressed = cache_dir.join(basename_compressed);
194 let base_compressed = cache_dir.join(basename_compressed);
@@ -193,15 +212,26 @@ where
193 &base_compressed,
212 &base_compressed,
194 &default_raw,
213 &default_raw,
195 std::slice::from_ref(&mise_directory_share),
214 std::slice::from_ref(&mise_directory_share),
215+ Some(&provision_log),
197− ensure_instance_disk(&instance_raw, &default_raw)?;
218+ let _ = ensure_instance_disk(
221+ ByteSize(args.disk_bytes),
224+ let base_size = fs::metadata(&default_raw)?.len();
225+ let instance_size = fs::metadata(&instance_raw)?.len();
226+ let needs_resize = instance_size > base_size;
198 let disk_path = instance_raw;
227 let disk_path = instance_raw;
200 let mut login_actions = Vec::new();
229 let mut login_actions = Vec::new();
201 let mut directory_shares = Vec::new();
230 let mut directory_shares = Vec::new();
203 if !args.no_default_mounts {
232 if !args.no_default_mounts {
233+ let project_guest_dir = PathBuf::from(PROJECT_GUEST_BASE).join(project_name);
204− login_actions.push(Send(format!("cd {project_name}")));
234+ login_actions.push(Send(format!("cd {}", project_guest_dir.display())));
206 // discourage read/write of .git folder from within the VM. note that this isn't secure, since the VM runs as root and could unmount this.
236 // discourage read/write of .git folder from within the VM. note that this isn't secure, since the VM runs as root and could unmount this.
207 // I couldn't find an alternative way to do this --- the MacOS sandbox doesn't apply to the Apple Virtualization system
237 // I couldn't find an alternative way to do this --- the MacOS sandbox doesn't apply to the Apple Virtualization system
@@ -209,15 +239,6 @@ where
209 login_actions.push(Send(r"mount -t tmpfs tmpfs .git/".into()));
239 login_actions.push(Send(r"mount -t tmpfs tmpfs .git/".into()));
212− directory_shares.push(
213− DirectoryShare::new(
215− PathBuf::from("/root/").join(project_name),
218− .expect("Project directory must exist"),
221 directory_shares.push(mise_directory_share);
242 directory_shares.push(mise_directory_share);
@@ -227,6 +248,11 @@ where
227 directory_shares.push(DirectoryShare::from_mount_spec(spec)?);
248 directory_shares.push(DirectoryShare::from_mount_spec(spec)?);
252+ let resize_cmd = script_command_from_content("resize_disk.sh", RESIZE_DISK_SCRIPT)?;
253+ login_actions.push(Send(resize_cmd));
230 if let Some(motd_action) = motd_login_action(&directory_shares) {
256 if let Some(motd_action) = motd_login_action(&directory_shares) {
231 login_actions.push(motd_action);
257 login_actions.push(motd_action);
@@ -239,34 +265,29 @@ where
239 &directory_shares[..],
265 &directory_shares[..],
240 args.cpu_count,
266 args.cpu_count,
241 args.ram_bytes,
267 args.ram_bytes,
242 io_handler,
269 io_handler,
246−fn script_command_from_path(
249−) -> Result<String, Box<dyn std::error::Error>> {
250− let script = fs::read_to_string(path)
251− .map_err(|err| format!("Failed to read script {}: {err}", path.display()))?;
252− let label = format!("{}_{}", index, path.file_name().unwrap().display());
253− script_command_from_content(&label, &script)
256−pub(crate) fn script_command_from_content(
273+pub fn script_command_from_content(label: &str, script: &str) -> Result<String> {
259−) -> Result<String, Box<dyn std::error::Error>> {
260 let marker = "VIBE_SCRIPT_EOF";
274 let marker = "VIBE_SCRIPT_EOF";
261 let guest_dir = "/tmp/vibe-scripts";
275 let guest_dir = "/tmp/vibe-scripts";
262 let guest_path = format!("{guest_dir}/{label}.sh");
276 let guest_path = format!("{guest_dir}/{label}.sh");
277+ let script_body = match script.split_once('\n') {
278+ Some((first, rest)) if first.starts_with("#!") => rest,
281+ let wrapped_script = ERROR_REPORT_SCRIPT
282+ .replace("__LABEL__", label)
283+ .replace("__SCRIPT_BODY__", script_body);
263 let command = format!(
284 let command = format!(
264− "mkdir -p {guest_dir}\ncat >{guest_path} <<'{marker}'\n{script}\n{marker}\nchmod +x {guest_path}\n{guest_path}"
285+ "mkdir -p {guest_dir}\ncat >{guest_path} <<'{marker}'\n{wrapped_script}\n{marker}\nchmod +x {guest_path}\n{guest_path}"
266 if script.contains(marker) {
287 if script.contains(marker) {
267− return Err(
288+ bail!(format!(
268− format!("Script '{label}' contains marker '{marker}', cannot safely upload").into(),
289+ "Script '{label}' contains marker '{marker}', cannot safely upload"
271 Ok(command)
292 Ok(command)
@@ -330,6 +351,12 @@ enum WaitResult {
354+#[derive(PartialEq, Eq)]
333pub enum VmInput {
360pub enum VmInput {
334 Bytes(Vec<u8>),
361 Bytes(Vec<u8>),
335 Shutdown,
362 Shutdown,
@@ -337,6 +364,7 @@ pub enum VmInput {
338enum VmOutput {
365enum VmOutput {
339 LoginActionTimeout { action: String, timeout: Duration },
366 LoginActionTimeout { action: String, timeout: Duration },
367+ LoginActionFailed { action: String, reason: String },
342#[derive(Default)]
370#[derive(Default)]
@@ -373,6 +401,41 @@ impl OutputMonitor {
373 WaitResult::Found
401 WaitResult::Found
405+ fn wait_for_any(&self, needles: &[&str], timeout: Duration) -> WaitAnyResult {
406+ let mut found: Option<usize> = None;
407+ let (_unused, timeout_result) = self
409+ .wait_timeout_while(self.buffer.lock().unwrap(), timeout, |buf| {
410+ if let Some((pos, idx, len)) = find_any(buf, needles) {
411+ *buf = buf[(pos + len)..].to_string();
420+ if timeout_result.timed_out() {
421+ WaitAnyResult::Timeout
423+ WaitAnyResult::Found(found.unwrap_or(0))
428+fn find_any(buf: &str, needles: &[&str]) -> Option<(usize, usize, usize)> {
429+ let mut best: Option<(usize, usize, usize)> = None; // (pos, idx, len)
430+ for (idx, needle) in needles.iter().enumerate() {
431+ if let Some(pos) = buf.find(needle) {
432+ let candidate = (pos, idx, needle.len());
433+ if best.is_none_or(|b| candidate.0 < b.0) {
434+ best = Some(candidate);
378#[derive(Debug)]
441#[derive(Debug)]
@@ -421,15 +484,17 @@ impl IoControl {
421fn ensure_base_image(
484fn ensure_base_image(
422 base_raw: &Path,
485 base_raw: &Path,
423 base_compressed: &Path,
486 base_compressed: &Path,
424−) -> Result<(), Box<dyn std::error::Error>> {
487+ status: Option<&StatusEmitter<'_>>,
425 if base_raw.exists() {
489 if base_raw.exists() {
426 return Ok(());
490 return Ok(());
429 if !base_compressed.exists()
493 if !base_compressed.exists()
430− || std::fs::metadata(base_compressed).map(|m| m.len())? < DEBIAN_COMPRESSED_SIZE_BYTES
494+ || fs::metadata(base_compressed).map(|m| m.len())? < DEBIAN_COMPRESSED_SIZE_BYTES
432− println!("Downloading base image...");
496+ emit_status(status, "downloading base image...");
497+ tracing::info!("downloading base image");
433 let status = Command::new("curl")
498 let status = Command::new("curl")
435 "--continue-at",
500 "--continue-at",
@@ -443,12 +508,14 @@ fn ensure_base_image(
444 .status()?;
509 .status()?;
445 if !status.success() {
510 if !status.success() {
446− return Err("Failed to download base image".into());
511+ bail!("failed to download base image");
450 // Check SHA
515 // Check SHA
517+ emit_status(status, "verifying base image...");
518+ tracing::info!("verifying base image...");
452 let input = format!("{} {}\n", DEBIAN_COMPRESSED_SHA, base_compressed.display());
519 let input = format!("{} {}\n", DEBIAN_COMPRESSED_SHA, base_compressed.display());
454 let mut child = Command::new("/usr/bin/shasum")
521 let mut child = Command::new("/usr/bin/shasum")
@@ -466,22 +533,25 @@ fn ensure_base_image(
467 let status = child.wait().expect("failed to wait on child");
534 let status = child.wait().expect("failed to wait on child");
468 if !status.success() {
535 if !status.success() {
469− return Err(format!("SHA validation failed for {DEBIAN_COMPRESSED_DISK_URL}").into());
537+ "SHA validation failed for {DEBIAN_COMPRESSED_DISK_URL}"
473− println!("Decompressing base image...");
542+ emit_status(status, "decompressing base image...");
543+ tracing::info!("decompressing base image...");
474 let status = Command::new("tar")
544 let status = Command::new("tar")
477 &base_compressed.to_string_lossy(),
547 &base_compressed.to_string_lossy(),
478 BASE_DISK_RAW_NAME,
548 BASE_DISK_RAW_NAME,
480− .stdout(std::fs::File::create(base_raw)?)
550+ .stdout(fs::File::create(base_raw)?)
481 .status()?;
551 .status()?;
483 if !status.success() {
553 if !status.success() {
484− return Err("Failed to decompress base image".into());
554+ bail!("Failed to decompress base image");
@@ -492,24 +562,56 @@ fn ensure_default_image(
492 base_compressed: &Path,
562 base_compressed: &Path,
493 default_raw: &Path,
563 default_raw: &Path,
494 directory_shares: &[DirectoryShare],
564 directory_shares: &[DirectoryShare],
495−) -> Result<(), Box<dyn std::error::Error>> {
565+ provision_log: Option<&Path>,
566+ status: Option<&StatusEmitter<'_>>,
496 if default_raw.exists() {
568 if default_raw.exists() {
497 return Ok(());
569 return Ok(());
500− ensure_base_image(base_raw, base_compressed)?;
572+ ensure_base_image(base_raw, base_compressed, status)?;
502− println!("Configuring base image...");
574+ emit_status(status, "configuring base image...");
575+ tracing::info!("configuring base image...");
503 fs::copy(base_raw, default_raw)?;
576 fs::copy(base_raw, default_raw)?;
505− let provision_command = script_command_from_content(PROVISION_SCRIPT_NAME, PROVISION_SCRIPT)?;
578+ let provision_command = script_command_from_content("provision.sh", PROVISION_SCRIPT)?;
506− run_vm(
579+ let provision_actions = [
508− &[Send(provision_command)],
580+ Send(provision_command),
582+ success: "VIBEBOX_PROVISION_OK".to_string(),
583+ failure: "VIBEBOX_PROVISION_FAILED".to_string(),
584+ timeout: PROVISION_EXPECT_TIMEOUT,
587+ let provision_result = if let Some(log_path) = provision_log {
588+ let log_path = log_path.to_path_buf();
593+ BoxConfig::default().cpu_count,
594+ BoxConfig::default().ram_size.as_u64(),
596+ move |output_monitor, vm_output_fd, vm_input_fd| {
597+ spawn_vm_io_with_log(output_monitor, vm_output_fd, vm_input_fd, log_path)
509− directory_shares,
604+ directory_shares,
510− DEFAULT_CPU_COUNT,
605+ BoxConfig::default().cpu_count,
511− DEFAULT_RAM_BYTES,
606+ BoxConfig::default().ram_size.as_u64(),
611+ if let Err(err) = provision_result {
612+ let _ = fs::remove_file(default_raw);
@@ -517,15 +619,47 @@ fn ensure_default_image(
517fn ensure_instance_disk(
619fn ensure_instance_disk(
518 instance_raw: &Path,
620 instance_raw: &Path,
519 template_raw: &Path,
621 template_raw: &Path,
520−) -> Result<(), Box<dyn std::error::Error>> {
622+ target_bytes: ByteSize,
623+ status: Option<&StatusEmitter<'_>>,
521 if instance_raw.exists() {
625 if instance_raw.exists() {
626+ let current_size = ByteSize(fs::metadata(instance_raw)?.len());
627+ if current_size != target_bytes {
628+ let current_gb = current_size;
629+ let target_gb = target_bytes;
631+ "instance disk size does not match config (current {}, config {}); disk_gb applies only on init. Run `vibebox reset` to recreate or set disk_gb to match; using existing disk.",
522− return Ok(());
636+ return Ok(false);
525− println!("Creating instance disk from {}...", template_raw.display());
639+ let template_size = ByteSize(fs::metadata(template_raw)?.len());
640+ if target_bytes < template_size {
642+ "Requested disk size {} is smaller than base image size {}",
643+ target_bytes, template_size
646+ let target_size = target_bytes;
647+ let needs_resize = target_size > template_size;
649+ emit_status(status, "creating instance disk...");
650+ tracing::info!("creating instance disk...");
651+ tracing::info!(path = %template_raw.display(), "creating instance disk");
526− std::fs::create_dir_all(instance_raw.parent().unwrap())?;
652+ fs::create_dir_all(instance_raw.parent().unwrap())?;
653+ if target_size == template_size {
527− fs::copy(template_raw, instance_raw)?;
654+ fs::copy(template_raw, instance_raw)?;
528− Ok(())
655+ return Ok(needs_resize);
658+ let mut dst = fs::File::create(instance_raw)?;
659+ dst.set_len(target_size.as_u64())?;
660+ let mut src = fs::File::open(template_raw)?;
661+ std::io::copy(&mut src, &mut dst)?;
531pub struct IoContext {
665pub struct IoContext {
@@ -541,18 +675,17 @@ pub fn create_pipe() -> (OwnedFd, OwnedFd) {
541 (read_stream.into(), write_stream.into())
675 (read_stream.into(), write_stream.into())
544−pub fn spawn_vm_io_with_hooks<F, G>(
678+pub fn spawn_vm_io_with_hooks<
679+ F: FnMut(&str) -> bool + std::marker::Send + 'static,
680+ G: FnMut(&[u8]) + std::marker::Send + 'static,
545 output_monitor: Arc<OutputMonitor>,
682 output_monitor: Arc<OutputMonitor>,
546 vm_output_fd: OwnedFd,
683 vm_output_fd: OwnedFd,
547 vm_input_fd: OwnedFd,
684 vm_input_fd: OwnedFd,
548 io_control: Arc<IoControl>,
685 io_control: Arc<IoControl>,
549 mut on_line: F,
686 mut on_line: F,
550 mut on_output: G,
687 mut on_output: G,
551−) -> IoContext
688+) -> IoContext {
553− F: FnMut(&str) -> bool + ::std::marker::Send + 'static,
554− G: FnMut(&[u8]) + ::std::marker::Send + 'static,
556 let (input_tx, input_rx): (Sender<VmInput>, Receiver<VmInput>) = mpsc::channel();
689 let (input_tx, input_rx): (Sender<VmInput>, Receiver<VmInput>) = mpsc::channel();
558 // raw_guard is set when we've put the user's terminal into raw mode because we've attached stdin/stdout to the VM.
691 // raw_guard is set when we've put the user's terminal into raw mode because we've attached stdin/stdout to the VM.
@@ -700,14 +833,14 @@ where
700 PollResult::Spurious => continue,
833 PollResult::Spurious => continue,
701 PollResult::Ready(bytes) => {
834 PollResult::Ready(bytes) => {
702 if io_control.forward_output() {
835 if io_control.forward_output() {
703− // enable raw mode, if we haven't already
836+ // enable raw mode if we haven't already
704 if raw_guard.lock().unwrap().is_none()
837 if raw_guard.lock().unwrap().is_none()
705 && let Ok(guard) = enable_raw_mode(libc::STDIN_FILENO)
838 && let Ok(guard) = enable_raw_mode(libc::STDIN_FILENO)
707 *raw_guard.lock().unwrap() = Some(guard);
840 *raw_guard.lock().unwrap() = Some(guard);
710− let mut stdout = std::io::stdout().lock();
843+ let mut stdout = io::stdout().lock();
711 if stdout.write_all(bytes).is_err() {
844 if stdout.write_all(bytes).is_err() {
@@ -723,7 +856,7 @@ where
724 // Copies data from mpsc channel into VM, so vibe can "type" stuff and run scripts.
857 // Copies data from mpsc channel into VM, so vibe can "type" stuff and run scripts.
725 let mux_thread = thread::spawn(move || {
858 let mux_thread = thread::spawn(move || {
726− let mut vm_writer = std::fs::File::from(vm_input_fd);
859+ let mut vm_writer = fs::File::from(vm_input_fd);
728 match input_rx.recv() {
861 match input_rx.recv() {
729 Ok(VmInput::Bytes(data)) => {
862 Ok(VmInput::Bytes(data)) => {
@@ -753,7 +886,7 @@ pub fn spawn_vm_io_with_line_handler<F>(
753 on_line: F,
886 on_line: F,
754) -> IoContext
887) -> IoContext
756− F: FnMut(&str) -> bool + ::std::marker::Send + 'static,
889+ F: FnMut(&str) -> bool + std::marker::Send + 'static,
758 spawn_vm_io_with_hooks(
891 spawn_vm_io_with_hooks(
759 output_monitor,
892 output_monitor,
@@ -773,6 +906,36 @@ pub fn spawn_vm_io(
773 spawn_vm_io_with_line_handler(output_monitor, vm_output_fd, vm_input_fd, |_| false)
906 spawn_vm_io_with_line_handler(output_monitor, vm_output_fd, vm_input_fd, |_| false)
909+fn spawn_vm_io_with_log(
910+ output_monitor: Arc<OutputMonitor>,
911+ vm_output_fd: OwnedFd,
912+ vm_input_fd: OwnedFd,
915+ let log_file = fs::OpenOptions::new()
921+ .map(|file| Arc::new(Mutex::new(file)));
923+ spawn_vm_io_with_hooks(
930+ if let Some(log) = &log_file
931+ && let Ok(mut file) = log.lock()
933+ let _ = file.write_all(bytes);
776impl IoContext {
939impl IoContext {
777 pub fn shutdown(self) {
940 pub fn shutdown(self) {
778 let _ = self.input_tx.send(VmInput::Shutdown);
941 let _ = self.input_tx.send(VmInput::Shutdown);
@@ -790,7 +953,7 @@ fn create_vm_configuration(
790 vm_writes_to_fd: OwnedFd,
953 vm_writes_to_fd: OwnedFd,
791 cpu_count: usize,
954 cpu_count: usize,
792 ram_bytes: u64,
955 ram_bytes: u64,
793−) -> Result<Retained<VZVirtualMachineConfiguration>, Box<dyn std::error::Error>> {
956+) -> Result<Retained<VZVirtualMachineConfiguration>> {
795 let platform =
958 let platform =
796 VZGenericPlatformConfiguration::init(VZGenericPlatformConfiguration::alloc());
959 VZGenericPlatformConfiguration::init(VZGenericPlatformConfiguration::alloc());
@@ -824,7 +987,7 @@ fn create_vm_configuration(
825 VZDiskImageCachingMode::Automatic,
988 VZDiskImageCachingMode::Automatic,
826 VZDiskImageSynchronizationMode::Full,
989 VZDiskImageSynchronizationMode::Full,
829 let disk_device = VZVirtioBlockDeviceConfiguration::initWithAttachment(
992 let disk_device = VZVirtioBlockDeviceConfiguration::initWithAttachment(
830 VZVirtioBlockDeviceConfiguration::alloc(),
993 VZVirtioBlockDeviceConfiguration::alloc(),
@@ -911,7 +1074,7 @@ fn create_vm_configuration(
911 // Validate
1074 // Validate
912 config.validateWithError().map_err(|e| {
1075 config.validateWithError().map_err(|e| {
913 io::Error::other(format!(
1076 io::Error::other(format!(
914− "Invalid VM configuration: {:?}",
1077+ "invalid VM configuration: {:?}",
915 e.localizedDescription()
1078 e.localizedDescription()
@@ -920,9 +1083,9 @@ fn create_vm_configuration(
923−fn load_efi_variable_store() -> Result<Retained<VZEFIVariableStore>, Box<dyn std::error::Error>> {
1086+fn load_efi_variable_store() -> Result<Retained<VZEFIVariableStore>> {
924 unsafe {
1087 unsafe {
925− let temp_dir = std::env::temp_dir();
1088+ let temp_dir = env::temp_dir();
926 let temp_path = temp_dir.join(format!("efi_variable_store_{}.efivars", std::process::id()));
1089 let temp_path = temp_dir.join(format!("efi_variable_store_{}.efivars", std::process::id()));
927 let url = nsurl_from_path(&temp_path)?;
1090 let url = nsurl_from_path(&temp_path)?;
928 let options = VZEFIVariableStoreInitializationOptions::AllowOverwrite;
1091 let options = VZEFIVariableStoreInitializationOptions::AllowOverwrite;
@@ -938,8 +1101,8 @@ fn load_efi_variable_store() -> Result<Retained<VZEFIVariableStore>, Box<dyn std
938fn spawn_login_actions_thread(
1101fn spawn_login_actions_thread(
939 login_actions: Vec<LoginAction>,
1102 login_actions: Vec<LoginAction>,
940 output_monitor: Arc<OutputMonitor>,
1103 output_monitor: Arc<OutputMonitor>,
941− input_tx: mpsc::Sender<VmInput>,
1104+ input_tx: Sender<VmInput>,
942− vm_output_tx: mpsc::Sender<VmOutput>,
1105+ vm_output_tx: Sender<VmOutput>,
943) -> thread::JoinHandle<()> {
1106) -> thread::JoinHandle<()> {
944 thread::spawn(move || {
1107 thread::spawn(move || {
945 for a in login_actions {
1108 for a in login_actions {
@@ -953,22 +1116,31 @@ fn spawn_login_actions_thread(
1123+ } => match output_monitor.wait_for_any(&[&success, &failure], timeout) {
1124+ WaitAnyResult::Found(0) => {}
1125+ WaitAnyResult::Found(_) => {
1126+ let _ = vm_output_tx.send(VmOutput::LoginActionFailed {
1127+ action: format!("expect '{}'", success),
1128+ reason: format!("saw failure marker '{}'", failure),
1132+ WaitAnyResult::Timeout => {
1133+ let _ = vm_output_tx.send(VmOutput::LoginActionTimeout {
1134+ action: format!("expect '{}'", success),
956 Send(mut text) => {
1140 Send(mut text) => {
957 text.push('\n'); // Type the newline so the command is actually submitted.
1141 text.push('\n'); // Type the newline so the command is actually submitted.
958 input_tx.send(VmInput::Bytes(text.into_bytes())).unwrap();
1142 input_tx.send(VmInput::Bytes(text.into_bytes())).unwrap();
960− Script { path, index } => {
961− let command = match script_command_from_path(&path, index) {
962− Ok(command) => command,
968− let mut text = command;
970− input_tx.send(VmInput::Bytes(text.into_bytes())).unwrap();
@@ -980,8 +1152,9 @@ fn run_vm_with_io<F>(
980 directory_shares: &[DirectoryShare],
1152 directory_shares: &[DirectoryShare],
981 cpu_count: usize,
1153 cpu_count: usize,
982 ram_bytes: u64,
1154 ram_bytes: u64,
1155+ status: Option<&StatusEmitter<'_>>,
983 io_handler: F,
1156 io_handler: F,
984−) -> Result<(), Box<dyn std::error::Error>>
1157+) -> Result<()>
986 F: FnOnce(Arc<OutputMonitor>, OwnedFd, OwnedFd) -> IoContext,
1159 F: FnOnce(Arc<OutputMonitor>, OwnedFd, OwnedFd) -> IoContext,
@@ -1028,21 +1201,23 @@ where
1029 match rx.try_recv() {
1202 match rx.try_recv() {
1030 Ok(result) => {
1203 Ok(result) => {
1031− result.map_err(|e| format!("Failed to start VM: {}", e))?;
1204+ result.map_err(|e| Error::msg(format!("Failed to start VM: {}", e)))?;
1034 Err(mpsc::TryRecvError::Empty) => continue,
1207 Err(mpsc::TryRecvError::Empty) => continue,
1035 Err(mpsc::TryRecvError::Disconnected) => {
1208 Err(mpsc::TryRecvError::Disconnected) => {
1036− return Err("VM start channel disconnected".into());
1209+ bail!("VM start channel disconnected");
1041 if Instant::now() >= start_deadline {
1214 if Instant::now() >= start_deadline {
1042− return Err("Timed out waiting for VM to start".into());
1215+ bail!("Timed out waiting for VM to start");
1045− println!("VM booting...");
1218+ emit_status(status, "vm booting... go vibecoder!");
1219+ tracing::info!("vm booting... go vibecoder!");
1220+ tracing::info!("vm booting");
1047 let output_monitor = Arc::new(OutputMonitor::default());
1222 let output_monitor = Arc::new(OutputMonitor::default());
1048 let io_ctx = io_handler(output_monitor.clone(), we_read_from, we_write_to);
1223 let io_ctx = io_handler(output_monitor.clone(), we_read_from, we_write_to);
@@ -1087,7 +1262,7 @@ where
1089 let mut last_state = None;
1264 let mut last_state = None;
1090− let mut exit_result = Ok(());
1265+ let mut exit_result: Result<(), String> = Ok(());
1092 unsafe {
1267 unsafe {
1093 NSRunLoop::mainRunLoop().runMode_beforeDate(
1268 NSRunLoop::mainRunLoop().runMode_beforeDate(
@@ -1106,12 +1281,28 @@ where
1106 exit_result = Err(format!(
1281 exit_result = Err(format!(
1107 "Login action ({}) timed out after {:?}; shutting down.",
1282 "Login action ({}) timed out after {:?}; shutting down.",
1108 action, timeout
1283 action, timeout
1111 unsafe {
1285 unsafe {
1112 if vm.canRequestStop() {
1286 if vm.canRequestStop() {
1113 if let Err(err) = vm.requestStopWithError() {
1287 if let Err(err) = vm.requestStopWithError() {
1114− eprintln!("Failed to request VM stop: {:?}", err);
1288+ tracing::error!(error = ?err, "failed to request VM stop");
1290+ } else if vm.canStop() {
1291+ let handler = RcBlock::new(|_error: *mut NSError| {});
1292+ vm.stopWithCompletionHandler(&handler);
1297+ Ok(VmOutput::LoginActionFailed { action, reason }) => {
1298+ exit_result = Err(format!(
1299+ "Login action ({}) failed: {}; shutting down.",
1303+ if vm.canRequestStop() {
1304+ if let Err(err) = vm.requestStopWithError() {
1305+ tracing::error!(error = ?err, "failed to request VM stop");
1116 } else if vm.canStop() {
1307 } else if vm.canStop() {
1117 let handler = RcBlock::new(|_error: *mut NSError| {});
1308 let handler = RcBlock::new(|_error: *mut NSError| {});
@@ -1123,7 +1314,7 @@ where
1123 Err(mpsc::TryRecvError::Empty) => {}
1314 Err(mpsc::TryRecvError::Empty) => {}
1124 Err(mpsc::TryRecvError::Disconnected) => {}
1315 Err(mpsc::TryRecvError::Disconnected) => {}
1126− if state != objc2_virtualization::VZVirtualMachineState::Running {
1317+ if state != VZVirtualMachineState::Running {
1127 //eprintln!("VM stopped with state: {:?}", state);
1318 //eprintln!("VM stopped with state: {:?}", state);
@@ -1133,7 +1324,7 @@ where
1134 io_ctx.shutdown();
1325 io_ctx.shutdown();
1136− exit_result
1327+ exit_result.map_err(Error::msg)
1139fn run_vm(
1330fn run_vm(
@@ -1142,18 +1333,20 @@ fn run_vm(
1142 directory_shares: &[DirectoryShare],
1333 directory_shares: &[DirectoryShare],
1143 cpu_count: usize,
1334 cpu_count: usize,
1144 ram_bytes: u64,
1335 ram_bytes: u64,
1145−) -> Result<(), Box<dyn std::error::Error>> {
1336+ status: Option<&StatusEmitter<'_>>,
1146 run_vm_with_io(
1338 run_vm_with_io(
1147 disk_path,
1339 disk_path,
1148 login_actions,
1340 login_actions,
1149 directory_shares,
1341 directory_shares,
1150 cpu_count,
1342 cpu_count,
1151 ram_bytes,
1343 ram_bytes,
1152 spawn_vm_io,
1345 spawn_vm_io,
1156−fn nsurl_from_path(path: &Path) -> Result<Retained<NSURL>, Box<dyn std::error::Error>> {
1349+fn nsurl_from_path(path: &Path) -> Result<Retained<NSURL>> {
1157 let abs_path = if path.is_absolute() {
1350 let abs_path = if path.is_absolute() {
1158 path.to_path_buf()
1351 path.to_path_buf()
1159 } else {
1352 } else {
@@ -1162,7 +1355,7 @@ fn nsurl_from_path(path: &Path) -> Result<Retained<NSURL>, Box<dyn std::error::E
1162 let ns_path = NSString::from_str(
1355 let ns_path = NSString::from_str(
1163 abs_path
1356 abs_path
1164 .to_str()
1357 .to_str()
1165− .ok_or("Non-UTF8 path encountered while building NSURL")?,
1358+ .with_context(|| "non-UTF8 path encountered while building NSURL")?,
1167 Ok(NSURL::fileURLWithPath(&ns_path))
1360 Ok(NSURL::fileURLWithPath(&ns_path))
@@ -1177,7 +1370,7 @@ fn enable_raw_mode(fd: i32) -> io::Result<RawModeGuard> {
1177 let original = attributes;
1370 let original = attributes;
1179 // Disable translation of carriage return to newline on input
1372 // Disable translation of carriage return to newline on input
1180− attributes.c_iflag &= !(libc::ICRNL);
1373+ attributes.c_iflag &= !libc::ICRNL;
1181 // Disable canonical mode (line buffering), echo, and signal generation
1374 // Disable canonical mode (line buffering), echo, and signal generation
1182 attributes.c_lflag &= !(libc::ICANON | libc::ECHO | libc::ISIG);
1375 attributes.c_lflag &= !(libc::ICANON | libc::ECHO | libc::ISIG);
1183 attributes.c_cc[libc::VMIN] = 0;
1376 attributes.c_cc[libc::VMIN] = 0;
@@ -1205,10 +1398,10 @@ impl Drop for RawModeGuard {
1206// Ensure the running binary has com.apple.security.virtualization entitlements by checking and, if not, signing and relaunching.
1399// Ensure the running binary has com.apple.security.virtualization entitlements by checking and, if not, signing and relaunching.
1207pub fn ensure_signed() {
1400pub fn ensure_signed() {
1208− if std::env::var("VIBEBOX_SKIP_CODESIGN").as_deref() == Ok("1") {
1401+ if env::var("VIBEBOX_SKIP_CODESIGN").as_deref() == Ok("1") {
1211− let exe = std::env::current_exe().expect("failed to get current exe path");
1404+ let exe = env::current_exe().expect("failed to get current exe path");
1212 let exe_str = exe.to_str().expect("exe path not valid utf-8");
1405 let exe_str = exe.to_str().expect("exe path not valid utf-8");
1214 let has_required_entitlements = {
1407 let has_required_entitlements = {
@@ -1230,10 +1423,10 @@ pub fn ensure_signed() {
1232 const ENTITLEMENTS: &str = include_str!("entitlements.plist");
1425 const ENTITLEMENTS: &str = include_str!("entitlements.plist");
1233− let entitlements_path = std::env::temp_dir().join("entitlements.plist");
1426+ let entitlements_path = env::temp_dir().join("entitlements.plist");
1234− std::fs::write(&entitlements_path, ENTITLEMENTS).expect("failed to write entitlements");
1427+ fs::write(&entitlements_path, ENTITLEMENTS).expect("failed to write entitlements");
1236− let status = Command::new("codesign")
1429+ let output = Command::new("codesign")
1238 "--sign",
1431 "--sign",
@@ -1242,22 +1435,27 @@ pub fn ensure_signed() {
1242 entitlements_path.to_str().unwrap(),
1435 entitlements_path.to_str().unwrap(),
1243 exe_str,
1436 exe_str,
1245− .status();
1438+ .output();
1247− let _ = std::fs::remove_file(&entitlements_path);
1440+ let _ = fs::remove_file(&entitlements_path);
1249− match status {
1442+ match output {
1250− Ok(s) if s.success() => {
1443+ Ok(o) if o.status.success() => {
1444+ let stderr = String::from_utf8_lossy(&o.stderr);
1445+ if !stderr.trim().is_empty() {
1446+ tracing::debug!(codesign_stderr = %stderr.trim(), "codesign output");
1251− let err = Command::new(&exe).args(std::env::args_os().skip(1)).exec();
1448+ let err = Command::new(&exe).args(env::args_os().skip(1)).exec();
1252− eprintln!("failed to re-exec after signing: {err}");
1449+ tracing::error!(error = %err, "failed to re-exec after signing");
1253 std::process::exit(1);
1450 std::process::exit(1);
1255− Ok(s) => {
1452+ Ok(o) => {
1256− eprintln!("codesign failed with status: {s}");
1453+ let stderr = String::from_utf8_lossy(&o.stderr);
1454+ tracing::error!(status = %o.status, codesign_stderr = %stderr.trim(), "codesign failed");
1257 std::process::exit(1);
1455 std::process::exit(1);
1259 Err(e) => {
1457 Err(e) => {
1260− eprintln!("failed to run codesign: {e}");
1458+ tracing::error!(error = %e, "failed to run codesign");
1261 std::process::exit(1);
1459 std::process::exit(1);