@@ -1,7 +1,7 @@
1−use crate::session_manager::{GLOBAL_CACHE_DIR_NAME, INSTANCE_DIR_NAME};
2−use anyhow::{Context, Error, Result, bail};
31use std::{
4− env, fs,
2+ env,
3+ ffi::OsString,
4+ fs,
55 io::{self, Write},
66 os::{
77 fd::RawFd,
@@ -23,8 +23,8 @@ use std::{
2323};
2424
2525use block2::RcBlock;
26−use bytesize::ByteSize;
2726use dispatch2::DispatchQueue;
27+use lexopt::prelude::*;
2828use objc2::{AnyThread, rc::Retained, runtime::ProtocolObject};
2929use objc2_foundation::*;
3030use objc2_virtualization::*;
@@ -33,46 +33,39 @@ const DEBIAN_COMPRESSED_DISK_URL: &str = "https://cloud.debian.org/images/cloud/
3333const DEBIAN_COMPRESSED_SHA: &str = "6ab9be9e6834adc975268367f2f0235251671184345c34ee13031749fdfbf66fe4c3aafd949a2d98550426090e9ac645e79009c51eb0eefc984c15786570bb38";
3434const DEBIAN_COMPRESSED_SIZE_BYTES: u64 = 280901576;
3535const SHARED_DIRECTORIES_TAG: &str = "shared";
36−pub const PROJECT_GUEST_BASE: &str = "/usr/local/vibebox-mounts";
3736
37+const BYTES_PER_MB: u64 = 1024 * 1024;
38+const DEFAULT_CPU_COUNT: usize = 2;
39+const DEFAULT_RAM_MB: u64 = 2048;
40+const DEFAULT_RAM_BYTES: u64 = DEFAULT_RAM_MB * BYTES_PER_MB;
3841const START_TIMEOUT: Duration = Duration::from_secs(60);
42+const DEFAULT_EXPECT_TIMEOUT: Duration = Duration::from_secs(30);
3943const LOGIN_EXPECT_TIMEOUT: Duration = Duration::from_secs(120);
40−const PROVISION_EXPECT_TIMEOUT: Duration = Duration::from_secs(900);
41−
42−const ERROR_REPORT_SCRIPT: &str = include_str!("error_report.sh");
4344const PROVISION_SCRIPT: &str = include_str!("provision.sh");
44−const RESIZE_DISK_SCRIPT: &str = include_str!("resize_disk.sh");
45−const DEFAULT_RAW_NAME: &str = "default.raw";
46−const INSTANCE_RAW_NAME: &str = "instance.raw";
47−const BASE_DISK_RAW_NAME: &str = "disk.raw";
4845
4946#[derive(Clone)]
50−pub enum LoginAction {
51− Expect {
52− text: String,
53− timeout: Duration,
54− },
55− ExpectEither {
56− success: String,
57− failure: String,
58− timeout: Duration,
59− },
47+pub(crate) enum LoginAction {
48+ Expect { text: String, timeout: Duration },
6049 Send(String),
50+ Script { path: PathBuf, index: usize },
6151}
62−use crate::config::BoxConfig;
6352use LoginAction::*;
6453
6554#[derive(Clone)]
66−pub struct DirectoryShare {
55+pub(crate) struct DirectoryShare {
6756 host: PathBuf,
6857 guest: PathBuf,
6958 read_only: bool,
7059}
7160
7261impl DirectoryShare {
73− pub fn new(host: PathBuf, mut guest: PathBuf, read_only: bool) -> Result<Self> {
62+ pub(crate) fn new(
63+ host: PathBuf,
64+ mut guest: PathBuf,
65+ read_only: bool,
66+ ) -> Result<Self, Box<dyn std::error::Error>> {
7467 if !host.exists() {
75− bail!(format!("host path does not exist: {}", host.display()));
68+ return Err(format!("Host path does not exist: {}", host.display()).into());
7669 }
7770 if !guest.is_absolute() {
7871 guest = PathBuf::from("/root").join(guest);
@@ -84,22 +77,23 @@ impl DirectoryShare {
8477 })
8578 }
8679
87− pub fn from_mount_spec(spec: &str) -> Result<Self> {
80+ pub(crate) fn from_mount_spec(spec: &str) -> Result<Self, Box<dyn std::error::Error>> {
8881 let parts: Vec<&str> = spec.split(':').collect();
8982 if parts.len() < 2 || parts.len() > 3 {
90− bail!(format!("invalid mount spec: {spec}"));
83+ return Err(format!("Invalid mount spec: {spec}").into());
9184 }
92− let host = expand_tilde_path(parts[0]);
85+ let host = PathBuf::from(parts[0]);
9386 let guest = PathBuf::from(parts[1]);
9487 let read_only = if parts.len() == 3 {
9588 match parts[2] {
9689 "read-only" => true,
9790 "read-write" => false,
9891 _ => {
99− bail!(format!(
92+ return Err(format!(
10093 "Invalid mount mode '{}'; expected read-only or read-write",
10194 parts[2]
102− ));
95+ )
96+ .into());
10397 }
10498 }
10599 } else {
@@ -122,49 +116,19 @@ impl DirectoryShare {
122116 }
123117}
124118
125−fn expand_tilde_path(value: &str) -> PathBuf {
126− if let Some(stripped) = value.strip_prefix("~/") {
127− if let Ok(home) = env::var("HOME") {
128− return PathBuf::from(home).join(stripped);
129− }
130− } else if value == "~"
131− && let Ok(home) = env::var("HOME")
132− {
133− return PathBuf::from(home);
134− }
135− PathBuf::from(value)
136−}
137−
138−pub struct VmArg {
139− pub cpu_count: usize,
140− pub ram_bytes: u64,
141− pub disk_bytes: u64,
142− pub no_default_mounts: bool,
143− pub mounts: Vec<String>,
144−}
145−
146−type StatusEmitter<'a> = dyn Fn(&str) + std::marker::Send + Sync + 'a;
147−
148−fn emit_status(status: Option<&StatusEmitter<'_>>, message: &str) {
149− if let Some(status) = status {
150− status(message);
151− }
152−}
153−
154−pub fn run_with_args<F>(args: VmArg, io_handler: F) -> Result<()>
119+pub fn run_with_args<F>(args: CliArgs, io_handler: F) -> Result<(), Box<dyn std::error::Error>>
155120where
156121 F: FnOnce(Arc<OutputMonitor>, OwnedFd, OwnedFd) -> IoContext,
157122{
158− run_with_args_and_extras(args, io_handler, Vec::new(), Vec::new(), None)
123+ run_with_args_and_extras(args, io_handler, Vec::new(), Vec::new())
159124}
160125
161−pub fn run_with_args_and_extras<F>(
162− args: VmArg,
126+pub(crate) fn run_with_args_and_extras<F>(
127+ args: CliArgs,
163128 io_handler: F,
164129 extra_login_actions: Vec<LoginAction>,
165130 extra_directory_shares: Vec<DirectoryShare>,
166− status: Option<&StatusEmitter<'_>>,
167−) -> Result<()>
131+) -> Result<(), Box<dyn std::error::Error>>
168132where
169133 F: FnOnce(Arc<OutputMonitor>, OwnedFd, OwnedFd) -> IoContext,
170134{
@@ -173,7 +137,7 @@ where
173137 let project_root = env::current_dir()?;
174138 let project_name = project_root
175139 .file_name()
176− .with_context(|| "Project directory has no name")?
140+ .ok_or("Project directory has no name")?
177141 .to_string_lossy()
178142 .into_owned();
179143
@@ -181,14 +145,10 @@ where
181145 let cache_home = env::var("XDG_CACHE_HOME")
182146 .map(PathBuf::from)
183147 .unwrap_or_else(|_| home.join(".cache"));
184− let cache_dir = cache_home.join(GLOBAL_CACHE_DIR_NAME);
148+ let cache_dir = cache_home.join("vibe");
185149 let guest_mise_cache = cache_dir.join(".guest-mise-cache");
186150
187− let instance_dir = project_root.join(INSTANCE_DIR_NAME);
188− fs::create_dir_all(&instance_dir)?;
189− emit_status(status, "preparing VM image...");
190− tracing::info!("preparing VM image...");
191− let provision_log = instance_dir.join("provision.log");
151+ let instance_dir = project_root.join(".vibe");
192152
193153 let basename_compressed = DEBIAN_COMPRESSED_DISK_URL.rsplit('/').next().unwrap();
194154 let base_compressed = cache_dir.join(basename_compressed);
@@ -197,8 +157,8 @@ where
197157 basename_compressed.trim_end_matches(".tar.xz")
198158 ));
199159
200− let default_raw = cache_dir.join(DEFAULT_RAW_NAME);
201− let instance_raw = instance_dir.join(INSTANCE_RAW_NAME);
160+ let default_raw = cache_dir.join("default.raw");
161+ let instance_raw = instance_dir.join("instance.raw");
202162
203163 // Prepare system-wide directories
204164 fs::create_dir_all(&cache_dir)?;
@@ -207,31 +167,28 @@ where
207167 let mise_directory_share =
208168 DirectoryShare::new(guest_mise_cache, "/root/.local/share/mise".into(), false)?;
209169
210− ensure_default_image(
211− &base_raw,
212− &base_compressed,
213− &default_raw,
214− std::slice::from_ref(&mise_directory_share),
215− Some(&provision_log),
216− status,
217− )?;
218− let _ = ensure_instance_disk(
219− &instance_raw,
220− &default_raw,
221− ByteSize(args.disk_bytes),
222− status,
223− )?;
224− let base_size = fs::metadata(&default_raw)?.len();
225− let instance_size = fs::metadata(&instance_raw)?.len();
226− let needs_resize = instance_size > base_size;
227− let disk_path = instance_raw;
170+ let disk_path = if let Some(path) = args.disk {
171+ if !path.exists() {
172+ return Err(format!("Disk image does not exist: {}", path.display()).into());
173+ }
174+ path
175+ } else {
176+ ensure_default_image(
177+ &base_raw,
178+ &base_compressed,
179+ &default_raw,
180+ std::slice::from_ref(&mise_directory_share),
181+ )?;
182+ ensure_instance_disk(&instance_raw, &default_raw)?;
183+
184+ instance_raw
185+ };
228186
229187 let mut login_actions = Vec::new();
230188 let mut directory_shares = Vec::new();
231189
232190 if !args.no_default_mounts {
233− let project_guest_dir = PathBuf::from(PROJECT_GUEST_BASE).join(project_name);
234− login_actions.push(Send(format!("cd {}", project_guest_dir.display())));
191+ login_actions.push(Send(format!("cd {project_name}")));
235192
236193 // discourage read/write of .git folder from within the VM. note that this isn't secure, since the VM runs as root and could unmount this.
237194 // I couldn't find an alternative way to do this --- the MacOS sandbox doesn't apply to the Apple Virtualization system
@@ -239,7 +196,32 @@ where
239196 login_actions.push(Send(r"mount -t tmpfs tmpfs .git/".into()));
240197 }
241198
199+ directory_shares.push(
200+ DirectoryShare::new(
201+ project_root,
202+ PathBuf::from("/root/").join(project_name),
203+ false,
204+ )
205+ .expect("Project directory must exist"),
206+ );
207+
242208 directory_shares.push(mise_directory_share);
209+
210+ // Add default shares, if they exist
211+ for share in [
212+ DirectoryShare::new(home.join(".codex"), "/usr/local/codex".into(), false),
213+ DirectoryShare::new(home.join(".claude"), "/usr/local/claude".into(), false),
214+ DirectoryShare::new(
215+ "/Users/zhangjie/Documents/Code/CompletePrograms/vibebox/.ssh".into(),
216+ "/usr/local/ssh".into(),
217+ true,
218+ ),
219+ ]
220+ .into_iter()
221+ .flatten()
222+ {
223+ directory_shares.push(share)
224+ }
243225 }
244226
245227 directory_shares.extend(extra_directory_shares);
@@ -248,46 +230,199 @@ where
248230 directory_shares.push(DirectoryShare::from_mount_spec(spec)?);
249231 }
250232
251− if needs_resize {
252− let resize_cmd = script_command_from_content("resize_disk.sh", RESIZE_DISK_SCRIPT)?;
253− login_actions.push(Send(resize_cmd));
254− }
255−
256233 if let Some(motd_action) = motd_login_action(&directory_shares) {
257234 login_actions.push(motd_action);
258235 }
259236
260237 login_actions.extend(extra_login_actions);
261238
239+ // Any user-provided login actions must come after our system ones
240+ login_actions.extend(args.login_actions);
241+
262242 run_vm_with_io(
263243 &disk_path,
264244 &login_actions,
265245 &directory_shares[..],
266246 args.cpu_count,
267247 args.ram_bytes,
268− status,
269248 io_handler,
270249 )
271250}
272251
273−pub fn script_command_from_content(label: &str, script: &str) -> Result<String> {
252+pub fn print_help() {
253+ println!(
254+ "Vibe is a quick way to spin up a Linux virtual machine on Mac to sandbox LLM agents.
255+
256+vibe [OPTIONS] [disk-image.raw]
257+
258+Options
259+
260+ --help Print this help message.
261+ --version Print the version (commit SHA).
262+ --no-default-mounts Disable all default mounts.
263+ --mount host-path:guest-path[:read-only | :read-write] Mount `host-path` inside VM at `guest-path`.
264+ Defaults to read-write.
265+ Errors if host-path does not exist.
266+ --cpus <count> Number of virtual CPUs (default {DEFAULT_CPU_COUNT}).
267+ --ram <megabytes> RAM size in megabytes (default {DEFAULT_RAM_MB}).
268+ --script <path/to/script.sh> Run script in VM.
269+ --send <some-command> Type `some-command` followed by newline into the VM.
270+ --expect <string> [timeout-seconds] Wait for `string` to appear in console output before executing next `--script` or `--send`.
271+ If `string` does not appear within timeout (default 30 seconds), shutdown VM with error.
272+"
273+ );
274+}
275+
276+pub fn print_version() {
277+ println!("Vibe");
278+ println!("https://github.com/lynaghk/vibe/");
279+ println!("Git SHA: {}", env!("GIT_SHA"));
280+}
281+
282+pub struct CliArgs {
283+ disk: Option<PathBuf>,
284+ version: bool,
285+ help: bool,
286+ no_default_mounts: bool,
287+ mounts: Vec<String>,
288+ login_actions: Vec<LoginAction>,
289+ cpu_count: usize,
290+ ram_bytes: u64,
291+}
292+
293+impl CliArgs {
294+ pub fn version(&self) -> bool {
295+ self.version
296+ }
297+
298+ pub fn help(&self) -> bool {
299+ self.help
300+ }
301+
302+ pub fn cpu_count(&self) -> usize {
303+ self.cpu_count
304+ }
305+
306+ pub fn ram_bytes(&self) -> u64 {
307+ self.ram_bytes
308+ }
309+
310+ pub fn ram_mb(&self) -> u64 {
311+ self.ram_bytes / BYTES_PER_MB
312+ }
313+}
314+
315+pub fn parse_cli() -> Result<CliArgs, Box<dyn std::error::Error>> {
316+ parse_cli_from(env::args_os())
317+}
318+
319+pub fn parse_cli_from<I>(args: I) -> Result<CliArgs, Box<dyn std::error::Error>>
320+where
321+ I: IntoIterator<Item = OsString>,
322+{
323+ fn os_to_string(value: OsString, flag: &str) -> Result<String, Box<dyn std::error::Error>> {
324+ value
325+ .into_string()
326+ .map_err(|_| format!("{flag} expects valid UTF-8").into())
327+ }
328+
329+ let mut parser = lexopt::Parser::from_iter(args);
330+ let mut disk = None;
331+ let mut version = false;
332+ let mut help = false;
333+ let mut no_default_mounts = false;
334+ let mut mounts = Vec::new();
335+ let mut login_actions = Vec::new();
336+ let mut script_index = 0;
337+ let mut cpu_count = DEFAULT_CPU_COUNT;
338+ let mut ram_bytes = DEFAULT_RAM_BYTES;
339+
340+ while let Some(arg) = parser.next()? {
341+ match arg {
342+ Long("version") => version = true,
343+ Long("help") | Short('h') => help = true,
344+ Long("no-default-mounts") => no_default_mounts = true,
345+ Long("cpus") => {
346+ let value = os_to_string(parser.value()?, "--cpus")?.parse()?;
347+ if value == 0 {
348+ return Err("--cpus must be >= 1".into());
349+ }
350+ cpu_count = value;
351+ }
352+ Long("ram") => {
353+ let value: u64 = os_to_string(parser.value()?, "--ram")?.parse()?;
354+ if value == 0 {
355+ return Err("--ram must be >= 1".into());
356+ }
357+ ram_bytes = value * BYTES_PER_MB;
358+ }
359+ Long("mount") => {
360+ mounts.push(os_to_string(parser.value()?, "--mount")?);
361+ }
362+ Long("script") => {
363+ login_actions.push(Script {
364+ path: os_to_string(parser.value()?, "--script")?.into(),
365+ index: script_index,
366+ });
367+ script_index += 1;
368+ }
369+ Long("send") => {
370+ login_actions.push(Send(os_to_string(parser.value()?, "--send")?));
371+ }
372+ Long("expect") => {
373+ let text = os_to_string(parser.value()?, "--expect")?;
374+ let timeout = match parser.optional_value() {
375+ Some(value) => Duration::from_secs(os_to_string(value, "--expect")?.parse()?),
376+ None => DEFAULT_EXPECT_TIMEOUT,
377+ };
378+ login_actions.push(Expect { text, timeout });
379+ }
380+ Value(value) => {
381+ if disk.is_some() {
382+ return Err("Only one disk path may be provided".into());
383+ }
384+ disk = Some(PathBuf::from(value));
385+ }
386+ _ => return Err(arg.unexpected().into()),
387+ }
388+ }
389+
390+ Ok(CliArgs {
391+ disk,
392+ version,
393+ help,
394+ no_default_mounts,
395+ mounts,
396+ login_actions,
397+ cpu_count,
398+ ram_bytes,
399+ })
400+}
401+
402+fn script_command_from_path(
403+ path: &Path,
404+ index: usize,
405+) -> Result<String, Box<dyn std::error::Error>> {
406+ let script = fs::read_to_string(path)
407+ .map_err(|err| format!("Failed to read script {}: {err}", path.display()))?;
408+ let label = format!("{}_{}", index, path.file_name().unwrap().display());
409+ script_command_from_content(&label, &script)
410+}
411+
412+pub(crate) fn script_command_from_content(
413+ label: &str,
414+ script: &str,
415+) -> Result<String, Box<dyn std::error::Error>> {
274416 let marker = "VIBE_SCRIPT_EOF";
275417 let guest_dir = "/tmp/vibe-scripts";
276418 let guest_path = format!("{guest_dir}/{label}.sh");
277− let script_body = match script.split_once('\n') {
278− Some((first, rest)) if first.starts_with("#!") => rest,
279− _ => script,
280− };
281− let wrapped_script = ERROR_REPORT_SCRIPT
282− .replace("__LABEL__", label)
283− .replace("__SCRIPT_BODY__", script_body);
284419 let command = format!(
285− "mkdir -p {guest_dir}\ncat >{guest_path} <<'{marker}'\n{wrapped_script}\n{marker}\nchmod +x {guest_path}\n{guest_path}"
420+ "mkdir -p {guest_dir}\ncat >{guest_path} <<'{marker}'\n{script}\n{marker}\nchmod +x {guest_path}\n{guest_path}"
286421 );
287422 if script.contains(marker) {
288− bail!(format!(
289− "Script '{label}' contains marker '{marker}', cannot safely upload"
290− ));
423+ return Err(
424+ format!("Script '{label}' contains marker '{marker}', cannot safely upload").into(),
425+ );
291426 }
292427 Ok(command)
293428}
@@ -351,12 +486,6 @@ enum WaitResult {
351486 Found,
352487}
353488
354−#[derive(PartialEq, Eq)]
355−enum WaitAnyResult {
356− Timeout,
357− Found(usize),
358−}
359−
360489pub enum VmInput {
361490 Bytes(Vec<u8>),
362491 Shutdown,
@@ -364,7 +493,6 @@ pub enum VmInput {
364493
365494enum VmOutput {
366495 LoginActionTimeout { action: String, timeout: Duration },
367− LoginActionFailed { action: String, reason: String },
368496}
369497
370498#[derive(Default)]
@@ -401,41 +529,6 @@ impl OutputMonitor {
401529 WaitResult::Found
402530 }
403531 }
404−
405− fn wait_for_any(&self, needles: &[&str], timeout: Duration) -> WaitAnyResult {
406− let mut found: Option<usize> = None;
407− let (_unused, timeout_result) = self
408− .condvar
409− .wait_timeout_while(self.buffer.lock().unwrap(), timeout, |buf| {
410− if let Some((pos, idx, len)) = find_any(buf, needles) {
411− *buf = buf[(pos + len)..].to_string();
412− found = Some(idx);
413− false
414− } else {
415− true
416− }
417− })
418− .unwrap();
419−
420− if timeout_result.timed_out() {
421− WaitAnyResult::Timeout
422− } else {
423− WaitAnyResult::Found(found.unwrap_or(0))
424− }
425− }
426−}
427−
428−fn find_any(buf: &str, needles: &[&str]) -> Option<(usize, usize, usize)> {
429− let mut best: Option<(usize, usize, usize)> = None; // (pos, idx, len)
430− for (idx, needle) in needles.iter().enumerate() {
431− if let Some(pos) = buf.find(needle) {
432− let candidate = (pos, idx, needle.len());
433− if best.is_none_or(|b| candidate.0 < b.0) {
434− best = Some(candidate);
435− }
436− }
437− }
438− best
439532}
440533
441534#[derive(Debug)]
@@ -484,17 +577,15 @@ impl IoControl {
484577fn ensure_base_image(
485578 base_raw: &Path,
486579 base_compressed: &Path,
487− status: Option<&StatusEmitter<'_>>,
488−) -> Result<()> {
580+) -> Result<(), Box<dyn std::error::Error>> {
489581 if base_raw.exists() {
490582 return Ok(());
491583 }
492584
493585 if !base_compressed.exists()
494− || fs::metadata(base_compressed).map(|m| m.len())? < DEBIAN_COMPRESSED_SIZE_BYTES
586+ || std::fs::metadata(base_compressed).map(|m| m.len())? < DEBIAN_COMPRESSED_SIZE_BYTES
495587 {
496− emit_status(status, "downloading base image...");
497− tracing::info!("downloading base image");
588+ println!("Downloading base image...");
498589 let status = Command::new("curl")
499590 .args([
500591 "--continue-at",
@@ -508,14 +599,12 @@ fn ensure_base_image(
508599 ])
509600 .status()?;
510601 if !status.success() {
511− bail!("failed to download base image");
602+ return Err("Failed to download base image".into());
512603 }
513604 }
514605
515606 // Check SHA
516607 {
517− emit_status(status, "verifying base image...");
518− tracing::info!("verifying base image...");
519608 let input = format!("{} {}\n", DEBIAN_COMPRESSED_SHA, base_compressed.display());
520609
521610 let mut child = Command::new("/usr/bin/shasum")
@@ -533,25 +622,18 @@ fn ensure_base_image(
533622
534623 let status = child.wait().expect("failed to wait on child");
535624 if !status.success() {
536− bail!(format!(
537− "SHA validation failed for {DEBIAN_COMPRESSED_DISK_URL}"
538− ));
625+ return Err(format!("SHA validation failed for {DEBIAN_COMPRESSED_DISK_URL}").into());
539626 }
540627 }
541628
542− emit_status(status, "decompressing base image...");
543− tracing::info!("decompressing base image...");
629+ println!("Decompressing base image...");
544630 let status = Command::new("tar")
545− .args([
546− "-xOf",
547− &base_compressed.to_string_lossy(),
548− BASE_DISK_RAW_NAME,
549− ])
550− .stdout(fs::File::create(base_raw)?)
631+ .args(["-xOf", &base_compressed.to_string_lossy(), "disk.raw"])
632+ .stdout(std::fs::File::create(base_raw)?)
551633 .status()?;
552634
553635 if !status.success() {
554− bail!("Failed to decompress base image");
636+ return Err("Failed to decompress base image".into());
555637 }
556638
557639 Ok(())
@@ -562,56 +644,24 @@ fn ensure_default_image(
562644 base_compressed: &Path,
563645 default_raw: &Path,
564646 directory_shares: &[DirectoryShare],
565− provision_log: Option<&Path>,
566− status: Option<&StatusEmitter<'_>>,
567−) -> Result<()> {
647+) -> Result<(), Box<dyn std::error::Error>> {
568648 if default_raw.exists() {
569649 return Ok(());
570650 }
571651
572− ensure_base_image(base_raw, base_compressed, status)?;
652+ ensure_base_image(base_raw, base_compressed)?;
573653
574− emit_status(status, "configuring base image...");
575− tracing::info!("configuring base image...");
654+ println!("Configuring base image...");
576655 fs::copy(base_raw, default_raw)?;
577656
578657 let provision_command = script_command_from_content("provision.sh", PROVISION_SCRIPT)?;
579− let provision_actions = [
580− Send(provision_command),
581− ExpectEither {
582− success: "VIBEBOX_PROVISION_OK".to_string(),
583− failure: "VIBEBOX_PROVISION_FAILED".to_string(),
584− timeout: PROVISION_EXPECT_TIMEOUT,
585− },
586− ];
587− let provision_result = if let Some(log_path) = provision_log {
588− let log_path = log_path.to_path_buf();
589− run_vm_with_io(
590− default_raw,
591− &provision_actions,
592− directory_shares,
593− BoxConfig::default().cpu_count,
594− BoxConfig::default().ram_size.as_u64(),
595− status,
596− move |output_monitor, vm_output_fd, vm_input_fd| {
597− spawn_vm_io_with_log(output_monitor, vm_output_fd, vm_input_fd, log_path)
598− },
599− )
600− } else {
601− run_vm(
602− default_raw,
603− &provision_actions,
604− directory_shares,
605− BoxConfig::default().cpu_count,
606− BoxConfig::default().ram_size.as_u64(),
607− status,
608− )
609− };
610−
611− if let Err(err) = provision_result {
612− let _ = fs::remove_file(default_raw);
613− return Err(err);
614− }
658+ run_vm(
659+ default_raw,
660+ &[Send(provision_command)],
661+ directory_shares,
662+ DEFAULT_CPU_COUNT,
663+ DEFAULT_RAM_BYTES,
664+ )?;
615665
616666 Ok(())
617667}
@@ -619,47 +669,15 @@ fn ensure_default_image(
619669fn ensure_instance_disk(
620670 instance_raw: &Path,
621671 template_raw: &Path,
622− target_bytes: ByteSize,
623− status: Option<&StatusEmitter<'_>>,
624−) -> Result<bool> {
672+) -> Result<(), Box<dyn std::error::Error>> {
625673 if instance_raw.exists() {
626− let current_size = ByteSize(fs::metadata(instance_raw)?.len());
627− if current_size != target_bytes {
628− let current_gb = current_size;
629− let target_gb = target_bytes;
630− tracing::warn!(
631− "instance disk size does not match config (current {}, config {}); disk_gb applies only on init. Run `vibebox reset` to recreate or set disk_gb to match; using existing disk.",
632− current_gb,
633− target_gb
634− );
635− }
636− return Ok(false);
637− }
638−
639− let template_size = ByteSize(fs::metadata(template_raw)?.len());
640− if target_bytes < template_size {
641− bail!(format!(
642− "Requested disk size {} is smaller than base image size {}",
643− target_bytes, template_size
644− ));
645− }
646− let target_size = target_bytes;
647− let needs_resize = target_size > template_size;
648−
649− emit_status(status, "creating instance disk...");
650− tracing::info!("creating instance disk...");
651− tracing::info!(path = %template_raw.display(), "creating instance disk");
652− fs::create_dir_all(instance_raw.parent().unwrap())?;
653− if target_size == template_size {
654− fs::copy(template_raw, instance_raw)?;
655− return Ok(needs_resize);
674+ return Ok(());
656675 }
657676
658− let mut dst = fs::File::create(instance_raw)?;
659− dst.set_len(target_size.as_u64())?;
660− let mut src = fs::File::open(template_raw)?;
661− std::io::copy(&mut src, &mut dst)?;
662− Ok(needs_resize)
677+ println!("Creating instance disk from {}...", template_raw.display());
678+ std::fs::create_dir_all(instance_raw.parent().unwrap())?;
679+ fs::copy(template_raw, instance_raw)?;
680+ Ok(())
663681}
664682
665683pub struct IoContext {
@@ -675,17 +693,18 @@ pub fn create_pipe() -> (OwnedFd, OwnedFd) {
675693 (read_stream.into(), write_stream.into())
676694}
677695
678−pub fn spawn_vm_io_with_hooks<
679− F: FnMut(&str) -> bool + std::marker::Send + 'static,
680− G: FnMut(&[u8]) + std::marker::Send + 'static,
681−>(
696+pub fn spawn_vm_io_with_hooks<F, G>(
682697 output_monitor: Arc<OutputMonitor>,
683698 vm_output_fd: OwnedFd,
684699 vm_input_fd: OwnedFd,
685700 io_control: Arc<IoControl>,
686701 mut on_line: F,
687702 mut on_output: G,
688−) -> IoContext {
703+) -> IoContext
704+where
705+ F: FnMut(&str) -> bool + ::std::marker::Send + 'static,
706+ G: FnMut(&[u8]) + ::std::marker::Send + 'static,
707+{
689708 let (input_tx, input_rx): (Sender<VmInput>, Receiver<VmInput>) = mpsc::channel();
690709
691710 // raw_guard is set when we've put the user's terminal into raw mode because we've attached stdin/stdout to the VM.
@@ -833,14 +852,14 @@ pub fn spawn_vm_io_with_hooks<
833852 PollResult::Spurious => continue,
834853 PollResult::Ready(bytes) => {
835854 if io_control.forward_output() {
836− // enable raw mode if we haven't already
855+ // enable raw mode, if we haven't already
837856 if raw_guard.lock().unwrap().is_none()
838857 && let Ok(guard) = enable_raw_mode(libc::STDIN_FILENO)
839858 {
840859 *raw_guard.lock().unwrap() = Some(guard);
841860 }
842861
843− let mut stdout = io::stdout().lock();
862+ let mut stdout = std::io::stdout().lock();
844863 if stdout.write_all(bytes).is_err() {
845864 break;
846865 }
@@ -856,7 +875,7 @@ pub fn spawn_vm_io_with_hooks<
856875
857876 // Copies data from mpsc channel into VM, so vibe can "type" stuff and run scripts.
858877 let mux_thread = thread::spawn(move || {
859− let mut vm_writer = fs::File::from(vm_input_fd);
878+ let mut vm_writer = std::fs::File::from(vm_input_fd);
860879 loop {
861880 match input_rx.recv() {
862881 Ok(VmInput::Bytes(data)) => {
@@ -886,7 +905,7 @@ pub fn spawn_vm_io_with_line_handler<F>(
886905 on_line: F,
887906) -> IoContext
888907where
889− F: FnMut(&str) -> bool + std::marker::Send + 'static,
908+ F: FnMut(&str) -> bool + ::std::marker::Send + 'static,
890909{
891910 spawn_vm_io_with_hooks(
892911 output_monitor,
@@ -906,36 +925,6 @@ pub fn spawn_vm_io(
906925 spawn_vm_io_with_line_handler(output_monitor, vm_output_fd, vm_input_fd, |_| false)
907926}
908927
909−fn spawn_vm_io_with_log(
910− output_monitor: Arc<OutputMonitor>,
911− vm_output_fd: OwnedFd,
912− vm_input_fd: OwnedFd,
913− log_path: PathBuf,
914−) -> IoContext {
915− let log_file = fs::OpenOptions::new()
916− .create(true)
917− .write(true)
918− .truncate(true)
919− .open(&log_path)
920− .ok()
921− .map(|file| Arc::new(Mutex::new(file)));
922−
923− spawn_vm_io_with_hooks(
924− output_monitor,
925− vm_output_fd,
926− vm_input_fd,
927− IoControl::new(),
928− |_| false,
929− move |bytes| {
930− if let Some(log) = &log_file
931− && let Ok(mut file) = log.lock()
932− {
933− let _ = file.write_all(bytes);
934− }
935− },
936− )
937−}
938−
939928impl IoContext {
940929 pub fn shutdown(self) {
941930 let _ = self.input_tx.send(VmInput::Shutdown);
@@ -953,7 +942,7 @@ fn create_vm_configuration(
953942 vm_writes_to_fd: OwnedFd,
954943 cpu_count: usize,
955944 ram_bytes: u64,
956−) -> Result<Retained<VZVirtualMachineConfiguration>> {
945+) -> Result<Retained<VZVirtualMachineConfiguration>, Box<dyn std::error::Error>> {
957946 unsafe {
958947 let platform =
959948 VZGenericPlatformConfiguration::init(VZGenericPlatformConfiguration::alloc());
@@ -987,7 +976,7 @@ fn create_vm_configuration(
987976 false,
988977 VZDiskImageCachingMode::Automatic,
989978 VZDiskImageSynchronizationMode::Full,
990− )?;
979+ ).unwrap();
991980
992981 let disk_device = VZVirtioBlockDeviceConfiguration::initWithAttachment(
993982 VZVirtioBlockDeviceConfiguration::alloc(),
@@ -1074,7 +1063,7 @@ fn create_vm_configuration(
10741063 // Validate
10751064 config.validateWithError().map_err(|e| {
10761065 io::Error::other(format!(
1077− "invalid VM configuration: {:?}",
1066+ "Invalid VM configuration: {:?}",
10781067 e.localizedDescription()
10791068 ))
10801069 })?;
@@ -1083,9 +1072,9 @@ fn create_vm_configuration(
10831072 }
10841073}
10851074
1086−fn load_efi_variable_store() -> Result<Retained<VZEFIVariableStore>> {
1075+fn load_efi_variable_store() -> Result<Retained<VZEFIVariableStore>, Box<dyn std::error::Error>> {
10871076 unsafe {
1088− let temp_dir = env::temp_dir();
1077+ let temp_dir = std::env::temp_dir();
10891078 let temp_path = temp_dir.join(format!("efi_variable_store_{}.efivars", std::process::id()));
10901079 let url = nsurl_from_path(&temp_path)?;
10911080 let options = VZEFIVariableStoreInitializationOptions::AllowOverwrite;
@@ -1101,8 +1090,8 @@ fn load_efi_variable_store() -> Result<Retained<VZEFIVariableStore>> {
11011090fn spawn_login_actions_thread(
11021091 login_actions: Vec<LoginAction>,
11031092 output_monitor: Arc<OutputMonitor>,
1104− input_tx: Sender<VmInput>,
1105− vm_output_tx: Sender<VmOutput>,
1093+ input_tx: mpsc::Sender<VmInput>,
1094+ vm_output_tx: mpsc::Sender<VmOutput>,
11061095) -> thread::JoinHandle<()> {
11071096 thread::spawn(move || {
11081097 for a in login_actions {
@@ -1116,31 +1105,22 @@ fn spawn_login_actions_thread(
11161105 return;
11171106 }
11181107 }
1119− ExpectEither {
1120− success,
1121− failure,
1122− timeout,
1123− } => match output_monitor.wait_for_any(&[&success, &failure], timeout) {
1124− WaitAnyResult::Found(0) => {}
1125− WaitAnyResult::Found(_) => {
1126− let _ = vm_output_tx.send(VmOutput::LoginActionFailed {
1127− action: format!("expect '{}'", success),
1128− reason: format!("saw failure marker '{}'", failure),
1129− });
1130− return;
1131− }
1132− WaitAnyResult::Timeout => {
1133− let _ = vm_output_tx.send(VmOutput::LoginActionTimeout {
1134− action: format!("expect '{}'", success),
1135− timeout,
1136− });
1137− return;
1138− }
1139− },
11401108 Send(mut text) => {
11411109 text.push('\n'); // Type the newline so the command is actually submitted.
11421110 input_tx.send(VmInput::Bytes(text.into_bytes())).unwrap();
11431111 }
1112+ Script { path, index } => {
1113+ let command = match script_command_from_path(&path, index) {
1114+ Ok(command) => command,
1115+ Err(err) => {
1116+ eprintln!("{err}");
1117+ return;
1118+ }
1119+ };
1120+ let mut text = command;
1121+ text.push('\n');
1122+ input_tx.send(VmInput::Bytes(text.into_bytes())).unwrap();
1123+ }
11441124 }
11451125 }
11461126 })
@@ -1152,9 +1132,8 @@ fn run_vm_with_io<F>(
11521132 directory_shares: &[DirectoryShare],
11531133 cpu_count: usize,
11541134 ram_bytes: u64,
1155− status: Option<&StatusEmitter<'_>>,
11561135 io_handler: F,
1157−) -> Result<()>
1136+) -> Result<(), Box<dyn std::error::Error>>
11581137where
11591138 F: FnOnce(Arc<OutputMonitor>, OwnedFd, OwnedFd) -> IoContext,
11601139{
@@ -1201,23 +1180,21 @@ where
12011180
12021181 match rx.try_recv() {
12031182 Ok(result) => {
1204− result.map_err(|e| Error::msg(format!("Failed to start VM: {}", e)))?;
1183+ result.map_err(|e| format!("Failed to start VM: {}", e))?;
12051184 break;
12061185 }
12071186 Err(mpsc::TryRecvError::Empty) => continue,
12081187 Err(mpsc::TryRecvError::Disconnected) => {
1209− bail!("VM start channel disconnected");
1188+ return Err("VM start channel disconnected".into());
12101189 }
12111190 }
12121191 }
12131192
12141193 if Instant::now() >= start_deadline {
1215− bail!("Timed out waiting for VM to start");
1194+ return Err("Timed out waiting for VM to start".into());
12161195 }
12171196
1218− emit_status(status, "vm booting... go vibecoder!");
1219− tracing::info!("vm booting... go vibecoder!");
1220− tracing::info!("vm booting");
1197+ println!("VM booting...");
12211198
12221199 let output_monitor = Arc::new(OutputMonitor::default());
12231200 let io_ctx = io_handler(output_monitor.clone(), we_read_from, we_write_to);
@@ -1262,7 +1239,7 @@ where
12621239 );
12631240
12641241 let mut last_state = None;
1265− let mut exit_result: Result<(), String> = Ok(());
1242+ let mut exit_result = Ok(());
12661243 loop {
12671244 unsafe {
12681245 NSRunLoop::mainRunLoop().runMode_beforeDate(
@@ -1281,28 +1258,12 @@ where
12811258 exit_result = Err(format!(
12821259 "Login action ({}) timed out after {:?}; shutting down.",
12831260 action, timeout
1284− ));
1261+ )
1262+ .into());
12851263 unsafe {
12861264 if vm.canRequestStop() {
12871265 if let Err(err) = vm.requestStopWithError() {
1288− tracing::error!(error = ?err, "failed to request VM stop");
1289− }
1290− } else if vm.canStop() {
1291− let handler = RcBlock::new(|_error: *mut NSError| {});
1292− vm.stopWithCompletionHandler(&handler);
1293− }
1294− }
1295− break;
1296− }
1297− Ok(VmOutput::LoginActionFailed { action, reason }) => {
1298− exit_result = Err(format!(
1299− "Login action ({}) failed: {}; shutting down.",
1300− action, reason
1301− ));
1302− unsafe {
1303− if vm.canRequestStop() {
1304− if let Err(err) = vm.requestStopWithError() {
1305− tracing::error!(error = ?err, "failed to request VM stop");
1266+ eprintln!("Failed to request VM stop: {:?}", err);
13061267 }
13071268 } else if vm.canStop() {
13081269 let handler = RcBlock::new(|_error: *mut NSError| {});
@@ -1314,7 +1275,7 @@ where
13141275 Err(mpsc::TryRecvError::Empty) => {}
13151276 Err(mpsc::TryRecvError::Disconnected) => {}
13161277 }
1317− if state != VZVirtualMachineState::Running {
1278+ if state != objc2_virtualization::VZVirtualMachineState::Running {
13181279 //eprintln!("VM stopped with state: {:?}", state);
13191280 break;
13201281 }
@@ -1324,7 +1285,7 @@ where
13241285
13251286 io_ctx.shutdown();
13261287
1327− exit_result.map_err(Error::msg)
1288+ exit_result
13281289}
13291290
13301291fn run_vm(
@@ -1333,20 +1294,18 @@ fn run_vm(
13331294 directory_shares: &[DirectoryShare],
13341295 cpu_count: usize,
13351296 ram_bytes: u64,
1336− status: Option<&StatusEmitter<'_>>,
1337−) -> Result<()> {
1297+) -> Result<(), Box<dyn std::error::Error>> {
13381298 run_vm_with_io(
13391299 disk_path,
13401300 login_actions,
13411301 directory_shares,
13421302 cpu_count,
13431303 ram_bytes,
1344− status,
13451304 spawn_vm_io,
13461305 )
13471306}
13481307
1349−fn nsurl_from_path(path: &Path) -> Result<Retained<NSURL>> {
1308+fn nsurl_from_path(path: &Path) -> Result<Retained<NSURL>, Box<dyn std::error::Error>> {
13501309 let abs_path = if path.is_absolute() {
13511310 path.to_path_buf()
13521311 } else {
@@ -1355,7 +1314,7 @@ fn nsurl_from_path(path: &Path) -> Result<Retained<NSURL>> {
13551314 let ns_path = NSString::from_str(
13561315 abs_path
13571316 .to_str()
1358− .with_context(|| "non-UTF8 path encountered while building NSURL")?,
1317+ .ok_or("Non-UTF8 path encountered while building NSURL")?,
13591318 );
13601319 Ok(NSURL::fileURLWithPath(&ns_path))
13611320}
@@ -1370,7 +1329,7 @@ fn enable_raw_mode(fd: i32) -> io::Result<RawModeGuard> {
13701329 let original = attributes;
13711330
13721331 // Disable translation of carriage return to newline on input
1373− attributes.c_iflag &= !libc::ICRNL;
1332+ attributes.c_iflag &= !(libc::ICRNL);
13741333 // Disable canonical mode (line buffering), echo, and signal generation
13751334 attributes.c_lflag &= !(libc::ICANON | libc::ECHO | libc::ISIG);
13761335 attributes.c_cc[libc::VMIN] = 0;
@@ -1398,10 +1357,7 @@ impl Drop for RawModeGuard {
13981357
13991358// Ensure the running binary has com.apple.security.virtualization entitlements by checking and, if not, signing and relaunching.
14001359pub fn ensure_signed() {
1401− if env::var("VIBEBOX_SKIP_CODESIGN").as_deref() == Ok("1") {
1402− return;
1403− }
1404− let exe = env::current_exe().expect("failed to get current exe path");
1360+ let exe = std::env::current_exe().expect("failed to get current exe path");
14051361 let exe_str = exe.to_str().expect("exe path not valid utf-8");
14061362
14071363 let has_required_entitlements = {
@@ -1423,10 +1379,10 @@ pub fn ensure_signed() {
14231379 }
14241380
14251381 const ENTITLEMENTS: &str = include_str!("entitlements.plist");
1426− let entitlements_path = env::temp_dir().join("entitlements.plist");
1427− fs::write(&entitlements_path, ENTITLEMENTS).expect("failed to write entitlements");
1382+ let entitlements_path = std::env::temp_dir().join("entitlements.plist");
1383+ std::fs::write(&entitlements_path, ENTITLEMENTS).expect("failed to write entitlements");
14281384
1429− let output = Command::new("codesign")
1385+ let status = Command::new("codesign")
14301386 .args([
14311387 "--sign",
14321388 "-",
@@ -1435,27 +1391,22 @@ pub fn ensure_signed() {
14351391 entitlements_path.to_str().unwrap(),
14361392 exe_str,
14371393 ])
1438− .output();
1394+ .status();
14391395
1440− let _ = fs::remove_file(&entitlements_path);
1396+ let _ = std::fs::remove_file(&entitlements_path);
14411397
1442− match output {
1443− Ok(o) if o.status.success() => {
1444− let stderr = String::from_utf8_lossy(&o.stderr);
1445− if !stderr.trim().is_empty() {
1446− tracing::debug!(codesign_stderr = %stderr.trim(), "codesign output");
1447− }
1448− let err = Command::new(&exe).args(env::args_os().skip(1)).exec();
1449− tracing::error!(error = %err, "failed to re-exec after signing");
1398+ match status {
1399+ Ok(s) if s.success() => {
1400+ let err = Command::new(&exe).args(std::env::args_os().skip(1)).exec();
1401+ eprintln!("failed to re-exec after signing: {err}");
14501402 std::process::exit(1);
14511403 }
1452− Ok(o) => {
1453− let stderr = String::from_utf8_lossy(&o.stderr);
1454− tracing::error!(status = %o.status, codesign_stderr = %stderr.trim(), "codesign failed");
1404+ Ok(s) => {
1405+ eprintln!("codesign failed with status: {s}");
14551406 std::process::exit(1);
14561407 }
14571408 Err(e) => {
1458− tracing::error!(error = %e, "failed to run codesign");
1409+ eprintln!("failed to run codesign: {e}");
14591410 std::process::exit(1);
14601411 }
14611412 }