on master help sign in
Bump version, update changelog
commitb3504fbcb0430a8ef8bc5cf254dbcf01d390a51a authorJonathan Daugherty <cygnus@foobox.com> dateSun 27 Feb 2022, 15:23 (5 years ago) parent9891504
2 files changed+30−1
CHANGELOG.md+29 vty.cabal+1−1
CHANGELOG.md+29
@@ -1,4 +1,33 @@
11
2+5.34
3+----
4+
5+API changes:
6+ * Added an `NFData` instance for `Event` (thanks Mario Lang)
7+ * Removed `Monoid` and `Semigroup` instances for `Attr` and
8+ `MaybeDefault`. This change removed the instances because they were
9+ misbehaved; merging `Attr` and `MaybeDefault` values with these
10+ instances resulted in field value losses. For example, before this
11+ change,
12+```
13+(defAttr `withForeColor` blue) <> (defAttr `withBackColor` green)
14+```
15+ would result in just
16+```
17+ (defAttr `withBackColor` green)
18+```
19+ because the instances were designed to favor the right-hand
20+ arguments' fields even if they had not been explicitly set
21+ (a consequence of the `MaybeDefault` `Semigroup` instance).
22+ While that behavior was sensible specifically in the context of
23+ `Graphics.Vty.Inline`, it wasn't a useful user-facing API and it made
24+ for surprising instance behavior. Since there is actually no good way
25+ to handle this in a `Semigroup` instance for `Attr` -- some choices
26+ have to be made about how to merge two attributes' foreground colors,
27+ and that won't be much better than what we had -- the instance was
28+ just removed.
29+
30+
2315.33
332----
433
vty.cabal+1−1
@@ -1,5 +1,5 @@
11name: vty
2−version: 5.33
2+version: 5.34
33license: BSD3
44license-file: LICENSE
55author: AUTHORS