Merge pull request #909 from wader/lint-more-and-fixes

lint: More linters and some fixes

.golangci.yml

@@ -23,6 +23,8 @@ linters:
         - unconvert
         - unparam
         - wastedassign
+        - staticcheck
+        - govet
 
 linters-settings:
     revive:
@@ -41,6 +43,13 @@ linters-settings:
             - rela
             - equalisation
             - synchronisation
+    govet:
+        enable-all: true
+        disable:
+            - fieldalignment
+            - shadow
+    staticcheck:
+        checks: ["all"]
 
 run:
     timeout: 5m

format/xml/xml.go

@@ -288,7 +288,6 @@ func decodeXML(d *decode.D) any {
 
 	bbr := d.RawLen(d.Len())
 	var r any
-	var err error
 
 	br := bitio.NewIOReadSeeker(bbr)
 
@@ -310,9 +309,6 @@ func decodeXML(d *decode.D) any {
 	} else {
 		r = fromXMLToObject(n, xi)
 	}
-	if err != nil {
-		d.Fatalf("%s", err)
-	}
 	var s scalar.Any
 	s.Actual = r
 

pkg/interp/binary.go

@@ -287,9 +287,6 @@ func (i *Interp) _open(c any) any {
 	// bitio.Buffer -> (bitio.Reader) -> aheadreadseeker -> progressreadseeker -> ctxreadseeker -> readseeker
 
 	bbf.br = bitio.NewIOBitReadSeeker(aheadRs)
-	if err != nil {
-		return err
-	}
 
 	return bbf
 }