1
1
mirror of https://github.com/walles/moar.git synced 2024-11-27 01:05:23 +03:00
moar/m/scrollPosition.go
Johan Walles 056c766bd3 Handle a potential null value
I don't understand how this happens, but:
* It's uncommon
* It's been reported once during startup
* I'm assuming this is a race condition during startup
* Let's just treat the scroll position as zero if unset

Then let's cross our fingers and hope we don't crash anywhere else in
this situation.

Fixes: https://github.com/walles/moar/issues/198
2024-03-20 06:55:29 +01:00

412 lines
12 KiB
Go

package m
import (
"fmt"
"github.com/walles/moar/m/linenumbers"
)
// Please create using newScrollPosition(name)
type scrollPosition struct {
internalDontTouch scrollPositionInternal
}
func newScrollPosition(name string) scrollPosition {
if len(name) == 0 {
panic("Non-empty name required")
}
return scrollPosition{
internalDontTouch: scrollPositionInternal{
name: name,
},
}
}
type scrollPositionInternal struct {
// Line number in the input stream, or nil if nothing has been read yet or
// there are no lines.
lineNumber *linenumbers.LineNumber
// Scroll this many screen lines before rendering. Can be negative.
deltaScreenLines int
name string
canonicalizing bool
canonical scrollPositionCanonical
}
// If any of these change, we have to recompute the scrollPositionInternal values
type scrollPositionCanonical struct {
width int // From pager
height int // From pager
showLineNumbers bool // From pager
showStatusBar bool // From pager
wrapLongLines bool // From pager
lineNumber *linenumbers.LineNumber // From scrollPositionInternal
deltaScreenLines int // From scrollPositionInternal
}
func canonicalFromPager(pager *Pager) scrollPositionCanonical {
width, height := pager.screen.Size()
return scrollPositionCanonical{
width: width,
height: height,
showLineNumbers: pager.ShowLineNumbers,
showStatusBar: pager.ShowStatusBar,
wrapLongLines: pager.WrapLongLines,
lineNumber: pager.scrollPosition.internalDontTouch.lineNumber,
deltaScreenLines: pager.scrollPosition.internalDontTouch.deltaScreenLines,
}
}
// Create a new position, scrolled towards the end of the file
func (sp scrollPosition) PreviousLine(scrollDistance int) scrollPosition {
return scrollPosition{
internalDontTouch: scrollPositionInternal{
name: sp.internalDontTouch.name,
lineNumber: sp.internalDontTouch.lineNumber,
deltaScreenLines: sp.internalDontTouch.deltaScreenLines - scrollDistance,
},
}
}
// Create a new position, scrolled towards the end of the file
func (sp scrollPosition) NextLine(scrollDistance int) scrollPosition {
return scrollPosition{
internalDontTouch: scrollPositionInternal{
name: sp.internalDontTouch.name,
lineNumber: sp.internalDontTouch.lineNumber,
deltaScreenLines: sp.internalDontTouch.deltaScreenLines + scrollDistance,
},
}
}
// Create a new position, scrolled to the given line number
//
//revive:disable-next-line:unexported-return
func NewScrollPositionFromLineNumber(lineNumber linenumbers.LineNumber, name string) scrollPosition {
return scrollPosition{
internalDontTouch: scrollPositionInternal{
name: name,
lineNumber: &lineNumber,
deltaScreenLines: 0,
},
}
}
// Move towards the top until deltaScreenLines is not negative any more
func (si *scrollPositionInternal) handleNegativeDeltaScreenLines(pager *Pager) {
for !si.lineNumber.IsZero() && si.deltaScreenLines < 0 {
// Render the previous line
previousLineNumber := si.lineNumber.NonWrappingAdd(-1)
previousLine := pager.reader.GetLine(previousLineNumber)
previousSubLines, _ := pager.renderLine(previousLine, previousLineNumber, *si)
// Adjust lineNumber and deltaScreenLines to move up into the previous
// screen line
si.lineNumber = &previousLineNumber
si.deltaScreenLines += len(previousSubLines)
}
if si.lineNumber.IsZero() && si.deltaScreenLines <= 0 {
// Can't go any higher
si.deltaScreenLines = 0
return
}
}
// Move towards the bottom until deltaScreenLines is within range of the
// rendering of the current line.
//
// This method will not do any screen-height based clipping, so it could be that
// the position is too far down to display after this returns.
func (si *scrollPositionInternal) handlePositiveDeltaScreenLines(pager *Pager) {
for {
line := pager.reader.GetLine(*si.lineNumber)
if line == nil {
// Out of bounds downwards, get the last line...
si.lineNumber = linenumbers.LineNumberFromLength(pager.reader.GetLineCount())
line = pager.reader.GetLine(*si.lineNumber)
if line == nil {
panic(fmt.Errorf("Last line is nil"))
}
subLines, _ := pager.renderLine(line, *si.lineNumber, *si)
// ... and go to the bottom of that.
si.deltaScreenLines = len(subLines) - 1
return
}
subLines, _ := pager.renderLine(line, *si.lineNumber, *si)
if si.deltaScreenLines < len(subLines) {
// Sublines are within bounds!
return
}
nextLineNumber := si.lineNumber.NonWrappingAdd(1)
si.lineNumber = &nextLineNumber
si.deltaScreenLines -= len(subLines)
}
}
// This method assumes si contains a canonical position
func (si *scrollPositionInternal) emptyBottomLinesCount(pager *Pager) int {
unclaimedViewportLines := pager.visibleHeight()
// Start counting where the current input line begins
unclaimedViewportLines += si.deltaScreenLines
lineNumber := *si.lineNumber
for {
line := pager.reader.GetLine(lineNumber)
if line == nil {
// No more lines!
break
}
subLines, _ := pager.renderLine(line, lineNumber, *si)
unclaimedViewportLines -= len(subLines)
if unclaimedViewportLines <= 0 {
return 0
}
// Move to the next line
lineNumber = lineNumber.NonWrappingAdd(1)
}
return unclaimedViewportLines
}
func (si *scrollPositionInternal) isCanonical(pager *Pager) bool {
if si.canonical.lineNumber == nil {
// Awaiting initial lines from the reader
return false
}
if si.canonical == canonicalFromPager(pager) {
return true
}
return false
}
// Is the given position visible on screen?
func (sp scrollPosition) isVisible(pager *Pager) bool {
if sp.internalDontTouch.deltaScreenLines < 0 {
panic(fmt.Errorf("Negative incoming deltaScreenLines: %#v", sp.internalDontTouch))
}
if sp.internalDontTouch.lineNumber.IsBefore(*pager.lineNumber()) {
// Line number too low, not visible
return false
}
lastVisiblePosition := pager.getLastVisiblePosition()
if sp.internalDontTouch.lineNumber.IsAfter(*lastVisiblePosition.lineNumber(pager)) {
// Line number too high, not visible
return false
}
// Line number is within range, now check the sub-line number
if sp.internalDontTouch.deltaScreenLines > lastVisiblePosition.deltaScreenLines(pager) {
// Sub-line-number too high, not visible
return false
}
return true
}
// Only to be called from the scrollPosition getters!!
//
// Canonicalize the scroll position vs the given pager. A canonical position can
// just be displayed on screen, it has been clipped both towards the top and
// bottom of the screen, taking into account the screen height.
func (si *scrollPositionInternal) canonicalize(pager *Pager) {
if si.isCanonical(pager) {
return
}
if si.canonicalizing {
panic(fmt.Errorf("Scroll position canonicalize() called recursively for %s", si.name))
}
si.canonicalizing = true
defer func() {
si.canonical = canonicalFromPager(pager)
si.canonicalizing = false
}()
if pager.reader.GetLineCount() == 0 {
si.lineNumber = nil
si.deltaScreenLines = 0
return
}
if si.lineNumber == nil {
// We have lines, but no line number, start at the top
si.lineNumber = &linenumbers.LineNumber{}
}
si.handleNegativeDeltaScreenLines(pager)
si.handlePositiveDeltaScreenLines(pager)
emptyBottomLinesCount := si.emptyBottomLinesCount(pager)
if emptyBottomLinesCount > 0 {
// First, adjust deltaScreenLines to get us to the top
si.deltaScreenLines -= emptyBottomLinesCount
// Then, actually go up that many lines
si.handleNegativeDeltaScreenLines(pager)
}
}
func scrollPositionFromLineNumber(name string, lineNumber linenumbers.LineNumber) *scrollPosition {
return &scrollPosition{
internalDontTouch: scrollPositionInternal{
name: name,
lineNumber: &lineNumber,
},
}
}
// Line number in the input stream, or nil if nothing has been read
func (p *Pager) lineNumber() *linenumbers.LineNumber {
p.scrollPosition.internalDontTouch.canonicalize(p)
return p.scrollPosition.internalDontTouch.lineNumber
}
// Line number in the input stream, or nil if nothing has been read
func (sp *scrollPosition) lineNumber(pager *Pager) *linenumbers.LineNumber {
sp.internalDontTouch.canonicalize(pager)
return sp.internalDontTouch.lineNumber
}
// Scroll this many screen lines before rendering
//
// Always >= 0.
func (p *Pager) deltaScreenLines() int {
p.scrollPosition.internalDontTouch.canonicalize(p)
return p.scrollPosition.internalDontTouch.deltaScreenLines
}
// Scroll this many screen lines before rendering
//
// Always >= 0.
func (sp *scrollPosition) deltaScreenLines(pager *Pager) int {
sp.internalDontTouch.canonicalize(pager)
return sp.internalDontTouch.deltaScreenLines
}
func (p *Pager) scrollToEnd() {
inputLineCount := p.reader.GetLineCount()
if inputLineCount == 0 {
return
}
lastInputLineNumber := *linenumbers.LineNumberFromLength(inputLineCount)
lastInputLine := p.reader.GetLine(lastInputLineNumber)
p.scrollPosition.internalDontTouch.lineNumber = &lastInputLineNumber
// Scroll down enough. We know for sure the last line won't wrap into more
// lines than the number of characters it contains.
p.scrollPosition.internalDontTouch.deltaScreenLines = len(lastInputLine.raw)
if p.TargetLineNumber == nil {
// Start following the end of the file
//
// Otherwise, if we're already aiming for some place, don't overwrite
// that.
maxLineNumber := linenumbers.LineNumberMax()
p.TargetLineNumber = &maxLineNumber
}
}
// Can be either because Pager.scrollToEnd() was just called or because the user
// has pressed the down arrow enough times.
func (p *Pager) isScrolledToEnd() bool {
inputLineCount := p.reader.GetLineCount()
if inputLineCount == 0 {
// No lines available, which means we can't scroll any further down
return true
}
lastInputLineNumber := *linenumbers.LineNumberFromLength(inputLineCount)
visibleLines, _, _ := p.renderLines()
lastVisibleLine := visibleLines[len(visibleLines)-1]
if lastVisibleLine.inputLine != lastInputLineNumber {
// Last input line is not on the screen
return false
}
// Last line is on screen, now we need to figure out whether we can see all
// of it
lastInputLine := p.reader.GetLine(lastInputLineNumber)
lastInputLineRendered, _ := p.renderLine(lastInputLine, lastInputLineNumber, p.scrollPosition.internalDontTouch)
lastRenderedSubLine := lastInputLineRendered[len(lastInputLineRendered)-1]
// If the last visible subline is the same as the last possible subline then
// we're at the bottom
return lastVisibleLine.wrapIndex == lastRenderedSubLine.wrapIndex
}
// Returns nil if there are no lines
func (p *Pager) getLastVisiblePosition() *scrollPosition {
renderedLines, _, _ := p.renderLines()
if len(renderedLines) == 0 {
return nil
}
lastRenderedLine := renderedLines[len(renderedLines)-1]
return &scrollPosition{
internalDontTouch: scrollPositionInternal{
name: "Last Visible Position",
lineNumber: &lastRenderedLine.inputLine,
deltaScreenLines: lastRenderedLine.wrapIndex,
},
}
}
func numberPrefixLength(pager *Pager, scrollPosition scrollPositionInternal) int {
// This method used to live in screenLines.go, but I moved it here because
// it touches scroll position internals.
if !pager.ShowLineNumbers {
return 0
}
maxPossibleLineNumber := *linenumbers.LineNumberFromLength(pager.reader.GetLineCount())
// This is an approximation assuming we don't do any wrapping. Finding the
// real answer while wrapping requires rendering, which requires the real
// answer and so on, so we do an approximation here to save us from
// recursion.
//
// Let's improve on demand.
var lineNumber linenumbers.LineNumber
// Ref: https://github.com/walles/moar/issues/198
if scrollPosition.lineNumber != nil {
lineNumber = *scrollPosition.lineNumber
}
maxVisibleLineNumber := lineNumber.NonWrappingAdd(
scrollPosition.deltaScreenLines +
pager.visibleHeight() - 1)
if maxVisibleLineNumber.IsAfter(maxPossibleLineNumber) {
maxVisibleLineNumber = maxPossibleLineNumber
}
// Count the length of the last line number
numberPrefixLength := len(maxVisibleLineNumber.Format()) + 1
if numberPrefixLength < 4 {
// 4 = space for 3 digits followed by one whitespace
//
// https://github.com/walles/moar/issues/38
numberPrefixLength = 4
}
return numberPrefixLength
}