wez/wezterm
1
1
Fork 0
mirror of https://github.com/wez/wezterm.git synced 2024-12-25 14:22:37 +03:00
Code Issues Projects Releases Wiki Activity

improve scroll_up perf

Browse Source 
We were marking the entire scrollback history as dirty on each line
scroll.  This was from the early days and isn't needed any more.
This brings the runtime of:

```
$ find /usr > /tmp/usr-files.txt
$ time cat /tmp/usr-files.txt
```

down from ~2.5s to ~1.2s.

Also avoid a redundant line_mut() call in set_cell().
This commit is contained in:
Wez Furlong 2018-02-19 08:14:03 -08:00
parent 966eb2ce4c
commit 1b989b011d
1 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
term/src/screen.rs
View File

@ -105,18 +105,19 @@ impl Screen {
attr
);
let line = self.line_mut(line_idx);
if attr.hyperlink.is_some() {
self.line_mut(line_idx).set_has_hyperlink(true);
line.set_has_hyperlink(true);
}
let cells = &mut self.line_mut(line_idx).cells;
let width = cells.len();
let width = line.cells.len();
// if the line isn't wide enough, pad it out with the default attributes
if x >= width {
cells.resize(x + 1, Cell::default());
line.cells.resize(x + 1, Cell::default());
}
cells[x] = Cell::from_char(c, attr);
&cells[x]
line.cells[x] = Cell::from_char(c, attr);
&line.cells[x]
}
pub fn clear_line(&mut self, y: VisibleRowIndex, cols: std::ops::Range<usize>) {
@ -179,7 +180,7 @@ impl Screen {
pub fn scroll_up(&mut self, scroll_region: &Range<VisibleRowIndex>, num_rows: usize) {
debug!("scroll_up {:?} {}", scroll_region, num_rows);
let phys_scroll = self.phys_range(&scroll_region);
assert!(num_rows <= phys_scroll.end - phys_scroll.start);
debug_assert!(num_rows <= phys_scroll.end - phys_scroll.start);
// Invalidate the lines that will move before they move so that
// the indices of the lines are stable (we may remove lines below)
@ -207,14 +208,6 @@ impl Screen {
self.lines.remove(phys_scroll.start);
}
if scroll_region.start == 0 {
// All of the lines above the top are now effectively dirty because
// they were moved into scrollback by the scroll operation.
for y in 0..phys_scroll.start {
self.line_mut(y).set_dirty();
}
}
if scroll_region.end as usize == self.physical_rows {
// It's cheaper to push() than it is insert() at the end
for _ in 0..num_rows {