1
1
mirror of https://github.com/wez/wezterm.git synced 2024-11-13 07:22:52 +03:00

remove use of tinyfiledialogs

It will pass the message text to the shell without proper quoting
which results in it running all sorts of garbage depending on
the message you're trying to display.

Very scary!

refs: https://github.com/jdm/tinyfiledialogs-rs/issues/19
This commit is contained in:
Wez Furlong 2019-11-22 08:48:33 -08:00
parent 95900dc0a5
commit 3057befa5d
2 changed files with 0 additions and 13 deletions

View File

@ -46,7 +46,6 @@ structopt = "0.2"
tabout = { path = "tabout" }
term = { path = "term" }
termwiz = { path = "termwiz"}
tinyfiledialogs = "3.3"
toml = "0.4"
unicode-normalization = "0.1"
unicode-segmentation = "1.5"

View File

@ -599,18 +599,6 @@ fn main() -> Result<(), Error> {
let message = e.to_string();
log::error!("{}", message);
// Avoid showing a modal dialog for IO errors such as
// BrokenPipe; those can manifest with the `cli proxy` subcommand
// running on the remote host, and no one would ever see those
// dialogs anyway
if e.downcast_ref::<std::io::Error>().is_none() {
tinyfiledialogs::message_box_ok(
"wezterm",
&message,
tinyfiledialogs::MessageBoxIcon::Error,
);
}
}
result
}