wez/wezterm
1
1
Fork 0
mirror of https://github.com/wez/wezterm.git synced 2024-11-11 03:27:05 +03:00
Code Issues Projects Releases Wiki Activity

fix positioning of visual bell

Browse Source 
refs: https://github.com/wez/wezterm/issues/2364
This commit is contained in:
Wez Furlong 2022-08-06 13:42:28 -07:00
parent 3941d2a564
commit 4c1fd693b4
2 changed files with 37 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/changelog.md
View File

@ -81,6 +81,7 @@ As features stabilize some brief notes about them will accumulate here.
* Tab `x` button is no longer obscured by tab title text for long tab titles [#2269](https://github.com/wez/wezterm/issues/2269)
* Cursor position could end up in the wrong place when rewrapping lines and the cursor was on the rewrap boundary [#2162](https://github.com/wez/wezterm/issues/2162)
* Two or more panes closing at the same time could result in their containing tab hanging and being stuck with "no pane" for a title [#2304](https://github.com/wez/wezterm/issues/2304)
* Visual Bell now fills out to the adjacent window edges rather than being constrained by the padding. [#2364](https://github.com/wez/wezterm/issues/2364)
#### Updated
* Bundled harfbuzz to 5.1.0

40
wezterm-gui/src/termwindow/render.rs
View File

@ -1239,13 +1239,45 @@ impl super::TermWindow {
let cell_width = self.render_metrics.cell_size.width as f32;
let cell_height = self.render_metrics.cell_size.height as f32;
// We want to fill out to the edges of the splits
let (x, width_delta) = if pos.left == 0 {
(0., padding_left + (cell_width / 2.0))
} else {
(
padding_left - (cell_width / 2.0) + (pos.left as f32 * cell_width),
cell_width,
)
};
let (y, height_delta) = if pos.top == 0 {
(
(top_pixel_y - padding_top),
padding_top + (cell_height / 2.0),
)
} else {
(
top_pixel_y + (pos.top as f32 * cell_height) - (cell_height / 2.0),
cell_height,
)
};
let mut quad = self.filled_rectangle(
&mut layers[0],
euclid::rect(
(pos.left as f32 * cell_width) + padding_left,
top_pixel_y + (pos.top as f32 * cell_height) + padding_top,
pos.width as f32 * cell_width,
pos.height as f32 * cell_height,
x,
y,
// Go all the way to the right edge if we're right-most
if pos.left + pos.width >= self.terminal_size.cols as usize {
self.dimensions.pixel_width as f32 - x
} else {
(pos.width as f32 * cell_width) + width_delta
},
// Go all the way to the bottom if we're bottom-most
if pos.top + pos.height >= self.terminal_size.rows as usize {
self.dimensions.pixel_height as f32 - y
} else {
(pos.height as f32 * cell_height) + height_delta as f32
},
),
background,
)?;