wez/wezterm
1
1
Fork 0
mirror of https://github.com/wez/wezterm.git synced 2024-12-25 14:22:37 +03:00
Code Issues Projects Releases Wiki Activity

termwiz: fix off-by-one in computing line length

Browse Source 
We were over-allocating 1 extra cell in the end-of-line case
This commit is contained in:
Wez Furlong 2021-08-11 16:53:37 -07:00
parent 1e7c7e7059
commit 60786dd74d
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
termwiz/src/surface/line.rs
View File

@ -438,17 +438,17 @@ impl Line {
}
fn set_cell_impl(&mut self, idx: usize, cell: Cell, clear: bool, seqno: SequenceNo) -> &Cell {
let width = cell.width();
// if the line isn't wide enough, pad it out with the default attributes.
// The .max(1) stuff is here in case we get called with a
// zero-width cell. That shouldn't happen: those sequences
// should get filtered out in the terminal parsing layer,
// but in case one does sneak through, we need to ensure that
// we grow the cells array to hold this bogus entry.
// https://github.com/wez/wezterm/issues/768
if idx + width.max(1) >= self.cells.len() {
self.cells.resize(idx + width.max(1), Cell::default());
let width = cell.width().max(1);
// if the line isn't wide enough, pad it out with the default attributes.
if idx + width > self.cells.len() {
self.cells.resize(idx + width, Cell::default());
}
self.invalidate_implicit_hyperlinks(seqno);