splitting writer out of Tab::pty()

src/gliumwindows.rs

@@ -635,14 +635,9 @@ impl GliumTerminalWindow {
                         return Ok(());
                     }
 
-                    tab.terminal().key_down(key, mods, &mut *tab.pty())?
+                    tab.terminal().key_down(key, mods, &mut *tab.writer())?
                 }
-
-                ElementState::Released => tab.terminal().key_up(
-                    key,
-                    mods,
-                    &mut TabHost::new(&mut tab.pty(), &mut self.host),
-                )?,
+                ElementState::Released => {}
             }
         } else {
             eprintln!("event {:?} with no mapping", event);
@@ -695,7 +690,7 @@ impl GliumTerminalWindow {
                     tab.terminal().key_down(
                         KeyCode::Char(c),
                         self.last_modifiers,
-                        &mut *tab.pty(),
+                        &mut *tab.writer(),
                     )?;
                     self.paint_if_needed()?;
                 }

src/guicommon/tabs.rs

@@ -37,9 +37,14 @@ impl Tab {
         self.process.borrow_mut()
     }
 
+    #[deprecated(note = "use writer or something else")]
     pub fn pty(&self) -> RefMut<MasterPty> {
         self.pty.borrow_mut()
     }
+
+    pub fn writer(&self) -> RefMut<MasterPty> {
+        self.pty.borrow_mut()
+    }
 }
 
 impl Drop for Tab {

src/xwindows/xwin.rs

@@ -241,21 +241,7 @@ impl X11TerminalWindow {
                         return Ok(());
                     }
 
-                    tab.terminal().key_down(code, mods, &mut *tab.pty())?;
-                }
-            }
-            xcb::KEY_RELEASE => {
-                let key_press: &xcb::KeyPressEvent = unsafe { xcb::cast_event(event) };
-                if let Some((code, mods)) = self.decode_key(key_press) {
-                    let tab = match self.tabs.get_active() {
-                        Some(tab) => tab,
-                        None => return Ok(()),
-                    };
-                    tab.terminal().key_up(
-                        code,
-                        mods,
-                        &mut TabHost::new(&mut tab.pty(), &mut self.host),
-                    )?;
+                    tab.terminal().key_down(code, mods, &mut *tab.writer())?;
                 }
             }
             xcb::MOTION_NOTIFY => {

term/src/terminalstate.rs

@@ -910,15 +910,6 @@ impl TerminalState {
         Ok(())
     }
 
-    pub fn key_up(
-        &mut self,
-        _: KeyCode,
-        _: KeyModifiers,
-        _: &mut TerminalHost,
-    ) -> Result<(), Error> {
-        Ok(())
-    }
-
     pub fn resize(&mut self, physical_rows: usize, physical_cols: usize) {
         self.screen.resize(physical_rows, physical_cols);
         self.scroll_region = 0..physical_rows as i64;