wez/wezterm
1
1
Fork 0
mirror of https://github.com/wez/wezterm.git synced 2024-11-10 15:04:32 +03:00
Code Issues Projects Releases Wiki Activity

wayland: do not spam the compositor with title "changes" that don't change

Browse Source 
In the worst case this can cause badly implemented desktop components like panels
to constantly rerender and waste 100% CPU (that's how I found a bug in mine :D)
when anything is constantly updating in the terminal (like viewing a log stream).
This commit is contained in:
Greg V 2021-10-22 17:16:33 +03:00 committed by Wez Furlong
parent 04768fd1e2
commit 6fbb8802c0
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
window/src/os/wayland/window.rs
View File

@ -127,6 +127,9 @@ pub struct WaylandWindowInner {
invalidated: bool,
font_config: Rc<FontConfiguration>,
config: Option<ConfigHandle>,
// cache the title for comparison to avoid spamming
// the compositor with updates that don't actually change it
title: Option<String>,
// wegl_surface is listed before gl_state because it
// must be dropped before gl_state otherwise the underlying
// libraries will segfault on shutdown
@ -340,6 +343,7 @@ impl WaylandWindow {
pending_mouse,
pending_first_configure: Some(pending_first_configure),
frame_callback: None,
title: None,
gl_state: None,
wegl_surface: None,
}));
@ -821,7 +825,7 @@ impl WindowOps for WaylandWindow {
fn set_title(&self, title: &str) {
let title = title.to_owned();
WaylandConnection::with_window_inner(self.0, move |inner| {
inner.set_title(&title);
inner.set_title(title);
Ok(())
});
}
@ -1054,11 +1058,17 @@ impl WaylandWindowInner {
}
/// Change the title for the window manager
fn set_title(&mut self, title: &str) {
fn set_title(&mut self, title: String) {
if let Some(last_title) = self.title.as_ref() {
if last_title == &title {
return;
}
}
if let Some(window) = self.window.as_ref() {
window.set_title(title.to_string());
window.set_title(title.clone());
}
self.refresh_frame();
self.title = Some(title);
}
fn set_resize_increments(&mut self, x: u16, y: u16) {