wez/wezterm
1
1
Fork 0
mirror of https://github.com/wez/wezterm.git synced 2024-08-17 02:00:25 +03:00
Code Issues Projects Releases Wiki Activity

gui: don't repaint during resize

Browse Source 
Wait until set_inner_size() has finished before repainting.  If we
repaint while our request to resize is in progress, our understanding of
the current size of the window may be inconsistent with the actual size,
causing the rendered contents of the window to bounce around.
This commit is contained in:
Jeffrey Knockel 2024-02-18 12:22:05 -05:00 committed by Wez Furlong
parent 6dff0fbe2c
commit 753b6e77ea
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
wezterm-gui/src/termwindow/mod.rs
View File

@ -370,6 +370,7 @@ pub struct TermWindow {
pub dimensions: Dimensions,
pub window_state: WindowState,
pub resizes_pending: usize,
is_repaint_pending: bool,
pending_scale_changes: LinkedList<resize::ScaleChange>,
/// Terminal dimensions
terminal_size: TerminalSize,
@ -696,6 +697,7 @@ impl TermWindow {
dimensions,
window_state: WindowState::default(),
resizes_pending: 0,
is_repaint_pending: false,
pending_scale_changes: LinkedList::new(),
terminal_size,
render_state,
@ -954,6 +956,14 @@ impl TermWindow {
}
WindowEvent::SetInnerSizeCompleted => {
self.resizes_pending -= 1;
if self.is_repaint_pending {
self.is_repaint_pending = false;
if self.webgpu.is_some() {
self.do_paint_webgpu()?;
} else {
self.do_paint(window);
}
}
self.apply_pending_scale_changes();
Ok(true)
}
@ -984,8 +994,16 @@ impl TermWindow {
window.invalidate();
Ok(true)
}
WindowEvent::NeedRepaint if self.webgpu.is_some() => self.do_paint_webgpu(),
WindowEvent::NeedRepaint => Ok(self.do_paint(window)),
WindowEvent::NeedRepaint => {
if self.resizes_pending > 0 {
self.is_repaint_pending = true;
Ok(true)
} else if self.webgpu.is_some() {
self.do_paint_webgpu()
} else {
Ok(self.do_paint(window))
}
}
WindowEvent::Notification(item) => {
if let Ok(notif) = item.downcast::<TermWindowNotif>() {
self.dispatch_notif(*notif, window)