wez/wezterm
1
1
Fork 0
mirror of https://github.com/wez/wezterm.git synced 2024-12-22 12:51:31 +03:00
Code Issues Projects Releases Wiki Activity

posix: prefer to resolve shell via the password database

Browse Source 
I've had a couple of people report issues like
https://github.com/wez/wezterm/issues/2378 recently, and we can avoid
this class of problem by unsetting SHELL at proces startup, so that's
what we do.
This commit is contained in:
Wez Furlong 2022-08-30 19:00:05 -07:00
parent ed731a0d8d
commit ad9490ee8f
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/config/launch.md
View File

@ -22,6 +22,9 @@ have `$SHELL` set in the environment, you will need to sign out and
sign back in again for the environment to pick up your new `$SHELL`
value.
*Since: nightly builds only*: wezterm will now always resolve the shell via the
password database.
### On Windows Systems
1. The value of the `%COMSPEC%` environment variable is used if it is set.

6
env-bootstrap/src/lib.rs
View File

@ -198,4 +198,10 @@ pub fn bootstrap() {
// wezterm or the mux server from inside gnome terminal.
// <https://github.com/wez/wezterm/issues/2237>
std::env::remove_var("VTE_VERSION");
// Sice folks don't like to reboot or sign out if they `chsh`,
// SHELL may be stale. Rather than using a stale value, unset
// it so that pty::CommandBuilder::get_shell will resolve the
// shell from the password database instead.
std::env::remove_var("SHELL");
}