wez/wezterm
1
1
Fork 0
mirror of https://github.com/wez/wezterm.git synced 2024-11-23 06:54:45 +03:00
Code Issues Projects Releases Wiki Activity

windows: avoid panic when clicking on links

Browse Source 
The `open` crate causes us to recurse into our wndproc and re-borrow,
so avoid that and schedule a separate call later.
This commit is contained in:
Wez Furlong 2019-11-04 08:56:11 -08:00
parent c8f34aa81b
commit e288ecce7c
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/frontend/gui/termwindow.rs
View File

@ -55,10 +55,17 @@ impl<'a> term::TerminalHost for Host<'a> {
}
fn click_link(&mut self, link: &Arc<term::cell::Hyperlink>) {
log::error!("clicking {}", link.uri());
if let Err(err) = open::that(link.uri()) {
log::error!("failed to open {}: {:?}", link.uri(), err);
}
// Ensure that we spawn the `open` call outside of the context
// of our window loop; on Windows it can cause a panic due to
// triggering our WndProc recursively.
let link = link.clone();
promise::Future::with_executor(executor(), move || {
log::error!("clicking {}", link.uri());
if let Err(err) = open::that(link.uri()) {
log::error!("failed to open {}: {:?}", link.uri(), err);
}
Ok(())
});
}
}